From unknown Sun Jun 22 17:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55406: GUIX Image API: wrong fs type and flag Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 13 May 2022 23:01:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 55406@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165248283127788 (code B ref -1); Fri, 13 May 2022 23:01:03 +0000 Received: (at submit) by debbugs.gnu.org; 13 May 2022 23:00:31 +0000 Received: from localhost ([127.0.0.1]:45288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npeGs-0007Dx-Bh for submit@debbugs.gnu.org; Fri, 13 May 2022 19:00:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:47498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npd7n-0004uo-Ir for submit@debbugs.gnu.org; Fri, 13 May 2022 17:47:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npd7n-0003xf-C9 for bug-guix@gnu.org; Fri, 13 May 2022 17:47:03 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:45982) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npd7l-0005rd-VV for bug-guix@gnu.org; Fri, 13 May 2022 17:47:03 -0400 Received: by mail-ed1-x52e.google.com with SMTP id be20so11352669edb.12 for ; Fri, 13 May 2022 14:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=TLmK96nxre60q2+vyAfDEHs6NN957oxrW8ESbYmsH1E=; b=aWv5QmWjqVol94WxyQrd8Fh2uPAAGwe8Buf0vsKF0brN8O/utNflgiRqJconmv6od+ kkkOyVYgU/SEglL31WR6nDssdjORnJ0njMJ9xvLMDmxW9fXzQLuafnag16WvGZBcAgah db9pldAbnU+SlBMLOs1cXzjrsg9KQ4irpKMDedAp8U1ldjviF1nBdHrM9K/Yqg7/rOdN iimUphy/THj98Qjz8G5G15J1wsNEUx1ys6nVrgtuv6a4bFNtFGq4zfo7qwYxULvnTLrp q5T0DGT+sz34kFkscQNd7fZhVtpm3/i0fgZfQtnHrFR7cbK6SShee0iIIL/Rha2JrTJa K1sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=TLmK96nxre60q2+vyAfDEHs6NN957oxrW8ESbYmsH1E=; b=innbJSFATu9IrPmnUYWqowhe9hDs6LJrY3LqLuwT1rVZZm4m268BOmKQ1uebEfqxNG zbg8/VvsSIXHEIHVYTVrrhV9GVh9arQBRUScL4bPelwjJBIK8hCs6olJ7dOdcJICFvat u3yGcDejeh3ME4czQIvMeNW+pu0Hw+QpOAR6yCExX+V4pq8iLm4pVoceceDHkKqqFTkQ 4YHMywGVZrut8ZD0l7mQ6NkY/ohY5s2UQvFcT2Hd+yN2kUMK5y2VkPKeYQNdBHqWXryq JOrvX3HzJ4MDRo+/f0+pZrh57CdL/ddLfrsy4kMQ1O2x36WvPGlfMXsjD5uQ1B3NNgbO m7ug== X-Gm-Message-State: AOAM5339ZjKuscbyupU05KBnmHO+F4cD5l4B3bplLrtUwDK2Rw4lwJQS jllSOWoImBpd1DHQpEVOTz1pzcZ7lkX/mzDd X-Google-Smtp-Source: ABdhPJyGSWP3WKprSzozZwwj0x1fhaUEf5lz87FNrQKC0bBny310qDK+SMslYpa7IYbV4tmDF9VDxg== X-Received: by 2002:a05:6402:1a34:b0:425:ca01:58ec with SMTP id be20-20020a0564021a3400b00425ca0158ecmr677143edb.373.1652478420209; Fri, 13 May 2022 14:47:00 -0700 (PDT) Received: from smtpclient.apple ([31.141.85.74]) by smtp.gmail.com with ESMTPSA id c18-20020aa7c992000000b0042617ba63d2sm1386046edt.92.2022.05.13.14.46.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 May 2022 14:46:59 -0700 (PDT) From: Pavel Shlyak Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Message-Id: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> Date: Sat, 14 May 2022 00:46:57 +0300 X-Mailer: Apple Mail (2.3696.80.82.1.1) Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=shlyakpavel@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Fri, 13 May 2022 19:00:29 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I have a scheme code like (define rpi-boot-partition (partition (size (* 128 (expt 2 20))) (label "BOOT") (file-system "vfat") (flags '()) (initializer (gexp initialize-efi-partition)))) (define rpi-root-partition (partition (size 'guess) (label "RASPIROOT") (file-system "ext4") (flags '(boot)) (initializer (gexp initialize-root-partition)))) (define raspberry-pi-image (image (format 'disk-image) (partitions (list rpi-boot-partition rpi-root-partition)))) The output is like that: $ fdisk -l = /gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-ima= ge Device Boot Start End Sectors Size Id Type = /gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-ima= ge1 1 262144 262144 128M 83 Linux = /gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-ima= ge2 262145 3583688 3321544 1.6G 83 Linux=09 No boot flag is set on the first partition. The file system seems to be = incorrect (ext* instead of vfat)= From debbugs-submit-bounces@debbugs.gnu.org Sat May 14 04:27:57 2022 Received: (at control) by debbugs.gnu.org; 14 May 2022 08:27:57 +0000 Received: from localhost ([127.0.0.1]:45705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npn80-0005sS-W0 for submit@debbugs.gnu.org; Sat, 14 May 2022 04:27:57 -0400 Received: from tobias.gr ([80.241.217.52]:42472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npn7y-0005sI-En for control@debbugs.gnu.org; Sat, 14 May 2022 04:27:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=zn/nJ6mx1gnl0 MZIKCyHQ+EdOS1jnPwWr8lj6rkqY6c=; h=to:from:date; d=tobias.gr; b=NVqLjl CXfP/4sXp7CP6ZpnA+2tW/62cX2tpJ7DVz5FVaJOYs9Qlm4bd0ppX20Gc+SPtQzorocm9x PWNQQQuweWSoNEWHwNecAajC2GfJkDdOf6pOaoyQXeFqyV6G1Qq4bV+xPfqDbL7Oj3gtF4 d9/1c5WES5ooiGtfVrizwiWAY+YEqeyQJJa7nwrzjE6iA+Jzf6ABnVfsdMiEiddNf7g7Pl SwxRS80rqJDZnGcjQW/dajHvLDgoVn0ifK6FGzdjFX/b0ywzFix0uf/zRzE/mPDWvAO9cK 3VAYP4dOoPrLlBV5xnTQddyJnq48aLlyUZxnwnViDyZl0zZm8QqwCkYw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id ec2e6ee2 for ; Sat, 14 May 2022 08:27:48 +0000 (UTC) MIME-Version: 1.0 Date: Sat, 14 May 2022 10:27:47 +0200 From: Tobias Geerinckx-Rice To: control@debbugs.gnu.org Message-ID: <47933e2c0cfb127ecbfb0cc1be7eba9b@tobias.gr> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 3.7 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 55405 55406 Content analysis details: (3.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject -0.0 T_SCC_BODY_TEXT_LINE No description available. 1.7 BODY_EMPTY No body text in message X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.7 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 55405 55406 Content analysis details: (2.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 1.7 BODY_EMPTY No body text in message merge 55405 55406 From debbugs-submit-bounces@debbugs.gnu.org Sat May 14 05:16:21 2022 Received: (at control) by debbugs.gnu.org; 14 May 2022 09:16:21 +0000 Received: from localhost ([127.0.0.1]:45757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npnsr-0002Mm-LJ for submit@debbugs.gnu.org; Sat, 14 May 2022 05:16:21 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:42618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npnsp-0002K5-G4 for control@debbugs.gnu.org; Sat, 14 May 2022 05:16:20 -0400 Received: from [192.168.222.254] ([188.189.252.23]) by xavier.telenet-ops.be with bizsmtp id WZGH2700C0X38ms01ZGHZx; Sat, 14 May 2022 11:16:17 +0200 Message-ID: Subject: Re: bug#55405: Image API produces incorrect images From: Maxime Devos Date: Sat, 14 May 2022 11:16:12 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ueRRvbyXUTSrqdQTnhBz" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1652519777; bh=T6QW3KJf1zdLVjSi6GSe7HWdvuF08q3PqveeYH9CoDg=; h=Subject:From:Cc:Date:In-Reply-To:References; b=AQC8KANpstvd416qD6L3o0hqSbYbAMcqpIcN00Kyizv7z+jH4Nw0+2t+KqVVKq8Sz EaKZ7/SU16yXd9/jwPphMiSwoeYt2Cya2zGvw7a5vDFJ3FHhqLB2wdHr0V2KwWME35 ezhvt2sPzgi78I61q+gyadXvA4M7bERepk/Gm8Yj4LV/tH5I/uJ0/AJwuCnM2gr37O 8LM1aPZuqSPzJ86/O4TmjdITRvrgSnjcegTlMry2D656lsygvjIQ7DWTtryH6rENJ5 qZ8r88AHL9U8PWAblbnjRVRgUx4yoBTSCeEmSH7FLbARnA0qZwvSOdRSjB65wkzns7 XEOXzLFVJpspg== X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 55405 55406 thanks (duplicate) Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 MISSING_HEADERS Missing To: header -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [195.130.132.52 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maximedevos[at]telenet.be) -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: control Cc: control@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-ueRRvbyXUTSrqdQTnhBz Content-Type: text/plain Content-Transfer-Encoding: quoted-printable merge 55405 55406 thanks (duplicate) --=-ueRRvbyXUTSrqdQTnhBz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYn9zXBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7k93AQC0OBNW0Oa7RseBKpPWALNCRsn0 e19BMBlLuuxTm7WOqgD8DrBHiwhTsYHDV+i+XrwkDd3Yln8VbmFw79MWhSfbAgM= =i/Sn -----END PGP SIGNATURE----- --=-ueRRvbyXUTSrqdQTnhBz-- From unknown Sun Jun 22 17:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55406: GUIX Image API: wrong fs type and flag References: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> In-Reply-To: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 15 May 2022 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 55406@debbugs.gnu.org Received: via spool by 55406-submit@debbugs.gnu.org id=B55406.165263468016980 (code B ref 55406); Sun, 15 May 2022 17:12:02 +0000 Received: (at 55406) by debbugs.gnu.org; 15 May 2022 17:11:20 +0000 Received: from localhost ([127.0.0.1]:50563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqHm4-0004Po-FZ for submit@debbugs.gnu.org; Sun, 15 May 2022 13:11:20 -0400 Received: from mail-ej1-f45.google.com ([209.85.218.45]:36419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqHm3-0004Pb-Hf for 55406@debbugs.gnu.org; Sun, 15 May 2022 13:11:19 -0400 Received: by mail-ej1-f45.google.com with SMTP id z2so24673471ejj.3 for <55406@debbugs.gnu.org>; Sun, 15 May 2022 10:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:mime-version:subject:message-id:date:to; bh=oAHtv9+Dur1c3SwbPSb77xaGQRgKgQ0Lii7J2GnzTUc=; b=BQR6NpFuDLhOEfMP358uwnt/JYPX6It4N7HZvIePywioFyjeljJndeMRiimsHHqNhc w464w7H9ZSziCLiP7kia2TMrd5GWLKcJ1O77qu/a+f8iGjO0agl82drJeqq1eljfNdui 0Oo2mI+mF6Ok8lhogcGDpogCzyjaAl6m9EU/jzlj/jrsqf+Zmh1KGqq1CaRxAMbBTSYy U4iTPZhmXytHs5cYmJP5+QGF2brLV05XF7SeA89w45qJd2cJu4qf2Cl7ofBcLw0c2/m2 oPkM6HnV9B3Q6tMr+eN7D9/1KB2xwprLtDZitn/O9l7dCQVgS0VDMQIbpFvjVSeOHOmj ejKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=oAHtv9+Dur1c3SwbPSb77xaGQRgKgQ0Lii7J2GnzTUc=; b=HxETX6zsa8DbrAslaOdGN2KV7LhyafzzsQOXMoVqBONnBOX0lmxv1uq4MUyqxmKQMO 5djfbB7ziyGlCIoRRUvPYjX38+y+mSXPMqm+NjY3BnaRRN9VrhJK6XcdZ+DcuySr4k5o 1CfgwiVPzSpAtPYWpIVJo8XB9Fm4/Gi27hPtAdE4+OTpao2SWvnawwheh5k7kkDDXn+b S4VAVKf1tBGeopz5l3eXD6KDoUX5mG+Fpq7TAkGQuKlVlnC/Moot0ZLy6AJgnKhh6KEe O67FGaEic3qmKIN7NEuDq8/UZaoRp/hquYvK37Eje6VWJV0hlsoioV0+/hJNeXrd3jQI sqnw== X-Gm-Message-State: AOAM531k96U3y5iPoUqDWNl5CU+vQbEGMTFWhqb3xL2IqBH/GqxPam7F 2OwOkYAe9PmRPA8DYSZyV9tBb8lxC34= X-Google-Smtp-Source: ABdhPJxQn3V5+jfws3JWUX5J7L1RtXdZ9U1aroct8CptTPnonkOHg6MS97DLn+shOHIBmw2+kf68jA== X-Received: by 2002:a17:906:9b92:b0:6fd:e4ce:e416 with SMTP id dd18-20020a1709069b9200b006fde4cee416mr12385205ejc.394.1652634673132; Sun, 15 May 2022 10:11:13 -0700 (PDT) Received: from smtpclient.apple ([78.188.101.200]) by smtp.gmail.com with ESMTPSA id 28-20020a170906101c00b006f3ef214e0dsm2803193ejm.115.2022.05.15.10.11.12 for <55406@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 May 2022 10:11:12 -0700 (PDT) From: Pavel Shlyak Content-Type: multipart/alternative; boundary="Apple-Mail=_718FC3BA-CCEF-4DE1-B737-D18C5869EE94" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Message-Id: <1219026A-541C-4689-9C3E-C35A8F39E30B@gmail.com> Date: Sun, 15 May 2022 20:11:11 +0300 X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_718FC3BA-CCEF-4DE1-B737-D18C5869EE94 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I found it. It blows my mind. Let me just cry out here. (define (partition->dos-type partition) ;; Return the MBR partition type corresponding to the given = PARTITION. ;; See: https://en.wikipedia.org/wiki/Partition_type. (let ((flags (partition-flags partition))) (cond ((member 'esp flags) "0xEF") (else "0x83")))) (define (partition->gpt-type partition) ;; Return the genimage GPT partition type code corresponding to = PARTITION. ;; See = https://github.com/pengutronix/genimage/blob/master/README.rst (let ((flags (partition-flags partition))) (cond ((member 'esp flags) "U") (else "L"))))= --Apple-Mail=_718FC3BA-CCEF-4DE1-B737-D18C5869EE94 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii I = found it. It blows my mind. Let me just cry out here.

(define (partition->dos-type partition)
;; Return the MBR = partition type corresponding to the given PARTITION.
;; = See: https://en.wikipedia.org/wiki/Partition_type.
<= div class=3D""> (let ((flags (partition-flags partition)))
(cond
((member 'esp flags) = "0xEF")
(else "0x83"))))

(define (partition->gpt-type partition)
;; Return the genimage = GPT partition type code corresponding to PARTITION.
;; = See https://github.com/pengutronix/genimage/blob/master/README.rst<= /a>
(let ((flags (partition-flags = partition)))
(cond
= ((member 'esp = flags) "U")
(else "L"))))
= --Apple-Mail=_718FC3BA-CCEF-4DE1-B737-D18C5869EE94-- From unknown Sun Jun 22 17:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55406: GUIX Image API: wrong fs type and flag References: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> In-Reply-To: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 15 May 2022 22:17:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 55406@debbugs.gnu.org Received: via spool by 55406-submit@debbugs.gnu.org id=B55406.165265300830676 (code B ref 55406); Sun, 15 May 2022 22:17:03 +0000 Received: (at 55406) by debbugs.gnu.org; 15 May 2022 22:16:48 +0000 Received: from localhost ([127.0.0.1]:50957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqMXf-0007yh-R3 for submit@debbugs.gnu.org; Sun, 15 May 2022 18:16:48 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:45891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqHbS-0004A8-VR for 55406@debbugs.gnu.org; Sun, 15 May 2022 13:00:23 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 2C8D93200B74 for <55406@debbugs.gnu.org>; Sun, 15 May 2022 13:00:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 15 May 2022 13:00:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1652634016; x=1652720416; bh=DpwA8+Z1us 1hCQ1sxnVN+WQyKfCu23toY0RXsYkol4c=; b=ovuKhgosHCR6ulJLzqeFZ4TJJU ZOWpArPs2zrfVjZWxYjo05z5TntBqkgm8PV1CR/6/4qr8JSFKf3agBRVVlA/5viX vR9njVf3AT1Sfhu97W/tZ6E+ptlPQLtY7eG8Xrj5VftM4XltF3E0ycH2MHQzwvVD RpPwNoUXXUFGbMZPCH4tzt843CCFKR0iytOqprj17oBwlBKJJBIZ2ac3obJJMAqV ayLryvVzCAigLn865eAFJePpz095k99//hZxJXEdmjgefzxPpVhUsl20A+qOJbwy 4yYDIX9qUEO5Lr01WfFaHCzSJ1mD0lP5sMhwPNorUR/KE+Y93yWB1xz2YkYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652634016; x= 1652720416; bh=DpwA8+Z1us1hCQ1sxnVN+WQyKfCu23toY0RXsYkol4c=; b=O ktiinRwCfKyNeOd4MhWFIp+W6o9B/rwz3pFLo0uvbbwa8eR99HYvKuxM1IXAkA+j pG0ZxjaDYsybBweDDgIqy8bl1M3zKf/CYk/IQkMbgX9nZi/2jEVIl+O9z799NWaM pT1BlyJq3xOtYgnDlGVUkn8YBMtks/NJSnzVekwvnW99OZ9xGxfLpdTNS8BRQOij fdgwq7aRViL24VxiGkVjXaRLCmVsoBvh5fj0aJiVilh2VNU23lkKG5QJCSvl39P7 2ej8xObK3JaLqBvgREveZKGDx+p8eLCi9+Fdg1FcSVVw6f9522UeU9iVBNDLK/th ytvwTMVry7/wN1/9rTufw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheefgddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtgfgggfukfffvffosehtqhhmtd hhtdejnecuhfhrohhmpefrrghvvghlucfuhhhlhigrkhcuoehprdhshhhlhigrkhesphgr nhhthhgvrhigrdhorhhgqeenucggtffrrghtthgvrhhnpefgieffleefuedvteektdduhf ekheejgeejtdekveefheekhfdvkeejleefgfdttdenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgrnhhthhgvrhigrd horhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <55406@debbugs.gnu.org>; Sun, 15 May 2022 13:00:15 -0400 (EDT) From: Pavel Shlyak Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Message-Id: Date: Sun, 15 May 2022 20:00:14 +0300 X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Sun, 15 May 2022 18:16:46 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) It looks like setting esp flag with (flags '(esp)) also sets file system = to vfat. However, 1. I still cannot resolve boot flag issue 2. I do not need that flag and I=E2=80=99d be glad getting correct = partition without it= From unknown Sun Jun 22 17:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55406: WIP: Image API support for fat16 partitions References: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> In-Reply-To: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 20 May 2022 17:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 55406@debbugs.gnu.org Received: via spool by 55406-submit@debbugs.gnu.org id=B55406.16530676793790 (code B ref 55406); Fri, 20 May 2022 17:28:02 +0000 Received: (at 55406) by debbugs.gnu.org; 20 May 2022 17:27:59 +0000 Received: from localhost ([127.0.0.1]:40016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns6Ps-0000z1-DL for submit@debbugs.gnu.org; Fri, 20 May 2022 13:27:59 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns60i-0000Kl-JY for 55406@debbugs.gnu.org; Fri, 20 May 2022 13:01:57 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6350B5C0176 for <55406@debbugs.gnu.org>; Fri, 20 May 2022 13:01:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 20 May 2022 13:01:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1653066109; x=1653152509; bh=60XrWM/7KA25r3YEJmefnTj2h3hIx2WQeAs uu5psL6w=; b=krpWUZPnf5vF6ic42yjFBh4gWsox4HTJ1z5raraXc85L2zxD0H9 u1vBpgxnwfYWks1cAXXqap1x5KO3x670pSWmgEVqZiBhNhbaAEpiSvDSSd9OMkDs VsaYZSil7B1+h+4E0FAHr4OwhUqgMFdLnAhT4vSQYNX+h3OoXmeXE1vq0LEFO9oD fYKewzzYdOc1h2BG8fBgQEkSKCh9PAYy9HprtwuI6PqpzDjIfWUU0Xw8m8yRfdRc ujC95ek/MoBQm05MSRrfNPEPv7roIfbvEhkLD65CWI+8P8ZAp88QW4R+dsBZi0nU m5NYV7rdDO3gifpfS0DpV1dt/UETnAymvug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653066109; x= 1653152509; bh=60XrWM/7KA25r3YEJmefnTj2h3hIx2WQeAsuu5psL6w=; b=S dn5ybMYCUoqqIU33inwuHlWILqPnp3J2O1Mh/FIFF0YxLhrJiSKuWN4OaoyGQbVh g2X5XlpbsmL9D1DWDr5vhzIaepXV/R3GJedd1DnV88+vVHG7w/92m9aO6ZiznYVu hsqyqIzuAdzOnGgrUxPdvQFf2UA8QZGPjDBwplYfD3aJzAEnW7w6rvOMyIbyQqAS nJ5miL+yR1q1Zaa0VAa4dbS05mthqoNNbSi3SkNLgnQd/pz99c89EH4nfKqxFueG 8uFzpUx2A+KmLezsaG4/oVfSQGtz5YQ79ZH2dkEv+mt8X0NOXWvWu0ClKGUorT6f OaMY0PUJ86rzTUMV7eRYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieefgddutdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtggguffkfffvofesmhdtmherhh dtjeenucfhrhhomheprfgrvhgvlhcuufhhlhihrghkuceophdrshhhlhihrghksehprghn thhhvghrgidrohhrgheqnecuggftrfgrthhtvghrnhepiedvgefhueeigfegffffudevte ffffehtedvvdefieevffdtjeelffdtffeujedtnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepphdrshhhlhihrghksehprghnthhhvghrgidroh hrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <55406@debbugs.gnu.org>; Fri, 20 May 2022 13:01:48 -0400 (EDT) From: Pavel Shlyak Content-Type: multipart/mixed; boundary="Apple-Mail=_C26817B6-2E89-43A3-B968-96788B71F0D6" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Message-Id: <332533F2-B819-4EF4-9EAA-FBB55AAD13E5@pantherx.org> Date: Fri, 20 May 2022 20:01:45 +0300 X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Fri, 20 May 2022 13:27:55 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_C26817B6-2E89-43A3-B968-96788B71F0D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 I have written a small patch to partially fix the issue. Flags are still = not set. GPT is still not fixed. There=E2=80=99s no need to return file = systems that are not supported in make-partition-image function in = gnu/build/image.scm --Apple-Mail=_C26817B6-2E89-43A3-B968-96788B71F0D6 Content-Disposition: attachment; filename=mbr-support-vfat-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="mbr-support-vfat-partitions.patch" Content-Transfer-Encoding: 7bit diff --git a/gnu/system/image.scm b/gnu/system/image.scm index 42e215f614..a83f844682 100644 --- a/gnu/system/image.scm +++ b/gnu/system/image.scm @@ -304,10 +304,15 @@ (define (format->image-type format) (define (partition->dos-type partition) ;; Return the MBR partition type corresponding to the given PARTITION. ;; See: https://en.wikipedia.org/wiki/Partition_type. - (let ((flags (partition-flags partition))) + (let ((flags (partition-flags partition)) (file-system (partition-file-system partition))) (cond - ((member 'esp flags) "0xEF") - (else "0x83")))) + ((member 'esp flags) "0xEF") + ((string-prefix? "ext" file-system) "0x83") + ((string=? file-system "vfat") "0x0E") + (else + (raise (condition + (&message + (message "unsupported partition type")))))))) (define (partition->gpt-type partition) ;; Return the genimage GPT partition type code corresponding to PARTITION. --Apple-Mail=_C26817B6-2E89-43A3-B968-96788B71F0D6-- From unknown Sun Jun 22 17:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55406: WIP: Image API support for fat16 partitions References: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> In-Reply-To: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 20 May 2022 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 55406@debbugs.gnu.org Received: via spool by 55406-submit@debbugs.gnu.org id=B55406.16530787656425 (code B ref 55406); Fri, 20 May 2022 20:33:02 +0000 Received: (at 55406) by debbugs.gnu.org; 20 May 2022 20:32:45 +0000 Received: from localhost ([127.0.0.1]:40175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns9If-0001fV-KG for submit@debbugs.gnu.org; Fri, 20 May 2022 16:32:45 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:58629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns8i9-0000hH-A9 for 55406@debbugs.gnu.org; Fri, 20 May 2022 15:54:58 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 413D6320096C for <55406@debbugs.gnu.org>; Fri, 20 May 2022 15:54:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 20 May 2022 15:54:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1653076490; x=1653162890; bh=O4VdmWTmofyZC1gQkQS/C+2XhToW2ndFtaW 2uYVubpQ=; b=ah5JDnKGmT2Uh9pamEum60F714iWqgt4z7Joq9RrmsgNjEt+1/i fnjw05LQkyrXkEZH7pBaWnuebB5lu4OLgbu1w7aH+wWGA/24w4+Dz3h2MMRwb8a0 7TZKYoDQEFbpnBbBXg6Wstq5v3PyLN9arZlmpZHpLzeFQEB46zGee/eK03ajOprm sVdRvc7VGu6qC2Sd0mFvwfOMDAsGR7dkrnGhyumN0CxB14BQRuP4fsf80R0lFxN+ uTRh/4EBUAvf06/jPF0a3JaR446xYewGa+bMcQ1okvA9LbwOI21FC8KjTDQpTnaU INDyRx2D8hYDvOffeHZoj3IFK/ihrBQTDHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653076490; x= 1653162890; bh=O4VdmWTmofyZC1gQkQS/C+2XhToW2ndFtaW2uYVubpQ=; b=S dCtQozNMxlzMIKgOU1O4/pFCYnCYyUexbukQsrjmipYgZDu0njePPTNxPktFVuXs LiXdV2PJXFLONLvVJukuDZoHmuvTdBPOWFC/4V2M3CLu6nTMX2LApQKwgnZPuRJy Oml5tw9DOvoQ97ER8lvJPVXGKsqMR4cGsFTFgwXXeg5iOwedLJQsLkvwYQKmYbpE wRwcp2broOXTBXfUDIWmctUxv/urMJB8Tz9uhjQL1sLRh7QYzTlzoGfb8zOLgkC4 5qZx6/SWbPbjikMPFGZupocFsEeiG/o1+t3EguLnGr/IyIVWNz4nHR0AJyzLDPF0 TGV4sgDByAIE2QGDzAKMg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieefgddugedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtggguffkfffvofesmhdtmherhh dtvdenucfhrhhomheprfgrvhgvlhcuufhhlhihrghkuceophdrshhhlhihrghksehprghn thhhvghrgidrohhrgheqnecuggftrfgrthhtvghrnhepjeeiheefieevtefghfegveefhe duffekfeegkeegkefghfefleeljeegvdfhledunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepphdrshhhlhihrghksehprghnthhhvghrgidroh hrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <55406@debbugs.gnu.org>; Fri, 20 May 2022 15:54:50 -0400 (EDT) From: Pavel Shlyak Content-Type: multipart/mixed; boundary="Apple-Mail=_3E4E0DCA-B609-474E-A9E2-3E49666CC6CC" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Message-Id: Date: Fri, 20 May 2022 22:54:47 +0300 X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Fri, 20 May 2022 16:32:41 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_3E4E0DCA-B609-474E-A9E2-3E49666CC6CC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii This patch fixes GPT support for fat partitions. Should be applied after = gpt-support-vfat-partitions.patch --Apple-Mail=_3E4E0DCA-B609-474E-A9E2-3E49666CC6CC Content-Disposition: attachment; filename=gpt-support-vfat-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="gpt-support-vfat-partitions.patch" Content-Transfer-Encoding: 7bit diff --git a/gnu/system/image.scm b/gnu/system/image.scm index a83f844682..a6267feab2 100644 --- a/gnu/system/image.scm +++ b/gnu/system/image.scm @@ -317,10 +317,15 @@ (define (partition->dos-type partition) (define (partition->gpt-type partition) ;; Return the genimage GPT partition type code corresponding to PARTITION. ;; See https://github.com/pengutronix/genimage/blob/master/README.rst - (let ((flags (partition-flags partition))) + (let ((flags (partition-flags partition)) (file-system (partition-file-system partition))) (cond ((member 'esp flags) "U") - (else "L")))) + ((string-prefix? "ext" file-system) "L") + ((string=? file-system "vfat") "F") + (else + (raise (condition + (&message + (message "unsupported partition type")))))))) (define (partition-image partition) ;; Return as a file-like object, an image of the given PARTITION. A --Apple-Mail=_3E4E0DCA-B609-474E-A9E2-3E49666CC6CC-- From unknown Sun Jun 22 17:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55406: Patch to handle boot flag in Image API References: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> In-Reply-To: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 21 May 2022 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 55406@debbugs.gnu.org Received: via spool by 55406-submit@debbugs.gnu.org id=B55406.165315170428942 (code B ref 55406); Sat, 21 May 2022 16:49:02 +0000 Received: (at 55406) by debbugs.gnu.org; 21 May 2022 16:48:24 +0000 Received: from localhost ([127.0.0.1]:42865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsSH9-0007Wi-BC for submit@debbugs.gnu.org; Sat, 21 May 2022 12:48:24 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:43133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsOr9-0005LQ-TL for 55406@debbugs.gnu.org; Sat, 21 May 2022 09:09:22 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 14C8F32002E8 for <55406@debbugs.gnu.org>; Sat, 21 May 2022 09:09:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 21 May 2022 09:09:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1653138552; x=1653224952; bh=ccnoPTp9FJHVwzVO5Ox1BFkEWI9Xs/VzLPj OjeCpwu8=; b=PRXwD5OksaFqinIuC2boDW06LuVt12651SnrVf3g4qUO1lnE5o5 fsdKJglp0M5XHBHHa24GhdpP5Afk2oueMEYtQ9k6Mq4b0mEoZNyBNr3O9Aq9BoE1 PQCEn32F2Tce30IbWyA0CgXdvvWNX1E7QLs18smOlOtXplQImUvk34JY1jTZtGoS ubzrOONpy5JGWJKw1UxueuZ++qifZ6tvQ73qycOvsLimHl0rfmcCgfRDJ8XsmXyE 8psGvtS9GhSX4Nz/JhWEItaMYkasn90WpoDjGCuyGfCFADiOBANOkXkCaKcg5YgJ p2PvFXnIdfPBDhrVH+1BT+qCO8kb+MXFEKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653138552; x= 1653224952; bh=ccnoPTp9FJHVwzVO5Ox1BFkEWI9Xs/VzLPjOjeCpwu8=; b=M Udeoyc3cnUyEaxJZ122hobXPlXrxeA6adPf1LK6laGdrdrEPQNz85HKzyw2mJmif uk0Fkor6j+0BVnchoNe2CDE2RhG6fZ4baDEwfaDxEIwxzbk6iMJbFjHwYGSCuIK2 MZm8llEFOe7zi+Ec4J8YJuiikGQjQuq9IcguGV0pBbOuxy8RosU7r2CDtg+KF3Vc +DYZG3VRVSsNJqX6Y8Qo4NiDFMwScGTWKiAUNLTovDPNOow9t8RgCCeqL3h+pZVj UkdDNsPVjoMZHVuvsZkrmUCt87tWIJBbjM9647/3wSAeiU1XO+kjfioeItJBGy+T a/xzEJ4+dscnm4Xs8EZog== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieeigdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephfgtggfukfffvffosehmtdhmrehhtd ejnecuhfhrohhmpefrrghvvghlucfuhhhlhigrkhcuoehprdhshhhlhigrkhesphgrnhht hhgvrhigrdhorhhgqeenucggtffrrghtthgvrhhnpeeivdeghfeuiefggeffffduveetff ffheetvddvfeeivefftdejlefftdffueejtdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgrnhhthhgvrhigrdhorh hg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <55406@debbugs.gnu.org>; Sat, 21 May 2022 09:09:11 -0400 (EDT) From: Pavel Shlyak Content-Type: multipart/mixed; boundary="Apple-Mail=_2F485A46-F632-4F27-AB75-92B811BCB156" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Message-Id: <37ECE4BB-C5C7-4C9E-A54A-03F12EA2464E@pantherx.org> Date: Sat, 21 May 2022 16:09:07 +0300 X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Sat, 21 May 2022 12:48:22 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_2F485A46-F632-4F27-AB75-92B811BCB156 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Here=E2=80=99s the last patch in the set that adds support for the boot = flag. It should be merged after mbr-support-vfat-partitions.patch and = gpt-support-vfat-partitions.patch The issue can be closed as soon as all three patches are merged. Have a nice day! =20= --Apple-Mail=_2F485A46-F632-4F27-AB75-92B811BCB156 Content-Disposition: attachment; filename=support-bootable-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="support-bootable-partitions.patch" Content-Transfer-Encoding: 7bit cdiff --git a/gnu/build/image.scm b/gnu/build/image.scm index 81caa424f8..321fba40e3 100644 --- a/gnu/build/image.scm +++ b/gnu/build/image.scm @@ -48,12 +48,13 @@ (define (sexp->partition sexp) "Take SEXP, a tuple as returned by 'partition->gexp', and turn it into a record." (match sexp - ((size file-system file-system-options label uuid) + ((size file-system file-system-options label uuid flags) (partition (size size) (file-system file-system) (file-system-options file-system-options) (label label) - (uuid uuid))))) + (uuid uuid) + (flags flags))))) (define (size-in-kib size) "Convert SIZE expressed in bytes, to kilobytes and return it as a string." @@ -78,6 +79,7 @@ (define* (make-ext-image partition target root (fs-options (partition-file-system-options partition)) (label (partition-label partition)) (uuid (partition-uuid partition)) + (flags (partition-flags partition)) (journal-options "lazy_itable_init=1,lazy_journal_init=1")) (apply invoke `("fakeroot" "mke2fs" "-t" ,fs "-d" ,root diff --git a/gnu/system/image.scm b/gnu/system/image.scm index a6267feab2..d903cb4579 100644 --- a/gnu/system/image.scm +++ b/gnu/system/image.scm @@ -218,7 +218,8 @@ (define (partition->gexp partition) #$(partition-file-system-options partition) #$(partition-label partition) #$(and=> (partition-uuid partition) - uuid-bytevector))) + uuid-bytevector) + #$(partition-flags partition))) (define gcrypt-sqlite3&co ;; Guile-Gcrypt, Guile-SQLite3, and their propagated inputs. @@ -392,17 +393,21 @@ (define (partition->config image partition) (partition-type-values image partition))) (let ((label (partition-label partition)) (image (partition-image partition)) - (offset (partition-offset partition))) + (offset (partition-offset partition)) + (bootable (if (member 'boot (partition-flags partition)) + "true" "false" ))) #~(format #f "~/partition ~a { ~/~/~a = ~a ~/~/image = \"~a\" ~/~/offset = \"~a\" + ~/~/bootable = \"~a\" ~/}" #$label #$partition-type-attribute #$partition-type-value #$image - #$offset)))) + #$offset + #$bootable)))) (define (genimage-type-options image-type image) (cond --Apple-Mail=_2F485A46-F632-4F27-AB75-92B811BCB156-- From unknown Sun Jun 22 17:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55406: GUIX Image API: wrong fs type and flag Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 22 May 2022 13:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Pavel Shlyak Cc: 55406@debbugs.gnu.org Received: via spool by 55406-submit@debbugs.gnu.org id=B55406.165322641825061 (code B ref 55406); Sun, 22 May 2022 13:34:01 +0000 Received: (at 55406) by debbugs.gnu.org; 22 May 2022 13:33:38 +0000 Received: from localhost ([127.0.0.1]:43984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsliE-0006W9-3S for submit@debbugs.gnu.org; Sun, 22 May 2022 09:33:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsliB-0006Vv-Ia for 55406@debbugs.gnu.org; Sun, 22 May 2022 09:33:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsli6-0005sb-7f; Sun, 22 May 2022 09:33:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=cR55PrRlthLMvLbpKWcJLn+P021EggCNtV8Ylu9QuwQ=; b=bVttn6hYFmhhUpcSzNGZ oRemnFX92YJN1fPuB1zaHN/1Mzi552VSrke2NLKIajQ+dJVRTh9tWikd99mDkZ62nmGqaQp6XACN+ DRwOcNycLXcGe9Dmde9x/cdRnT/FLN6j1tCCcfmr2oHnhJ7T/WfH0LM4M/e3NO9YSj/nRkBBWMBRM vrC2jHebD3tCC3gDBQlNWWIkTI7AowzpnMGfggvYrfj9UAa+KiqYbH90DhEoZCXdLWTVKOefbmXo9 gAExCKY3EBOiYqpeaoEZWAgcqOAkZvSGHvMB3JlB8a+2J1A2uVD20NMQqbJ4QIoIVG1zgF/DKZUsf bYSMrk5b80P0cw==; Received: from [109.190.253.11] (port=41308 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsli5-0007DL-A8; Sun, 22 May 2022 09:33:30 -0400 From: Mathieu Othacehe References: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> <37ECE4BB-C5C7-4C9E-A54A-03F12EA2464E@pantherx.org> Date: Sun, 22 May 2022 15:33:22 +0200 In-Reply-To: <37ECE4BB-C5C7-4C9E-A54A-03F12EA2464E@pantherx.org> (Pavel Shlyak's message of "Sat, 21 May 2022 16:09:07 +0300") Message-ID: <87zgj91yl9.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Pavel, > Here=E2=80=99s the last patch in the set that adds support for the boot > flag. It should be merged after mbr-support-vfat-partitions.patch and > gpt-support-vfat-partitions.patch The issue can be closed as soon as > all three patches are merged. Have a nice day! Thanks for those three patches. At first sight, they look fine :) It would be great if you could resend them using "git format-patch", following the guidelines available here: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html. Could you also add your copyright on top of the edited files? Mathieu From unknown Sun Jun 22 17:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55406: [PATCH] GUIX Image API support for vfat and boot flag Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 22 May 2022 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 55406@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165322816629854 (code B ref -1); Sun, 22 May 2022 14:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 May 2022 14:02:46 +0000 Received: from localhost ([127.0.0.1]:46101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsmAQ-0007lS-Ff for submit@debbugs.gnu.org; Sun, 22 May 2022 10:02:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:52236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsmAM-0007lD-3y for submit@debbugs.gnu.org; Sun, 22 May 2022 10:02:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsmAL-0008J7-Tw for guix-patches@gnu.org; Sun, 22 May 2022 10:02:41 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:48637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsmAJ-0001r3-Rf; Sun, 22 May 2022 10:02:41 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 85007320005D; Sun, 22 May 2022 10:02:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 22 May 2022 10:02:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1653228157; x=1653314557; bh=nW9J9zo0eN TeWMGTeMyV66xU8q+UUqF7EM7OF66K5z8=; b=CyZMyuFrJLgF2CVNF6ftYcDnFC pLIXPnE33rav5VTpvbLUcBeW+LgQoDXWXDR9BF6oMGHuJm+I3uHql1n5q9LWDbwE uXhhGVN5q+iQ7TgXP3Kl655zJLOcbCj7nPqRlTzYSh3qD5bha7VXpO6uWTYhggrs mHV8cg+16MVOwCvgxKyWPiiScTlh+kpZUMF5eSXGN+P/6SWvJXt6cY/CoNUWHAjt T18LlZE6sMm51DjztiVDugjxZiPdsUJFNczSjrT6SCRg80SG4v4NHrN70dpKFy+V /aRv4KutrOlBKNKyveH8WwM5NefLETuuGeWnYHxdqn7NJPkNMk5dHo2TNFqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653228157; x=1653314557; bh=nW9J9zo0eNTeWMGTeMyV66xU8q+U UqF7EM7OF66K5z8=; b=Nl4OH+6tHtfNy12aDfLvT0+C4njQbKxgDqzCwzL1P0Ct q3Vpr8gepigUtDIZDnxb1i5QUgoInzyFGCBUFNXXeVS8QIta7Ocfhux7aYkmSRjI NwqiNGmppEEV2cpf2buyLkyIOBEh1d1wmr/V+bRAILY+yVu+QeZNv7m58EgLIDFU vHDr6vd11rJecsSGu+FCt9V0j057ACoxXVJCzXfLsg1Jtv1Dk18ewaNdvScT9yy/ bqA/iPvkHkLFi+LGbQyAJuawvHqoSyYCJFp6IW2nWgpqA04e2pJ+e8aa1wU220Sb +EKfq+PLFstD24mSC/dUInisCNR0EabaglQn3um7Og== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieekgdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhkfgtggfuffgjvefvfhfosehmtdhmrehhtddvnecuhfhrohhmpefrrghvvghl ucfuhhhlhigrkhcuoehprdhshhhlhigrkhesphgrnhhthhgvrhigrdhorhhgqeenucggtf frrghtthgvrhhnpeehhfegffffudetieffvddukeethfeiudeugfeuvefgheeiudettedv vedvgeehtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehprdhshhhlhigrkhesphgrnhhthhgvrhigrdhorhhg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 22 May 2022 10:02:35 -0400 (EDT) From: Pavel Shlyak Message-Id: <895504EA-0884-481A-BCB7-189C38D42740@pantherx.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_99FBFEF4-1574-486F-9DDB-25AB95B4199F" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Date: Sun, 22 May 2022 17:02:33 +0300 In-Reply-To: <87zgj91yl9.fsf_-_@gnu.org> References: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> <37ECE4BB-C5C7-4C9E-A54A-03F12EA2464E@pantherx.org> <87zgj91yl9.fsf_-_@gnu.org> X-Mailer: Apple Mail (2.3696.100.31) Received-SPF: pass client-ip=64.147.123.20; envelope-from=p.shlyak@pantherx.org; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --Apple-Mail=_99FBFEF4-1574-486F-9DDB-25AB95B4199F Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Ok, I tried to format them :) --Apple-Mail=_99FBFEF4-1574-486F-9DDB-25AB95B4199F Content-Disposition: attachment; filename=0001-Image-API-support-VFAT-partitions-in-MBR.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Image-API-support-VFAT-partitions-in-MBR.patch" Content-Transfer-Encoding: quoted-printable =46rom=20ec65ce70cfb26a9936099cdb0d1a156a747fa42b=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Sun,=2022=20May=202022=2016:52:45=20+0300=0ASubject:=20[PATCH=20= 1/4]=20Image=20API:=20support=20VFAT=20partitions=20in=20MBR=0A=0A---=0A=20= gnu/system/image.scm=20|=2011=20++++++++---=0A=201=20file=20changed,=208=20= insertions(+),=203=20deletions(-)=0A=0Adiff=20--git=20= a/gnu/system/image.scm=20b/gnu/system/image.scm=0Aindex=20= 42e215f614..a83f844682=20100644=0A---=20a/gnu/system/image.scm=0A+++=20= b/gnu/system/image.scm=0A@@=20-304,10=20+304,15=20@@=20(define=20= (format->image-type=20format)=0A=20=20=20=20=20(define=20= (partition->dos-type=20partition)=0A=20=20=20=20=20=20=20;;=20Return=20= the=20MBR=20partition=20type=20corresponding=20to=20the=20given=20= PARTITION.=0A=20=20=20=20=20=20=20;;=20See:=20= https://en.wikipedia.org/wiki/Partition_type.=0A-=20=20=20=20=20=20(let=20= ((flags=20(partition-flags=20partition)))=0A+=20=20=20=20=20=20(let=20= ((flags=20(partition-flags=20partition))=20(file-system=20= (partition-file-system=20partition)))=0A=20=20=20=20=20=20=20=20=20(cond=0A= -=20=20=20=20=20=20=20=20=20((member=20'esp=20flags)=20"0xEF")=0A-=20=20=20= =20=20=20=20=20=20(else=20"0x83"))))=0A+=20=20=20=20=20=20=20=20=20=20= ((member=20'esp=20flags)=20"0xEF")=0A+=20=20=20=20=20=20=20=20=20=20= ((string-prefix?=20"ext"=20file-system)=20"0x83")=0A+=20=20=20=20=20=20=20= =20=20=20((string=3D?=20file-system=20"vfat")=20"0x0E")=0A+=20=20=20=20=20= =20=20=20=20=20(else=0A+=20=20=20=20=20=20=20=20=20=20=20=20(raise=20= (condition=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(message=20"unsupported=20= partition=20type"))))))))=0A=20=0A=20=20=20=20=20(define=20= (partition->gpt-type=20partition)=0A=20=20=20=20=20=20=20;;=20Return=20= the=20genimage=20GPT=20partition=20type=20code=20corresponding=20to=20= PARTITION.=0A--=20=0A2.32.1=20(Apple=20Git-133)=0A=0A= --Apple-Mail=_99FBFEF4-1574-486F-9DDB-25AB95B4199F Content-Disposition: attachment; filename=0002-Image-API-support-VFAT-partitions-in-GPT.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0002-Image-API-support-VFAT-partitions-in-GPT.patch" Content-Transfer-Encoding: quoted-printable =46rom=2087dd32f21450c4f84c55f6afc11ba1979e201ec9=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Sun,=2022=20May=202022=2016:53:30=20+0300=0ASubject:=20[PATCH=20= 2/4]=20Image=20API:=20support=20VFAT=20partitions=20in=20GPT=0A=0A---=0A=20= gnu/system/image.scm=20|=209=20+++++++--=0A=201=20file=20changed,=207=20= insertions(+),=202=20deletions(-)=0A=0Adiff=20--git=20= a/gnu/system/image.scm=20b/gnu/system/image.scm=0Aindex=20= a83f844682..a6267feab2=20100644=0A---=20a/gnu/system/image.scm=0A+++=20= b/gnu/system/image.scm=0A@@=20-317,10=20+317,15=20@@=20(define=20= (partition->dos-type=20partition)=0A=20=20=20=20=20(define=20= (partition->gpt-type=20partition)=0A=20=20=20=20=20=20=20;;=20Return=20= the=20genimage=20GPT=20partition=20type=20code=20corresponding=20to=20= PARTITION.=0A=20=20=20=20=20=20=20;;=20See=20= https://github.com/pengutronix/genimage/blob/master/README.rst=0A-=20=20=20= =20=20=20(let=20((flags=20(partition-flags=20partition)))=0A+=20=20=20=20= =20=20(let=20((flags=20(partition-flags=20partition))=20(file-system=20= (partition-file-system=20partition)))=0A=20=20=20=20=20=20=20=20=20(cond=0A= =20=20=20=20=20=20=20=20=20=20=20((member=20'esp=20flags)=20"U")=0A-=20=20= =20=20=20=20=20=20=20=20(else=20"L"))))=0A+=20=20=20=20=20=20=20=20=20=20= ((string-prefix?=20"ext"=20file-system)=20"L")=0A+=20=20=20=20=20=20=20=20= =20=20((string=3D?=20file-system=20"vfat")=20"F")=0A+=20=20=20=20=20=20=20= =20=20=20(else=0A+=20=20=20=20=20=20=20=20=20=20=20=20(raise=20= (condition=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(message=20"unsupported=20= partition=20type"))))))))=0A=20=0A=20=20=20=20=20(define=20= (partition-image=20partition)=0A=20=20=20=20=20=20=20;;=20Return=20as=20= a=20file-like=20object,=20an=20image=20of=20the=20given=20PARTITION.=20=20= A=0A--=20=0A2.32.1=20(Apple=20Git-133)=0A=0A= --Apple-Mail=_99FBFEF4-1574-486F-9DDB-25AB95B4199F Content-Disposition: attachment; filename=0003-Image-API-support-boot-flag.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0003-Image-API-support-boot-flag.patch" Content-Transfer-Encoding: quoted-printable =46rom=2062980309a32ca1ecc5547345bdbc706d42c59d3b=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Sun,=2022=20May=202022=2016:53:49=20+0300=0ASubject:=20[PATCH=20= 3/4]=20Image=20API:=20support=20boot=20flag=0A=0A---=0A=20= gnu/build/image.scm=20=20|=20=206=20++++--=0A=20gnu/system/image.scm=20|=20= 11=20++++++++---=0A=202=20files=20changed,=2012=20insertions(+),=205=20= deletions(-)=0A=0Adiff=20--git=20a/gnu/build/image.scm=20= b/gnu/build/image.scm=0Aindex=2081caa424f8..321fba40e3=20100644=0A---=20= a/gnu/build/image.scm=0A+++=20b/gnu/build/image.scm=0A@@=20-48,12=20= +48,13=20@@=20(define=20(sexp->partition=20sexp)=0A=20=20=20"Take=20= SEXP,=20a=20tuple=20as=20returned=20by=20'partition->gexp',=20and=20turn=20= it=20into=20a=0A=20=20record."=0A=20=20=20(match=20sexp=0A-=20= =20=20=20((size=20file-system=20file-system-options=20label=20uuid)=0A+=20= =20=20=20((size=20file-system=20file-system-options=20label=20uuid=20= flags)=0A=20=20=20=20=20=20(partition=20(size=20size)=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(file-system=20file-system)=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(file-system-options=20= file-system-options)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (label=20label)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(uuid=20= uuid)))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(uuid=20= uuid)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(flags=20= flags)))))=0A=20=0A=20(define=20(size-in-kib=20size)=0A=20=20=20"Convert=20= SIZE=20expressed=20in=20bytes,=20to=20kilobytes=20and=20return=20it=20as=20= a=20string."=0A@@=20-78,6=20+79,7=20@@=20(define*=20(make-ext-image=20= partition=20target=20root=0A=20=20=20=20=20=20=20=20=20(fs-options=20= (partition-file-system-options=20partition))=0A=20=20=20=20=20=20=20=20=20= (label=20(partition-label=20partition))=0A=20=20=20=20=20=20=20=20=20= (uuid=20(partition-uuid=20partition))=0A+=20=20=20=20=20=20=20=20(flags=20= (partition-flags=20partition))=0A=20=20=20=20=20=20=20=20=20= (journal-options=20"lazy_itable_init=3D1,lazy_journal_init=3D1"))=0A=20=20= =20=20=20(apply=20invoke=0A=20=20=20=20=20=20=20=20=20=20=20=20= `("fakeroot"=20"mke2fs"=20"-t"=20,fs=20"-d"=20,root=0Adiff=20--git=20= a/gnu/system/image.scm=20b/gnu/system/image.scm=0Aindex=20= a6267feab2..d903cb4579=20100644=0A---=20a/gnu/system/image.scm=0A+++=20= b/gnu/system/image.scm=0A@@=20-218,7=20+218,8=20@@=20(define=20= (partition->gexp=20partition)=0A=20=20=20=20=20=20=20= #$(partition-file-system-options=20partition)=0A=20=20=20=20=20=20=20= #$(partition-label=20partition)=0A=20=20=20=20=20=20=20#$(and=3D>=20= (partition-uuid=20partition)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20uuid-bytevector)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= uuid-bytevector)=0A+=20=20=20=20=20=20#$(partition-flags=20partition)))=0A= =20=0A=20(define=20gcrypt-sqlite3&co=0A=20=20=20;;=20Guile-Gcrypt,=20= Guile-SQLite3,=20and=20their=20propagated=20inputs.=0A@@=20-392,17=20= +393,21=20@@=20(define=20(partition->config=20image=20partition)=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (partition-type-values=20image=20partition)))=0A=20=20=20=20=20=20=20=20=20= (let=20((label=20(partition-label=20partition))=0A=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(image=20(partition-image=20partition))=0A-=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(offset=20(partition-offset=20= partition)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20(offset=20= (partition-offset=20partition))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(bootable=20(if=20(member=20'boot=20(partition-flags=20partition))=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20"true"=20"false"=20)))=0A=20=20=20=20=20=20=20=20=20=20=20= #~(format=20#f=20"~/partition=20~a=20{=0A=20=20=20~/~/~a=20=3D=20~a=0A=20= =20=20~/~/image=20=3D=20\"~a\"=0A=20=20=20~/~/offset=20=3D=20\"~a\"=0A+=20= =20~/~/bootable=20=3D=20\"~a\"=0A=20=20=20~/}"=0A=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20#$label=0A=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20#$partition-type-attribute=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= #$partition-type-value=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20#$image=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20#$offset))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20#$offset=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20#$bootable))))=0A=20=0A=20=20=20=20=20(define=20= (genimage-type-options=20image-type=20image)=0A=20=20=20=20=20=20=20= (cond=0A--=20=0A2.32.1=20(Apple=20Git-133)=0A=0A= --Apple-Mail=_99FBFEF4-1574-486F-9DDB-25AB95B4199F Content-Disposition: attachment; filename=0004-Update-copyright.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0004-Update-copyright.patch" Content-Transfer-Encoding: quoted-printable =46rom=20e8d8130a3c06c43715879d5d74ded2fa8e57dd2e=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Sun,=2022=20May=202022=2016:58:22=20+0300=0ASubject:=20[PATCH=20= 4/4]=20Update=20copyright=0A=0A---=0A=20gnu/build/image.scm=20=20|=201=20= +=0A=20gnu/system/image.scm=20|=201=20+=0A=202=20files=20changed,=202=20= insertions(+)=0A=0Adiff=20--git=20a/gnu/build/image.scm=20= b/gnu/build/image.scm=0Aindex=20321fba40e3..3e8b94e2d6=20100644=0A---=20= a/gnu/build/image.scm=0A+++=20b/gnu/build/image.scm=0A@@=20-5,6=20+5,7=20= @@=0A=20;;;=20Copyright=20=C2=A9=202017=20Marius=20Bakke=20= =0A=20;;;=20Copyright=20=C2=A9=202020,=202022=20= Tobias=20Geerinckx-Rice=20=0A=20;;;=20Copyright=20=C2=A9=20= 2020=20Mathieu=20Othacehe=20=0A+;;;=20Copyright=20= =C2=A9=202022=20Pavel=20Shlyak=20=0A=20;;;=0A=20= ;;;=20This=20file=20is=20part=20of=20GNU=20Guix.=0A=20;;;=0Adiff=20--git=20= a/gnu/system/image.scm=20b/gnu/system/image.scm=0Aindex=20= d903cb4579..e1eecabc33=20100644=0A---=20a/gnu/system/image.scm=0A+++=20= b/gnu/system/image.scm=0A@@=20-1,6=20+1,7=20@@=0A=20;;;=20GNU=20Guix=20= ---=20Functional=20package=20management=20for=20GNU=0A=20;;;=20Copyright=20= =C2=A9=202020,=202021=20Mathieu=20Othacehe=20=0A=20= ;;;=20Copyright=20=C2=A9=202020=20Jan=20(janneke)=20Nieuwenhuizen=20= =0A+;;;=20Copyright=20=C2=A9=202022=20Pavel=20Shlyak=20= =0A=20;;;=0A=20;;;=20This=20file=20is=20part=20of=20= GNU=20Guix.=0A=20;;;=0A--=20=0A2.32.1=20(Apple=20Git-133)=0A=0A= --Apple-Mail=_99FBFEF4-1574-486F-9DDB-25AB95B4199F-- From unknown Sun Jun 22 17:15:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Pavel Shlyak Subject: bug#55406: closed (Re: bug#55406: GUIX Image API: wrong fs type and flag) Message-ID: References: <878rqslkgw.fsf_-_@gnu.org> <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> X-Gnu-PR-Message: they-closed 55406 X-Gnu-PR-Package: guix Reply-To: 55406@debbugs.gnu.org Date: Mon, 23 May 2022 08:31:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1653294662-30894-1" This is a multi-part message in MIME format... ------------=_1653294662-30894-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55406: GUIX Image API: wrong fs type and flag which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55406@debbugs.gnu.org. --=20 55406: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55406 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1653294662-30894-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55406-done) by debbugs.gnu.org; 23 May 2022 08:30:48 +0000 Received: from localhost ([127.0.0.1]:47229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt3Si-00081o-2q for submit@debbugs.gnu.org; Mon, 23 May 2022 04:30:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt3Se-00081X-QS for 55406-done@debbugs.gnu.org; Mon, 23 May 2022 04:30:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57110) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt3SY-0005o6-20; Mon, 23 May 2022 04:30:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=OPnYYNdNTBmJ2LxhjK8m5FoYYHq2adjDeigKpI5NyyY=; b=SB6ijkkIe7qqysIF4y0W ApZd8dZh3p4Gt2cG2nPU3oqX4us28Rq0ROhNDIc6RjniheEbKZICRqzGbvOx+HtZQt3PyysfIjIgo gUTMa2PXz8Fb882YTPMvdbqz63oY4ktX+QB1/wRi/2rKEtObny8QRX5ypVzVxhtGSr40vrwb6F6Y1 EC0hYjAPGO/VOa5RfGUTfYlShhSus8ihf+5cYUEHIa2tYkIaz6yqqguAssFkhWYJe86wz3d4c/mcB bzInwA2HPCVvW3OvQrLbrc1qdx8FjTVtTuwX3Eu26nKPFiZLBVi7NudTpnXS9kOXJCc+n9CDTXZzx F7YgScj98vfz0g==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2774.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2774]:36462 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt3SM-0001Ly-0U; Mon, 23 May 2022 04:30:32 -0400 From: Mathieu Othacehe To: Pavel Shlyak Subject: Re: bug#55406: GUIX Image API: wrong fs type and flag References: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> <37ECE4BB-C5C7-4C9E-A54A-03F12EA2464E@pantherx.org> <87zgj91yl9.fsf_-_@gnu.org> <895504EA-0884-481A-BCB7-189C38D42740@pantherx.org> Date: Mon, 23 May 2022 10:30:23 +0200 In-Reply-To: <895504EA-0884-481A-BCB7-189C38D42740@pantherx.org> (Pavel Shlyak's message of "Sun, 22 May 2022 17:02:33 +0300") Message-ID: <878rqslkgw.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55406-done Cc: 55406-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Pavel, > Ok, I tried to format them :) Thanks, I added commit messages following our guidelines, fixed the indentation and a few other small details. Pushed on master! Mathieu ------------=_1653294662-30894-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 May 2022 23:00:31 +0000 Received: from localhost ([127.0.0.1]:45288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npeGs-0007Dx-Bh for submit@debbugs.gnu.org; Fri, 13 May 2022 19:00:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:47498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npd7n-0004uo-Ir for submit@debbugs.gnu.org; Fri, 13 May 2022 17:47:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npd7n-0003xf-C9 for bug-guix@gnu.org; Fri, 13 May 2022 17:47:03 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:45982) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npd7l-0005rd-VV for bug-guix@gnu.org; Fri, 13 May 2022 17:47:03 -0400 Received: by mail-ed1-x52e.google.com with SMTP id be20so11352669edb.12 for ; Fri, 13 May 2022 14:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=TLmK96nxre60q2+vyAfDEHs6NN957oxrW8ESbYmsH1E=; b=aWv5QmWjqVol94WxyQrd8Fh2uPAAGwe8Buf0vsKF0brN8O/utNflgiRqJconmv6od+ kkkOyVYgU/SEglL31WR6nDssdjORnJ0njMJ9xvLMDmxW9fXzQLuafnag16WvGZBcAgah db9pldAbnU+SlBMLOs1cXzjrsg9KQ4irpKMDedAp8U1ldjviF1nBdHrM9K/Yqg7/rOdN iimUphy/THj98Qjz8G5G15J1wsNEUx1ys6nVrgtuv6a4bFNtFGq4zfo7qwYxULvnTLrp q5T0DGT+sz34kFkscQNd7fZhVtpm3/i0fgZfQtnHrFR7cbK6SShee0iIIL/Rha2JrTJa K1sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=TLmK96nxre60q2+vyAfDEHs6NN957oxrW8ESbYmsH1E=; b=innbJSFATu9IrPmnUYWqowhe9hDs6LJrY3LqLuwT1rVZZm4m268BOmKQ1uebEfqxNG zbg8/VvsSIXHEIHVYTVrrhV9GVh9arQBRUScL4bPelwjJBIK8hCs6olJ7dOdcJICFvat u3yGcDejeh3ME4czQIvMeNW+pu0Hw+QpOAR6yCExX+V4pq8iLm4pVoceceDHkKqqFTkQ 4YHMywGVZrut8ZD0l7mQ6NkY/ohY5s2UQvFcT2Hd+yN2kUMK5y2VkPKeYQNdBHqWXryq JOrvX3HzJ4MDRo+/f0+pZrh57CdL/ddLfrsy4kMQ1O2x36WvPGlfMXsjD5uQ1B3NNgbO m7ug== X-Gm-Message-State: AOAM5339ZjKuscbyupU05KBnmHO+F4cD5l4B3bplLrtUwDK2Rw4lwJQS jllSOWoImBpd1DHQpEVOTz1pzcZ7lkX/mzDd X-Google-Smtp-Source: ABdhPJyGSWP3WKprSzozZwwj0x1fhaUEf5lz87FNrQKC0bBny310qDK+SMslYpa7IYbV4tmDF9VDxg== X-Received: by 2002:a05:6402:1a34:b0:425:ca01:58ec with SMTP id be20-20020a0564021a3400b00425ca0158ecmr677143edb.373.1652478420209; Fri, 13 May 2022 14:47:00 -0700 (PDT) Received: from smtpclient.apple ([31.141.85.74]) by smtp.gmail.com with ESMTPSA id c18-20020aa7c992000000b0042617ba63d2sm1386046edt.92.2022.05.13.14.46.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 May 2022 14:46:59 -0700 (PDT) From: Pavel Shlyak Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: GUIX Image API: wrong fs type and flag Message-Id: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> Date: Sat, 14 May 2022 00:46:57 +0300 To: bug-guix@gnu.org X-Mailer: Apple Mail (2.3696.80.82.1.1) Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=shlyakpavel@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 13 May 2022 19:00:29 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I have a scheme code like (define rpi-boot-partition (partition (size (* 128 (expt 2 20))) (label "BOOT") (file-system "vfat") (flags '()) (initializer (gexp initialize-efi-partition)))) (define rpi-root-partition (partition (size 'guess) (label "RASPIROOT") (file-system "ext4") (flags '(boot)) (initializer (gexp initialize-root-partition)))) (define raspberry-pi-image (image (format 'disk-image) (partitions (list rpi-boot-partition rpi-root-partition)))) The output is like that: $ fdisk -l = /gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-ima= ge Device Boot Start End Sectors Size Id Type = /gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-ima= ge1 1 262144 262144 128M 83 Linux = /gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-ima= ge2 262145 3583688 3321544 1.6G 83 Linux=09 No boot flag is set on the first partition. The file system seems to be = incorrect (ext* instead of vfat)= ------------=_1653294662-30894-1-- From unknown Sun Jun 22 17:15:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Pavel Shlyak Subject: bug#55405: closed (Re: bug#55406: GUIX Image API: wrong fs type and flag) Message-ID: References: <878rqslkgw.fsf_-_@gnu.org> X-Gnu-PR-Message: they-closed 55405 X-Gnu-PR-Package: guix Reply-To: 55405@debbugs.gnu.org Date: Mon, 23 May 2022 08:31:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1653294662-30894-3" This is a multi-part message in MIME format... ------------=_1653294662-30894-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55406: Image API produces incorrect images which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55405@debbugs.gnu.org. --=20 55406: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55406 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1653294662-30894-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55406-done) by debbugs.gnu.org; 23 May 2022 08:30:48 +0000 Received: from localhost ([127.0.0.1]:47229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt3Si-00081o-2q for submit@debbugs.gnu.org; Mon, 23 May 2022 04:30:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt3Se-00081X-QS for 55406-done@debbugs.gnu.org; Mon, 23 May 2022 04:30:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57110) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt3SY-0005o6-20; Mon, 23 May 2022 04:30:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=OPnYYNdNTBmJ2LxhjK8m5FoYYHq2adjDeigKpI5NyyY=; b=SB6ijkkIe7qqysIF4y0W ApZd8dZh3p4Gt2cG2nPU3oqX4us28Rq0ROhNDIc6RjniheEbKZICRqzGbvOx+HtZQt3PyysfIjIgo gUTMa2PXz8Fb882YTPMvdbqz63oY4ktX+QB1/wRi/2rKEtObny8QRX5ypVzVxhtGSr40vrwb6F6Y1 EC0hYjAPGO/VOa5RfGUTfYlShhSus8ihf+5cYUEHIa2tYkIaz6yqqguAssFkhWYJe86wz3d4c/mcB bzInwA2HPCVvW3OvQrLbrc1qdx8FjTVtTuwX3Eu26nKPFiZLBVi7NudTpnXS9kOXJCc+n9CDTXZzx F7YgScj98vfz0g==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2774.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2774]:36462 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt3SM-0001Ly-0U; Mon, 23 May 2022 04:30:32 -0400 From: Mathieu Othacehe To: Pavel Shlyak Subject: Re: bug#55406: GUIX Image API: wrong fs type and flag References: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> <37ECE4BB-C5C7-4C9E-A54A-03F12EA2464E@pantherx.org> <87zgj91yl9.fsf_-_@gnu.org> <895504EA-0884-481A-BCB7-189C38D42740@pantherx.org> Date: Mon, 23 May 2022 10:30:23 +0200 In-Reply-To: <895504EA-0884-481A-BCB7-189C38D42740@pantherx.org> (Pavel Shlyak's message of "Sun, 22 May 2022 17:02:33 +0300") Message-ID: <878rqslkgw.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55406-done Cc: 55406-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Pavel, > Ok, I tried to format them :) Thanks, I added commit messages following our guidelines, fixed the indentation and a few other small details. Pushed on master! Mathieu ------------=_1653294662-30894-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 May 2022 23:00:30 +0000 Received: from localhost ([127.0.0.1]:45286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npeGs-0007Dv-2D for submit@debbugs.gnu.org; Fri, 13 May 2022 19:00:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:39884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npchh-00044Z-Mp for submit@debbugs.gnu.org; Fri, 13 May 2022 17:20:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npchh-0005o1-3x for bug-guix@gnu.org; Fri, 13 May 2022 17:20:05 -0400 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]:41604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npchf-0001Qf-JO for bug-guix@gnu.org; Fri, 13 May 2022 17:20:04 -0400 Received: by mail-ej1-x631.google.com with SMTP id dk23so18474980ejb.8 for ; Fri, 13 May 2022 14:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=kzA1IRWdofuDJLdSKwc4BfwVs4L0tq9SkNdkAgRJeb0=; b=C8rBDGIixZvovvm/htPlJKvbMbOWAz3sppKqXHMKOCfeLj2X2PXQ/uamwns3Il7N0b lOq66wY2OG0/7U9DH3f7LorJeJWddEIa7KWJ/1Y9UmysNnGem1cRzGdtzFSzUibTt9AH IIbgTyfTRL67YTKBI2teIfNAMVVe3xRnw2lAjryVNQZFcr8odiezF2XLtYHBuOiMP1Ju M+y8VHz86CQP7ahumSJMQzfvby7Xh5TmPiFjJTDJImHTAnf0pngO75ubfY0t9NVYmfhq vX+Bw8VutzOJJO9LLWF8JMLltUL+YREGK2Mp/5ql+/oMKL4xG6sFMN6aVHRPUmKRkesP wvuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=kzA1IRWdofuDJLdSKwc4BfwVs4L0tq9SkNdkAgRJeb0=; b=C+o2yzo6jWKW68p2gDvrrlH5qXGqOEVOpUggigivHgt5hNvBC0fXuo2ie0Xu6bDfS/ iA3Npm15YT7Ypwy+rUpIu4c5CgDCYL98frHSi2p0lvtIy5Oy6ib8FBvbRcR5J20SKnQZ H+U3ta4ePtUf29c10UmlC+KD8o+kzZcVRQSq1qhxozc23tO8gnuj+w8Vqgpia1kX2wx+ hzoGlnhxbn09qCDZ10j7p5GMFbxX82q6lxSOKZM9q0akqazrJEmOK3uqVBhMIJcqjj50 afpLABpX3h7ZUkCuXxPcpJO4B58GAPScppIXy4zLUXZ+aZEsknDJPklhIZy70MJR+m3M V/QA== X-Gm-Message-State: AOAM531RBaoZCKNMvnJfEElpuoid34sBaJ66vthqZb7Pn/C7JIYKRJ7W 7HxE6z3XKF7t+UQQenVuZFSMaR84XzHXGr43 X-Google-Smtp-Source: ABdhPJxpQeHpCYPhyNaRSniLyEGOGHRHsXZhrQNfBEpNta1ItnhYhGHL/6RdIYqr4U7yvXa1Vz9Bkg== X-Received: by 2002:a17:906:dc93:b0:6f4:6a93:f227 with SMTP id cs19-20020a170906dc9300b006f46a93f227mr5900019ejc.661.1652476801056; Fri, 13 May 2022 14:20:01 -0700 (PDT) Received: from smtpclient.apple ([31.141.85.74]) by smtp.gmail.com with ESMTPSA id og32-20020a1709071de000b006f3ef214db9sm1125341ejc.31.2022.05.13.14.19.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 May 2022 14:20:00 -0700 (PDT) From: Pavel Shlyak Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Image API produces incorrect images Message-Id: Date: Sat, 14 May 2022 00:19:58 +0300 To: bug-guix@gnu.org X-Mailer: Apple Mail (2.3696.80.82.1.1) Received-SPF: pass client-ip=2a00:1450:4864:20::631; envelope-from=shlyakpavel@gmail.com; helo=mail-ej1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 13 May 2022 19:00:29 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I have a scheme code like (define rpi-boot-partition (partition (size (* 128 (expt 2 20))) (label "BOOT") (file-system "vfat") (flags '()) (initializer (gexp initialize-efi-partition)))) (define rpi-root-partition (partition (size 'guess) (label "RASPIROOT") (file-system "ext4") (flags '(boot)) (initializer (gexp initialize-root-partition)))) (define raspberry-pi-image (image (format 'disk-image) (partitions (list rpi-boot-partition rpi-root-partition)))) The output is like that: $ fdisk -l = /gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-ima= ge Device = Boot Start End Sectors Size Id Type = /gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-ima= ge1 1 262144 262144 128M 83 Linux = /gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-ima= ge2 262145 3583688 3321544 1.6G 83 Linux=09 No boot flag is set on the first partition. The file system seems to be = incorrect (ext* instead of vfat)= ------------=_1653294662-30894-3--