From unknown Wed Jun 18 00:24:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#55396 <55396@debbugs.gnu.org> To: bug#55396 <55396@debbugs.gnu.org> Subject: Status: 29.0.50; project-find-file don't work on a project with many submodules Reply-To: bug#55396 <55396@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:24:16 +0000 retitle 55396 29.0.50; project-find-file don't work on a project with many = submodules reassign 55396 emacs submitter 55396 Eason Huang severity 55396 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri May 13 09:03:57 2022 Received: (at submit) by debbugs.gnu.org; 13 May 2022 13:03:57 +0000 Received: from localhost ([127.0.0.1]:43187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npUxY-0003m9-Oc for submit@debbugs.gnu.org; Fri, 13 May 2022 09:03:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:56824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npUxV-0003ly-FL for submit@debbugs.gnu.org; Fri, 13 May 2022 09:03:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npUxU-00024g-Py for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 09:03:53 -0400 Received: from out162-62-57-64.mail.qq.com ([162.62.57.64]:38895) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npUxN-00065T-Da for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 09:03:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1652447015; bh=JVoFH5WBrEPpIXqYh/0hfJAKFnxoen9jmyvUxc8ZZEk=; h=From:To:Subject:Date; b=e7g6SpNLLXeV9ijOX7O7LEHhqkkkca83t4713sNOkzoZIWPsZbDauD175ZRN7TmYW BBwzEV8hobF6qnm3gbvRkm5Y7DR80WF+ekHjRbK34VzfiKLD1xmjil0/l9L2hDUe6S 6+nEOggr14yX8qFpxGmTVh7RfxtiK/qPjKeBvWg8= Received: from MacBook ([180.162.211.86]) by newxmesmtplogicsvrszc11.qq.com (NewEsmtp) with SMTP id E0D02CDD; Fri, 13 May 2022 20:56:13 +0800 X-QQ-mid: xmsmtpt1652446573ta2bh7lzo Message-ID: X-QQ-XMAILINFO: M6hcvg9P9OAZiYC4P0ZN4aDLYvo4hqYgfwLTLPamf1qNuS+hv59gDaSD+1n/w9 bD3cOsBDovpYoOC0DBRFPGPHBgEjQbWFk2zdDget9O+WOQu+5EwQiYe6LnT9UAF6iIBhUa4wN/BZ 2z+qiMXcpCnJ3ydTb+tz5mPLu94DZQUcI7UzwXvlJkrQAL6GTjjBmjj6BWMtr4eqGOO2WKkeKZvG TvdzAKUr5QvwcsAxISawnjpWoiwmhy1g+AeKLix76yLJ5KWNfmQ7JDLKMUWGonCunQNfebuvCTHP 0ddaJj3b2LVxhrF8wllBLPgeiql1p6zSiq52h8tv8TLoffTqZ9XYjZt7su7qTZPH9jk9of4cvh37 zxIZVh26QzBkfDE2cybXKm8tHaiT5xQXGi5rS8hDptJeE7+uWd9NbYPZeHeyg2g3OiyPvSQLzJMm FY0Gk8H93Dz1LpXotWmWfa4W6D9ifT/d/wS1tPwRdSorUN09u2GcOo0Rq32ik8FOKuOW6cnLSLhf nS691+atK0YIF46ovSIECI0TKECfXuy0XUMTC6t6+zGLSanxoDN45x/AD+KFLXmsGE2a7SCgTm8B vl9GuTpGXSX4WeQihcl/lHu1X06iCUN4IS1ZDVlf79ZwYRunuWaYQleNxJdfL4t7RL+jT3p7dCAS NRNMHDFbR3kMWjrteZFiqMESgfdwKeGPhfukqSOokGuMzxhqbQY3MuvBg53mnpAVag603XOlnvEx h5hJlA22PSinzcvaiqZWlmvo5VZG4XHH0ZcFH3PJ5t9fx2j+2dAwlJPzWNnTJBx9u6hjywgGy6NN 1omGW1xJka9aTnodnSR8JE6a+LgJ3zh5l5a0zz6Y6Kqqy3yqTnq4+QRX86uzozS7MrEoTxroJdxV aBk0Ek4ri/Lu2heZSrUitZr1U98svYOZi30ief7645U+4Hc5ssYvU= From: Eason Huang To: bug-gnu-emacs@gnu.org Subject: 29.0.50; project-find-file don't work on a project with many submodules Date: Fri, 13 May 2022 20:56:12 +0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=162.62.57.64; envelope-from=aqua0210@foxmail.com; helo=out162-62-57-64.mail.qq.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) I try to use `M-x project-find-file` in my `.emacs.d` config project. It takes a long time(about 1 minutes), and finally get a error as bellow: ``` process-file: Variable binding depth exceeds max-specpdl-size ``` The .emacs.d project include 95 submudules of Git, is this too huge for project.el? You can visit my config: https://github.com/Eason0210/emacs.d On other git project with a few submodules(about 14), it works well. For exmaple this one: https://github.com/emacscollective/emacs.g And I try to start emacs with `emacs -q`, set `(setq debug-on-errort)`. Then reproduce the issue, will get the following debug error: Debugger entered--Lisp error: (excessive-variable-binding) call-process("git" nil (t nil) nil "--no-pager" "ls-files" "-z" "-c" "-o" "--exclude-standard") process-file("git" nil (t nil) nil "--no-pager" "ls-files" "-z" "-c" "-o" "--exclude-standard") vc-git--call((t nil) "ls-files" "-z" "-c" "-o" "--exclude-standard") vc-git--out-ok("ls-files" "-z" "-c" "-o" "--exclude-standard") vc-git--run-command-string(nil "ls-files" "-z" "-c" "-o" "--exclude-standard") project--vc-list-files("/Users/eason/.emacs.d/lib/aggressive-indent" Git nil) #f(compiled-function (module) #)("lib/aggressive-indent") project--vc-list-files("/Users/eason/.emacs.d/." Git nil) #f(compiled-function (module) #)(".") project--vc-list-files("/Users/eason/.emacs.d/." Git nil) #f(compiled-function (module) #)(".") project--vc-list-files("/Users/eason/.emacs.d/." Git nil) #f(compiled-function (module) #)(".") project--vc-list-files("/Users/eason/.emacs.d/." Git nil) #f(compiled-function (module) #)(".") project--vc-list-files("/Users/eason/.emacs.d/." Git nil) #f(compiled-function (module) #)(".") project--vc-list-files("/Users/eason/.emacs.d/." Git nil) #f(compiled-function (module) #)(".") .... there are 1100 lines more here ... project--vc-list-files("/Users/eason/.emacs.d/." Git nil) #f(compiled-function (module) #)(".") project--vc-list-files("/Users/eason/.emacs.d/." Git nil) #f(compiled-function (module) #)(".") project--vc-list-files("~/.emacs.d/" Git nil) #f(compiled-function (dir) #)("~/.emacs.d/") mapcan(#f(compiled-function (dir) #) ("~/.emacs.d/")) #f(compiled-function (project &optional dirs) #)((vc Git "~/.emacs.d/") ("~/.emacs.d/")) apply(#f(compiled-function (project &optional dirs) #) (vc Git "~/.emacs.d/") ("~/.emacs.d/")) project-files((vc Git "~/.emacs.d/") ("~/.emacs.d/")) project-find-file-in(#("init.el" 0 7 (fontified t help-echo "mouse-2: visit this file in other window" mouse-face highlight dired-filename t)) ("~/.emacs.d/") (vc Git "~/.emacs.d/") nil) project-find-file(nil) funcall-interactively(project-find-file nil) command-execute(project-find-file record) execute-extended-command(nil "project-find-file" "project-find-fi") funcall-interactively(execute-extended-command nil "project-find-file" "project-find-fi") command-execute(execute-extended-command) My platfrom informations: In GNU Emacs 29.0.50 (build 1, x86_64-apple-darwin21.4.0, NS appkit-2113.40 Version 12.3.1 (Build 21E258)) of 2022-05-09 built on macbook Repository revision: 4f1e748df208ced08c7cda8f96e6a5638ad14240 Repository branch: master Windowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.3.1 Configured using: 'configure --with-ns --with-modules '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp:/usr/local/share/emacs/site-lisp' --with-xwidgets --with-native-compilation 'CFLAGS=-I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include -O2' 'LDFLAGS=-L/usr/local/opt/gcc/lib/gcc/11 -L/usr/local/opt/gcc/lib/gcc/11/gcc/x86_64-apple-darwin21/11 -L/usr/local/opt/libgccjit/lib/gcc/11 -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include -Wl,-headerpad_max_install_names'' Configured features: ACL DBUS GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP XIM XWIDGETS ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/d Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media rmc puny rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-fns radix-tree cl-print debug backtrace help-mode find-func thingatpt vc-mtn vc-hg vc-git diff-mode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view easy-mmode pcvs-util vc vc-dispatcher project seq gv subr-x byte-opt bytecomp byte-compile cconv dired-aux cl-loaddefs cl-lib dired dired-loaddefs iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice simple cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads xwidget-internal dbusbind kqueue cocoa ns lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 765142 20103) (symbols 48 9014 0) (strings 32 215443 3200) (string-bytes 1 8854733) (vectors 16 21867) (vector-slots 8 482129 32483) (floats 8 30 306) (intervals 56 31551 79) (buffers 992 17)) -- Eason Huang From debbugs-submit-bounces@debbugs.gnu.org Sat May 14 21:48:11 2022 Received: (at 55396) by debbugs.gnu.org; 15 May 2022 01:48:11 +0000 Received: from localhost ([127.0.0.1]:47770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nq3Mh-0006tA-C2 for submit@debbugs.gnu.org; Sat, 14 May 2022 21:48:11 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:52980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nq3Mg-0006sd-7P for 55396@debbugs.gnu.org; Sat, 14 May 2022 21:48:10 -0400 Received: by mail-wm1-f54.google.com with SMTP id k126so6849579wme.2 for <55396@debbugs.gnu.org>; Sat, 14 May 2022 18:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Dh4ZQZu4BiaftZwQ+LKKG2FUjj7lnjFUaeQSCc/UaVw=; b=Au7v8+8Xg+Um5psiVCTmBImObXxlF20CEp1CcJHhp9XtcSgyJP2YZEI/V4YPMApdQO 8NdzhhNTH/wp8CIQq8Iln3daRkw2QE4u3PIAreYRueBz85ZzDdmbp5Y7e0yZ6rZkGD+/ mvvzN5eMUhNENBs7/nGwfGOAWu6LED9O7QNJhgdXV2WSOUpUFCI8x7TB47V7ivFYuhi1 vIT2xTji427XSYcP9RNmns6n0bgWyIENjM6GhyK4QiONekqxBFbjzY/LJrVjo0Ub9hAg 2RtEhoBl5J0xKS1qk94tkoM2zoT7lGNaxBX6wMrc8xhp9rFj5EquWorTqo7rxd95SfHC usfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Dh4ZQZu4BiaftZwQ+LKKG2FUjj7lnjFUaeQSCc/UaVw=; b=Z2NFtEFdYCWXPdP+RX5dte9zxeLTd8DMeuLwRgyfLQAay8jJYb6g7Q0OkEoCd+HM55 NmS2HqYJ8m9BekpvfQe58W8P3Dq9330Tre2axICYr6nnygC62Op74nlKHVYKkehzLwYX qc6S6+P873xfUOdpSlzNGK6Q4r7Z6mcFAx19vfERaUs6sWLah3E7XD4HCn5jaxXiK7sC 1cRheJ8KS7eWbNCf8acdN14AaHvKfMpI+eUTWlMf+DJBcZU/1/Lo70WyoTFU3uCsA9CT oPH7x9HzVKId/0GfbcXyr4HQaHk6Eiw+mKGW6VXaIhvtgiNiujB5HdVGNTKP+RTs0Hgp 6+PQ== X-Gm-Message-State: AOAM531Jr2u45Zm1VFcfZABmP7mevD4FVw3+/yBtEbVlhFWGyZxQ1sTw AixJLnbJPt30DAcNjiPabrE= X-Google-Smtp-Source: ABdhPJwb8erBN+CSwR/C2qtmmPwVpk6osLURF4WQTctRZIFBeRb28zMfy6RejUMrYHUfgNwplE0Z9Q== X-Received: by 2002:a05:600c:1989:b0:394:8dc0:b57f with SMTP id t9-20020a05600c198900b003948dc0b57fmr21381130wmq.110.1652579283984; Sat, 14 May 2022 18:48:03 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j3-20020a05600c1c0300b003942a244eddsm6984395wms.34.2022.05.14.18.48.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 May 2022 18:48:02 -0700 (PDT) Message-ID: <59b18871-823a-6f95-fbe3-0a697e1e2cc3@yandex.ru> Date: Sun, 15 May 2022 04:48:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules Content-Language: en-US To: Eason Huang , 55396@debbugs.gnu.org References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55396 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 13.05.2022 15:56, Eason Huang wrote: > I try to use `M-x project-find-file` in my `.emacs.d` config project. It > takes a long time(about 1 minutes), and finally get a error as bellow: > > ``` > process-file: Variable binding depth exceeds max-specpdl-size > ``` > > The .emacs.d project include 95 submudules of Git, is this too huge for > project.el? Hi! That's a lot, but the above error indicates excess recursion. Do the submodules in your repo in turn have checked out submodules inside, and so on? As a workaround, you can set project-vc-merge-submodules to nil (at least temporarily, until we get a better fix). From debbugs-submit-bounces@debbugs.gnu.org Sun May 15 00:09:52 2022 Received: (at 55396) by debbugs.gnu.org; 15 May 2022 04:09:52 +0000 Received: from localhost ([127.0.0.1]:47819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nq5Zn-0001xq-O6 for submit@debbugs.gnu.org; Sun, 15 May 2022 00:09:51 -0400 Received: from out203-205-221-239.mail.qq.com ([203.205.221.239]:46627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nq5Zk-0001xX-Km for 55396@debbugs.gnu.org; Sun, 15 May 2022 00:09:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1652587778; bh=kAEQoyn1q2xnuMZzc20IqU68qwWELr6gkvIWpyX1MP0=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=h8ECxRflX4CNIxJ7izRjU+U14pN5FWh22nKX6SmZOp/mJf/n4QasDugSJvmfdd2k1 7OeWxSTFdTDZKRcD2r1vbwVllqhbnFNJrwhPsgYSusHq/p1uUtNPWGV4mD2fX446jR RUw53WSImcCOFybsnuLq+f4QniE2E0AEWKWT7kXk= Received: from MacBook ([180.162.211.86]) by newxmesmtplogicsvrsza9.qq.com (NewEsmtp) with SMTP id 264B7A73; Sun, 15 May 2022 12:09:36 +0800 X-QQ-mid: xmsmtpt1652587776t6n1ndav5 Message-ID: X-QQ-XMAILINFO: NPETcIssjKadT4Q79sIhZGriidrspXUxkgyHvJGgdQeVAex0vJuiZG/Bmtq+bE SjOoYRyZmB96U7eSfZRZRLLXfXPs58J7M1kQShlHeucEmxwFL9CcmyPQNYnbEmuH2pTsC28nN86b 12X+j/zY7NdgpolGyL8pFKglUVBJWpvJeGqog+ZEwurJ8OwDN0rwltb/wEnJaagsW/g4Bhr0AeI5 ig60HNS/TmhdeR078XgaJgeeV+0KoJHxbFKjG07fUTj00pRZ7D0Mb0ooKCmbTYizq/PJURtliCby SuOYtCZXBwhQyJxYJSCinv8e3UFMjXTjqLGE41OdgOX2EagUrG2HG9Rv4jWvS/D+IAqoLb+NnXkI 7Ub/YPUGrEm9DWd14d1aLkpS1hON99QWdgyepFoHYkJuUvfB3UFxhtFQqSH5OQRPPr6qiVF3gELq WckNyZK0Wy8FUOKgycBjhMSH4MzZVBt+ERuRUYNk9KP2+uskTMZ0d1LTcGboFPcS5bf3R/gNxQqo Mf/0dyWaR8eTLZGxorIQXsctd3ZOyQFf+BWqLdsEF4+vBjbVYrTZ27LKCw5a5Bp5YoCHh1lT6n8e 3Z9smidEevxmzpfFahAeHZd6gW7b1yjkuCZFhI/5JQiOXYKvFDvJP4iusNRDMGQp4UwjugFoN19F 3rSjJOXHDOArnlmxBduKO8xv7VQn+g8E5Xvfv6A7ONGtVx8MpBZmZi/BfAK/2YYOMAVzFVljaUOB mZZtj40Z5SMHBmV226X2w9oeiZPZLfMFnVqRZtDWzeeOvHMlSfIQYEuziH1TztHgml4tJ/jaoFRV ahNZAAzkw13hYPmswGe74H3EX2RkSXVuRCWk5MHnn2UdEdKS/AzeExRfw6oDMkVL8FTM/9sZbUh6 swY2yhFJ6gmkZFqWcs5e558lLCCMi/rQDOOuwsquAy From: Eason Huang To: Dmitry Gutov Subject: Re: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules References: <59b18871-823a-6f95-fbe3-0a697e1e2cc3@yandex.ru> Date: Sun, 15 May 2022 12:09:36 +0800 In-Reply-To: <59b18871-823a-6f95-fbe3-0a697e1e2cc3@yandex.ru> (Dmitry Gutov's message of "Sun, 15 May 2022 04:48:00 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.8 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dmitry Gutov writes: > On 13.05.2022 15:56, Eason Huang wrote: >> I try to use `M-x project-find-file` in my `.emacs.d` config project. It >> takes a long time(about 1 minutes), and finally get a error as bellow: >> ``` > [...] Content analysis details: (3.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.239 listed in list.dnswl.org] 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -0.0 T_SCC_BODY_TEXT_LINE No description available. 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 55396 Cc: 55396@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dmitry Gutov writes: > On 13.05.2022 15:56, Eason Huang wrote: >> I try to use `M-x project-find-file` in my `.emacs.d` config project. It >> takes a long time(about 1 minutes), and finally get a error as bellow: >> ``` > [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.239 listed in list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) Dmitry Gutov writes: > On 13.05.2022 15:56, Eason Huang wrote: >> I try to use `M-x project-find-file` in my `.emacs.d` config project. It >> takes a long time(about 1 minutes), and finally get a error as bellow: >> ``` >> process-file: Variable binding depth exceeds max-specpdl-size >> ``` >> The .emacs.d project include 95 submudules of Git, is this too huge >> for >> project.el? > > Hi! That's a lot, but the above error indicates excess recursion. Do > the submodules in your repo in turn have checked out submodules > inside, and so on? I try another project with 42 submodules, when I use `Borg` to install `Corfu` extensions, I need to set two load-path on `.gitmodules`. And this setting will trigger the same issue. ``` [submodule "corfu"] load-path = . load-path = extensions path = lib/corfu url = git@github.com:minad/corfu.git ``` if I remove the load-path, just leave it as below, project.el wokrs well. ``` [submodule "corfu"] path = lib/corfu url = git@github.com:minad/corfu.git ``` May be the above infomation can help you. > As a workaround, you can set project-vc-merge-submodules to nil (at > least temporarily, until we get a better fix). > Thanks, I try to set project-vc-merge-submodules to nil, and It works. By the way, I also tried `projectile` on the huge .emacs.d, It works but can feel the latency. -- Eason Huang From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 12 18:17:42 2022 Received: (at 55396) by debbugs.gnu.org; 12 Jun 2022 22:17:42 +0000 Received: from localhost ([127.0.0.1]:56617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Vtt-0007P4-Tl for submit@debbugs.gnu.org; Sun, 12 Jun 2022 18:17:42 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:43560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Vtp-0007On-Ae for 55396@debbugs.gnu.org; Sun, 12 Jun 2022 18:17:40 -0400 Received: by mail-wr1-f41.google.com with SMTP id m24so4993589wrb.10 for <55396@debbugs.gnu.org>; Sun, 12 Jun 2022 15:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=tVxzxYWTJDale4e6WRtTjKewwMKNsXDFBGJjOIWgazg=; b=iQYyY/hgwaB4NTA3A0VznN/8lQS74GmH44vGx+aQQj3htLp6nIiW5wJdZ+974/j2ys OVqi7CnJLLErkt6Pr86BEDWWOcM7uy+aSEnjMxHnSfDJPkvk9GBBc1uQefxT6Upl9vhi zXfxNsXzbmZRQBi6rGRIAJPUCjm614/VU/FROpB3pWlfPKnp2r/jawoJpFH6ZBRu7nqU iSxW2oV35tE9y198d+lf9vpBGexQEb59mnV6hi6BEgD4EqTrI7dr5kB0pS/p9IwGqyKn mPkSg49LaTYeIuzCJF4UMUUHO6XHnQwz7EO2fo7e9nNTbhRJgW9HGBQ4ItXy3Wq1NQmW rW4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=tVxzxYWTJDale4e6WRtTjKewwMKNsXDFBGJjOIWgazg=; b=wembtdpUzmt6kXSsb77Me6hB693xAKziIjXNY1iVlqY0o92WGw7E4xibJ5EzqMD8mI vf06wfa/msHknNQgEaFCu6gDz4m4rFYJDzepNg+sjKSWROlf6VheAIJLPQYompWW1TUE k1ciSNFjwgBKTZv0dd9gNC2pQPfqVIDxhVc8cQBNzNRu6teVjepbEx+y41wmM0tQlMPV HLzbbIAwTegLsdkBrCk7Czbm6lfAIfnh0NXFb2fsh0rR8rCIFpTyzAtnbFrpOXa51gOi CYx+Oe3zXjVMATZBKSp/AcVU+6f07nm7g1XDjvFSgc0BHtL1X0GV99GRF7wuojJYGnOl sE6w== X-Gm-Message-State: AOAM530SOBThQyqvLVW1RMsvEsn5JOKurNbEqQ0OxzrgF6sAO0PNrNY9 CdfzXd2fOkzJUzLnUaf5L+8= X-Google-Smtp-Source: ABdhPJx0Kkd9fqrSpYAx1Oul1zE3f+uWk0FI4cHGkCWNgacQ6v1d7CzC18Yzpf41FA9HfJ7hL42ysw== X-Received: by 2002:a5d:59a5:0:b0:218:3ffb:e6ea with SMTP id p5-20020a5d59a5000000b002183ffbe6eamr37483320wrr.715.1655072251218; Sun, 12 Jun 2022 15:17:31 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id x5-20020a5d54c5000000b002167efdd549sm6760003wrv.38.2022.06.12.15.17.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jun 2022 15:17:30 -0700 (PDT) Message-ID: Date: Mon, 13 Jun 2022 01:17:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules Content-Language: en-US To: Eason Huang , 55396@debbugs.gnu.org References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55396 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi again, sorry for the delay. On 13.05.2022 15:56, Eason Huang wrote: > And I try to start emacs with `emacs -q`, set `(setq debug-on-errort)`. > Then reproduce the issue, will get the following debug error: > > Debugger entered--Lisp error: (excessive-variable-binding) > call-process("git" nil (t nil) nil "--no-pager" "ls-files" "-z" "-c" "-o" "--exclude-standard") > process-file("git" nil (t nil) nil "--no-pager" "ls-files" "-z" "-c" "-o" "--exclude-standard") > vc-git--call((t nil) "ls-files" "-z" "-c" "-o" "--exclude-standard") > vc-git--out-ok("ls-files" "-z" "-c" "-o" "--exclude-standard") > vc-git--run-command-string(nil "ls-files" "-z" "-c" "-o" "--exclude-standard") > project--vc-list-files("/Users/eason/.emacs.d/lib/aggressive-indent" Git nil) > #f(compiled-function (module) #)("lib/aggressive-indent") > project--vc-list-files("/Users/eason/.emacs.d/." Git nil) > #f(compiled-function (module) #)(".") > project--vc-list-files("/Users/eason/.emacs.d/." Git nil) > #f(compiled-function (module) #)(".") > project--vc-list-files("/Users/eason/.emacs.d/." Git nil) > #f(compiled-function (module) #)(".") > project--vc-list-files("/Users/eason/.emacs.d/." Git nil) Looking at the backtrace again, it seems the problem is not related to the number of submodules. It's a plain infloop. Could you try to help with debugging? Alternatively, you could provide a simple repo with this problem that doesn't require Borg to initialize. Though it probably doesn't (shouldn't) require Borg anyway, given how the problem looks. What does project--vc-list-files do in your case? It calls 'git ls-files' to fetch the list of files in the parent repo, then parses the list of submodules in it, and repeats the same call inside each submodule (using (concat default-directory module) as target). Looking at the backtrace, it mentions "/Users/eason/.emacs.d/." over and over again. So it seems like (project--git-submodules) returns a list which has "." as one of its elements. How does that happen? Do you have a submodule entry which points to "."? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 13 11:00:50 2022 Received: (at 55396) by debbugs.gnu.org; 13 Jun 2022 15:00:51 +0000 Received: from localhost ([127.0.0.1]:60119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0lYg-0000DE-54 for submit@debbugs.gnu.org; Mon, 13 Jun 2022 11:00:50 -0400 Received: from out203-205-221-202.mail.qq.com ([203.205.221.202]:57063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0lYY-0008M1-Vt for 55396@debbugs.gnu.org; Mon, 13 Jun 2022 11:00:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1655132427; bh=rVOOSR8mTx6O3724D3/a6ozSIua1z8U7KHlsqlBedL4=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=phxIebUwamEsnif4aMPKgXirv/ne4qFGff3ssjWYKCZ5/vW2nSDIA0U0Z1FXb8Q// or4S3rOJ1zX8AkERcuwUkydyHFR+8JhMDhxZ+uaKaHM/4YN+2/OqCPfToEaYH3qQOO 3wwu1bqGL5jEcqaO1+Fr2WxRS7tSd65rl+Bltrns= Received: from MacBook ([114.82.35.172]) by newxmesmtplogicsvrszb6.qq.com (NewEsmtp) with SMTP id 1A16295; Mon, 13 Jun 2022 23:00:26 +0800 X-QQ-mid: xmsmtpt1655132426tk5o5mg8u Message-ID: X-QQ-XMAILINFO: NkD3iGBRs6TjZbrH801BoCLyk9PPN8FbEytEBCk3wwZO8l8H+L3qoShIeIYyAW ovM9n5RNxKHOWAHJjgpKDMvgn5zFxXjrju2ASa7aiNeFT7kxUPtgtYE5ehLPWZCoktJL7hWQaQa9 9LoMt+eFI4697WifVG/B7tOTGZ8RnZRLackS780RyvndO5c9r6SjlicKW5rmRD8KkQvg7Shfgw8l WNZWRyyVAedTTj5a+lWofR/7mYt6VCdYwICUOwzpTFt322X23grqhhmtK4kA60mrKfPgW76TSWzJ T+NvM9Z21TzDCm2ft9rUc5twhqyD6DWqvIC/BbjEV2qwCJa9nkfEukrEv2PKBnyMrNl1etQ+XZkD a3sQGf2caoGtFlIy34y/lN4PWsJ8Khu8ysHEkEVvTi7knDQD5lGyb7oyBDc2nIIdPNN0VYC6P7qf HC6WeYwerNcQop5xKYhmtqJiz2XG1ly/UHb45GOGyjn1JOqcYyMkzZnjnUV0r3f1h9ptlzYBIKws KHmXs6vj6RPZSFrUupDEgjGve2r1VgCXObMUzuci0XvKF2pEQ94DS/8GllfBiBQVNZvQr6HmyPkl uiJYVOH72JsI2cSapuHDtE2qWhsG6ki4DHO85yAQAR4us7FVyrp95rYcSbZqXyx0x3vAwzDp58e5 8LZVZiqD2rv17O+HKh9OgSvWifgRL73zBkjtF1GZN2Yt8wnaMUmu6qd4JFCRSJHOdzBwpqOV05c5 zyj0y8szAOL0zhpbzHTUlfJtjN6Z6AJ2TApykcbma493GVv1mKdQCgfJ5AfACGW6xZ+C0bxRWfxG suikovCiVzDxu1ELcnyWVI4UKhZGwXOQFmCdZSCbBCfEAWA8B3pe6JCmIjN4ypm3LW+tzJ37SJSw /dZ4cZQCedskFv8N1cykLZlkfzU6Yz5HU3GOZUW99yGbd9Jv0OWPY/wYXIHQifqA== From: Eason Huang To: Dmitry Gutov Subject: Re: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules References: Date: Mon, 13 Jun 2022 23:00:25 +0800 In-Reply-To: (Dmitry Gutov's message of "Mon, 13 Jun 2022 01:17:28 +0300") X-OQ-MSGID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 3.8 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dmitry Gutov writes: Hi Dmitry, Thanks for reply. Content analysis details: (3.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.202 listed in list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -0.0 T_SCC_BODY_TEXT_LINE No description available. 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 55396 Cc: 55396@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dmitry Gutov writes: Hi Dmitry, Thanks for reply. Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.202 listed in list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) Dmitry Gutov writes: Hi Dmitry, Thanks for reply. > Hi again, sorry for the delay. > > On 13.05.2022 15:56, Eason Huang wrote: >> And I try to start emacs with `emacs -q`, set `(setq debug-on-errort)`. >> Then reproduce the issue, will get the following debug error: >> Debugger entered--Lisp error: (excessive-variable-binding) >> call-process("git" nil (t nil) nil "--no-pager" "ls-files" "-z" "-c" = "-o" "--exclude-standard") >> process-file("git" nil (t nil) nil "--no-pager" "ls-files" "-z" "-c" = "-o" "--exclude-standard") >> vc-git--call((t nil) "ls-files" "-z" "-c" "-o" "--exclude-standard") >> vc-git--out-ok("ls-files" "-z" "-c" "-o" "--exclude-standard") >> vc-git--run-command-string(nil "ls-files" "-z" "-c" "-o" "--exclude-s= tandard") >> project--vc-list-files("/Users/eason/.emacs.d/lib/aggressive-indent" = Git nil) >> #f(compiled-function (module) #)("lib/agg= ressive-indent") >> project--vc-list-files("/Users/eason/.emacs.d/." Git nil) >> #f(compiled-function (module) #)(".") >> project--vc-list-files("/Users/eason/.emacs.d/." Git nil) >> #f(compiled-function (module) #)(".") >> project--vc-list-files("/Users/eason/.emacs.d/." Git nil) >> #f(compiled-function (module) #)(".") >> project--vc-list-files("/Users/eason/.emacs.d/." Git nil) > > Looking at the backtrace again, it seems the problem is not related to > the number of submodules. It's a plain infloop. > > Could you try to help with debugging? Alternatively, you could provide > a simple repo with this problem that doesn't require Borg to > initialize. Though it probably doesn't (shouldn't) require Borg > anyway, given how the problem looks. I create an simple which only include a submodule, I take vertico for example. you can get it here: https://github.com/Eason0210/sample-project.git Steps to reproduce the issue: 1. Create an empty folder call `.emacs.d` (The name is not matter, you can use any name) 2. cd .emacs.d, and let's say i want to add vertico as an submodule ``` git init git submodule add --name vertico git@github.com:minad/vertico.git lib/verti= co git add . git commit -m "add vertico" ``` 3. so far so good. 4. Modify the .gitmodules file, add load-path for extensions directory of vertico repo ``` [submodule "vertico"] path =3D lib/vertico url =3D git@github.com:minad/vertico.git load-path =3D . load-path =3D extensions #+end_src ``` 5. Now perform ~M-x, project-find-file~ in the .emacs.d directory will cause the issue. > What does project--vc-list-files do in your case? It calls 'git > ls-files' to fetch the list of files in the parent repo, then parses > the list of submodules in it, and repeats the same call inside each > submodule (using (concat default-directory module) as target). I try 'git ls-files .' in vertico submodule in iterm and get this: ``` =E2=9E=9C vertico git:(main) git ls-files . LICENSE README.org extensions/vertico-buffer.el extensions/vertico-directory.el extensions/vertico-flat.el extensions/vertico-grid.el extensions/vertico-indexed.el extensions/vertico-mouse.el extensions/vertico-multiform.el extensions/vertico-quick.el extensions/vertico-repeat.el extensions/vertico-reverse.el extensions/vertico-unobtrusive.el vertico.el ``` ``` =E2=9E=9C vertico git:(main) git ls-files extensions extensions/vertico-buffer.el extensions/vertico-directory.el extensions/vertico-flat.el extensions/vertico-grid.el extensions/vertico-indexed.el extensions/vertico-mouse.el extensions/vertico-multiform.el extensions/vertico-quick.el extensions/vertico-repeat.el extensions/vertico-reverse.el extensions/vertico-unobtrusive.el ``` > Looking at the backtrace, it mentions "/Users/eason/.emacs.d/." over > and over again. So it seems like (project--git-submodules) returns a > list which has "." as one of its elements. > > How does that happen? Do you have a submodule entry which points to "."? > I found that it's this line `load-path =3D .` cause the issue. Borg need this line to add the vertico directory to load-path when user add a subDirectory to load-path. May be it is an issue of Borg? --=20 Eason Huang From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 13 21:04:11 2022 Received: (at 55396) by debbugs.gnu.org; 14 Jun 2022 01:04:11 +0000 Received: from localhost ([127.0.0.1]:60778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0uyZ-0003wA-Fp for submit@debbugs.gnu.org; Mon, 13 Jun 2022 21:04:11 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:39817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0uyV-0003vu-Uz for 55396@debbugs.gnu.org; Mon, 13 Jun 2022 21:04:09 -0400 Received: by mail-wr1-f48.google.com with SMTP id x17so9118098wrg.6 for <55396@debbugs.gnu.org>; Mon, 13 Jun 2022 18:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=aeaJ+wLvJV/r+Pklin69MeTlUp4N5Da+B3WcONqERno=; b=cVr2g9VlqqK7k4CNixcvOzDT++oUePbIJKVLvgo7tM/xEkiMAA2PnuK0/lKWgTyMVZ R9sfZtAEUFr6nf7uI61g8lrJEt2RJ+IcrYmQHuiJLWDT+jxgD1CX+00HZnKv4e1vkuKc UsY8Cpw7ocf+8CVRnyu5CKrabaEqpwbENB5C9li+7PT3UUju4RtarnAY2PRhkoY0N+Ir LEinmCX/KyPTsmqVf9rN+Y0J2BI15vUuvP5GqZdbZ85eSsOIKIBpMgipPIuxVqaBP462 lsfEvwnYuX3N3AgJEFvpJpHclpkOWm/3YaYu+XSxSzx6Oeb5SyVb554baU7YUWizG6x0 JQ0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=aeaJ+wLvJV/r+Pklin69MeTlUp4N5Da+B3WcONqERno=; b=jDBt3KH8wZJ5nQZqjEOsyycjp4/2wEA7OiXofs2K7ABOpzFgW6vnOAsOabu2zpPKkk slGRdcXSLxXGGTpY6y2n9sEtJA0g1jqJHP6cIXf8sDZJGYt/Pq/d8P5XRVKxsI/vuKvf lNQ7yyFHBHTsuZaBECR4GMJsUQn77eO7NOS+6jFoLdddGov1PGTdqg1tCBjszBU7xir+ T84A8YUMrE7D6+W9P88idOKbf7ndL88Lbkn2Te9XeCOBTQLgaLeIaCIbvMVdk4LJCa8g wm6S4A+8IFEebvM+SD3RCU1grzkNw5RAhww/7vzivYzIUIjCyONQ6Pr1qTAfQC+PepbR Fsrg== X-Gm-Message-State: AJIora/k6HtWdZq89DHXhwkEheHrP2ejq7xvdqrFb1SRfeIZfKMgR9Cd aG3ppLVSaN40rOUd2csnjKk= X-Google-Smtp-Source: AGRyM1taHD9nkiVfH0JJvgZB5NR3+JohVl7T9vc2Hf/2ZpE4cx15h1cdAA/w8laSRb8ihkQjv3YMHQ== X-Received: by 2002:adf:f90d:0:b0:20c:de32:4d35 with SMTP id b13-20020adff90d000000b0020cde324d35mr2122509wrr.583.1655168642010; Mon, 13 Jun 2022 18:04:02 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f187-20020a1c38c4000000b003973ea7e725sm18401792wma.0.2022.06.13.18.04.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jun 2022 18:04:01 -0700 (PDT) Message-ID: Date: Tue, 14 Jun 2022 04:03:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules Content-Language: en-US To: Eason Huang References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55396 Cc: 55396@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 13.06.2022 18:00, Eason Huang wrote: >> Looking at the backtrace, it mentions "/Users/eason/.emacs.d/." over >> and over again. So it seems like (project--git-submodules) returns a >> list which has "." as one of its elements. >> >> How does that happen? Do you have a submodule entry which points to "."? >> > I found that it's this line `load-path = .` cause the issue. Borg need > this line to add the vertico directory to load-path when user add a > subDirectory to load-path. May be it is an issue of Borg? Now that I've tried adding that locally, it indeed what triggered the problem. It was a bug in 'project--git-submodules', which I've just fixed on master in commit 915b34d280. I think file listing together with submodules should work fine now in your case. Not sure about the performance though: we use one process call per submodule, so the overhead might get noticeable with 42 of them. But please give it a try. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 07:22:36 2022 Received: (at 55396) by debbugs.gnu.org; 14 Jun 2022 11:22:36 +0000 Received: from localhost ([127.0.0.1]:33079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o14d2-0005GE-2L for submit@debbugs.gnu.org; Tue, 14 Jun 2022 07:22:36 -0400 Received: from out203-205-251-36.mail.qq.com ([203.205.251.36]:57386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o14ct-0005Fr-Iy for 55396@debbugs.gnu.org; Tue, 14 Jun 2022 07:22:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1655205737; bh=odCW2HhGbLI1TmyloxmQOGMuZKdbwNn9x/ExFNzpvjI=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=zGdQcVV5S1soQLXQHGurTzdDh0otHPm3Sc4ESHzqd3LgJbI6ZqOWYXPf6RcU2BpeY 29hUPz2YihdrL1NhGjFSW4eQO/16Zz3UaqooF9p3VRHFMcjsqyReHJvG82ji//LqwQ WcSeiv0xZ2GA3CAOJSpXSy+H9Al8I4Ojqbvv6uqc= Received: from MacBook ([114.82.35.172]) by newxmesmtplogicsvrszb6.qq.com (NewEsmtp) with SMTP id 59006071; Tue, 14 Jun 2022 19:22:16 +0800 X-QQ-mid: xmsmtpt1655205736tnreda3q2 Message-ID: X-QQ-XMAILINFO: MEdp4Db0NDmH5YvCx3fXs/CLWKI3Mony6MRr6ebqP0FhilVm0pPZq9qOtg+fcY CE2p6lvs649DY/Gy/XqPqeKrHHzDRDnFFwNl9MKMHJR4RLt1pb8Vv+vwd1+NU+WA/jKeQqljuwPS HuMxC5Wj+giv1IjLWndx81jAS3Q1azTvJv4z7Zn0R2rw3M77F1SC64Y+pJ6IwMyiepqH3kR+viyH 6BRh9PsD/hz+1h4HbZwaj/P6VxYXPesuDfpsec7gnKouMMiC47YADwbdUon3kXCkwK82Nm8DgV8S /825octozXC1gl6p9LTnyvRnNHpdlZ92jGzRV0XwLi1vbEtlr1TsoTgAG14xKoQ9xwgOfhjhsGYn lgxyUMBE9H3LUW7YDypKCc77GO2z2LM6AEcLOJjTFE2Vgn87mKL8JU27rPwnHt8BwVxW0Ib49Mx9 9Wr4W7Z74Dj1kMRSlaBoxFaY7c0xQVw8GBiInrb8bNdiV0AqdjSW0bXS1ZU3crF1an3C5YaLHjIP D8W8EaUnJ/FsgjvrIFDpDJdvTTAlEazqZWDJq9fxvq73xmMgptiFhttxmknEcyaUwzkX+g8euG0I jNC/SES7iIDun26EfCFMAVs0UMZrt1rE+KddJcpwbodMKPm1Bl3OZdYeti93FUBjfhB6nfDcP6vR diA9MdRyk4JPVjMXW5wsx6zR3QJ0XcJ25FZdDHxme/Den6EOQSs/xpFaMbgMlbRr6IfDcs8s/xLq MAgiJO3HudFa74avqAv9a+PZTdwhiT0hfMboyKO2y28F6zY4Qnf/hatKoLM6ob47+2bdI6V2ndly DqzYu55aGmWfiorQWPj4aitXSx2HaVua/JdwbGLWlWBrPgprV2bGw4wb7bZLlq/63h10fWMyAXYh j2CzVqDRSwox3ouz89JOiocQgIX/WG4eR7OwwTl/4mzJL5bBrQUGA= From: Eason Huang To: Dmitry Gutov Subject: Re: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules References: Date: Tue, 14 Jun 2022 19:22:15 +0800 In-Reply-To: (Dmitry Gutov's message of "Tue, 14 Jun 2022 04:03:59 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.9 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dmitry Gutov writes: > On 13.06.2022 18:00, Eason Huang wrote: >>> Looking at the backtrace, it mentions "/Users/eason/.emacs.d/." over >>> and over again. So it seems like (project--git-submodules) returns a >>> list whi [...] Content analysis details: (3.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.251.36 listed in list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) 0.0 T_SPF_HELO_TEMPERROR SPF: test of HELO record failed (temperror) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -0.0 T_SCC_BODY_TEXT_LINE No description available. 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 55396 Cc: 55396@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dmitry Gutov writes: > On 13.06.2022 18:00, Eason Huang wrote: >>> Looking at the backtrace, it mentions "/Users/eason/.emacs.d/." over >>> and over again. So it seems like (project--git-submodules) returns a >>> list whi [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.251.36 listed in list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) Dmitry Gutov writes: > On 13.06.2022 18:00, Eason Huang wrote: >>> Looking at the backtrace, it mentions "/Users/eason/.emacs.d/." over >>> and over again. So it seems like (project--git-submodules) returns a >>> list which has "." as one of its elements. >>> >>> How does that happen? Do you have a submodule entry which points to "."? >>> >> I found that it's this line `load-path = .` cause the issue. Borg need >> this line to add the vertico directory to load-path when user add a >> subDirectory to load-path. May be it is an issue of Borg? > > Now that I've tried adding that locally, it indeed what triggered the > problem. It was a bug in 'project--git-submodules', which I've just > fixed on master in commit 915b34d280. > > I think file listing together with submodules should work fine now in > your case. Not sure about the performance though: we use one process > call per submodule, so the overhead might get noticeable with 42 of > them. But please give it a try. > Great, I tried on my huge .emacs.d project, it works well and fast. Tested on macOS with latest commit. You can close this bug now. Thanks for your great work on it. -- Eason Huang From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 08:47:10 2022 Received: (at 55396-done) by debbugs.gnu.org; 14 Jun 2022 12:47:10 +0000 Received: from localhost ([127.0.0.1]:33421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o15ws-0005Pm-CC for submit@debbugs.gnu.org; Tue, 14 Jun 2022 08:47:10 -0400 Received: from mail-ej1-f52.google.com ([209.85.218.52]:37750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o15wq-0005KQ-Vi for 55396-done@debbugs.gnu.org; Tue, 14 Jun 2022 08:47:09 -0400 Received: by mail-ej1-f52.google.com with SMTP id gl15so16960112ejb.4 for <55396-done@debbugs.gnu.org>; Tue, 14 Jun 2022 05:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NiD60nCQfxPz72DLSVFftQSNGo19YT4fsBraYKrDRA0=; b=f4BfYPokuKoCCMG+8MzuLDgaIwyDvuSabrBFhY1PrtjbnQS9q7urqMZ0+XUT5ShqK1 dTH7UlgktSCFvFSVH02GWQLrrAlVu6/TvGweLlio+lQQTKBvxUz/D3Z4ld3nW7PgzpB+ oZ+TLVEl/flSyeSCiyEE8J6l3FP5SMvfO/wuGvYKjr/NcxYy+4V7N7PDusyrsEq6XrFh g6UJVmw6nOcnRGSDLM2GbfpeO4NTOXH7dTeWmzhGMYfiXotl9VR64dKjkdIQlb/rB2VV +iZ6/JNxCFelJviKABvWZJBSpQ/5H1q7w26T6zYZZ2VmohhmUvIcay5jN0pSySB/02nV ThNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NiD60nCQfxPz72DLSVFftQSNGo19YT4fsBraYKrDRA0=; b=UE8fKbbNGZgTPke+6fUVx8OFCb0E7wgkNS2f0pzy311oVGAgLv3+ZlyLA5O1wZ8Nam 2i4CsiFAmASDltK6lDiddpShEyJgUOsh5EUyvJN2igjB4ZUN4ubpVL0RHQeeosFRcCmF lWQmpkzxLGZEWM4MSayeolI3BWFzLJKw62Bt7luXDDxTnjhc43cxZpWaWFFaEu6fv9zr jmKZP163Yv/8LzlybFy/AoRjfTKKMUrocdBnAPOU82/uyet5QCvVcjf1ij3hw+DXLtia nOr2Ts1+kuoZQbyS3c507sA8/vG5ukzHKBcTclVGiO0IH9cKz90bX36d6jlm5ZOfXP/V kcyw== X-Gm-Message-State: AJIora9vvALyke2o2Lf5eMzLCd7+wKgkn+lM3YP1OBiSqOmgpzQq/k9q hN6GsNn8q6HIPpGkiMUT690= X-Google-Smtp-Source: ABdhPJwkXF9fhb+5T3tNjMaGkfefZaZb6NaXlYHqUjMUX4L/zu8rQSyRbDEffYqFtCsik3sSyZTxVg== X-Received: by 2002:a17:906:2316:b0:711:e7f2:a33 with SMTP id l22-20020a170906231600b00711e7f20a33mr4036088eja.726.1655210822807; Tue, 14 Jun 2022 05:47:02 -0700 (PDT) Received: from [192.168.236.48] ([173.237.64.48]) by smtp.googlemail.com with ESMTPSA id c17-20020a50f611000000b0042fbc23bfcesm7059281edn.46.2022.06.14.05.47.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 05:47:02 -0700 (PDT) Message-ID: <3370ad42-5217-5e66-85a1-6bc1fffac017@yandex.ru> Date: Tue, 14 Jun 2022 15:47:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules Content-Language: en-US To: Eason Huang References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55396-done Cc: 55396-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 14.06.2022 14:22, Eason Huang wrote: > Great, I tried on my huge .emacs.d project, it works well and fast. > > Tested on macOS with latest commit. > > You can close this bug now. Thanks for your great work on it. Thanks for testing! Closing. From unknown Wed Jun 18 00:24:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Jul 2022 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator