GNU bug report logs - #55387
28.1.50; csv-mode: header does not align when line numbers are displayed

Previous Next

Package: emacs;

Reported by: Joost Kremers <joostkremers <at> fastmail.fm>

Date: Thu, 12 May 2022 15:38:02 UTC

Severity: normal

Tags: moreinfo

Found in version 28.1.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #28 received at 55387 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: larsi <at> gnus.org, joostkremers <at> fastmail.fm
Cc: 55387 <at> debbugs.gnu.org
Subject: Re: bug#55387: 28.1.50;
 csv-mode: header does not align when line numbers are displayed
Date: Fri, 13 May 2022 18:55:32 +0300
> Resent-From: Eli Zaretskii <eliz <at> gnu.org>
> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
> Resent-CC: bug-gnu-emacs <at> gnu.org
> Resent-Sender: help-debbugs <at> gnu.org
> Cc: joostkremers <at> fastmail.fm, 55387 <at> debbugs.gnu.org
> Date: Fri, 13 May 2022 17:20:43 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > Cc: joostkremers <at> fastmail.fm, 55387 <at> debbugs.gnu.org
> > Date: Fri, 13 May 2022 17:12:03 +0300
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > 
> > > header-line-format would look like
> > > 
> > > (display-line-spaces <the rest>)
> > > 
> > > where display-line-spaces would indeed be updated by the redisplay code
> > > (to be of the same length as (line-number-display-width 'columns)).
> 
> Btw, isn't it true that the problem is not in displaying the
> header-line, but in adjusting the alignment of the _body_ of the table
> to the changes in header-line (which happen automatically)?  In which
> case how will header-line construct help?

So looking at cvs-mode.el, I conclude that I don't really understand
the problem.  It seems to use :align-to display spec to align columns
in the body of the table, which should keep the alignment when
line-numbers are turned on and off, so is the problem with the
header-line after all?  If so, why isn't just using
line-number-display-width when calculating the header-line-format good
enough?

Perhaps Joost could describe the problem in more detail?




This bug report was last modified 3 years and 11 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.