GNU bug report logs - #55386
29.0.50; check-declare-directory doesn't work on Windows

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: yasu <at> utahime.org, 55386 <at> debbugs.gnu.org
Subject: bug#55386: 29.0.50; check-declare-directory doesn't work on Windows
Date: Sat, 14 May 2022 13:40:11 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> How about the below?  It's 3% to 9% slower than the find/grep version
> (because it examines more files, I think), but much simpler (IMNSHO),
> and works on any platform without any caveats.

[...]

> -  (let ((files (process-lines-ignore-status
> -                find-program root
> -                "-name" "*.el"
> -                "-exec" grep-program
> -                "-l" "^[ \t]*(declare-function" "{}" "+")))
> +  (let ((files (directory-files-recursively root "\\.el\\'")))
>      (when files
>        (apply #'check-declare-files files))))

I'm surprised that it's just 9% slower -- there's 2K files in the Emacs
tree, and only one a quarter of them have a declare-function.  Is
process-lines-ignore-status really slow or something?

But the change looks fine to me in any case.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.