GNU bug report logs - #55370
[PATCH] Add support for the Syloti Nagri script

Previous Next

Package: emacs;

Reported by: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>

Date: Wed, 11 May 2022 15:03:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55370 <at> debbugs.gnu.org
Subject: bug#55370: [PATCH] Add support for the Syloti Nagri script
Date: Thu, 12 May 2022 22:58:43 +0530
[Message part 1 (text/plain, inline)]
Ok I will do that, thanks!

On Thu, May 12, 2022 at 10:55 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Thu, 12 May 2022 22:40:02 +0530
> > Cc: 55370 <at> debbugs.gnu.org
> >
> > Yes it was not correct, this seems more appropriate.
> >
> > ;; Syloti Nagri composition rules
> > (let ((consonant            "[\xA807-\xA80A\xA80C-\xA822]")
> >       (independent-vowel    "[\xA800\xA801\xA803-\xA805]")
> >       (vowel                "[\xA802\xA823-\xA827]")
> >       (nasal                "[\xA80B]")
> >       (virama               "[\xA806\xA82C]"))
> >   (set-char-table-range composition-function-table
> >                         '(#xA802 . #xA82C)
> >                         (list (vector
> >                                ;; Consonant conjunct based syllables
> >                                (concat independent-vowel "?" consonant
> "\\(?:" virama consonant "\\)+"
> >                                        vowel "?" nasal "?")
> >                                1 'font-shape-gstring))))
> >
> > btw this range does not cause emacs to slow down, right?
>
> It might, because the range is very large, and so any character in the
> range #xA802..#xA82C will cause Emacs to try to match the regexp.
>
> So if there's a way of having the rules on fewer characters, that
> would be better, even if there will be more rules.
>
> > also should I send separate patches for the syloti nagri, and the fix
> for previous scripts, or combine them into
> > one?
>
> You can combine them into a single patch, just make sure the log
> message mentions all the changes.
>
> Thanks.
>
[Message part 2 (text/html, inline)]

This bug report was last modified 3 years and 8 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.