Subject: Re: bug#55370: [PATCH] Add support for the Syloti Nagri script

From: Eli Zaretskii <[email-masked]>
Date: Thu, 12 May 2022 20:25:18 +0300

> From: समीर सिंह Sameer Singh <[email-masked]>
> Date: Thu, 12 May 2022 22:40:02 +0530
> Cc: [email-masked]
> 
> Yes it was not correct, this seems more appropriate.
> 
> ;; Syloti Nagri composition rules
> (let ((consonant            "[\xA807-\xA80A\xA80C-\xA822]")
>       (independent-vowel    "[\xA800\xA801\xA803-\xA805]")
>       (vowel                "[\xA802\xA823-\xA827]")
>       (nasal                "[\xA80B]")
>       (virama               "[\xA806\xA82C]"))
>   (set-char-table-range composition-function-table
>                         '(#xA802 . #xA82C)
>                         (list (vector
>                                ;; Consonant conjunct based syllables
>                                (concat independent-vowel "?" consonant "\\(?:" virama consonant "\\)+"
>                                        vowel "?" nasal "?")
>                                1 'font-shape-gstring))))
> 
> btw this range does not cause emacs to slow down, right?

It might, because the range is very large, and so any character in the
range #xA802..#xA82C will cause Emacs to try to match the regexp.

So if there's a way of having the rules on fewer characters, that
would be better, even if there will be more rules.

> also should I send separate patches for the syloti nagri, and the fix for previous scripts, or combine them into
> one?

You can combine them into a single patch, just make sure the log
message mentions all the changes.

Thanks.