From debbugs-submit-bounces@debbugs.gnu.org Wed May 11 05:23:52 2022 Received: (at submit) by debbugs.gnu.org; 11 May 2022 09:23:53 +0000 Received: from localhost ([127.0.0.1]:36079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noiZU-0000kz-MS for submit@debbugs.gnu.org; Wed, 11 May 2022 05:23:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:53840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noiZS-0000kq-2I for submit@debbugs.gnu.org; Wed, 11 May 2022 05:23:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noiZQ-0006Oe-BF for bug-guix@gnu.org; Wed, 11 May 2022 05:23:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35588) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noiZQ-00085v-1X for bug-guix@gnu.org; Wed, 11 May 2022 05:23:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=bKDpbbaioKJnsg3angw7TFAkxeAhbYLVcXJlRdsr6EM=; b=HETuD2OYaDRewZ EVpFVW5GySJPiuIC4Xgs6F8R9mlTw0RYOeZ6B1JgZmnoXagWR20BN0iUm9B/a1XVG8ovhbiHh3Tc/ TRiPZA9/0K/IFrLy+iNk+op/zYWAEPtUBaE28gx49H1T508NNPissQ075emgEbNzwjzQ50oDevSDA mnt/ThPOsLvTK+Cw5jp2IxG+GISVlFt06JEQMq+L/IWrG05U1wg/TTyMy8ikZx+vkaReoh82rRRK+ eMW1qzmlIKoJW41xQ6yTPocsb9Pwew2NzcFJxwCa3fXZMKNNeTL+tCao8KUKBwGltHg1F0kSK1gEp TQNxhhxRqfKJuEeshSYg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:58630 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noiZM-0008Dr-DX for bug-guix@gnu.org; Wed, 11 May 2022 05:23:46 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: bug-guix@gnu.org Subject: [Installer] =?utf-8?Q?=E2=80=98guix?= system =?utf-8?Q?init?= =?utf-8?Q?=E2=80=99?= displays dots instead of progress bars X-Debbugs-Cc: Josselin Poiret , Mathieu Othacehe X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 =?utf-8?Q?Flor=C3=A9al?= an 230 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 11 May 2022 11:23:42 +0200 Message-ID: <87pmkko21t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! I=E2=80=99ve used an installer built from this commit: --8<---------------cut here---------------start------------->8--- Generation 214 May 02 2022 21:44:14 (current) guix 6b588da repository URL: https://git.savannah.gnu.org/git/guix.git branch: master commit: 6b588da368c77cde82ea2f22ca315116228777ad --8<---------------cut here---------------end--------------->8--- During installation, =E2=80=98guix system init=E2=80=99 displays dots inste= ad of progress bars for downloads and such. This suggests that =E2=80=98display-download-progress=E2=80=99 gets #:tty? = #f. This may be a side effect of running it in a pipe in =E2=80=98run-external-command-with-handler=E2=80=99. Thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed May 11 05:26:59 2022 Received: (at control) by debbugs.gnu.org; 11 May 2022 09:26:59 +0000 Received: from localhost ([127.0.0.1]:36086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noicV-0000qI-74 for submit@debbugs.gnu.org; Wed, 11 May 2022 05:26:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noicU-0000q6-Aj for control@debbugs.gnu.org; Wed, 11 May 2022 05:26:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35682) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noicP-0000CK-4P for control@debbugs.gnu.org; Wed, 11 May 2022 05:26:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=/NFi4n1h4EfCFeK+glm7+E3QHLDnL5lpWVhjsXrIYfE=; b=XrnPrdDzNu+Ruf fCVy9ygzHKsqaHqsKCgct8RlDLiJus4LYEGuGxvPMKs9dUJWI/GibOoPUMHZD/8Nv3VcKdq7VSel4 A1Y+ffJKSjawupZCCxmAQpOEtR6W7d3aaJAO+SgoiowDKADNFq/afeMGT7QC/ITFRurYdaXbtaDhM OGzE5sVMfFbmAgUek0wzAvEK9zBdjjzsQIwF/wT3Iq8w9JBcEs3H/c5BTfB+3Qw/TtNvkJ+GFqIUC z4Md0EMC+AGbji8Xl0zMR6ip2R0RflvHun88hYihbPARF0P303/XpA6+KhctvjYSsjw8PdGYgW7DQ KsY/7AWX49FY8VrK8vgQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59079 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noicO-0007Mi-Bu for control@debbugs.gnu.org; Wed, 11 May 2022 05:26:52 -0400 Date: Wed, 11 May 2022 11:26:50 +0200 Message-Id: <87o804o1wl.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #55360 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) severity 55360 important quit From debbugs-submit-bounces@debbugs.gnu.org Wed May 11 05:27:18 2022 Received: (at control) by debbugs.gnu.org; 11 May 2022 09:27:18 +0000 Received: from localhost ([127.0.0.1]:36091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noico-0000rQ-D0 for submit@debbugs.gnu.org; Wed, 11 May 2022 05:27:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noicn-0000rE-JD for control@debbugs.gnu.org; Wed, 11 May 2022 05:27:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noici-0000F0-CN for control@debbugs.gnu.org; Wed, 11 May 2022 05:27:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=m7Msd4xFcigKiQDLU39cJbwTas+E9XqYLdRkskLIbTc=; b=j0wgdzVUIkTTwa 7g5EXuoyLxW/6qtJQTARemjzEbP96XO0rKx+KDdc0sSSM9tbAq6uqoO9OeU1dR4XZPmJJfKJL75mI BICZtwAeqL4vS0Oj4mIxEZ46b+8DNz7gus4zKHtC99C486ubWKN9i2wMXelOLWPH17RjhKgR+09ki 0cj7oL7dO4Pt/BWK3SVcUrhjIJCDlN10T5fDAlG4ra7RiySlYI19Hh9Y7Hc1btUV5RZOM8Pdx7TEr 78/J46NcDvEQtAF9HZjlIgF25tgY9PLtrW0sQvw/S18dQ/X2+9HLQoujeOCRVu/E0vKiAnKqsV/Xq ETk0PzLppUbATpgzEHSg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54031 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noich-0007Nf-UA for control@debbugs.gnu.org; Wed, 11 May 2022 05:27:12 -0400 Date: Wed, 11 May 2022 11:27:10 +0200 Message-Id: <87mtfoo1w1.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #53214 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) block 53214 by 55360 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 18 15:59:42 2022 Received: (at 55360) by debbugs.gnu.org; 18 Jul 2022 19:59:42 +0000 Received: from localhost ([127.0.0.1]:52153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDWu6-0003QA-IB for submit@debbugs.gnu.org; Mon, 18 Jul 2022 15:59:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDWu2-0003Pv-Bw for 55360@debbugs.gnu.org; Mon, 18 Jul 2022 15:59:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDWtw-0002FE-OW; Mon, 18 Jul 2022 15:59:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=VhxyRYIxexp3uXPBL2ln7aTdRfVYnUyIrhzgPpOvKrQ=; b=ItQL3JHuQo9GdvWmV+jP W9eh+bNoEyZLf0OWieEsTYLIhOEUczHiSLBQwZ2ZZCOwiocVYabw2L5I+KIkFqDwnkkCWT5HF4RUp A4E79MqXrjPYXP1Xeg44uUBf+mDy6gFbjWuRvFB4dAVypaWXmM3Z2FAT2IAwyb0deAhB/G/KhHPqI zFp/H4kSngOKsOc72JTsp7JssvJo/gPhUn2pmxmy5P6sZnW3wndoGWfia6NNRHJv1HSSwLL5Bvsj7 tyJ43l5L2XydhHv6mVmxP/vTg5/EwBwhB+RSxIBc8IjoERqnL98UmKXQuIqbssP7vyywhnO+TSQ25 6QvJT5dGLXCSJw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59822 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDWtI-0005Nb-Ks; Mon, 18 Jul 2022 15:59:06 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Josselin Poiret , Mathieu Othacehe Subject: Re: bug#55360: [Installer] =?utf-8?Q?=E2=80=98guix?= system =?utf-8?Q?init=E2=80=99?= displays dots instead of progress bars References: <87pmkko21t.fsf@gnu.org> Date: Mon, 18 Jul 2022 21:58:50 +0200 In-Reply-To: <87pmkko21t.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 11 May 2022 11:23:42 +0200") Message-ID: <87y1wqw5tx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55360 Cc: 55360@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Ludovic Court=C3=A8s skribis: > During installation, =E2=80=98guix system init=E2=80=99 displays dots ins= tead of > progress bars for downloads and such. > > This suggests that =E2=80=98display-download-progress=E2=80=99 gets #:tty= ? #f. This may > be a side effect of running it in a pipe in > =E2=80=98run-external-command-with-handler=E2=80=99. This was introduced by: commit 0b9fbbb4dd24f227c9a708561ba291f6169ad2e6 Date: Sat Jan 15 14:50:00 2022 +0100 installer: Capture external commands output. * gnu/installer/utils.scm (run-external-command-with-handler, run-external-command-with-line-hooks): New variables. (run-command): Use run-external-command-with-line-hooks. According to , the goal was (unsurprisingly) to log standard output of commands. I=E2=80=99m not sure it=E2=80=99s a good idea for =E2=80=98guix system init= =E2=80=99: we=E2=80=99d be logging mostly progress bars, package names, and the likes to syslog=E2=80=94not su= per useful. So I=E2=80=99d suggest not capturing stdout of =E2=80=98guix syste= m init=E2=80=99. However, I wouldn=E2=80=99t mind factorizing the syslog facilities from 2cf65e1d543407bc7db43e7c7d39a215907efebc into, say, (guix syslog), and have (guix scripts system) use it to log important events. Thoughts? What about using =E2=80=98run-external-command-with-line-hooks=E2=80=99 for= other commands though? IIUC, the primary use case is file system tools. My gut feeling is that the cost/benefit ratio isn=E2=80=99t worth it (the c= ost here is complexity and maintenance burden of =E2=80=98run-external-command-with-handler=E2=80=99 & co.; the benefit is i= mproved logging). WDYT? I can hopefully dedicate a bit of time to this, but I need your guidance, comrades. :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 09 12:56:59 2022 Received: (at control) by debbugs.gnu.org; 9 Oct 2022 16:56:59 +0000 Received: from localhost ([127.0.0.1]:44864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZbn-00045b-H9 for submit@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohZbm-00045L-Dg for control@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35730) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohZbg-0007au-Mu for control@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=apOyAmOHc/Bd14mo04/y+wG/Zs/hBMHb4hmi/MeD5DA=; b=McBuDtFVmmxBi0 xPPpJUOKJHiMHVg69VgVb4sr7K7AYJEGdWw/t938yTGBfaV7vznG00arohJAjVFy1trfdInpBxv/W tkdfHLBMgbIheFjWUl49KvegjLpj1Z+NvIYcWZMvt0CVys/sy3RffOV6dQStjfNs+eFk33Z0Th0Bx GiG6zb5zz3Oii3TeY5RW517w5N9ELPfiCdUS/uKmOnvAKazLS0vffKjxmHWRw0xEW96wna+JBswQr qaD2sz+tqEYIeLRxixDk2aMTE417Jwix9s9WB/dnEBd6N3QGq7pWqQs4FB+t52hWX9plBVK+rDYTZ 1ryG9s27mk1ag/ypcMmg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:53068 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohZbg-0003tK-8X for control@debbugs.gnu.org; Sun, 09 Oct 2022 12:56:52 -0400 Date: Sun, 09 Oct 2022 18:56:51 +0200 Message-Id: <878rlp5418.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #55360 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 55360 58375 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 03:04:40 2022 Received: (at 55360) by debbugs.gnu.org; 13 Oct 2022 07:04:40 +0000 Received: from localhost ([127.0.0.1]:59242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oisGm-0006PG-5E for submit@debbugs.gnu.org; Thu, 13 Oct 2022 03:04:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oisGh-0006Ox-B8; Thu, 13 Oct 2022 03:04:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oisGZ-0000Kk-QG; Thu, 13 Oct 2022 03:04:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=3ugSvfXff1YuNEnDZ8sKVUbqEb+yytPunv/FFbTVeYs=; b=idd0u3iV/4yNuLXRNP84 kwGF78ClNFuWfQ4Tu0Qruseflut0rri9HSGH9N1Z+EADJi0FdU9ZLla5SEDwKBkeMli/f5XsK0MZX j5IntgQZlyuCDa+O39LrFQGHhww3Ss/Kg9FykFz88F6AhsJzfxLqqcLbdWC3yXzvZRGpTiWpBWPCo LtuLV+7XjGMjtukraj4U2hFXP/qrc7a8r46nDgbH8GC+EyPpvlTYbikQL04jsJYFNJNtjByX0Wdm4 TQoZwFGEAu0eX6Z+sN+t0ezRyz52zNM1FxF+fiskUhgwP/DN3eM7OnW6vBb11ueNhidLNJPwuImkH uwnh/dpHYhk9Fg==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:59700 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oisGG-0008Or-Ab; Thu, 13 Oct 2022 03:04:26 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#58375: Installer does not show what is being downloaded References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> Date: Thu, 13 Oct 2022 09:04:02 +0200 In-Reply-To: <87y1wqw5tx.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 18 Jul 2022 21:58:50 +0200") Message-ID: <87lepk5hnh.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55360 Cc: Josselin Poiret , 55360@debbugs.gnu.org, 58375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Ludo! > I=E2=80=99m not sure it=E2=80=99s a good idea for =E2=80=98guix system in= it=E2=80=99: we=E2=80=99d be logging > mostly progress bars, package names, and the likes to syslog=E2=80=94not = super > useful. So I=E2=80=99d suggest not capturing stdout of =E2=80=98guix sys= tem init=E2=80=99. In the bug report https://issues.guix.gnu.org/57983 capturing the 'guix system init' output highlighted a "guix substitute" crash. So it does seem like a useful mechanism, especially while 56005 is still open. Now the current situation is also not really acceptable. What about hiding the "guix system init" output completely and display a progress bar page instead? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 13 09:22:11 2022 Received: (at 55360) by debbugs.gnu.org; 13 Oct 2022 13:22:11 +0000 Received: from localhost ([127.0.0.1]:59937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiyA6-0004VB-QU for submit@debbugs.gnu.org; Thu, 13 Oct 2022 09:22:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiyA4-0004Uv-J7; Thu, 13 Oct 2022 09:22:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiy9z-0003ey-6H; Thu, 13 Oct 2022 09:22:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=DFSdyUBeDGpkIGR1Qnb9pzynxf9qLRN7rtzghbtYR3s=; b=nL29Zx8x2xP8HBbEykJ2 wTZg4JwROyxb7xi0tHY34PeJpvKGuL+qgj8i1Jwr+xVGo+A1044T0eRgBLNMPnkH3NTsmDis76cJE Rd530rhaU+tAo+2LbkL8nbFUv59wagdguybsRKGApmNVkjd2b+kiZcMSdvRZMPlv6b+ih/VSU7W0F p9ram6MUiH3pgYCDlwNt+wpHSkoaY7X5YUsWZApC3ZCe6PACKQQsix0hxbi/DUaMMYO6wF+TkJh0j hQp9E0a+gX6DLH8Srrmx9uEadjioZvMgu6HuZHdAQ0aJF9cAHFsED6YVq+OtztStAlMhwRGgN9CtU eDgsUWhKZ69cXg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:51868 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiy9s-0006sB-Ai; Thu, 13 Oct 2022 09:21:59 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#58375: Installer does not show what is being downloaded References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> <87lepk5hnh.fsf_-_@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Duodi 22 =?utf-8?Q?Vend=C3=A9miaire?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour de la =?utf-8?Q?P=C3=AAche?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 13 Oct 2022 15:21:53 +0200 In-Reply-To: <87lepk5hnh.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Thu, 13 Oct 2022 09:04:02 +0200") Message-ID: <87zgdzq2oe.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55360 Cc: Josselin Poiret , 55360@debbugs.gnu.org, 58375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Mathieu Othacehe skribis: >> I=E2=80=99m not sure it=E2=80=99s a good idea for =E2=80=98guix system i= nit=E2=80=99: we=E2=80=99d be logging >> mostly progress bars, package names, and the likes to syslog=E2=80=94not= super >> useful. So I=E2=80=99d suggest not capturing stdout of =E2=80=98guix sy= stem init=E2=80=99. > > In the bug report https://issues.guix.gnu.org/57983 capturing the 'guix > system init' output highlighted a "guix substitute" crash. So it does > seem like a useful mechanism, especially while 56005 is still open. Hmm right. is not installer-specific, so it=E2=80=99s annoying that we have to prepare for th= at, but we can=E2=80=99t deny such bugs exist and prevent installation. If we really want to capture the output of =E2=80=98guix system init=E2=80= =99, then we need to open a pseudo-terminal with =E2=80=98openpty=E2=80=99 & co. instead= of =E2=80=98pipe=E2=80=99 in =E2=80=98run-external-command-with-handler=E2=80=99. That may be relativel= y easy actually. But then I think this should be used sparsely, maybe only for =E2=80=98guix system init=E2=80=99. > Now the current situation is also not really acceptable. Nope. :-) > What about hiding the "guix system init" output completely and display > a progress bar page instead? I don=E2=80=99t think we can do that (with grafts, only part of the build p= lan is known upfront so we don=E2=80=99t even know beforehand how many items wi= ll be built/downloaded). Also, I think there are two strategies: either we run =E2=80=98guix system init=E2=80=99, in which case we let its output through, or we integrate =E2= =80=98guix system init=E2=80=99 functionality in the installer so we have more fine-gr= ain control over the process, in which case we could also have more graphical output or something. That second solution is a lot of work, though. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 14 11:44:42 2022 Received: (at 55360) by debbugs.gnu.org; 14 Oct 2022 15:44:42 +0000 Received: from localhost ([127.0.0.1]:38385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojMrZ-0007Rl-Ab for submit@debbugs.gnu.org; Fri, 14 Oct 2022 11:44:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojMrW-0007RP-CH; Fri, 14 Oct 2022 11:44:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojMrN-000454-5M; Fri, 14 Oct 2022 11:44:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fkR9vMg9G4UMYdCbRM4yvWrJz0zSsN7OSxK0cD4/fhs=; b=UGF+J25hLZR5BdXdCDdA 3u8YwVy2cACadWNQ0VE3HIC5vdzS86JeDg9vG2kIe5meQcMbfKYmz6qRNg3cNpfh/g90cv5aGdpVS Yl8+E/80Yy08fVfJZYt/1J4E7m+uzSTK7vQmVAVN8rp0R3Med2u8NYSS3JIFtntTTiucUVNLy+xKh 2M2QZypOdtlwTeYjxjkg1oRMRT6pGQkibEqMvv9IUgDjUDyiW37ZQDAMID+OSFcRjYndN1FodNcTZ aXcH9HuFugADGFZhyhBkst/rpusa/qbfav4B9y+CkI3hSn5yVwaA2gjwxG4UalO6qqB5G/YMwX8iF bb3zTVHEBjaTeg==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:48042 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojMrM-0004z1-GB; Fri, 14 Oct 2022 11:44:28 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#58375: Installer does not show what is being downloaded References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> <87lepk5hnh.fsf_-_@gnu.org> <87zgdzq2oe.fsf@gnu.org> Date: Fri, 14 Oct 2022 17:44:24 +0200 In-Reply-To: <87zgdzq2oe.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 13 Oct 2022 15:21:53 +0200") Message-ID: <871qrabeav.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55360 Cc: Josselin Poiret , 55360@debbugs.gnu.org, 58375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey, > If we really want to capture the output of =E2=80=98guix system init=E2= =80=99, then we > need to open a pseudo-terminal with =E2=80=98openpty=E2=80=99 & co. inste= ad of =E2=80=98pipe=E2=80=99 in > =E2=80=98run-external-command-with-handler=E2=80=99. That may be relativ= ely easy > actually. So I implemented your proposal. It seems to be working quite well. As discussed on #guix, we could avoid to dump the download bars to the syslog if the "guix system init" command succeeds. However, it seems quite tricky in the current implementation where the syslog dumping is actually a hook (%syslog-line-hook). Fixing this issue, I also realized that when the "guix system init" command fails, the user is only offered to resume the installation or restart it. In cases where "guix system init" failed because of a network issue, or because a partition was too small, restarting/resuming seems like the right thing to do. However, when the installer failed because "guix system init" crashed or segfaulted, restarting/resuming won't probably help, and dumping the crash is probably the best way to get help. That's why I added in a second patch, a new button "Report the failure" to the "run-install-failed-page". Thanks, Mathieu --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-installer-Run-the-guix-system-init-command-in-a-PTY.patch >From c6286404e9c4c0dc302c3d398a8f27b050cf4ce0 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Fri, 14 Oct 2022 17:28:27 +0200 Subject: [PATCH 1/2] installer: Run the "guix system init" command in a PTY. Fixes: * gnu/installer/utils.scm (run-external-command-with-handler/tty): New procedure. (run-external-command-with-line-hooks, run-command): Add a TTY? argument. * gnu/installer/final.scm (install-system): Call run-command with TTY? argument set to #true. --- gnu/installer/final.scm | 2 +- gnu/installer/utils.scm | 50 +++++++++++++++++++++++++++++++++-------- 2 files changed, 42 insertions(+), 10 deletions(-) diff --git a/gnu/installer/final.scm b/gnu/installer/final.scm index 3f6dacc490..044f79372b 100644 --- a/gnu/installer/final.scm +++ b/gnu/installer/final.scm @@ -211,7 +211,7 @@ (define (assert-exit x) (setenv "PATH" "/run/current-system/profile/bin/") - (set! ret (run-command install-command))) + (set! ret (run-command install-command #:tty? #t))) (lambda () ;; Restart guix-daemon so that it does no keep the MNT namespace ;; alive. diff --git a/gnu/installer/utils.scm b/gnu/installer/utils.scm index 5fd2e2d425..061493e6a7 100644 --- a/gnu/installer/utils.scm +++ b/gnu/installer/utils.scm @@ -20,6 +20,7 @@ (define-module (gnu installer utils) #:use-module (gnu services herd) #:use-module (guix utils) + #:use-module ((guix build syscalls) #:select (openpty login-tty)) #:use-module (guix build utils) #:use-module (guix i18n) #:use-module (srfi srfi-1) @@ -45,6 +46,7 @@ (define-module (gnu installer utils) nearest-exact-integer read-percentage run-external-command-with-handler + run-external-command-with-handler/tty run-external-command-with-line-hooks run-command run-command-in-installer @@ -124,10 +126,37 @@ (define dummy-pipe (close-port input) (close-pipe dummy-pipe))) -(define (run-external-command-with-line-hooks line-hooks command) +(define (run-external-command-with-handler/tty handler command) + "Run command specified by the list COMMAND in a child operating in a +pseudoterminal with output handler HANDLER. HANDLER is a procedure taking an +input port, to which the command will write its standard output and error. +Returns the integer status value of the child process as returned by waitpid." + (define-values (controller inferior) + (openpty)) + + (match (primitive-fork) + (0 + (catch #t + (lambda () + (close-fdes controller) + (login-tty inferior) + (apply execlp (car command) command)) + (lambda _ + (primitive-exit 127)))) + (pid + (close-fdes inferior) + (let* ((port (fdopen controller "r0")) + (result (false-if-exception + (handler port)))) + (close-port port) + (cdr (waitpid pid)))))) + +(define* (run-external-command-with-line-hooks line-hooks command + #:key (tty? #false)) "Run command specified by the list COMMAND in a child, processing each -output line with the procedures in LINE-HOOKS. Returns the integer status -value of the child process as returned by waitpid." +output line with the procedures in LINE-HOOKS. If TTY is set to #true, the +COMMAND will be run in a pseudoterminal. Returns the integer status value of +the child process as returned by waitpid." (define (handler input) (and (and=> (get-line input) @@ -136,14 +165,17 @@ (define (handler input) #f (begin (for-each (lambda (f) (f line)) (append line-hooks - %default-installer-line-hooks)) + %default-installer-line-hooks)) #t)))) (handler input))) - (run-external-command-with-handler handler command)) + (if tty? + (run-external-command-with-handler/tty handler command) + (run-external-command-with-handler handler command))) -(define* (run-command command) +(define* (run-command command #:key (tty? #f)) "Run COMMAND, a list of strings. Return true if COMMAND exited -successfully, #f otherwise." +successfully, #f otherwise. If TTY is set to #true, the COMMAND will be run +in a pseudoterminal." (define (pause) (format #t (G_ "Press Enter to continue.~%")) (send-to-clients '(pause)) @@ -154,8 +186,8 @@ (define (pause) (installer-log-line "running command ~s" command) (define result (run-external-command-with-line-hooks - (list %display-line-hook) - command)) + (list %display-line-hook) command + #:tty? tty?)) (define exit-val (status:exit-val result)) (define term-sig (status:term-sig result)) (define stop-sig (status:stop-sig result)) -- 2.37.3 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-installer-Propose-the-user-to-report-a-guix-system-i.patch >From 159b82a013cad8c3c698031cce9ee07956153da3 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Fri, 14 Oct 2022 17:33:28 +0200 Subject: [PATCH 2/2] installer: Propose the user to report a "guix system init" failure. * gnu/installer/newt/final.scm (run-install-failed-page): Add a "Report the failure" button. --- gnu/installer/newt/final.scm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gnu/installer/newt/final.scm b/gnu/installer/newt/final.scm index 7c3f73ee82..6e55be5067 100644 --- a/gnu/installer/newt/final.scm +++ b/gnu/installer/newt/final.scm @@ -80,16 +80,21 @@ (define (run-install-success-page) (define (run-install-failed-page) (match (current-clients) (() - (match (choice-window + (match (ternary-window (G_ "Installation failed") (G_ "Resume") (G_ "Restart the installer") + (G_ "Report the failure") (G_ "The final system installation step failed. You can resume from \ a specific step, or restart the installer.")) (1 (abort-to-prompt 'installer-step 'abort)) (2 ;; Keep going, the installer will be restarted later on. - #t))) + #t) + (3 (raise + (condition + (&message + (message "User abort."))))))) (_ (send-to-clients '(installation-failure)) #t))) -- 2.37.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 11:18:37 2022 Received: (at 55360) by debbugs.gnu.org; 18 Oct 2022 15:18:37 +0000 Received: from localhost ([127.0.0.1]:53791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okoMJ-0007hI-Ae for submit@debbugs.gnu.org; Tue, 18 Oct 2022 11:18:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okoLr-0007gB-L2; Tue, 18 Oct 2022 11:18:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49452) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoLl-0006Jn-So; Tue, 18 Oct 2022 11:17:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=/kSe6w2Cm36fLYagT5nqSB5UV6ylkOgU95xK3KcF49w=; b=Gvem/dLEK4jqtlGoNsRs EYBnSj4pCjAacFYj8DZdLQlHLWxr6FWIKCqgtCgCOqOoZ3mWAx3TruZC3xQt0fe/CD/m3LHIT0PYz bzn899uIxWb4oP8dpWIFYoqEmrm81KbFmTWFltkh30te5pybINXzdxDh2211X4DwV/CnFvK9uKgV3 AomrJV4tw4XhNAVY4Bc70vQrqb2mOLcW4ifr/2MSgAxj+t2Z/1nSoVITEFirj8aR+FpQyoYrWlKvM Js+PpZ/DMUIxJKR+pNUaV6pcYfaX2NqmKijyb3KnyNDctyFRy4k36WetWf+3z5ToTbgTVh9X9hILi N8C3wX/2wzaxWg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=41874 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoLk-0004N5-Oe; Tue, 18 Oct 2022 11:17:48 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#58375: Installer does not show what is being downloaded References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> <87lepk5hnh.fsf_-_@gnu.org> <87zgdzq2oe.fsf@gnu.org> <871qrabeav.fsf_-_@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 27 =?utf-8?Q?Vend=C3=A9miaire?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Piment X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 18 Oct 2022 17:17:47 +0200 In-Reply-To: <871qrabeav.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Fri, 14 Oct 2022 17:44:24 +0200") Message-ID: <87czapma90.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55360 Cc: Josselin Poiret , 55360@debbugs.gnu.org, 58375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Mathieu, Mathieu Othacehe skribis: > So I implemented your proposal. It seems to be working quite well. As > discussed on #guix, we could avoid to dump the download bars to the > syslog if the "guix system init" command succeeds. However, it seems > quite tricky in the current implementation where the syslog dumping is > actually a hook (%syslog-line-hook). Yes. I haven=E2=80=99t actually tested the patch but it LGTM. One thing to chec= k is whether =E2=80=98terminal-window-size=E2=80=99 returns something sensible f= or the pseudo-terminal; it could be that we need an extra ioctl so the pseudo-terminal has the same size as the actual terminal. > Fixing this issue, I also realized that when the "guix system init" > command fails, the user is only offered to resume the installation or > restart it. > > In cases where "guix system init" failed because of a network issue, or > because a partition was too small, restarting/resuming seems like the > right thing to do. > > However, when the installer failed because "guix system init" crashed or > segfaulted, restarting/resuming won't probably help, and dumping the > crash is probably the best way to get help. That's why I added in a > second patch, a new button "Report the failure" to the > "run-install-failed-page". Neat! > From c6286404e9c4c0dc302c3d398a8f27b050cf4ce0 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Fri, 14 Oct 2022 17:28:27 +0200 > Subject: [PATCH 1/2] installer: Run the "guix system init" command in a P= TY. > > Fixes: > > * gnu/installer/utils.scm (run-external-command-with-handler/tty): New > procedure. > (run-external-command-with-line-hooks, run-command): Add a TTY? argument. > * gnu/installer/final.scm (install-system): Call run-command with TTY? > argument set to #true. LGTM, modulo the terminal size issue mentioned above. > From 159b82a013cad8c3c698031cce9ee07956153da3 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Fri, 14 Oct 2022 17:33:28 +0200 > Subject: [PATCH 2/2] installer: Propose the user to report a "guix system > init" failure. > > * gnu/installer/newt/final.scm (run-install-failed-page): Add a "Report t= he > failure" button. LGTM. Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 10:40:23 2022 Received: (at 55360-done) by debbugs.gnu.org; 20 Oct 2022 14:40:23 +0000 Received: from localhost ([127.0.0.1]:35900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olWic-0000L4-Rg for submit@debbugs.gnu.org; Thu, 20 Oct 2022 10:40:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olWiZ-0000Kh-Iv; Thu, 20 Oct 2022 10:40:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olWiT-0004S7-9X; Thu, 20 Oct 2022 10:40:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=xq8qCLhr/yT7fmIPsPynd2yaLg2UsCANvV6zqIAXLaM=; b=mw9gkFMy1U+waSOzdta/ RoNFNCt0wOo/BrDMpJn1R1NvcpC91J/cs4tNDCv8VL1HxodwJCdeWaADh3dBMm5cbJ7U+d+umK7GO 4MtS06CJDDsnaBH112vOIGVN8QFbI4wEBXa3B5f4/KkxoFTPJRHhHQRsm+2qc/uGLVKi4LrFIPhut GaZiT3suMwTqJ4rMRP8iHm91tctS8j8z5bSMMkt+mgak6b2OGf+EUNhNnAU0CBoQVLUN0AxFL2o+Y WEDWmyYOWWRXSRzMZDTZwzby54r6E2Sm5ySbqYjEGWNCX/E6oAlPdi7FaHHSWT3+GFNDSeusBpsFT Ki/5p6sjd62V1w==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:59608 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olWiR-0002Mf-RD; Thu, 20 Oct 2022 10:40:12 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#58375: Installer does not show what is being downloaded References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> <87lepk5hnh.fsf_-_@gnu.org> <87zgdzq2oe.fsf@gnu.org> <871qrabeav.fsf_-_@gnu.org> <87czapma90.fsf@gnu.org> Date: Thu, 20 Oct 2022 16:40:08 +0200 In-Reply-To: <87czapma90.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 18 Oct 2022 17:17:47 +0200") Message-ID: <875ygepnhz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55360-done Cc: Josselin Poiret , 55360-done@debbugs.gnu.org, 58375-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, Thanks for having a look! > I haven=E2=80=99t actually tested the patch but it LGTM. One thing to ch= eck is > whether =E2=80=98terminal-window-size=E2=80=99 returns something sensible= for the > pseudo-terminal; it could be that we need an extra ioctl so the > pseudo-terminal has the same size as the actual terminal. Well it returns 0 for all fields, but I tested on several screen sizes and everything seems fine so I went ahead. While testing I noticed two new issues though: 1. When the disk is GPT partitionned there is no confirmation page in "run-label-page". Something I missed in #57232. 2. When there is an exception in run-external-command-with-handler/tty for instance, the backtrace page is displayed in the PTY and the keyboard shortcuts do not work anymore. I'll address point 1 shortly but could use some advice for point 2. Thanks, Mathieu From unknown Sat Jun 21 03:21:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 18 Nov 2022 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator