GNU bug report logs - #5536
set-face-attribute doesn't work correctly

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5536 in the body.
You can then email your comments to 5536 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: sj <prime.wizard+emacs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: set-face-attribute doesn't work correctly
Date: Sun, 7 Feb 2010 00:29:47 +0900

[Message part 1 (text/plain, inline)]

symptom:
(custom-face-attributes-get 'font-lock-keyword-face nil)
 ==> (:foreground "Cyan1")

(set-face-attribute 'font-lock-keyword-face nil
            :family "verdana")

(custom-face-attributes-get 'font-lock-keyword-face nil)
 ==> (:foreground "Cyan1" :family "verdana")

--------------------------------------------------------------

(set-face-attribute 'font-lock-keyword-face nil
            :family 'unspecified)

(custom-face-attributes-get 'font-lock-keyword-face nil)
 ==> (:foreground "Cyan1" :family "verdana")             ;; wasn't removed

--------------------------------------------------------------


my solution:
modify faces.el file
===============================================================
738c738
<       (when (stringp family)
---
>       (when (or (stringp family)(eq family 'unspecified))
741c741
<       (when (stringp foundry)
---
>       (when (or (stringp foundry)(eq foundry 'unspecified))
===============================================================

[Message part 2 (text/html, inline)]

Message #8 received at 5536 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: sj <prime.wizard+emacs <at> gmail.com>
Cc: 5536 <at> debbugs.gnu.org
Subject: Re: set-face-attribute doesn't work correctly
Date: Sat, 06 Feb 2010 23:14:57 -0500

> (custom-face-attributes-get 'font-lock-keyword-face nil)
>  ==> (:foreground "Cyan1")
> (set-face-attribute 'font-lock-keyword-face nil
>             :family "verdana")
> (custom-face-attributes-get 'font-lock-keyword-face nil)
>  ==> (:foreground "Cyan1" :family "verdana")
> (set-face-attribute 'font-lock-keyword-face nil
>             :family 'unspecified)
> (custom-face-attributes-get 'font-lock-keyword-face nil)
>  ==> (:foreground "Cyan1" :family "verdana")
>
> my solution:
> modify faces.el file

Thanks.  Your patch looks reasonable, and I've checked it in.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.