GNU bug report logs - #55357
29.0.50; [PATCH] Fix browse-url-emacs on file:// urls

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Subject: bug#55357: closed (Re: bug#55357: 29.0.50; [PATCH] Fix
 browse-url-emacs on file:// urls)
Date: Wed, 11 May 2022 18:37:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#55357: 29.0.50; [PATCH] Fix browse-url-emacs on file:// urls

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 55357 <at> debbugs.gnu.org.

-- 
55357: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55357
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: 55357-done <at> debbugs.gnu.org
Subject: Re: bug#55357: 29.0.50; [PATCH] Fix browse-url-emacs on file:// urls
Date: Wed, 11 May 2022 11:35:58 -0700

> On May 11, 2022, at 11:35 AM, Yuan Fu <casouri <at> gmail.com> wrote:
> 
> 
> 
>> On May 11, 2022, at 4:37 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> 
>>> Resent-From: Yuan Fu <casouri <at> gmail.com>
>>> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
>>> Resent-CC: bug-gnu-emacs <at> gnu.org
>>> Resent-Sender: help-debbugs <at> gnu.org
>>> From: Yuan Fu <casouri <at> gmail.com>
>>> Date: Wed, 11 May 2022 00:05:50 -0700
>>> 
>>> 
>>> [1:text/plain Hide]
>>> 
>>> 
>>> If you call browse-url-emacs with a file:// url, Emacs does not open the correct file:
>>> 
>>> (browse-url-emacs "file://~/a/b") opens /a/b
>>> (browse-url-emacs "file://a/b") opens /b
>>> 
>>> Basically unless the path is an absolute path, the first level is chopped because url parses it as host and throws it away. This patch concats the host back. If the path is absolute, host is empty string so it’s ok.
>> 
>> I think your URLs lack one or two more slashes. See
>> 
>> https://en.wikipedia.org/wiki/File_URI_scheme#How_many_slashes?
> 
> Ah! My bad. Closing.
> 
> Yuan
> 

[Message part 3 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50; [PATCH] Fix browse-url-emacs on file:// urls
Date: Wed, 11 May 2022 00:05:50 -0700

[Message part 4 (text/plain, inline)]

If you call browse-url-emacs with a file:// url, Emacs does not open the correct file:

(browse-url-emacs "file://~/a/b") opens /a/b
(browse-url-emacs "file://a/b") opens /b

Basically unless the path is an absolute path, the first level is chopped because url parses it as host and throws it away. This patch concats the host back. If the path is absolute, host is empty string so it’s ok.

Yuan

[file-url.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.