GNU bug report logs - #55329
[PATCH] Choose latex environment for table.el export

Previous Next

Package: emacs;

Reported by: Vladimir Nikishkin <lockywolf <at> gmail.com>

Date: Mon, 9 May 2022 03:24:02 UTC

Severity: normal

Tags: patch

Merged with 55333

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #10 received at 55329 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vladimir Nikishkin <lockywolf <at> gmail.com>
Cc: 55329 <at> debbugs.gnu.org
Subject: Re: bug#55329: [PATCH] Choose latex environment for table.el export
Date: Mon, 09 May 2022 14:25:35 +0300

> From: Vladimir Nikishkin  <lockywolf <at> gmail.com>
> Date: Mon, 09 May 2022 10:30:57 +0800
> 
> The patch creates 1 new customize variable:
> 1. table-latex-environment
> 
> And changes the following 2 functions:
> 1. table--generate-source-epilogue
> 2. table--generate-source-prologue

Thanks.  A couple of minor nits:

> +(defcustom table-latex-environment "tabular"
> +  "Which tabular-compatible environment to use when generating latex.
> +tabular and longtable are known to work."

I'm not sure I understand the purpose of the last sentence, nor what
it adds to the doc string.

Also, perhaps we should prefer symbol values, not string values here?
Symbols are easier to compare and harder to make mistakes.
This bug report was last modified 3 years and 66 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.