GNU bug report logs - #55316
[PATCH] scripts: package: Transform before creating manifest entries.

Previous Next

Full log

Message #16 received at 55316-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 55316-done <at> debbugs.gnu.org
Subject: Re: bug#55316: [PATCH] scripts: package: Transform before creating
 manifest entries.
Date: Mon, 23 May 2022 15:15:41 +0200

[Message part 1 (text/plain, inline)]

Hi Josselin,

Josselin Poiret <dev <at> jpoiret.xyz> skribis:

> * guix/scripts/package.scm (options->installable): Add TRANSFORM
> argument, to be able to directly transform the new packages before
> creating their manifest entries.
> (process-actions): Remove transform-entry, and step3, transforming
> directly in step2.
> * tests/guix-package.sh: Add test.

Finally applied with the cosmetic change below, thank you!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/tests/guix-package.sh b/tests/guix-package.sh
index c2f5e39de0..dedba2fd74 100644
--- a/tests/guix-package.sh
+++ b/tests/guix-package.sh
@@ -212,8 +212,8 @@ test ! -f "$profile/bin/sed"
 rm "$profile" "$profile"-[0-9]-link
 
 # Make sure transformations apply to propagated inputs and don't lead to
-# conflicts when installing them alongside, see bug
-# <https://lists.gnu.org/archive/html/guix-patches/2022-05/msg00277.html>
+# conflicts when installing them alongside, see
+# <https://issues.guix.gnu.org/55316>.
 mkdir "$module_dir"
 cat > "$module_dir/test.scm" <<EOF
 (define-module (test)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.