GNU bug report logs - #55276
[PATCH] gnu: Add xkblayout.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55276 in the body.
You can then email your comments to 55276 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Attila Lendvai <attila <at> lendvai.name>
To: guix-patches <at> gnu.org
Cc: Attila Lendvai <attila <at> lendvai.name>
Subject: [PATCH] gnu: Add xkblayout.
Date: Thu,  5 May 2022 18:46:59 +0200

* gnu/packages/xdisorg.scm (xkblayout): New variable.
---
 gnu/packages/xdisorg.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index d41c520962..b88f1b9445 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -387,6 +387,29 @@ (define-public xkb-switch
 state.")
     (license license:gpl3+)))
 
+(define-public xkblayout
+  ;; Upstream has no tags as of 2022-05-04
+  (let ((revision "0")
+        (commit "c0851b0f4bc9bc1a07240605baac8e50abe63fa8"))
+    (package
+      (name "xkblayout")
+      (version (string-append "0.0.0-" revision "-" (substring commit 0 7)))
+      (home-page "https://gitlab.freedesktop.org/whot/xkblayout")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url home-page)
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0057988l5l7pmwg7dp6cqvj5l4lr0g5z3wq189g6kz36l9rmh675"))))
+      (build-system python-build-system)
+      (synopsis "XKB layout template generator")
+      (description "xkblayout is a CLI application to generate templates for
+a new XKB layout, either in the user's home directory or the system directory.")
+      (license license:gpl3+))))
+
 (define-public xclip
   (package
     (name "xclip")
-- 
2.35.1

Message #8 received at 55276 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Attila Lendvai <attila <at> lendvai.name>, 55276 <at> debbugs.gnu.org
Subject: Re: [bug#55276] [PATCH] gnu: Add xkblayout.
Date: Thu, 05 May 2022 19:18:55 +0200

[Message part 1 (text/plain, inline)]

Attila Lendvai schreef op do 05-05-2022 om 18:46 [+0200]:
> +(define-public xkblayout
> +  ;; Upstream has no tags as of 2022-05-04
> +  (let ((revision "0")
> +        (commit "c0851b0f4bc9bc1a07240605baac8e50abe63fa8"))

I don't think the lack of tags matters, what relevant is whether there
is some kind of version number system.  So I'd go for

  ;; Upstream doesn't have any version numbers

However, upstream does have versions:

https://gitlab.freedesktop.org/whot/xkblayout/-/blob/master/setup.py#L6

... but it's an old version, so maybe upstream could be asked if it's a
’good’ version?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 55276 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Attila Lendvai <attila <at> lendvai.name>, 55276 <at> debbugs.gnu.org
Subject: Re: [bug#55276] [PATCH] gnu: Add xkblayout.
Date: Thu, 05 May 2022 19:19:09 +0200

[Message part 1 (text/plain, inline)]

Attila Lendvai schreef op do 05-05-2022 om 18:46 [+0200]:
> +      (version (string-append "0.0.0-" revision "-" (substring commit 0 7)))

'git-version'?

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 55276 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Attila Lendvai <attila <at> lendvai.name>, 55276 <at> debbugs.gnu.org
Subject: Re: [bug#55276] [PATCH] gnu: Add xkblayout.
Date: Thu, 05 May 2022 19:19:57 +0200

[Message part 1 (text/plain, inline)]

Attila Lendvai schreef op do 05-05-2022 om 18:46 [+0200]:
> +      (license license:gpl3+))))

xkblayout.py says otherwise (some kind of BSD maybe?)

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 55276 <at> debbugs.gnu.org (full text, mbox):

From: Attila Lendvai <attila <at> lendvai.name>
To: 55276 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila <at> lendvai.name>
Subject: [PATCH v2] gnu: Add xkblayout.
Date: Fri,  6 May 2022 08:22:55 +0200

* gnu/packages/xdisorg.scm (xkblayout): New variable.
---

i've addressed the issues i could, but i'm not sure anymore
whether this should be packaged for Guix at all. maybe
people should just clone the repo and run it from there?

feel free to reject it.

either way, i've requested some clarifications:

https://gitlab.freedesktop.org/whot/xkblayout/-/issues/

licensing is contradictory, COPYING says GPL.

 gnu/packages/xdisorg.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index d41c520962..08f4780fc2 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -387,6 +387,30 @@ (define-public xkb-switch
 state.")
     (license license:gpl3+)))
 
+(define-public xkblayout
+  ;; Upstream doesn't have any version numbers
+  (let ((version "0.0.0")
+        (revision "0")
+        (commit "c0851b0f4bc9bc1a07240605baac8e50abe63fa8"))
+    (package
+      (name "xkblayout")
+      (version (git-version version revision commit))
+      (home-page "https://gitlab.freedesktop.org/whot/xkblayout")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url home-page)
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0057988l5l7pmwg7dp6cqvj5l4lr0g5z3wq189g6kz36l9rmh675"))))
+      (build-system python-build-system)
+      (synopsis "XKB layout template generator")
+      (description "xkblayout is a CLI application to generate templates for
+a new XKB layout, either in the user's home directory or the system directory.")
+      (license license:gpl3+))))
+
 (define-public xclip
   (package
     (name "xclip")
-- 
2.35.1

Message #20 received at 55276 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Attila Lendvai <attila <at> lendvai.name>, 55276 <at> debbugs.gnu.org
Subject: Re: [bug#55276] [PATCH v2] gnu: Add xkblayout.
Date: Fri, 06 May 2022 14:19:22 +0200

[Message part 1 (text/plain, inline)]

Attila Lendvai schreef op vr 06-05-2022 om 08:22 [+0200]:
> +  ;; Upstream doesn't have any version numbers
> +  (let ((version "0.0.0")
> +        (revision "0")
> +        (commit "c0851b0f4bc9bc1a07240605baac8e50abe63fa8"))

TBC I don't think this is a blocker, it's more of an ‘it would be
convenient to have them’ thing.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 55276 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Attila Lendvai <attila <at> lendvai.name>, 55276 <at> debbugs.gnu.org
Subject: Re: [bug#55276] [PATCH v2] gnu: Add xkblayout.
Date: Fri, 06 May 2022 14:21:56 +0200

[Message part 1 (text/plain, inline)]

Attila Lendvai schreef op vr 06-05-2022 om 08:22 [+0200]:
> * gnu/packages/xdisorg.scm (xkblayout): New variable.
> ---
> 
> i've addressed the issues i could, but i'm not sure anymore
> whether this should be packaged for Guix at all.

I don't see why not, it's software and Guix is a software distribution
and some people create their own layouts.  Though you can close the
debbugs issue if you want to.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 55276-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Attila Lendvai <attila <at> lendvai.name>
Cc: 55276-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#55276: [PATCH] gnu: Add xkblayout.
Date: Mon, 09 May 2022 12:06:47 +0200

Hi,

Attila Lendvai <attila <at> lendvai.name> skribis:

> * gnu/packages/xdisorg.scm (xkblayout): New variable.

Applied, thanks!  And thanks to Maxime for reviewing.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.