From unknown Mon Jun 23 13:15:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 May 2022 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 55275@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165176453222316 (code B ref -1); Thu, 05 May 2022 15:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 May 2022 15:28:52 +0000 Received: from localhost ([127.0.0.1]:46213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmdPP-0005ns-NC for submit@debbugs.gnu.org; Thu, 05 May 2022 11:28:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:58056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmdPO-0005nl-Ds for submit@debbugs.gnu.org; Thu, 05 May 2022 11:28:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmdPN-0004nu-S6 for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 11:28:49 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:55702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmdPM-0001Qv-Ar for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 11:28:49 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5A84EFAAF6 for ; Thu, 5 May 2022 15:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1651764520; bh=PEyl8eHqZCFJ3FJbnyy//VZWQyHTf+AWmH4u/8XR6lY=; h=From:To:Subject:Date:From; b=c5TuonDOYgXuh6FmNPenAutX8XyLSg67F3aoN8f6pARk+XtYrU5VAhmop7bcOD2xN M4tZEyLfKKxdxIiYq0nX3OP/eqpyG8VInwOpGVvc9Hk+rOM+F1PxTpfSwY2JqJ8MGM iM4CffyTzmaDseGeKvE0DkaCxvCumo1XEXgaiUnI= From: Eric Abrahamsen Date: Thu, 05 May 2022 08:28:39 -0700 Message-ID: <87ilqkngm0.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) In ./lisp/gnus/nnvirtual.el, the `nnvirtual-retrieve-headers' deffoo let-binds `gnus-use-cache' to t when it uses `gnus-retrieve-headers' on its various constituent groups. For users not using the cache, this will result in an error. I can put an additional check in gnus-cache.el when we call `gnus-cache-retrieve-headers', but it would be nice to know why this necessary in the first place. The code comment on `nnvirtual-retrieve-headers' says: ;; FIX FIX FIX we want to check the cache! ;; This is probably evil if people have set ;; gnus-use-cache to nil themselves, but I ;; have no way of finding the true value of it. All the above is true, except I don't understand why we want to check the cache. This code is ancient and I'm only medium-hopeful Lars remembers the reasoning here, but on the face of it I don't know why we need to force a check of the cache. It seems like we could simply remove that, and the cache will still be checked iff the user has set `gnus-use-cache' to t. From unknown Mon Jun 23 13:15:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 May 2022 12:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: 55275@debbugs.gnu.org Received: via spool by 55275-submit@debbugs.gnu.org id=B55275.165183948427707 (code B ref 55275); Fri, 06 May 2022 12:19:02 +0000 Received: (at 55275) by debbugs.gnu.org; 6 May 2022 12:18:04 +0000 Received: from localhost ([127.0.0.1]:47377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmwuJ-0007Co-CV for submit@debbugs.gnu.org; Fri, 06 May 2022 08:18:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmwuA-0007Bv-Tp for 55275@debbugs.gnu.org; Fri, 06 May 2022 08:18:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=I3ex6uM+K7t1I9KfiNLfU1kBvjjmU0rjOQJo06D8SbA=; b=QoxG2m1MZ7yftYFrLMJfGFQh8l 6GJ91lfDYohhstPn8Z/4THhcKzJ4bWBH7hpXFJuqiRUlx7y5pDojuz+xJ3w/0ITJs/NMyG+ff358e oF/80n0Ob3OFaNF/5BGT/TcWyCtzFBx4RmyY54W8wU4rnVS8ypr331gZ2eezbCGIRHts=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmwu2-0006Qb-Ix; Fri, 06 May 2022 14:17:48 +0200 From: Lars Ingebrigtsen References: <87ilqkngm0.fsf@ericabrahamsen.net> X-Now-Playing: The Cure's _The Head On The Door_: "Sinking" Date: Fri, 06 May 2022 14:17:46 +0200 In-Reply-To: <87ilqkngm0.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 05 May 2022 08:28:39 -0700") Message-ID: <87sfpmlus5.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > All the above is true, except I don't understand why we want to check > the cache. This code is ancient and I'm only medium-hopeful Lars > remembers the reasoning here, but on the face of it I don't [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eric Abrahamsen writes: > All the above is true, except I don't understand why we want to check > the cache. This code is ancient and I'm only medium-hopeful Lars > remembers the reasoning here, but on the face of it I don't know why we > need to force a check of the cache. It seems like we could simply remove > that, and the cache will still be checked iff the user has set > `gnus-use-cache' to t. I have no recollection of that code. :-/ But, yes, I think removing that binding would be the right thing to do. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Jun 23 13:15:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eric Abrahamsen Subject: bug#55275: closed (Re: bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache) Message-ID: References: <878rrefum5.fsf@ericabrahamsen.net> <87ilqkngm0.fsf@ericabrahamsen.net> X-Gnu-PR-Message: they-closed 55275 X-Gnu-PR-Package: emacs Reply-To: 55275@debbugs.gnu.org Date: Fri, 06 May 2022 17:19:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1651857542-21979-1" This is a multi-part message in MIME format... ------------=_1651857542-21979-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of = the cache which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 55275@debbugs.gnu.org. --=20 55275: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55275 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1651857542-21979-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 55275-done) by debbugs.gnu.org; 6 May 2022 17:18:16 +0000 Received: from localhost ([127.0.0.1]:49677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nn1ap-0005hO-Mw for submit@debbugs.gnu.org; Fri, 06 May 2022 13:18:16 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:32942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nn1ab-0005gX-IO for 55275-done@debbugs.gnu.org; Fri, 06 May 2022 13:18:14 -0400 Received: from localhost (24-113-184-151.wavecable.com [24.113.184.151]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BB0E6FA08B; Fri, 6 May 2022 17:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1651857476; bh=y8Y6OIkSY3uY/OZYyFeNmvDqWNK2r0Xw/G/lWKLtlFY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dY6guXoOcmxjf83md/GXpYWGMPhEYHYC0yT7fWye/jI/HRA6UM76MwrxteQAedKiT C4C+paKKLk89GCQQ3ERFaf9qdmj6GoTTV0s739VcOzSrVfM9AFF91eGJLyMFbLtiHX 9cIdzwDTgNFvL4dxRLKCSgPZLYPUKf5DRFnHZxec= From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache References: <87ilqkngm0.fsf@ericabrahamsen.net> <87sfpmlus5.fsf@gnus.org> Date: Fri, 06 May 2022 10:17:54 -0700 In-Reply-To: <87sfpmlus5.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 06 May 2022 14:17:46 +0200") Message-ID: <878rrefum5.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55275-done Cc: 55275-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 05/06/22 14:17 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> All the above is true, except I don't understand why we want to check >> the cache. This code is ancient and I'm only medium-hopeful Lars >> remembers the reasoning here, but on the face of it I don't know why we >> need to force a check of the cache. It seems like we could simply remove >> that, and the cache will still be checked iff the user has set >> `gnus-use-cache' to t. > > I have no recollection of that code. :-/ It was a while ago :) > But, yes, I think removing that binding would be the right thing to do. Done. ------------=_1651857542-21979-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 May 2022 15:28:52 +0000 Received: from localhost ([127.0.0.1]:46213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmdPP-0005ns-NC for submit@debbugs.gnu.org; Thu, 05 May 2022 11:28:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:58056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmdPO-0005nl-Ds for submit@debbugs.gnu.org; Thu, 05 May 2022 11:28:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmdPN-0004nu-S6 for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 11:28:49 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:55702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmdPM-0001Qv-Ar for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 11:28:49 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5A84EFAAF6 for ; Thu, 5 May 2022 15:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1651764520; bh=PEyl8eHqZCFJ3FJbnyy//VZWQyHTf+AWmH4u/8XR6lY=; h=From:To:Subject:Date:From; b=c5TuonDOYgXuh6FmNPenAutX8XyLSg67F3aoN8f6pARk+XtYrU5VAhmop7bcOD2xN M4tZEyLfKKxdxIiYq0nX3OP/eqpyG8VInwOpGVvc9Hk+rOM+F1PxTpfSwY2JqJ8MGM iM4CffyTzmaDseGeKvE0DkaCxvCumo1XEXgaiUnI= From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache Date: Thu, 05 May 2022 08:28:39 -0700 Message-ID: <87ilqkngm0.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) In ./lisp/gnus/nnvirtual.el, the `nnvirtual-retrieve-headers' deffoo let-binds `gnus-use-cache' to t when it uses `gnus-retrieve-headers' on its various constituent groups. For users not using the cache, this will result in an error. I can put an additional check in gnus-cache.el when we call `gnus-cache-retrieve-headers', but it would be nice to know why this necessary in the first place. The code comment on `nnvirtual-retrieve-headers' says: ;; FIX FIX FIX we want to check the cache! ;; This is probably evil if people have set ;; gnus-use-cache to nil themselves, but I ;; have no way of finding the true value of it. All the above is true, except I don't understand why we want to check the cache. This code is ancient and I'm only medium-hopeful Lars remembers the reasoning here, but on the face of it I don't know why we need to force a check of the cache. It seems like we could simply remove that, and the cache will still be checked iff the user has set `gnus-use-cache' to t. ------------=_1651857542-21979-1--