From debbugs-submit-bounces@debbugs.gnu.org Thu May 05 07:16:49 2022 Received: (at submit) by debbugs.gnu.org; 5 May 2022 11:16:49 +0000 Received: from localhost ([127.0.0.1]:44528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmZTU-00064m-ME for submit@debbugs.gnu.org; Thu, 05 May 2022 07:16:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:56474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmZTS-000631-No for submit@debbugs.gnu.org; Thu, 05 May 2022 07:16:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmZTQ-0008Mh-I6 for bug-guix@gnu.org; Thu, 05 May 2022 07:16:46 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]:33450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmZTM-0002nL-Ds for bug-guix@gnu.org; Thu, 05 May 2022 07:16:44 -0400 Date: Thu, 05 May 2022 11:16:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail3; t=1651749397; bh=yRjvvIdsIMtw2IxA0C41PwJJvHpdy1L+z0domLrgeks=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=UZ5rajcDutisvuTGManbWROFUULDe1ATHjvEtuAH0UVxv85XWU1fXmHcVbL58xpQy iE17UV799ql4bf2cCWo38IgAEEGg7PQqKcFDZ5bQi8R9Dld1VfnxDr1Su0OIwa6UYt qomNQoYQPWpamBFNGtYQP2FhOp0IyCAOZqOqr5ER1QKYOinSN+TfN5nDIUQenW9bFV HEutwMbfpqNLO5X0i1yW6lpzg9dphiwaA8q2AfaEIVbtn0dtj3UY5bAgloDYIXVDl8 oyw7DXjfwz1G0ixYgjrI66ukLPcQM6QNYqiOAL0mtLxV1rNUw4+qTofOH7z/yFVgPl 2pI2Twv5Xtfeg== To: "bug-guix@gnu.org" From: Attila Lendvai Subject: unpack phase randomly changes the cwd Message-ID: Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.17; envelope-from=attila@lendvai.name; helo=mail-4317.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) at the end of the unpack phase, the working directory is changed to a rando= m directory. https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/gnu-build-system= .scm#n178 this is fine *when* the archive contains a single dir... but this DWIM'ness= has just burned 15 mintues of my life, and i recommend removing it. if it is to stay, then at least it should be patched that it only happens w= hen the dir after extraction only contains a single subdir, and no files ot= herwise. -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CWhen men hire themselves out to shoot other men to order, asking n= othing about the justice of their cause, I don=E2=80=99t care if they are s= hot themselves.=E2=80=9D =09=E2=80=94 Herbert Spencer (1820=E2=80=931903), during Britain's second A= fghan war From debbugs-submit-bounces@debbugs.gnu.org Thu May 05 08:18:31 2022 Received: (at 55270) by debbugs.gnu.org; 5 May 2022 12:18:31 +0000 Received: from localhost ([127.0.0.1]:44636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmaRD-0006T8-7e for submit@debbugs.gnu.org; Thu, 05 May 2022 08:18:31 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:44212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmaRB-0006Sz-1g for 55270@debbugs.gnu.org; Thu, 05 May 2022 08:18:29 -0400 Received: from [IPv6:2a02:2c40:200:b001::1:c51f] ([IPv6:2a02:2c40:200:b001::1:c51f]) by albert.telenet-ops.be with bizsmtp id T0JS270011673cg060JTMc; Thu, 05 May 2022 14:18:27 +0200 Message-ID: <378a823f4ae3a60c2d3ad419b22958524c933b19.camel@telenet.be> Subject: Re: bug#55270: unpack phase randomly changes the cwd From: Maxime Devos To: Attila Lendvai , 55270@debbugs.gnu.org Date: Thu, 05 May 2022 14:18:21 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-8nR/8CzggRC0XvhF0o4q" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1651753107; bh=LRC+FolItBDbxDh6MvLn0McfU1n364CCwPVQ26dL9HA=; h=Subject:From:To:Date:In-Reply-To:References; b=ALo98k/U1d4dxCHyYiKgW4tD/qUsscpVvHwjJU15LvWI24iQk7rEYb2qGLMk59cpp nmWgqJFlLzLm5097Z+r9gn25i1btzgohxWCpk6uaqFgGDTV8kk5f9MG1eeM2+hGGr1 u9mssSQ5+Xsz4p1Wh/qs86A/g7OnJsN+jRN+wW71esa7TtyJYIXUtFGCuCQVJb1rns vhNh6GqiDbLsMsdEubWuzn9WwmTiPTmxNmMeNH3BqC0gssL/sZ5If+dP1PTJiWm6Eb e5sUWwcK+NgdMGugnEKm763hy3Ylgkfi2HcWfHRhZOTsRHcGsG/NlrGFGpDyq8zko6 OZrecJ6mKyXzQ== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55270 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-8nR/8CzggRC0XvhF0o4q Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attila Lendvai schreef op do 05-05-2022 om 11:16 [+0000]: > at the end of the unpack phase, the working directory is changed to a ran= dom directory. >=20 > https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/gnu-build-syst= em.scm#n178 It takes the first result 'scandir' -- i.e., the 'smallest' file name according to string-locale=20 > this is fine *when* the archive contains a single dir... but this DWIM'ne= ss has just burned 15 mintues of my life, and i recommend removing it. >=20 > if it is to stay, then at least it should be patched that it only happens= when the dir after extraction only contains a single subdir, and no files = otherwise. Except maybe when using 'out-of-source?', I think it has to stay in some form -- somehow, we will have to run build scripts, "make", maybe do some 'substitute*', and having to type the version number and directory name inside build phases seems a bit error-prone (what if the source is changed fom tarball or 'zip' to a vcs checkout?). I agree with only chdiring if there's only one subdir (and no other files) though -- =E2=80=98just the first=E2=80=99 is a bit arbitrary. Greetings, Maxime. --=-8nR/8CzggRC0XvhF0o4q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnPAjRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hcPAQCFW/Nxza6Q/6DPskwK3/dzFebz aUV1g5TI31LsC29bPwD/SVm+R3wlX4KhqNDtMtfQ3vKEDM/rLKd+8HkMLCSshgc= =ci5l -----END PGP SIGNATURE----- --=-8nR/8CzggRC0XvhF0o4q-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 05 09:15:47 2022 Received: (at 55270) by debbugs.gnu.org; 5 May 2022 13:15:47 +0000 Received: from localhost ([127.0.0.1]:44804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmbKc-0006x5-Vb for submit@debbugs.gnu.org; Thu, 05 May 2022 09:15:47 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:11088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmbKZ-0006lp-Bb for 55270@debbugs.gnu.org; Thu, 05 May 2022 09:15:45 -0400 Date: Thu, 05 May 2022 13:15:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail3; t=1651756536; bh=jB6f2sTbM7hQ7UEGxBJXAiKsBa50JHGNMYF7k+oXMA4=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=N0B1bx4qR2/SeRINiGq3qt7yU6rWqQs/43BJ2hWQlnD/YzkPvAwpwmYWxfbUobzVH gfOEZf0rA4cm506Di4yHpV/EpJ+Su3eIqRE4hBYpWqP4zL6TBsew/smihekKirFnZ0 Vks1jeEnuRS4e+bMqCs73BWuMKkkZGK01V7Q0+d45XNCxllNfr18q8tGbVRxetILZU 71aUDSR24gsuzhNzq8X2bJfdl4M73CetJNnMxZ66+GQHFCGEN4OqyOApQOfZ+6do8s jmSBZ5csVu1s3E/4EK7vIoKAbpgD3KkJNT8XfrgWp6fZlVpax6+/i9ckQI2K6Hmk5T /oR1Yxt0j4UmQ== To: Maxime Devos From: Attila Lendvai Subject: Re: bug#55270: unpack phase randomly changes the cwd Message-ID: In-Reply-To: <378a823f4ae3a60c2d3ad419b22958524c933b19.camel@telenet.be> References: <378a823f4ae3a60c2d3ad419b22958524c933b19.camel@telenet.be> Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55270 Cc: 55270@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > It takes the first result 'scandir' -- i.e., the 'smallest' file name > according to string-locale reproducibility problems) fair enough. what i meant to communicate is that it's arbitrary, not random= . another potential issue: if the root of the archive contains a file called 'environment-variables', = then this way it would overwrite the one generated by Guix. this may not ne= cessarily be an issue, though, if that file is never used after the unpack = phase. maybe the cleanest would be to: 1) mkdir a directory ('extracted/'?) and chdir into it prior to unpacking, and 2) only do the DWIM chdir if the toplevel of the archive was a single dir. but i lack the necessary perspective to see all the implications. -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CThere is always a philosophy for lack of courage.=E2=80=9D =09=E2=80=94 Albert Camus (1913=E2=80=931960) From debbugs-submit-bounces@debbugs.gnu.org Thu May 05 16:12:22 2022 Received: (at 55270) by debbugs.gnu.org; 5 May 2022 20:12:22 +0000 Received: from localhost ([127.0.0.1]:46550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmhpm-0006uO-44 for submit@debbugs.gnu.org; Thu, 05 May 2022 16:12:22 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:45817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmhpk-0006u9-3Z for 55270@debbugs.gnu.org; Thu, 05 May 2022 16:12:20 -0400 Received: by mail-ed1-f65.google.com with SMTP id be20so6433692edb.12 for <55270@debbugs.gnu.org>; Thu, 05 May 2022 13:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=QK8NOPISF+rjYM7O4T5eeh6dTXaWD96UENRut72oZnw=; b=l5eLatgfBteLMdvXr/5mcmSyT++MUwynAC0xv3Wk0CXsSpiHZyZR/G7s4exSa7A8L+ clrD9TMctib0t9/EmT3mf0uTfvu8PfHPc8TDdPN3HTrB7gEEG8AvEJlwZurkn2xsKJfV VUfRMOK+n034WK4/WMe5MY78iPnXUYQAwgzistm4gCiLvH3EDv9OdXA9NXskLr03nSQq v2iGb8ynAsC0i2m6ntGn4nDkd/4uI1JtEkokvKvjuP/8fV284nVnkYFVbMT7ceExeBS/ Ey+JTo6DtdnK2/YjFebyvrre+xFHJKgFVW+vy5o8GwQtnqYb9qdeUDxaRnpuEWNm5Ay5 3GCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=QK8NOPISF+rjYM7O4T5eeh6dTXaWD96UENRut72oZnw=; b=pu99HSRAYHOkAF7Ht+QT20YeGM7T9lBy+cDM6NVtPLQzuS7yzY+CqXhmrwWEkZkUZG ZoloB7C37HnIpWcRy2ZFWZqioo7RW3b93Sm+A42iHZdROqP7CEjaC3P4tqBb2aEnWRDK rp9FJuW36LzIkpdNSaYJrtn4bYEOW/f/uEbvmgT9cO1f+MJbg0Cc5/Eu2epFWshi64hj Ehe3Amnbnlkk7vY2mGrrMlY0UyQCC1CNA293rMaojJIzfO3zUBJyDyoHmhbjy5xAd9d6 eI7V6vMcVkMq6TVS1Y0wmjqQ+/E/z7XGxjLzmok7lcBAna027K/yoHFgLRVfGJ23PgU5 YSog== X-Gm-Message-State: AOAM530jaXBpgCcBh7kuVKKPeYFchALIOlGyngtrqapYXKR2c+co4FyM XaRt9Eo9F+EuZZJBSGII3pI= X-Google-Smtp-Source: ABdhPJy4+f4mjA4YcmG5dNOG8iJmQW6MX8wOlJdJ09oKVFpT2GyZ8uAViDh/ahQmRXfOsp32DJwA0A== X-Received: by 2002:a05:6402:3695:b0:427:b16e:e1b4 with SMTP id ej21-20020a056402369500b00427b16ee1b4mr28989915edb.117.1651781534330; Thu, 05 May 2022 13:12:14 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id gv3-20020a1709072bc300b006f3ef214e5bsm1077446ejc.193.2022.05.05.13.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 13:12:13 -0700 (PDT) Message-ID: Subject: Re: unpack phase randomly changes the cwd From: Liliana Marie Prikler To: Attila Lendvai , 55270@debbugs.gnu.org Date: Thu, 05 May 2022 22:12:12 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55270 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Donnerstag, dem 05.05.2022 um 11:16 +0000 schrieb Attila Lendvai: > at the end of the unpack phase, the working directory is changed to a > random directory. > > https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/gnu-build-system.scm#n178 > > this is fine *when* the archive contains a single dir... but this > DWIM'ness has just burned 15 mintues of my life, and i recommend > removing it. url-fetch/tarbomb: Now this looks like a job for me. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 10:11:56 2022 Received: (at 55270) by debbugs.gnu.org; 12 Jul 2022 14:11:56 +0000 Received: from localhost ([127.0.0.1]:43334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBGcF-00020w-QH for submit@debbugs.gnu.org; Tue, 12 Jul 2022 10:11:56 -0400 Received: from mail-qk1-f170.google.com ([209.85.222.170]:34440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBGcD-00020Y-HG for 55270@debbugs.gnu.org; Tue, 12 Jul 2022 10:11:54 -0400 Received: by mail-qk1-f170.google.com with SMTP id b25so5808535qkl.1 for <55270@debbugs.gnu.org>; Tue, 12 Jul 2022 07:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0JL0olARzDJwe3Xe4+gi/yPAQz4K2p1vuq6RTbZHBlg=; b=TjiLkxeMuxw493HGv57Ju3qpzQOl7YGvuotnPNENA2la2LxXLUQSV1IK5DJKwNx5/r SiihTJ+b/n46Xozicm/4hOWnH36a9WjPiIs4XuW9CPWE6bePp4UQiixGF9SN/BKtvXnI 3J1EzOI4a1AWnJi34lmzNKnBQ310c74cn2hFIOLvejdjw31amAnMyAUOJsr92pWbLyOQ zvhag1VoJOd55qBUs959IWPMo9LulpNp1CkRctMcy+gUe8EjuCXpfF6URWBK6mqwkKM+ QrT4X4RtahbjcVldWaeEA3l/nF0dF3AlVGau411gwdWQ3DTgB1wR/DshY+CTBrjniYfZ dnZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0JL0olARzDJwe3Xe4+gi/yPAQz4K2p1vuq6RTbZHBlg=; b=C7mc5dX6I2JGBCwpsy5QvllfOJy7Swl25JdqgWRxYTnspMOB8cgh+gBiwHVQyiLicV rooTuGE4xYKBVjm7+k9rceAZtugmRRpW5I9nIkoo3TGhrJxMO4ZYUvHvyQ8xgtZVCuLe 0SSMlf3NCfzwXPtwxr9gGUogTqoAQzAS56YSgpDOsoBceP2nt6Qae90rYG5K9LXc0wu5 deBOLG9weIKijDpW3lYvJRMq0XpQ4CD4Fiqumg8E2H34MyxZiibOn+hD0TRCPixiBtnw ak79VaGebCJqHzcLSJhy6rqUm4i/kYn/1SSud6ariXvR+Lbd8e4kmAb8diqBfuSHARmT MAJw== X-Gm-Message-State: AJIora8rcyAPTHYRh0idx9+7zyreWpJjhrjNzrIOncC3B+Lm78RLgkZA jGDaJRzLz4FTuzZmzpBl/VRHTB22salWjDkC X-Google-Smtp-Source: AGRyM1u2RRy4hp/9X0zAZ1NIHpbkU7+61E9PW7vfnW9wbSRN5Yf8RbgM12svue/fM61kQApZdXIVhw== X-Received: by 2002:a05:620a:f0d:b0:6b5:473d:d4b with SMTP id v13-20020a05620a0f0d00b006b5473d0d4bmr15487614qkl.6.1657635107669; Tue, 12 Jul 2022 07:11:47 -0700 (PDT) Received: from hurd (dsl-155-226.b2b2c.ca. [66.158.155.226]) by smtp.gmail.com with ESMTPSA id u14-20020a05620a430e00b006a6a6f148e6sm9579605qko.17.2022.07.12.07.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 07:11:47 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: bug#55270: unpack phase randomly changes the cwd References: Date: Tue, 12 Jul 2022 10:11:46 -0400 In-Reply-To: (Liliana Marie Prikler's message of "Thu, 05 May 2022 22:12:12 +0200") Message-ID: <87a69e8lp9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55270 Cc: Attila Lendvai , 55270@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Liliana Marie Prikler writes: > Am Donnerstag, dem 05.05.2022 um 11:16 +0000 schrieb Attila Lendvai: >> at the end of the unpack phase, the working directory is changed to a >> random directory. >> >> https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/gnu-build-system.scm#n178 >> >> this is fine *when* the archive contains a single dir... but this >> DWIM'ness has just burned 15 mintues of my life, and i recommend >> removing it. > url-fetch/tarbomb: Now this looks like a job for me. Just to make sure, are you suggesting the archive type used here would have been better handled by url-fetch/tarboom? Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 12:47:51 2022 Received: (at 55270) by debbugs.gnu.org; 12 Jul 2022 16:47:51 +0000 Received: from localhost ([127.0.0.1]:43617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBJ39-000066-3w for submit@debbugs.gnu.org; Tue, 12 Jul 2022 12:47:51 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:34529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBJ37-00005A-En for 55270@debbugs.gnu.org; Tue, 12 Jul 2022 12:47:49 -0400 Received: by mail-ej1-f68.google.com with SMTP id oy13so10488978ejb.1 for <55270@debbugs.gnu.org>; Tue, 12 Jul 2022 09:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=U3vQbUkpc+M+fQZdhMaCuSAYq7ErolQfJz6H4gG5VBI=; b=SaUSeSWkLbSH34DP6F6lCmzCQ4hZfY1e5Rz7jU3Z7GYq+zS6MNHZ+2AU5gooykTPeo nvz7equ7RnhEtCjrKi1TDyXKd93Yrsdz/YI7QXAhVJX6zlh2dxQCwOgx5LkQcmBDSEmU gnzy6f5T8g9Ov453X/NwaaF4N9bVhhJWyVjhRb1t7SSyGDlon9P8qC2DElfYXKgZihnU V4AXyjf7fZ+e4kX5fU3K+g/X04Mag9xZmG7KpLFId/MtAnOiHpw4XJHjqZyulvDkEx6A W+ALNgZstuJPoJ7c1qNhaHYrT4N+j5jDgjGLlAQr7iPfaUufGJ67y+8yUywculNVJ+Po Vuvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=U3vQbUkpc+M+fQZdhMaCuSAYq7ErolQfJz6H4gG5VBI=; b=MPbssRafveaLT0i575B9coKxl95vv5w4VlcduGd6Mp4MrY81xwCmkQQBtF8/fsw/c0 aoyEbf3TfekDRr4dAsXdCXYwNk8jp69+3fQwu8T9gr83mE+6ybazg8uFgdIVhdzEeUcg 2H7K5IusmuOREtDbzB1NnEN4ZA4kBXc2kevftJkEJBvyZxOSch3xZ5hI1cJ43f2sEkJV wd7dDInvKem1oHptyP93/m/zx0mbCJ6x841u5/UqeaTAPNEoWjK6dyy6qaB47X27i1YG EGC2/5rnnF8cju2xaQB6WVp1YtAPg4XNuemwgque5i6696WtmXcbYBN5aH7Rk4vZS0r2 0AcA== X-Gm-Message-State: AJIora+4lBjnqe1RxA6IRyvnAvXZ57GiVxlOGjQHHe3e65rU+oZAbWMF bcE5BbajqKH1+wH0M6L7GkE= X-Google-Smtp-Source: AGRyM1vAd8fbVLakJjHnWQDftkVcRWUBNngGvdeweh8ndGw8zTeOFRj0Dy58Cdxp1hFSsd/dUFPhKg== X-Received: by 2002:a17:907:2887:b0:72b:68ce:2fff with SMTP id em7-20020a170907288700b0072b68ce2fffmr8338751ejc.423.1657644463587; Tue, 12 Jul 2022 09:47:43 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id 14-20020a170906318e00b00715705dd23asm3970546ejy.89.2022.07.12.09.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:47:43 -0700 (PDT) Message-ID: <87d3668336bb407c14cbb5fe908a408b759ebe95.camel@gmail.com> Subject: Re: bug#55270: unpack phase randomly changes the cwd From: Liliana Marie Prikler To: Maxim Cournoyer Date: Tue, 12 Jul 2022 18:47:42 +0200 In-Reply-To: <87a69e8lp9.fsf@gmail.com> References: <87a69e8lp9.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55270 Cc: Attila Lendvai , 55270@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Dienstag, dem 12.07.2022 um 10:11 -0400 schrieb Maxim Cournoyer: > Hi, > > Liliana Marie Prikler writes: > > > Am Donnerstag, dem 05.05.2022 um 11:16 +0000 schrieb Attila > > Lendvai: > > > at the end of the unpack phase, the working directory is changed > > > to a > > > random directory. > > > > > > https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/gnu-build-system.scm#n178 > > > > > > this is fine *when* the archive contains a single dir... but this > > > DWIM'ness has just burned 15 mintues of my life, and i recommend > > > removing it. > > > url-fetch/tarbomb: Now this looks like a job for me. > > Just to make sure, are you suggesting the archive type used here > would have been better handled by url-fetch/tarboom? That's what the docstring of url-fetch/tarbomb leads me to believe, yes. Is it not helpful?