GNU bug report logs - #55234
28.1; replace-string in rectangle regio

Previous Next

Full log

Message #38 received at 55234 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Paulo Sousa <de.sousa.paulus <at> gmail.com>, 55234 <at> debbugs.gnu.org
Subject: Re: bug#55234: 28.1; replace-string in rectangle regio
Date: Mon, 06 Jun 2022 10:43:20 +0300

>>  (defun rectangle--extract-region (orig &optional delete)
>>   ...
>>      (let* ((strs (funcall (if delete
>>                                #'delete-extract-rectangle
>>                              #'extract-rectangle)
>> -                          (region-beginning) (region-end)))
>> +                          ;; Avoid recursive calls
>> +                          (let (rectangle-mark-mode) (region-beginning))
>> +                          (let (rectangle-mark-mode) (region-end))))
>>             (str (mapconcat #'identity strs "\n")))
>>        (when (eq last-command 'kill-region)
>>          ;; Try to prevent kill-region from appending this to some
>
> Is it intended to - at the end - call the original functions here?

Wouldn't it go to infinite recursion when the advice on region-beginning
will call region-bounds that calls rectangle--extract-region again?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.