GNU bug report logs - #55231
[PATCH v1] initrd: Allow extra search paths with ‘initrd-extra-module-paths’

Previous Next

Full log

Message #227 received at 55231 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Ian Eure <ian <at> retrospec.tv>, Morgan Arnold <morgan.arnold <at> proton.me>,
 Brian Cully <bjc <at> spork.org>, Leo Famulari <leo <at> famulari.name>,
 Andreas Enge <andreas <at> enge.fr>, Kaelyn <kaelyn.alexi <at> protonmail.com>,
 Felix Lechner <felix.lechner <at> lease-up.com>,
 Mathieu Othacehe <othacehe <at> gnu.org>,
 John Kehayias <john.kehayias <at> protonmail.com>,
 Christopher Baines <guix <at> cbaines.net>, 55231 <at> debbugs.gnu.org,
 Simon Tournier <zimon.toutoune <at> gmail.com>
Subject: Re: bug#55231: [PATCH v1] initrd: Allow extra search paths with
 ‘initrd-extra-module-paths’
Date: Sun, 16 Feb 2025 18:40:54 +0100

Hello,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> From: Morgan Arnold <morgan.arnold <at> proton.me>
>
> This commit changes the conditions under which derivations, as
> constructed by the `derivation' procedure, are made substitutable, to
> prevent potential copyright violations related to the construction of
> substitutable initrds including non-substitutable derivations (in
> particular, ZFS).
>
> This change prevents such copyright violations by only marking a derivation as
> substitutable if it is itself marked substitutable along all of its inputs.
> This means that non-substitutable derivations propagate to other derivations
> using them as input.

Hmm.

> +  (define (user+system-env-vars inputs)

[...]

> +    (let* ((substitutable-inputs? (every substitutable-derivation?
> +                                         (map derivation-input-derivation
> +                                              inputs)))

This change doesn’t come for free.  I didn’t follow the discussion, but
adding overhead to such a core component to accommodate ZFS sounds
questionable to me.

> +          ;; DRV2 is *not* available as a substitute, since it has drv1 as
> +          ;; input, and the non-substitutability is viral to avoid
> +          ;; distributing non-substitutable items that could have become
> +          ;; embedded, for example in an initrd.

Who would distribute it though?  A build farm building a ZFS-enabled
initrd, right?  Is that a real use case?  (Perhaps this has already been
answered before; please let me know what I should look at, it’s a long
discussion!)

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.