GNU bug report logs - #55186
package-definition-location is wrong for inherited packages

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#55186: closed (package-definition-location is wrong for
 inherited packages)
Date: Mon, 16 May 2022 04:57:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 16 May 2022 00:56:19 -0400
with message-id <87tu9qjcss.fsf <at> gmail.com>
and subject line Re: bug#55186: package-definition-location is wrong for inherited packages
has caused the debbugs.gnu.org bug report #55186,
regarding package-definition-location is wrong for inherited packages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
55186: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55186
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Subject: package-definition-location is wrong for inherited packages
Date: Fri, 29 Apr 2022 11:56:34 -0400

Hi Guix,

Here's another problem with source location I've discovered when
attempting to locate the source of `python2-pytest-warnings', which
reads like:

--8<---------------cut here---------------start------------->8---
(define-public python2-pytest-warnings
  (package (inherit (package-with-python2
                     (strip-python2-variant python-pytest-warnings)))
           (properties `((superseded . ,python2-pytest)))))
--8<---------------cut here---------------end--------------->8---

The define-public line is at line 2569, but:

--8<---------------cut here---------------start------------->8---
(define package (car (find-packages-by-name "python2-pytest-warnings")))
(package-definition-location package) location->source-properties)
--8<---------------cut here---------------end--------------->8---

returns 2570, the line below.

Thanks,

Maxim

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 55186-done <at> debbugs.gnu.org
Subject: Re: bug#55186: package-definition-location is wrong for inherited
 packages
Date: Mon, 16 May 2022 00:56:19 -0400

Hi Ludovic,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> Here's another problem with source location I've discovered when
>> attempting to locate the source of `python2-pytest-warnings', which
>> reads like:
>>
>> (define-public python2-pytest-warnings
>>   (package (inherit (package-with-python2
>>                      (strip-python2-variant python-pytest-warnings)))
>>            (properties `((superseded . ,python2-pytest)))))
>
> It works for me:

Thanks for checking, this works for me too now.  I think I was amidst
modifications to the code, that induced me in error.  I've fixed what I
think was a typo in a comment in the code that made my understanding
difficult in the early commits of https://issues.guix.gnu.org/55424.

Happily closing,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.