GNU bug report logs - #55153
29.0.50; Implement system_process_attributes on Cygwin

Previous Next

Full log

Message #11 received at 55153 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 55153 <at> debbugs.gnu.org
Subject: Re: bug#55153: 29.0.50; Implement system_process_attributes on Cygwin
Date: Wed, 27 Apr 2022 18:52:58 +0300

> Date: Wed, 27 Apr 2022 11:16:46 -0400
> From: Ken Brown <kbrown <at> cornell.edu>
> 
> +# ifdef CYGWIN
> +  /* ttname */
> +  strcpy (procfn_end, "/ctty");
> +  fd = emacs_open (fn, O_RDONLY, 0);
> +  if (fd < 0)
> +    nread = 0;
> +  else
> +    {
> +      record_unwind_protect_int (close_file_unwind, fd);
> +      nread = emacs_read_quit (fd, procbuf, sizeof procbuf);
> +    }
> +  /* /proc/<pid>/ctty should always end in newline. */
> +  if (0 < nread && procbuf[nread - 1] == '\n')
> +    procbuf[nread - 1] = '\0';
> +  else
> +    procbuf[0] = '\0';
> +  attrs = Fcons (Fcons (Qttname, build_string (procbuf)), attrs);

Is what you read from /proc/<pid>/ctty guaranteed to be pure-ASCII
string?  If not, build_string is not the best idea here; you need to
produce a unibyte string and decode it.

Thanks.

P.S. Doesn't this warrant a NEWS entry?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.