From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 10:31:15 2022 Received: (at submit) by debbugs.gnu.org; 27 Apr 2022 14:31:15 +0000 Received: from localhost ([127.0.0.1]:43878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njihH-0002pV-6J for submit@debbugs.gnu.org; Wed, 27 Apr 2022 10:31:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:39536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njhlv-0005dd-Uv for submit@debbugs.gnu.org; Wed, 27 Apr 2022 09:32:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njhlt-0007Ll-9W for guix-patches@gnu.org; Wed, 27 Apr 2022 09:31:59 -0400 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]:34745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njhlq-0006pX-SH for guix-patches@gnu.org; Wed, 27 Apr 2022 09:31:56 -0400 Received: by mail-lf1-x141.google.com with SMTP id x33so3191977lfu.1 for ; Wed, 27 Apr 2022 06:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZCu5gr+T6YwnRNPzf09azLJPAkQ10pSn3jh8my6Rml0=; b=EBBHzebX/kCT9mjwgHvB30GiDPilgNf+zWhghS6EFjcw/qIxoWhlsE1VzRCWRcnheC IlZySkc2g5H2eVkbbgIX60T/NpY7WnoRowtC/VGcf/bL7GBKlFz3XhEpRVuagUJiM9I6 95lG4+YyUS7TyXDA5pB9NYM47XnWF2pgR6L7UOprX88K1QvukY4V0qbPTCyShejkpRyu QkjyxiGhpVEFGCgOrQ0AbKAZta+a+rAwpXk66by7TFJtWh0OJGXgRzYbXmvd+89PuDpB Zjo9yvu92e0cIrpYl+7+yDc4bACP3A4NKjvJ5KDajlhouweybIZyLsRq0CX2mE81T1jq oLvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZCu5gr+T6YwnRNPzf09azLJPAkQ10pSn3jh8my6Rml0=; b=Y3AI6calfVh2TVdQuHmAxgOyTeWE5thIy2oDE/s5/hWwD7+vDz6WyTgNHNahktLiXN wd3IEqi/m3IJD0olFb7UG+G3GFF0+eGje9RidBl97gbL15QJSNQkODEgSu83bA6ovsJp GxZwzhM2CBn8ekTJvKsy8Y8EpodKfYASjbOXNceOFkhyr0/7tLIvrrIVgke0WbzYj2yl vzOa2PanTe5ONNqVAolXAWaTauHjUdWDI6Y8sR3fZPv9ohAYXBKzoj23WU/WQgfw1xB2 aiZxS2IgmS4OBK6CQytAU1hsmKkfj8zDaBfnjnxARESzjaO8AbsEz49zoVsyQ2pevm2/ gSVA== X-Gm-Message-State: AOAM532LLfiPIBVhLpvzoAAJ+UL9cmebX1JUJUpdvBrX24HgiEMHEHT1 An0ZQFMpnICOlRjqoL5AiuMeypgwvqw= X-Google-Smtp-Source: ABdhPJxZTgRPkKP+C4nLg14yZby7Xfs/NWbDNTHI8TJBQJyOyD+hQxK88ESHG7UOhAjxzcEcFSZJWA== X-Received: by 2002:a05:6512:324f:b0:472:31e:7b38 with SMTP id c15-20020a056512324f00b00472031e7b38mr11959516lfr.625.1651066312412; Wed, 27 Apr 2022 06:31:52 -0700 (PDT) Received: from imp0.aladdin.ru ([91.199.251.7]) by smtp.gmail.com with ESMTPSA id w13-20020a19490d000000b0044af3f047a6sm2060725lfa.76.2022.04.27.06.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 06:31:51 -0700 (PDT) From: Adam Kandur To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-soothe-theme. Date: Wed, 27 Apr 2022 16:31:37 +0300 Message-Id: <20220427133137.2603-1-kefironpremise@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::141; envelope-from=kefironpremise@gmail.com; helo=mail-lf1-x141.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 27 Apr 2022 10:31:14 -0400 Cc: Adam Kandur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/emacs-xyz.scm (emacs-soothe-theme): New variable. --- gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index db1663c..34658e4 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -1482,6 +1482,30 @@ (define-public emacs-solidity a constant work in progress as the language itself also progresses.") (license license:gpl3+)))) +(define-public emacs-soothe-theme + (let ((commit "0786fe70c6c1b4ddcfb932fdc6862b9611cfc09b") + (revision "0")) + (package + (name "emacs-soothe-theme") + (version (git-version "0.1" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/emacsfodder/emacs-soothe-theme.git") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "10gh1hvxq9gm29r6qzlnva7vjidd7n4kih4z2ihyvbvy9za20xqw")))) + (build-system emacs-build-system) + (home-page "https://github.com/emacsfodder/emacs-soothe-theme.git") + (synopsis "A colorful, but muted theme for Emacs 24, dark background with light text") + (description + "An amalgam of muted color tones and highlighted backgrounds. Builtin support +for rainbow-delimiters, org-mode, whitespace-mode, ECB, flyspell, ido, linum, highlight +indentation, show-paren-mode, further mode support to come.") + (license license:gpl3+)))) + (define-public emacs-unpackaged-el (let ((commit "746801a677ada6cd6fa076e423aa0953779f3fad") (revision "3")) -- 2.35.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 06:27:40 2022 Received: (at 55152) by debbugs.gnu.org; 27 Jun 2022 10:27:40 +0000 Received: from localhost ([127.0.0.1]:49940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5ly0-000121-18 for submit@debbugs.gnu.org; Mon, 27 Jun 2022 06:27:40 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:54551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5lxy-00011l-9J for 55152@debbugs.gnu.org; Mon, 27 Jun 2022 06:27:39 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id C8A35200004; Mon, 27 Jun 2022 10:27:30 +0000 (UTC) From: Nicolas Goaziou To: Adam Kandur Subject: Re: [bug#55152] [PATCH] gnu: Add emacs-soothe-theme. References: <20220427133137.2603-1-kefironpremise@gmail.com> Date: Mon, 27 Jun 2022 12:27:29 +0200 In-Reply-To: <20220427133137.2603-1-kefironpremise@gmail.com> (Adam Kandur's message of "Wed, 27 Apr 2022 16:31:37 +0300") Message-ID: <87y1xijt9q.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 55152 Cc: 55152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hello, Adam Kandur writes: > * gnu/packages/emacs-xyz.scm (emacs-soothe-theme): New variable. Thank you. Sorry for the delay. Some comments follow. > +(define-public emacs-soothe-theme > + (let ((commit "0786fe70c6c1b4ddcfb932fdc6862b9611cfc09b") > + (revision "0")) > + (package > + (name "emacs-soothe-theme") > + (version (git-version "0.1" revision commit)) Where does this "0.1" come from? According to "soothe-theme.el" and Changelog, version is 20141027.2233. Also, I suggest to stick to commit hash 0568a61eeec0b074d8911886359a6c5da13d14cb, which is the penultimate commit, but matches version bump. You don't need to use `git-version' then. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/emacsfodder/emacs-soothe-theme.git") You can drop the ".git" suffix from the URL. > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "10gh1hvxq9gm29r6qzlnva7vjidd7n4kih4z2ihyvbvy9za20xqw")))) > + (build-system emacs-build-system) > + (home-page "https://github.com/emacsfodder/emacs-soothe-theme.git") > + (synopsis "A colorful, but muted theme for Emacs 24, dark backgrou= nd with light text") Synopsis must not start with an article. I would also remove reference to Emacs 24, which is unimportant in Guix. > + (description > + "An amalgam of muted color tones and highlighted backgrounds. Bu= iltin support=20 > +for rainbow-delimiters, org-mode, whitespace-mode, ECB, flyspell, ido, l= inum, highlight > +indentation, show-paren-mode, further mode support to come.") Description must contain complete sentence only. So it should be "Soothe theme is an amalgam=E2=80=A6". Also (nitpick) major mode are usually capitalized and un-hyphenized at least in the Emacs manual. So: Rainbom delimiters, Org mode, Whitespace mode, Flyspell, Ido, Linum=E2=80=A6 Since the project hasn't seen any commit in the last 7 years, maybe "further mode support to come" should be removed. > + (license license:gpl3+)))) License seems to be gpl3, not gpl3+. Could you send an updated patch? Regards, --=20 Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 20 09:02:12 2022 Received: (at 55152-done) by debbugs.gnu.org; 20 Jul 2022 13:02:12 +0000 Received: from localhost ([127.0.0.1]:56311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oE9LA-0000Gg-Eu for submit@debbugs.gnu.org; Wed, 20 Jul 2022 09:02:12 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:55561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oE9L5-0000GB-J9 for 55152-done@debbugs.gnu.org; Wed, 20 Jul 2022 09:02:10 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 716066000A; Wed, 20 Jul 2022 13:01:59 +0000 (UTC) From: Nicolas Goaziou To: Adam Kandur Subject: Re: [bug#55152] [PATCH] gnu: Add emacs-soothe-theme. References: <20220427133137.2603-1-kefironpremise@gmail.com> <87y1xijt9q.fsf@nicolasgoaziou.fr> Date: Wed, 20 Jul 2022 15:01:51 +0200 In-Reply-To: <87y1xijt9q.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Mon, 27 Jun 2022 12:27:29 +0200") Message-ID: <87bktkq6o0.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55152-done Cc: 55152-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, You sent me the updated patch in private. I applied it. Thank you. Closing, -- Nicolas Goaziou From unknown Fri Aug 15 04:02:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 18 Aug 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator