GNU bug report logs - #55149
29.0.50; Commit f30625943e broke magit/with-editor

Previous Next

Package: emacs;

Reported by: Tassilo Horn <thorn <at> fastmail.fm>

Date: Wed, 27 Apr 2022 12:59:01 UTC

Severity: normal

Tags: patch

Merged with 55160, 55161

Found in version 29.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Tassilo Horn <thorn <at> fastmail.fm>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 55149-done <at> debbugs.gnu.org, No Wayman <iarchivedmywholelife <at> gmail.com>, Juri Linkov <juri <at> linkov.net>
Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor
Date: Thu, 28 Apr 2022 16:14:56 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> I have the same problem, and distilled it to the shortest test case:
>>
>> ```
>> (defun testa ()
>>   1)
>>
>> (advice-add 'testa :after
>>             (lambda (&rest _) 2))
>>
>> (defun testb ()
>>   (interactive)
>>   (message "! %S" (testa)))
>> ```
>
> Thanks, should be fixed now,

It is, thanks.  Shouldn't you also adapt the add-function docstring?
Oh, that's adapted automatically!  Interesting approach.  And even more
interesting that the info docs were correct since 2014. :-)

Bye,
Tassilo
This bug report was last modified 3 years and 24 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.