GNU bug report logs - #55149
29.0.50; Commit f30625943e broke magit/with-editor

Previous Next

Package: emacs;

Reported by: Tassilo Horn <thorn <at> fastmail.fm>

Date: Wed, 27 Apr 2022 12:59:01 UTC

Severity: normal

Tags: patch

Merged with 55160, 55161

Found in version 29.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #82 received at 55149-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 55161-done <at> debbugs.gnu.org, dick <dick.r.chiang <at> gmail.com>,
 55149-done <at> debbugs.gnu.org
Subject: Re: bug#55161: 29.0.50; [PATCH] oclosure transcription error redux
Date: Thu, 28 Apr 2022 09:42:08 -0400

Lars Ingebrigtsen [2022-04-28 12:23:04] wrote:
> dick <dick.r.chiang <at> gmail.com> writes:
>
>> -   (:after (apply cdr r) (apply car r))
>> +   (:after (prog1 (apply cdr r) (apply car r)))
>
> I guess this is the same as bug#55149, so I've merged the reports.
>
> Apparently, returning the value of the :after function is what's
> documented to happen (and is what the trunk does now), but it didn't
> use to do that, so it's breaking advice that relies on the old
> behaviour, if I understand 55149 correctly.
> Stefan?

Yes, I implemented the new code from the doc (since the old code was
written in the form of an "undecipherable" bytecode string), but the doc
was wrong.  It's now fixed.


        Stefan
This bug report was last modified 3 years and 24 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.