GNU bug report logs - #55149
29.0.50; Commit f30625943e broke magit/with-editor

Previous Next

Package: emacs;

Reported by: Tassilo Horn <thorn <at> fastmail.fm>

Date: Wed, 27 Apr 2022 12:59:01 UTC

Severity: normal

Tags: patch

Merged with 55160, 55161

Found in version 29.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: "M. Ian Graham" <hello <at> miangraham.com>
To: Tassilo Horn <thorn <at> fastmail.fm>
Cc: "55149 <at> debbugs.gnu.org" <55149 <at> debbugs.gnu.org>, "monnier <at> iro.umontreal.ca" <monnier <at> iro.umontreal.ca>
Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor
Date: Thu, 28 Apr 2022 06:56:19 +0000

> Oh, well, the recipe can even be simplyfied to defining just a
> do-nothing advice!

Ah ha. Return value shenanigans. Here's a no-server test case.

--- begin elisp ---
(advice-add 'original :after
            #'original--advice)

(defun original () "correct: original return value passes through")
(defun original--advice () "broken: advice function's return value is used")

(message (original))
--- end elisp ---

Output before f30625943e:
$ emacs -Q --script bug-recipe.el
correct: original return value passes through

Output after f30625943e:
$ emacs -Q --script bug-recipe.el
broken: advice function's return value is used

-Ian
This bug report was last modified 3 years and 24 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.