From unknown Fri Jun 20 07:09:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#55149 <55149@debbugs.gnu.org> To: bug#55149 <55149@debbugs.gnu.org> Subject: Status: 29.0.50; Commit f30625943e broke magit/with-editor Reply-To: bug#55149 <55149@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:09:32 +0000 retitle 55149 29.0.50; Commit f30625943e broke magit/with-editor reassign 55149 emacs submitter 55149 Tassilo Horn severity 55149 normal tag 55149 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 08:59:01 2022 Received: (at submit) by debbugs.gnu.org; 27 Apr 2022 12:59:01 +0000 Received: from localhost ([127.0.0.1]:41528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njhG0-0000OF-Bw for submit@debbugs.gnu.org; Wed, 27 Apr 2022 08:59:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:52312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njhFy-0000O7-Nv for submit@debbugs.gnu.org; Wed, 27 Apr 2022 08:58:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njhFy-0000Zz-Fn for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 08:58:58 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:49435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njhFu-0000ew-JJ for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 08:58:58 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 54D893200982; Wed, 27 Apr 2022 08:58:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 27 Apr 2022 08:58:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1651064329; x=1651150729; bh=hh58ceR2dfq1Tqw1ubxMlRO3xJet9yRarQW /8NQYeh0=; b=ay4vwMHTHNS1ft5IIOyQukeB6wvN4ZwFwiCwUNkb5m2EylbG+7+ h/AIT+juPaP4kPb2uvE2A3hrL+N6qDSwqEaM9NjNMypHRaypkbWxZmyZuJHW40Qa zFuTJjGGABBi9h6O7DT80u5FVhXhBCIV+h1Xfol/C3PLWxJrre0uFBoQ787yXUvr RVoKCvrm0y637C2LOXpTe2Xti5jLpKS3qGsoqc+aBcvvFVzMm9rxZ+7CgIzU3jy3 IKTh4x9ShCae//zPtLezrL11ZGxIHmFoZPsHXlG3xz4+h7GvL5psVS6cJiRSz1NZ RknSzF5Sei3Xk4ACN5FzkHsn/rnF1ybu9eA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1651064329; x=1651150729; bh=hh58ceR2dfq1T qw1ubxMlRO3xJet9yRarQW/8NQYeh0=; b=x73tWk8zIuie/KAoKX5MyTYfGdT2a qokgRyD/W/J8BySP2XjX/wYjTwWnTih/0Pi52InrQk8RI+11Y8xshVUWSzTVapJ3 SuIJ0mDMpWxruso9dDbbdnlvruUVbiG3OVBpYx7jQ6315c5QxNz+lf8PYS1IkujO jqe+ayn5Rj83IDJkZJ3f318aJWokPiMDGnwdkErtRVoWiQQ/NZdg03docBDdiQvH BangK/fubrqsZTFCLadUjvxSe07iXMztuC65h9IqUn6M+pIgpLTLTGObHtg4eYS7 zLJnXP645CRgOJQrlNR/1rNtelsLUBf6Xd0G435Xwrtar/i7ISWhXGkWg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehgdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegfhffvufffkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhsihhlohcu jfhorhhnuceothhhohhrnhesfhgrshhtmhgrihhlrdhfmheqnecuggftrfgrthhtvghrnh epudefheehjeejteduffekvedvgfevffeltefhfeejfeetudekjeekheefjedugedunecu ffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Apr 2022 08:58:49 -0400 (EDT) User-agent: mu4e 1.7.13; emacs 29.0.50 From: Tassilo Horn To: bug-gnu-emacs@gnu.org, Stefan Monnier Subject: 29.0.50; Commit f30625943e broke magit/with-editor Date: Wed, 27 Apr 2022 14:48:58 +0200 Message-ID: <87wnfa3cop.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.20; envelope-from=thorn@fastmail.fm; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HEXHASH_WORD=1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Hi Stefan, your commit f30625943e on master somehow broke the magit and/or with-editor packages by somehow breaking emacsclient, see: https://github.com/magit/with-editor/issues/111 https://github.com/magit/magit/issues/4669 With stock-emacs when doing "emacsclient foo.txt", it just prints "Waiting for Emacs..." but finishes immediately. The existing emacs doesn't have a foo.txt buffer thereafter. "emacsclient -c foo.txt" results in a new frame which has a foo.txt buffer but it is not displayed in a window... In GNU Emacs 29.0.50 (build 23, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.17.6) of 2022-04-27 built on thinkpad-t440p Repository revision: bc9be5449e1127bc1b05a6cad8471c6eba52c8e9 Repository branch: HEAD System Description: Arch Linux Configured using: 'configure --with-pgtk --with-native-compilation --with-xinput2' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP XIM GTK3 ZLIB Important settings: value of $LC_MONETARY: de_DE.utf8 value of $LC_NUMERIC: de_DE.utf8 value of $LC_TIME: de_DE.utf8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: mu4e:main Minor modes in effect: editorconfig-mode: t global-aggressive-indent-mode: t pdf-occur-global-minor-mode: t diredfl-global-mode: t mu4e-search-minor-mode: t mu4e-update-minor-mode: t mu4e-context-minor-mode: t which-key-mode: t highlight-parentheses-mode: t global-corfu-mode: t corfu-mode: t yas-global-mode: t yas-minor-mode: t global-git-commit-mode: t magit-auto-revert-mode: t vertico-mode: t marginalia-mode: t minibuffer-depth-indicate-mode: t electric-pair-mode: t recentf-mode: t pixel-scroll-precision-mode: t pixel-scroll-mode: t override-global-mode: t save-place-mode: t savehist-mode: t shell-dirtrack-mode: t puni-global-mode: t puni-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t overwrite-mode: overwrite-mode-binary Load-path shadows: ~/Repos/el/mu/build/mu4e/mu4e hides ~/Repos/el/mu/mu4e/mu4e ~/Repos/el/mu/build/mu4e/mu4e-main hides ~/Repos/el/mu/mu4e/mu4e-main ~/Repos/el/mu/build/mu4e/mu4e-view hides ~/Repos/el/mu/mu4e/mu4e-view ~/Repos/el/mu/build/mu4e/mu4e-org hides ~/Repos/el/mu/mu4e/mu4e-org ~/Repos/el/mu/build/mu4e/mu4e-lists hides ~/Repos/el/mu/mu4e/mu4e-lists ~/Repos/el/mu/build/mu4e/mu4e-actions hides ~/Repos/el/mu/mu4e/mu4e-actions ~/Repos/el/mu/build/mu4e/mu4e-helpers hides ~/Repos/el/mu/mu4e/mu4e-helpers ~/Repos/el/mu/build/mu4e/mu4e-search hides ~/Repos/el/mu/mu4e/mu4e-search ~/Repos/el/mu/build/mu4e/mu4e-server hides ~/Repos/el/mu/mu4e/mu4e-server ~/Repos/el/mu/build/mu4e/mu4e-update hides ~/Repos/el/mu/mu4e/mu4e-update ~/Repos/el/mu/build/mu4e/mu4e-context hides ~/Repos/el/mu/mu4e/mu4e-context ~/Repos/el/mu/build/mu4e/mu4e-draft hides ~/Repos/el/mu/mu4e/mu4e-draft ~/Repos/el/mu/build/mu4e/mu4e-bookmarks hides ~/Repos/el/mu/mu4e/mu4e-bookmarks ~/Repos/el/mu/build/mu4e/mu4e-message hides ~/Repos/el/mu/mu4e/mu4e-message ~/Repos/el/mu/build/mu4e/mu4e-compose hides ~/Repos/el/mu/mu4e/mu4e-compose ~/Repos/el/mu/build/mu4e/mu4e-headers hides ~/Repos/el/mu/mu4e/mu4e-headers ~/Repos/el/mu/build/mu4e/mu4e-mark hides ~/Repos/el/mu/mu4e/mu4e-mark ~/Repos/el/mu/build/mu4e/mu4e-contacts hides ~/Repos/el/mu/mu4e/mu4e-contacts ~/Repos/el/mu/build/mu4e/mu4e-icalendar hides ~/Repos/el/mu/mu4e/mu4e-icalendar ~/Repos/el/mu/build/mu4e/mu4e-folders hides ~/Repos/el/mu/mu4e/mu4e-folders ~/Repos/el/mu/build/mu4e/mu4e-speedbar hides ~/Repos/el/mu/mu4e/mu4e-speedbar ~/Repos/el/mu/build/mu4e/mu4e-contrib hides ~/Repos/el/mu/mu4e/mu4e-contrib ~/Repos/el/mu/build/mu4e/mu4e-vars hides ~/Repos/el/mu/mu4e/mu4e-vars /home/horn/.emacs.d/elpa/transient-20220425.1314/transient hides /home/horn/Repos/el/emacs/lisp/transient Features: (shadow editorconfig-core editorconfig-core-handle editorconfig-fnmatch emacsbug so-long view puni pulse display-fill-column-indicator auto-package-update finder-inf generic yaml-mode fish-mode cargo cargo-process rust-utils rust-mode rust-rustfmt rust-playpen rust-compile rust-cargo web-mode disp-table preview-latex auto-loads tex-site editorconfig elfeed-show elfeed-search vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs debbugs-browse elfeed-csv elfeed elfeed-curl elfeed-log elfeed-db elfeed-lib avl-tree generator url-queue xml-query socks elpher hl-todo aggressive-indent rainbow-mode pdf-occur tablist tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet pdf-isearch pdf-misc pdf-tools pdf-view magit-bookmark bookmark jka-compr pdf-cache pdf-info tq pdf-util pdf-macs image-mode exif vc-git vc-dir ewoc epa-file rdictcc diredfl dired-x mu4e-icalendar gnus-icalendar org-capture org-refile icalendar diary-lib diary-loaddefs mu4e mu4e-org mu4e-view org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol org-keys oc org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs mu4e-main mu4e-headers mu4e-lists mu4e-compose mu4e-draft mu4e-actions smtpmail mu4e-search mu4e-bookmarks mu4e-mark mu4e-message flow-fill mule-util hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-server mu4e-context mu4e-vars mu4e-helpers ido mu4e-meta ecomplete auto-dictionary flyspell ispell tramp-smb which-key highlight-parentheses restclient kind-icon svg-lib corfu yasnippet forge-list forge-commands forge-semi forge-bitbucket buck forge-gogs gogs forge-gitea gtea forge-gitlab glab forge-github ghub-graphql treepy gsexp ghub let-alist forge-notify forge-revnote forge-pullreq forge-issue forge-topic yaml forge-post markdown-mode color thingatpt noutline outline forge-repo forge forge-core forge-db closql emacsql-sqlite emacsql emacsql-compiler magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode git-commit log-edit pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor server magit-mode magit-git magit-base magit-section crm dash compat-27 compat-26 visual-filename-abbrev rg vc vc-dispatcher rg-info-hack advice rg-menu transient comp comp-cstr compat rg-ibuffer rg-result wgrep-rg wgrep rg-history rg-header ibuf-ext ibuffer ibuffer-loaddefs grep compile debbugs soap-client url-http url-auth url-gw nsm warnings rng-xsd rng-dt rng-util xsd-regexp bug-reference vertico edmacro kmacro marginalia icomplete mb-depth use-package-diminish ace-window avy elec-pair rx recentf tree-widget pixel-scroll cua-base use-package-bind-key bind-key saveplace savehist smiley gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file url-dired svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range message sendmail yank-media rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util text-property-search mm-util mail-prsvr mail-utils range doom-themes-ext-org doom-themes-ext-visual-bell face-remap doom-Iosvkem-theme doom-themes doom-themes-base diminish cl-extra help-mode use-package-ensure use-package-core tramp tramp-loaddefs trampver tramp-integration cus-edit pp cus-load wid-edit files-x tramp-compat shell pcomplete comint ansi-color ring parse-time iso8601 time-date ls-lisp format-spec easy-mmode info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice simple cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 835148 61455) (symbols 48 49796 11) (strings 32 245719 8853) (string-bytes 1 7800532) (vectors 16 110598) (vector-slots 8 1761956 85817) (floats 8 999 399) (intervals 56 3115 390) (buffers 992 16)) From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 15:44:29 2022 Received: (at 55149) by debbugs.gnu.org; 27 Apr 2022 19:44:29 +0000 Received: from localhost ([127.0.0.1]:44459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njnaP-0000X7-C5 for submit@debbugs.gnu.org; Wed, 27 Apr 2022 15:44:29 -0400 Received: from mail-qk1-f170.google.com ([209.85.222.170]:38664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njnaO-0000Wv-LO for 55149@debbugs.gnu.org; Wed, 27 Apr 2022 15:44:28 -0400 Received: by mail-qk1-f170.google.com with SMTP id n185so2107747qke.5 for <55149@debbugs.gnu.org>; Wed, 27 Apr 2022 12:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:from:to:subject:in-reply-to:date:message-id:mime-version; bh=KrBWdYba3z15KkkxuTSQPmFzQ6BBRDw6n+FcYLXEccI=; b=QS2lS0kV2N80yutKjJINSzUOvXRvhyHhWUB9uQP4AQK50vF1VunGzUj+P3gg87Dc0D krzmqdxKG+EWlr0PZ10fjp3uckhU+ww/V/14dbJSixbavUfKskUWIf9nNYoA6HRtdRSp f1MyjJep4zSRMAEaUCj4XRrIRg+F5+wzy0a65qeieRat3qR+/85w926PGqibI7cu6kEe Uu2983Kt5ZOrx6VhxaWaz56ZsGGRVLJef1x6XYSPMXLfOZGvjxd75oKL6IRMC1X3HGic oSf8qzcSNmIKnJtVwyr1Kzof7EFan4jD0mU7rPOT5rDjQhutAmnxcvrL+NraoZcwWzMa MRyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:user-agent:from:to:subject:in-reply-to:date :message-id:mime-version; bh=KrBWdYba3z15KkkxuTSQPmFzQ6BBRDw6n+FcYLXEccI=; b=CL88VVkxvQd1z5hze8FZ8aY8B2u0U8EpTh3BXsu1WtnPCdHVsRPPK1wzAL1IBtZQC2 lAIt+Pz6/0EaBotnbXpCM1pzEb3Yz5j469cwmtU+4iTGzXXjV3BCUhmmWGOAxOZuYhGW I2beOpdOz4kzdQKvHitXzB/FBnH+xqV1c13m4dsk+gGgpCdzJl9MdMkM3qrxeLHo6KBM IeuY/0dP70Xv1OrZDYfBkdMZWhxA/bj9RryM7Jzk6L0Ix2TSVQ8+9DYEpHv8UrO6YLDz S6qZ1mtbKFPiO2HTlsYaPQYB2yl8wzwX7FXYSL3PX6ScO+3dXK8z8fk2JwlMOILG+HhB g3Xw== X-Gm-Message-State: AOAM530CT8EUh/yvQDHXL5yXozNjSEVcn/uKiIiAU9zWthw2rot+F1OT 20qMVRepn59Q5km/8lu4wTLy1I/EBu4= X-Google-Smtp-Source: ABdhPJwc4dmvb1c+ua+mzCM7ZJJFXDXIrCodG2h9aPGEvcLBlRuvxtY1xpdAwWB0I0XjFCyj3Y5aTA== X-Received: by 2002:a05:620a:492:b0:69f:5a43:b9dc with SMTP id 18-20020a05620a049200b0069f5a43b9dcmr9929053qkr.737.1651088661872; Wed, 27 Apr 2022 12:44:21 -0700 (PDT) Received: from arch ([2601:82:c200:166d:afae:ebe6:a0e2:409e]) by smtp.gmail.com with ESMTPSA id j64-20020a375543000000b0069f16d1fb73sm8570812qkb.119.2022.04.27.12.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 12:44:20 -0700 (PDT) User-agent: mu4e 1.7.13; emacs 29.0.50 From: No Wayman To: thorn@fastmail.fm, 55149@debbugs.gnu.org Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor In-Reply-To: 87wnfa3cop.fsf@fastmail.fm Date: Wed, 27 Apr 2022 15:41:29 -0400 Message-ID: <87czh2qpkc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55149 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Just chiming in to confirm that the same commit has broken something with emacsclient frames as well. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 17:48:38 2022 Received: (at 55149) by debbugs.gnu.org; 27 Apr 2022 21:48:38 +0000 Received: from localhost ([127.0.0.1]:44661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njpWY-0006DW-3G for submit@debbugs.gnu.org; Wed, 27 Apr 2022 17:48:38 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njpWW-0006DI-0L for 55149@debbugs.gnu.org; Wed, 27 Apr 2022 17:48:36 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4D0A9808D4; Wed, 27 Apr 2022 17:48:30 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E597C8051E; Wed, 27 Apr 2022 17:48:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651096108; bh=oUFX+dXKBUk5o8BI3y4b1ZvWDmFiKbzE3+om+GRb8E4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ob9oMkxMV7tMXPQzJiCCsBnTIeGr4Fz9d3xNotVS+r1hq8FCPQfGNnVhqMUyJ1WjD GWHceQ7OaJbzChc1YigeOE9ZVsBsBjoNCx/WAmW8PPVfnsDtIDyw2fksr0bR9SCTH6 Gr0LBN3ms4Zj1uCSt/xXppsngxUsIuwI/FVlYmlsTg9bztlecT/8/MpSgBM/hZkVlS 257hIvlg6lbG48t3bstUXEpHYAMf1qeb/tNzOyQMxJMbM03EGT60X79OXJzVZLJBQi TjSbvhF7MqUp0iG/p+XwFdkOkBR1fv/HWmSDyZNQreC0SeMVAscBiuScYXHw816kW+ P4F2UBQnRQd1w== Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D9E811204AD; Wed, 27 Apr 2022 17:48:28 -0400 (EDT) From: Stefan Monnier To: No Wayman Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Message-ID: References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> Date: Wed, 27 Apr 2022 17:48:27 -0400 In-Reply-To: <87czh2qpkc.fsf@gmail.com> (No Wayman's message of "Wed, 27 Apr 2022 15:41:29 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.208 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55149 Cc: thorn@fastmail.fm, 55149@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) No Wayman [2022-04-27 15:41:29] wrote: > Just chiming in to confirm that the same commit has broken something with > emacsclient frames as well. Could you give some details about that? The `git-commit` bug involves a lot of code, so it would be very helpful to have a recipe that involves less code. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 23:40:10 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 03:40:10 +0000 Received: from localhost ([127.0.0.1]:44871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njv0j-0000oN-SY for submit@debbugs.gnu.org; Wed, 27 Apr 2022 23:40:10 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njv0h-0000nl-CZ for 55149@debbugs.gnu.org; Wed, 27 Apr 2022 23:40:08 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 487D35C01BB; Wed, 27 Apr 2022 23:40:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 27 Apr 2022 23:40:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1651117201; x= 1651203601; bh=tw4rqz8R9YkhteTIo9zqvXfI4MOAnppndxeBeoDQifs=; b=j Q2QuoP3UzSn/TV791zT3DEGDeIQblcF5bcCg5wEWG2xTm/VgdNI/ZpPmCLWh2YQD PWXcQzuLg6WRFo8PS9kvYGpDepS8XEsdG+VoTwWfp+x876OevZY9Kf6VrNsokOBJ elSrQQUyGOkeWVvGgEUcVR51eyUUuq67WHjNM5AvcUFKnBnfxY7sViUZLmdUf7f6 bOXR+IJWyfsh+rrA5o2/khXMADoOZx+ir8nmuBXeNZQ9yg+K89tZSGvovZqEY/yO FujnsWbQvEpBlsbL2hRAW/sBUOWzXQBBbuZEPARsbGhg/y/Kse4XXtOh8VxhE85Q 2SG9vvgHqy2nvFpwlH7VA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1651117201; x=1651203601; bh=tw4rqz8R9Ykht eTIo9zqvXfI4MOAnppndxeBeoDQifs=; b=JMrWPqOwBWdelJEzo13KNwJN0pRww YeMnpFA6rutjXYJVLDi8gk3jf8rfUbo0Lmm2VFInDVqPjsZNc33IKTu5lYoF9j1o CGurbmNwfZ8W1Q2CZM736z04e/FSusz86z81tFp9nRXBip1NpxZ2T+YkxqQh4mEI ti/0DcZXLzsWDB4FazroRW895c3r8d8gigYYCKZzKCRB4Qs0jwpunncrwvSPrbFy G5GXJmCZILSHArJBy3/o5wTGgYqQlgv7JBzrwTO+2HUHE/ZXXaxOQEtl6FrdpUrv JClYlx542aivQ6GYYU6JQDJ5BXlylMxVaz6yEW5+uPFpEtyouhsSreUBQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefkjghfufggtgfgsehtqhertddttdejnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehthhhorhhnsehfrghsthhmrghilhdrfhhmqeenucggtffrrghtth gvrhhnpeeltefgkeehfeelvedvtedtkedvfefftdegffeiieetgfegkeefuddvvddtudeg geenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthh horhhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Apr 2022 23:40:00 -0400 (EDT) Date: Thu, 28 Apr 2022 05:39:57 +0200 (GMT+02:00) From: Tassilo Horn To: Stefan Monnier Message-ID: <5c751cd8-e337-4ef7-8f88-06709c6d7aa3@fastmail.fm> In-Reply-To: References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <5c751cd8-e337-4ef7-8f88-06709c6d7aa3@fastmail.fm> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55149 Cc: No Wayman , 55149@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I think he means what I've written in my original report. ``` With stock-emacs when doing "emacsclient foo.txt", it just prints "Waiting for Emacs..." but finishes immediately.=C2=A0 The existing emacs doesn't have a foo.txt buffer thereafter.=C2=A0 "emacsclient -c foo.txt" results in a new frame which has a foo.txt buffer but it is not displayed in a window... ``` Testing this strange emacsclient behavior requires no external packages at = all. 27.04.2022 23:48:32 Stefan Monnier : > No Wayman [2022-04-27 15:41:29] wrote: >> Just chiming in to confirm that the same commit has broken something wit= h >> emacsclient frames as well. >=20 > Could you give some details about that? > The `git-commit` bug involves a lot of code, so it would be very helpful > to have a recipe that involves less code. >=20 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 00:03:45 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 04:03:45 +0000 Received: from localhost ([127.0.0.1]:44901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njvNZ-0001Tu-FW for submit@debbugs.gnu.org; Thu, 28 Apr 2022 00:03:45 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:34543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njvNX-0001Te-VY for 55149@debbugs.gnu.org; Thu, 28 Apr 2022 00:03:44 -0400 Received: by mail-qt1-f169.google.com with SMTP id f14so2648030qtq.1 for <55149@debbugs.gnu.org>; Wed, 27 Apr 2022 21:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=foHdy5EQcxrzPJM7GlKOSGhQjHSTp9w4RRRTLAbiK0o=; b=qCwrRqdq57tkV8yeLKg24k4JjoDbPHnxjz68mnDzARb33QtFVvUpCbNz/St9zBMk2I UE+cYlpASWxNcYib7qxqaVCoCQk+JAjDf9UN/S9pYZYBrhvDS901e7vos/Uj/8+S6UQL 9t5aN7y491QHfze7EcslyCDuyX4hQSVUQxx/BtnxG/VaXZywkJz8zmleToVn3N7egT9C elosmikd7yqSOy/PIPtr5kek5YJxyposWBo7K0m7ebmr2+0yAvi489qhpw+nuFcC5Vd7 UQx1BqatOjwpXBQYwECal9loIwAgjrxlENX8G1jNU19uzHc6vgvtlMKpsUT4uvw0tPXO nKcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=foHdy5EQcxrzPJM7GlKOSGhQjHSTp9w4RRRTLAbiK0o=; b=ft15P/Gp4hw4/w9LNleuqnlKp/39qfYpRGmEBkLS8shKVMY/iyod0bEnercc0qj4Nd RptonS3jDYCkGFqxKygvNUsIFstquptoGebwCo1uKQ8c/BbRXoMAI+WwKMVEwk1Pq/22 x9o/ZjAEizFlFMyNErhWfjTcUhpsnV4OhiCu7llnkBkcNt2OAPriya/fDJs80XzYKjYN MSDDk3dyuKmeeiqQ4xoO94foGbpwD/HPwQlE5y4DUz0ZlrI1C3kaulq/+rjIr3F0kLwh uV4ON6mU7v5LIF3jsw1iDe6e5BznBaVzs/ojrewWdjDnpr1jXezJkRAM6sJP650tUcuL rYOQ== X-Gm-Message-State: AOAM5311qtEvBui9pn5Wwp6m/piUTcfQ9ttj/BsfVfMICV68I//S/1KW nwd+bciCfmh0uxp7bIGfS3JCaLHqhms= X-Google-Smtp-Source: ABdhPJwlNA6lnHiqVVSn4rljrFMPxX3QZV8nhao25ECJ2R5oD/Q1uTso9G9pfbgJzkn2xH7S0PnJcA== X-Received: by 2002:ac8:7d10:0:b0:2f2:2a7:41ff with SMTP id g16-20020ac87d10000000b002f202a741ffmr21174944qtb.566.1651118618015; Wed, 27 Apr 2022 21:03:38 -0700 (PDT) Received: from nbook ([2601:82:c200:166d:7a0:14e6:e26:75bd]) by smtp.gmail.com with ESMTPSA id m190-20020a378ac7000000b0069f8d810f16sm1817030qkd.85.2022.04.27.21.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 21:03:37 -0700 (PDT) References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <5c751cd8-e337-4ef7-8f88-06709c6d7aa3@fastmail.fm> User-agent: mu4e 1.7.9; emacs 29.0.50 From: No Wayman To: Tassilo Horn Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 00:02:36 -0400 In-reply-to: <5c751cd8-e337-4ef7-8f88-06709c6d7aa3@fastmail.fm> Message-ID: <875ymtua2o.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55149 Cc: Stefan Monnier , 55149@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tassilo Horn writes: > I think he means what I've written in my original report. Yes. Consider that a +1 in general from me. I've rolled everything back and unfortunately I don't have the time to dig into this one. I took a look at with-editor and it does advise several functions, including `server-switch-buffer'. Not sure if that is where the problem lies, just a hunch. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 00:50:56 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 04:50:56 +0000 Received: from localhost ([127.0.0.1]:44940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njw7E-0002h1-FM for submit@debbugs.gnu.org; Thu, 28 Apr 2022 00:50:56 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njw7B-0002gl-QL for 55149@debbugs.gnu.org; Thu, 28 Apr 2022 00:50:55 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5BA205C00FD; Thu, 28 Apr 2022 00:50:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 28 Apr 2022 00:50:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651121448; x=1651207848; bh=G4PhP5xVpg 9RAC7xhBk2VhD+zHW2GoxgqxDsjOcST7I=; b=SbTH8pBPQNFPW+fTmRlBy+VhC5 QTtsIYZBqkkPpmN5mSvn6p2IyrC11C9JzyQJ1/O4ZtHROoJOJJdYkjkrw+dxsYzR JSLUN1PnmJG3m6a9rZAymCypw8tz+A4gYgjgZDsKT2c8ryWSJokPpzOOkpKVh6tq UaG9eT/Y9siHQgPGW1DyypByeCF5jI7G6hNl2HN2TzF4KEYDY2uDc2tHhngfYDu8 HIRU+qmQO1Rub5nfpZKSYBI3nfcbKkHheMmbZDHVxkEzxzah19WpXmzepdB+E6JF UUvKsddA9tKvCvT3m2OUiydg9CB5MjRgVbCMISz0XKs6cPNsvwQUjtwZbC6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651121448; x= 1651207848; bh=G4PhP5xVpg9RAC7xhBk2VhD+zHW2GoxgqxDsjOcST7I=; b=y altGWUEaRh66FvuNe1T5vEmmoEU5OesCsz0VUKmRAudT58CmWHdwP+Wo4JkjBhyQ 0DqZTfidjtVhzdbYDtXGhTPil3r0l9h3/cUUcCpbDgKZsl1ZIu47yRIpa0fINRn5 rmyBXqAHbWtH2p+bx8Q27zS3h5fBAxOPIyD+kFT80EnipiujjOuymQTnlnzsFl1p L414BZy3MuBIhNRDtzeUk5IaZmpxptMX+ko4mIw0yi8dMV164W8qzmxKsyR8iGTU kouI7YZf5k1oA5NjtP0GGHTXBV4h3Zc1kJdG41Gfw+4pVfH7Z2SLWI3bjHWE1IfI 0QA8ukzvd70msFukDZiuw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvvefuffgjkfggtgesthdtre dttdertdenucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhhohhrnhesfhgrshht mhgrihhlrdhfmheqnecuggftrfgrthhtvghrnhepgeffiefhjeekueeiueehteetgfehte fgffegfeduheejiefhgfehteektefhvdfgnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhrnhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 00:50:46 -0400 (EDT) References: User-agent: mu4e 1.7.13; emacs 29.0.50 From: Tassilo Horn To: "M. Ian Graham" Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 06:47:50 +0200 In-reply-to: Message-ID: <87sfpxhkuz.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55149 Cc: "55149@debbugs.gnu.org" <55149@debbugs.gnu.org>, "monnier@iro.umontreal.ca" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) "M. Ian Graham" writes: >> With stock-emacs when doing "emacsclient foo.txt", it just prints >> "Waiting for Emacs..." but finishes immediately. > > Hi, quick clarification on this: As far as I can tell from my own > observations, all emacsclient breakage here is a downstream > side-effect of magit/with-editor's advice calls somehow getting messed > up. Oh, you are right. But I was able to extract (at least one of) the problematic with-editor advice(s) which cause the breakage. Save the below as bug-recipe.el: --8<---------------cut here---------------start------------->8--- (advice-add 'server-visit-files :after #'server-visit-files--with-editor-file-name-history-exclude) (defun server-visit-files--with-editor-file-name-history-exclude (files _proc &optional _nowait) (pcase-dolist (`(,file . ,_) files) (when (cl-find-if (lambda (regexp) (string-match-p regexp file)) '("don't care")) (setq file-name-history (delete file file-name-history))))) (server-start) --8<---------------cut here---------------end--------------->8--- Then start emacs as "emacs -Q -l bug-recipe.el" and you'll be able to perform my "stock emacs" recipe, i.e., emacsclient foo.txt => finishes immediately emacsclient -c foo.txt => doesn't display the foo.txt buffer Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 02:30:20 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 06:30:20 +0000 Received: from localhost ([127.0.0.1]:45058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njxfQ-0005Z7-74 for submit@debbugs.gnu.org; Thu, 28 Apr 2022 02:30:20 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:40753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njxfN-0005Yq-Px for 55149@debbugs.gnu.org; Thu, 28 Apr 2022 02:30:18 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 75E6A320097C; Thu, 28 Apr 2022 02:30:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 28 Apr 2022 02:30:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651127410; x=1651213810; bh=GJzhYZxwl8 s8FzB3GCLsG+SR9hAKcXGvgbXj0NdwkLg=; b=ZXqlhkcKDxjUvvzErO6fzxq0/U 9nHcZdxyoNMKIHegUuwknMUZ8NfU7d/8jaEjq/Q+dl1bWaMVIf7zlBf5X4NMsElD KisyYfHr72dohEB0oIkb2t59wxisyXzWAi5uSJ2jroQpxavdLnvblHTmAzXMnpj8 yMyClKTWdBjPLYMGSbIZbfq4YO1S+RJE+h0EzzqLRyKcwIlMdUivOZMp1wMS8m76 404R0QoMAtL8QpHgcubItRCmePHlhl/MDQWFvliPIvuR9lGd1hjpwiI5yutCPf+u LykrUftTffQPb5QKiXLIv8upckDMNItR4bOvyHAB/EupCj1UgvsIP4/0q2LA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651127410; x= 1651213810; bh=GJzhYZxwl8s8FzB3GCLsG+SR9hAKcXGvgbXj0NdwkLg=; b=v a06Eh2vpO64bvDSJ8ZBrufh3st3KPLaFnAaNyRyuAcn9m7b0DMki8PsDR6QD3J/h SqPCKOmuzbgcIFOesvdF/8nX5McdJVIhJKl5jfB3xDvjbd6mZmA/xLKQtlekxxei 9UasHoPaTmK1fJEaSXPxlcL0hA1225L8K+b1uUrazP0EIivRGa0qQjoN+Y9icM51 QcloHj7mYtuDFFJqChKh2BVaYNJKS+imGqSll5Qhw73RR8VmDU4+Bx7rIU5k1rgw yXhdhCrpbDeGeO2Rb4bWroyFqGHWsJpMLlnYtHilM9XEPOVqjkiPZNFXkp6xQzSH GEJdBpm7kBWDByyKEXnaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpehffgfhvfevufffjgfkgggtsehttd ertddtredtnecuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehthhhorhhnsehfrghs thhmrghilhdrfhhmqeenucggtffrrghtthgvrhhnpeegffeihfejkeeuieeuheettefghe etgfffgeefudehjeeihffgheetkeethfdvgfenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 02:30:10 -0400 (EDT) References: <87sfpxhkuz.fsf@fastmail.fm> User-agent: mu4e 1.7.13; emacs 29.0.50 From: Tassilo Horn To: "M. Ian Graham" Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 08:28:37 +0200 In-reply-to: Message-ID: <87o80lhg9b.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55149 Cc: "55149@debbugs.gnu.org" <55149@debbugs.gnu.org>, "monnier@iro.umontreal.ca" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) "M. Ian Graham" writes: >> Oh, you are right. But I was able to extract (at least one of) the >> problematic with-editor advice(s) which cause the breakage. > >> Save the below as bug-recipe.el: > > Nice find. Confirmed on my end that this breaks emacsclient commands > after f30625943e but not before. Had to add a require 'cl-lib to the > top, otherwise works perfectly with bare emacs -Q. Oh, well, the recipe can even be simplyfied to defining just a do-nothing advice! --8<---------------cut here---------------start------------->8--- (advice-add 'server-visit-files :after #'server-visit-files--with-editor-file-name-history-exclude) (defun server-visit-files--with-editor-file-name-history-exclude (files _proc &optional _nowait) nil) (server-start) --8<---------------cut here---------------end--------------->8--- Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 02:36:19 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 06:36:20 +0000 Received: from localhost ([127.0.0.1]:45070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njxlD-0005iU-AF for submit@debbugs.gnu.org; Thu, 28 Apr 2022 02:36:19 -0400 Received: from mail-4018.proton.ch ([185.70.40.18]:25167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njtXt-0006zQ-Eb for 55149@debbugs.gnu.org; Wed, 27 Apr 2022 22:06:19 -0400 Date: Thu, 28 Apr 2022 02:06:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=miangraham.com; s=protonmail3; t=1651111570; bh=CQKXwC8zRQ8XJCKrbsxmhkR/gyovDofizpU8sgzhrzM=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=Aoys8ynabRpVXoTiaBIl3KYblM+x80x/6wmiSkd5c4kj3JpVgEjDfB5d9/BRSimDX niyEdgt6neAAaC7R1rBXJ0xuEtkwhepFOD20t1ZK1qpF8vxpLF317sCWe5NU7DLMSL 16/BS/6jJ4RiIR+mZrmHKSwH6K4qNoALkJ+Hy9m/UEnnWaI1UHUPYvAGnpexPSDjtt MZvGOaeBXYd7GEFcoIllhREd27P3m+3gxLWyDSSGOnIfV/wIr+tNotgH7cdwW4Qzj8 m5O532q6azCw99K1rukEfT5nQd12ibYTc2cftI35tgZJPOML6zyawrqlwg54dgQnFg wKh1ysObtNgNQ== To: "55149@debbugs.gnu.org" <55149@debbugs.gnu.org> From: "M. Ian Graham" Subject: (No Subject) Message-ID: Feedback-ID: 29547276:user:proton MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_uv0w3pAXe87Ccym0OlwrchdnvO2zqXSKTyK17fL1Jk" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Quick clarification on server/emacsclient involvement: As far as I can tell, any emacsclient breakage here is a downstream side effect of magit/with-editor's advice calls somehow getting messed up. Using bc9be5449e1127bc1b05a6cad8471c6eba52c8e9 and prior I cannot reproduce any related problems. Using f30625943edefbd88ebf84acbc254ed88db27beb and later causes the magit-commit command to break with [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 SLIGHTLY_BAD_SUBJECT Subject contains something slightly spammy -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 HTML_MESSAGE BODY: HTML included in message -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 55149 X-Mailman-Approved-At: Thu, 28 Apr 2022 02:36:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "M. Ian Graham" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) This is a multi-part message in MIME format. --b1_uv0w3pAXe87Ccym0OlwrchdnvO2zqXSKTyK17fL1Jk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 UXVpY2sgY2xhcmlmaWNhdGlvbiBvbiBzZXJ2ZXIvZW1hY3NjbGllbnQgaW52b2x2ZW1lbnQ6IEFz IGZhciBhcyBJIGNhbiB0ZWxsLCBhbnkgZW1hY3NjbGllbnQgYnJlYWthZ2UgaGVyZSBpcyBhIGRv d25zdHJlYW0gc2lkZSBlZmZlY3Qgb2YgbWFnaXQvd2l0aC1lZGl0b3IncyBhZHZpY2UgY2FsbHMg c29tZWhvdyBnZXR0aW5nIG1lc3NlZCB1cC4KClVzaW5nIGJjOWJlNTQ0OWUxMTI3YmMxYjA1YTZj YWQ4NDcxYzZlYmE1MmM4ZTkgYW5kIHByaW9yIEkgY2Fubm90IHJlcHJvZHVjZSBhbnkgcmVsYXRl ZCBwcm9ibGVtcy4KVXNpbmcgZjMwNjI1OTQzZWRlZmJkODhlYmY4NGFjYmMyNTRlZDg4ZGIyN2Jl YiBhbmQgbGF0ZXIgY2F1c2VzIHRoZSBtYWdpdC1jb21taXQgY29tbWFuZCB0byBicmVhayB3aXRo IGEgR2l0RXJyb3IgKCJwcm9ibGVtIHdpdGggdGhlIGVkaXRvciIgd2hlcmUgdGhlIGVkaXRvciBp cyBlbWFjc2NsaWVudCkgYmVmb3JlIGRpc3BsYXlpbmcgaXRzIG1lc3NhZ2UgZWRpdG9yIHdpbmRv dy4KCkluIHRoZSBzYW1lIGVtYWNzIGluc3RhbmNlLCBvbmx5IGFmdGVyIGZpcnN0IHJlcHJvZHVj aW5nIHRoZSBtYWdpdC1jb21taXQgZXJyb3IgKGFuZCBwcmVzdW1hYmx5IGxlYXZpbmcgYSBzdGFs bGVkIGNsaWVudCBjb25uZWN0aW9uIGluIHBsYWNlKSwgbGF0ZXIgZW1hY3NjbGllbnQgdXNhZ2Ug ZmFpbHMgdmlhIHRoZSBDTEkuCkdpdmVuIGEgbmV3IHNlc3Npb24gdXNpbmcgYSBmcmVzaCBzZXJ2 ZXItc3RhcnQgYW5kIHVzaW5nIGJhc2ljIGVtYWNzY2xpZW50IGNvbW1hbmRzLCBJIGRvbid0IG9i c2VydmUgYW55IHByb2JsZW1zLgoKSSdtIG5vdCB5ZXQgc3VyZSB3aGF0IGEgbWluaW1hbCBicmVh a2luZyBhZHZpY2UgdGVzdCBsb29rcyBsaWtlLiBXaWxsIHNob3V0IGJhY2sgaWYgSSBmaW5kIHNv bWV0aGluZy4KCi1JYW4= --b1_uv0w3pAXe87Ccym0OlwrchdnvO2zqXSKTyK17fL1Jk Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGFyaWFsOyBmb250LXNpemU6IDE0cHg7Ij5RdWljayBj bGFyaWZpY2F0aW9uIG9uIHNlcnZlci9lbWFjc2NsaWVudCBpbnZvbHZlbWVudDogQXMgZmFyIGFz IEkgY2FuIHRlbGwsIGFueSBlbWFjc2NsaWVudCBicmVha2FnZSBoZXJlIGlzIGEgZG93bnN0cmVh bSBzaWRlIGVmZmVjdCBvZiBtYWdpdC93aXRoLWVkaXRvcidzIGFkdmljZSBjYWxscyBzb21laG93 IGdldHRpbmcgbWVzc2VkIHVwLjxicj48L2Rpdj48ZGl2IHN0eWxlPSJmb250LWZhbWlseTogYXJp YWw7IGZvbnQtc2l6ZTogMTRweDsiPjxicj48L2Rpdj48ZGl2IHN0eWxlPSJmb250LWZhbWlseTog YXJpYWw7IGZvbnQtc2l6ZTogMTRweDsiPlVzaW5nIGJjOWJlNTQ0OWUxMTI3YmMxYjA1YTZjYWQ4 NDcxYzZlYmE1MmM4ZTkgYW5kIHByaW9yIEkgY2Fubm90IHJlcHJvZHVjZSBhbnkgcmVsYXRlZCBw cm9ibGVtcy48L2Rpdj48ZGl2IHN0eWxlPSJmb250LWZhbWlseTogYXJpYWw7IGZvbnQtc2l6ZTog MTRweDsiPlVzaW5nIGYzMDYyNTk0M2VkZWZiZDg4ZWJmODRhY2JjMjU0ZWQ4OGRiMjdiZWIgYW5k IGxhdGVyIGNhdXNlcyB0aGUgbWFnaXQtY29tbWl0IGNvbW1hbmQgdG8gYnJlYWsgd2l0aCBhIEdp dEVycm9yICgicHJvYmxlbSB3aXRoIHRoZSBlZGl0b3IiIHdoZXJlIHRoZSBlZGl0b3IgaXMgZW1h Y3NjbGllbnQpIGJlZm9yZSBkaXNwbGF5aW5nIGl0cyBtZXNzYWdlIGVkaXRvciB3aW5kb3cuPC9k aXY+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGFyaWFsOyBmb250LXNpemU6IDE0cHg7Ij48YnI+ PC9kaXY+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGFyaWFsOyBmb250LXNpemU6IDE0cHg7Ij5J biB0aGUgc2FtZSBlbWFjcyBpbnN0YW5jZSwgb25seSBhZnRlciBmaXJzdCByZXByb2R1Y2luZyB0 aGUgbWFnaXQtY29tbWl0IGVycm9yIChhbmQgcHJlc3VtYWJseSBsZWF2aW5nIGEgc3RhbGxlZCBj bGllbnQgY29ubmVjdGlvbiBpbiBwbGFjZSksIGxhdGVyIGVtYWNzY2xpZW50IHVzYWdlIGZhaWxz IHZpYSB0aGUgQ0xJLjwvZGl2PjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBhcmlhbDsgZm9udC1z aXplOiAxNHB4OyI+R2l2ZW4gYSBuZXcgc2Vzc2lvbiB1c2luZyBhIGZyZXNoIHNlcnZlci1zdGFy dCBhbmQgdXNpbmcgYmFzaWMgZW1hY3NjbGllbnQgY29tbWFuZHMsIEkgZG9uJ3Qgb2JzZXJ2ZSBh bnkgcHJvYmxlbXMuPC9kaXY+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGFyaWFsOyBmb250LXNp emU6IDE0cHg7Ij48YnI+PC9kaXY+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGFyaWFsOyBmb250 LXNpemU6IDE0cHg7Ij5JJ20gbm90IHlldCBzdXJlIHdoYXQgYSBtaW5pbWFsIGJyZWFraW5nIGFk dmljZSB0ZXN0IGxvb2tzIGxpa2UuIFdpbGwgc2hvdXQgYmFjayBpZiBJIGZpbmQgc29tZXRoaW5n LjwvZGl2PjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBhcmlhbDsgZm9udC1zaXplOiAxNHB4OyI+ PGJyPjwvZGl2PjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBhcmlhbDsgZm9udC1zaXplOiAxNHB4 OyI+LUlhbjwvZGl2PjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBhcmlhbDsgZm9udC1zaXplOiAx NHB4OyI+PGJyPjwvZGl2Pg0KPGRpdiBjbGFzcz0icHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2sg cHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stZW1wdHkiIHN0eWxlPSJmb250LWZhbWlseTogYXJp YWw7IGZvbnQtc2l6ZTogMTRweDsiPg0KICAgIDxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0 dXJlX2Jsb2NrLXVzZXIgcHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stZW1wdHkiPjwvZGl2Pg0K DQogICAgICAgICAgICA8ZGl2IGNsYXNzPSJwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jay1wcm90 b24gcHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stZW1wdHkiPg0KDQogICAgICAgICAgICA8L2Rp dj4NCjwvZGl2Pg0K --b1_uv0w3pAXe87Ccym0OlwrchdnvO2zqXSKTyK17fL1Jk-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 02:36:20 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 06:36:20 +0000 Received: from localhost ([127.0.0.1]:45072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njxlD-0005iW-UW for submit@debbugs.gnu.org; Thu, 28 Apr 2022 02:36:20 -0400 Received: from mail-4022.proton.ch ([185.70.40.22]:63556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njvQk-0001Ye-I9 for 55149@debbugs.gnu.org; Thu, 28 Apr 2022 00:07:04 -0400 Date: Thu, 28 Apr 2022 04:06:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=miangraham.com; s=protonmail3; t=1651118815; bh=+AkRoZmwegcTXrP3g2WEFTPYbgxF09MjoOMLZpE/b4Q=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:Feedback-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID; b=J7QkrWVEeSviDikZIDQOgmSCKxkUTQm7ZV4OYxkfyCDKUpY74G7qWE6RUybWAzU2n yC6nQVP0j4LxJ8wAcDUmrYo/bHOQH9b7b9yFfjqeqCdOC4lYtewSfarhXOxYoH307V 8Tb32c1hP03Xv8aK/iTDZbtAtcVoVdXGQ+oZW5EcpaylGAU8MiJVdTbNKA3oo80ZP3 n1xzguLAerEyeCKHckV7ZpYPIlPaVGHrO/mb9HmcgLrWfFMC8vRD9ml5vK1GhBaEM6 4MziTyc4Uk6LYD33fnUlCAeEDsqlZFaeZWFuIJZEVgbXfkguSaQTUeEqrlDkm9orqX EkfFeQsFDn/FA== To: "55149@debbugs.gnu.org" <55149@debbugs.gnu.org> From: "M. Ian Graham" Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Message-ID: Feedback-ID: 29547276:user:proton MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_uPRqDsiJa7rrnoLzElh6XZLEdfYP6g0WiJ6ByrztleM" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55149 X-Mailman-Approved-At: Thu, 28 Apr 2022 02:36:18 -0400 Cc: "thorn@fastmail.fm" , "monnier@iro.umontreal.ca" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "M. Ian Graham" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_uPRqDsiJa7rrnoLzElh6XZLEdfYP6g0WiJ6ByrztleM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 PiBXaXRoIHN0b2NrLWVtYWNzIHdoZW4gZG9pbmcgImVtYWNzY2xpZW50IGZvby50eHQiLCBpdCBq dXN0IHByaW50cyAiV2FpdGluZyBmb3IgRW1hY3MuLi4iIGJ1dCBmaW5pc2hlcyBpbW1lZGlhdGVs eS4KCkhpLCBxdWljayBjbGFyaWZpY2F0aW9uIG9uIHRoaXM6IEFzIGZhciBhcyBJIGNhbiB0ZWxs IGZyb20gbXkgb3duIG9ic2VydmF0aW9ucywgYWxsIGVtYWNzY2xpZW50IGJyZWFrYWdlIGhlcmUg aXMgYSBkb3duc3RyZWFtIHNpZGUtZWZmZWN0IG9mIG1hZ2l0L3dpdGgtZWRpdG9yJ3MgYWR2aWNl IGNhbGxzIHNvbWVob3cgZ2V0dGluZyBtZXNzZWQgdXAuCgpPYnNlcnZlZCBicmVha2FnZToKClVz aW5nIGJjOWJlNTQ0OWUxMTI3YmMxYjA1YTZjYWQ4NDcxYzZlYmE1MmM4ZTkgYW5kIHByaW9yIEkg Y2Fubm90IHJlcHJvZHVjZSBhbnkgcmVsYXRlZCBwcm9ibGVtcy4gTWFnaXQgd29ya3MgcHJvcGVy bHkuClVzaW5nIGYzMDYyNTk0M2VkZWZiZDg4ZWJmODRhY2JjMjU0ZWQ4OGRiMjdiZWIgYW5kIGxh dGVyIGNhdXNlcyB0aGUgbWFnaXQtY29tbWl0IGNvbW1hbmQgdG8gYnJlYWsgd2l0aCBhIEdpdEVy cm9yICgicHJvYmxlbSB3aXRoIHRoZSBlZGl0b3IiLCB3aGVyZSB0aGUgZWRpdG9yIGlzIGVtYWNz Y2xpZW50KSBiZWZvcmUgZGlzcGxheWluZyBpdHMgbWVzc2FnZSBlZGl0b3Igd2luZG93LiBHaXZl biB0aGUgY29tbWl0IGNvbnRlbnRzIEkgYXNzdW1lIHRoZSBhZHZpY2UtYWRkIHVzYWdlIGluIHdp dGgtZWRpdG9yIGlzIGJlaW5nIGFmZmVjdGVkIHNvbWVob3cuCgplbWFjc2NsaWVudCBpc3N1ZXM6 CgpJbiB0aGUgc2FtZSBlbWFjcyBpbnN0YW5jZSBhcyBhYm92ZSwgb25seSBhZnRlciBmaXJzdCBy ZXByb2R1Y2luZyB0aGUgbWFnaXQtY29tbWl0IGVycm9yIChhbmQgcHJlc3VtYWJseSBsZWF2aW5n IGEgc3RhbGxlZCBjbGllbnQgY29ubmVjdGlvbiBpbiBwbGFjZSksIGxhdGVyIGVtYWNzY2xpZW50 IHVzYWdlIGZhaWxzIHZpYSB0aGUgQ0xJLgpHaXZlbiBhIG5ldyBzZXNzaW9uIHVzaW5nIGEgZnJl c2ggc2VydmVyLXN0YXJ0IGFuZCB1c2luZyBiYXNpYyBlbWFjc2NsaWVudCBjb21tYW5kcywgSSBk b24ndCBvYnNlcnZlIGFueSBwcm9ibGVtcy4KCklmIEknbSBtaXN1bmRlcnN0YW5kaW5nIGFueW9u ZSBhbmQgeW91J3JlIGFibGUgdG8gcmVwcm8gbWFudWFsIGVtYWNzY2xpZW50IGJyZWFrYWdlIHdp dGggYSBmcmVzaCBzZXJ2ZXIsIHBsZWFzZSBmb2xsb3cgdXAuCgpJJ20gbm90IHlldCBzdXJlIHdo YXQgYSBtaW5pbWFsIGJyZWFraW5nIGFkdmljZSB0ZXN0IGxvb2tzIGxpa2UuIFRyeWluZyBzaW1w bGUgYWR2aWNlLWFkZCBjYWxscyB0aGF0IGxvb2sgc2ltaWxhciB0byB3aXRoLWVkaXRvcidzIGhh c24ndCB0dXJuZWQgdXAgYW55IHByb2JsZW1zIHlldC4gSSdsbCBzaG91dCBiYWNrIGlmIEkgZmlu ZCBzb21ldGhpbmcuCi1JYW4= --b1_uPRqDsiJa7rrnoLzElh6XZLEdfYP6g0WiJ6ByrztleM Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGFyaWFsOyBmb250LXNpemU6IDE0cHg7Ij48cHJlPiZn dDsgV2l0aCBzdG9jay1lbWFjcyB3aGVuIGRvaW5nICJlbWFjc2NsaWVudCBmb28udHh0IiwgaXQg anVzdCBwcmludHMgIldhaXRpbmcgZm9yIEVtYWNzLi4uIiBidXQgZmluaXNoZXMgaW1tZWRpYXRl bHkuPC9wcmU+PHNwYW4+SGksIHF1aWNrIGNsYXJpZmljYXRpb24gb24gdGhpczogQXMgZmFyIGFz IEkgY2FuIHRlbGwgZnJvbSBteSBvd24gb2JzZXJ2YXRpb25zLCBhbGwgZW1hY3NjbGllbnQNCmJy ZWFrYWdlIGhlcmUgaXMgYSBkb3duc3RyZWFtIHNpZGUtZWZmZWN0IG9mIG1hZ2l0L3dpdGgtZWRp dG9yJ3MgYWR2aWNlDQpjYWxscyBzb21laG93IGdldHRpbmcgbWVzc2VkIHVwLjwvc3Bhbj48ZGl2 Pjxicj48L2Rpdj48ZGl2Pk9ic2VydmVkIGJyZWFrYWdlOjxicj48L2Rpdj48ZGl2Pjxicj48L2Rp dj48ZGl2PlVzaW5nIGJjOWJlNTQ0OWUxMTI3YmMxYjA1YTZjYWQ4NDcxYzZlYmE1MmM4ZTkgYW5k IHByaW9yIEkgY2Fubm90IHJlcHJvZHVjZSBhbnkgcmVsYXRlZCBwcm9ibGVtcy4gTWFnaXQgd29y a3MgcHJvcGVybHkuPGJyPjwvZGl2PjxkaXY+VXNpbmcNCiBmMzA2MjU5NDNlZGVmYmQ4OGViZjg0 YWNiYzI1NGVkODhkYjI3YmViIGFuZCBsYXRlciBjYXVzZXMgdGhlDQptYWdpdC1jb21taXQgY29t bWFuZCB0byBicmVhayB3aXRoIGEgR2l0RXJyb3IgKCJwcm9ibGVtIHdpdGggdGhlIGVkaXRvciIs DQogd2hlcmUgdGhlIGVkaXRvciBpcyBlbWFjc2NsaWVudCkgYmVmb3JlIGRpc3BsYXlpbmcgaXRz IG1lc3NhZ2UgZWRpdG9yDQp3aW5kb3cuIEdpdmVuIHRoZSBjb21taXQgY29udGVudHMgSSBhc3N1 bWUgdGhlIGFkdmljZS1hZGQgdXNhZ2UgaW4gd2l0aC1lZGl0b3IgaXMgYmVpbmcgYWZmZWN0ZWQg c29tZWhvdy48YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5lbWFjc2NsaWVudCBpc3N1ZXM6 PGJyPjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+SW4NCiB0aGUgc2FtZSBlbWFjcyBpbnN0YW5j ZSBhcyBhYm92ZSwgb25seSBhZnRlciBmaXJzdCByZXByb2R1Y2luZyB0aGUgbWFnaXQtY29tbWl0 DQplcnJvciAoYW5kIHByZXN1bWFibHkgbGVhdmluZyBhIHN0YWxsZWQgY2xpZW50IGNvbm5lY3Rp b24gaW4gcGxhY2UpLA0KbGF0ZXIgZW1hY3NjbGllbnQgdXNhZ2UgZmFpbHMgdmlhIHRoZSBDTEku PC9kaXY+PGRpdj5HaXZlbiBhIG5ldyBzZXNzaW9uIHVzaW5nIGEgZnJlc2ggc2VydmVyLXN0YXJ0 IGFuZCB1c2luZyBiYXNpYyBlbWFjc2NsaWVudCBjb21tYW5kcywgSSBkb24ndCBvYnNlcnZlIGFu eSBwcm9ibGVtcy48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PklmIEknbSBtaXN1bmRlcnN0YW5k aW5nIGFueW9uZSBhbmQgeW91J3JlIGFibGUgdG8gcmVwcm8gbWFudWFsIGVtYWNzY2xpZW50IGJy ZWFrYWdlIHdpdGggYSBmcmVzaCBzZXJ2ZXIsIHBsZWFzZSBmb2xsb3cgdXAuPGJyPjwvZGl2Pjxk aXY+PGJyPjwvZGl2PjxkaXY+SSdtIG5vdCB5ZXQgc3VyZSB3aGF0IGEgbWluaW1hbCBicmVha2lu ZyBhZHZpY2UgdGVzdCBsb29rcyBsaWtlLiBUcnlpbmcgc2ltcGxlIGFkdmljZS1hZGQgY2FsbHMg dGhhdCBsb29rIHNpbWlsYXIgdG8gd2l0aC1lZGl0b3IncyBoYXNuJ3QgdHVybmVkIHVwIGFueSBw cm9ibGVtcyB5ZXQuIEknbGwgc2hvdXQgYmFjayBpZiBJIGZpbmQgc29tZXRoaW5nLjwvZGl2Pjxk aXY+PGJyPjwvZGl2PjxzcGFuPi1JYW48L3NwYW4+PC9kaXY+PGRpdiBzdHlsZT0iZm9udC1mYW1p bHk6IGFyaWFsOyBmb250LXNpemU6IDE0cHg7Ij48YnI+PC9kaXY+DQo8ZGl2IGNsYXNzPSJwcm90 b25tYWlsX3NpZ25hdHVyZV9ibG9jayBwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jay1lbXB0eSIg c3R5bGU9ImZvbnQtZmFtaWx5OiBhcmlhbDsgZm9udC1zaXplOiAxNHB4OyI+DQogICAgPGRpdiBj bGFzcz0icHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stdXNlciBwcm90b25tYWlsX3NpZ25hdHVy ZV9ibG9jay1lbXB0eSI+PC9kaXY+DQoNCiAgICAgICAgICAgIDxkaXYgY2xhc3M9InByb3Rvbm1h aWxfc2lnbmF0dXJlX2Jsb2NrLXByb3RvbiBwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jay1lbXB0 eSI+DQoNCiAgICAgICAgICAgIDwvZGl2Pg0KPC9kaXY+DQo= --b1_uPRqDsiJa7rrnoLzElh6XZLEdfYP6g0WiJ6ByrztleM-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 02:36:21 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 06:36:21 +0000 Received: from localhost ([127.0.0.1]:45074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njxlE-0005ie-IN for submit@debbugs.gnu.org; Thu, 28 Apr 2022 02:36:20 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:57362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njxOP-00057O-Pu for 55149@debbugs.gnu.org; Thu, 28 Apr 2022 02:12:47 -0400 Date: Thu, 28 Apr 2022 06:12:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=miangraham.com; s=protonmail3; t=1651126358; bh=k8hPEyrM0t+yRSXryGx4ezOHiWN9Gx396ylUyufaV5M=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=CXaIt/hIIJmHumQOX5xWBUefgjZpS1x3uCpjHuabm+kJJoTXuAXTuN1nWvqNG7mDF oxFKJj4ZSF/CMChhHKjZ+V7PFxJIo3oBhIN7TmZ+WKYJHUt6WSbYspCbqQzhmswwML w1XqKJ2/eroK/wzLnEd2aUktdEPpg3bAJthN49kplRCDiIm50TwhhFVSnPeySEbQFm eJHSaSn5SwUHiu9Ky6FZrWcwUapsVzFcLPB15qD1arCvM8EDOpS+aQWOL9yVS6cvFq ouKemx8Sp623pVMtQm9zpNzpfr9u8EZKqpKj0I96cZHoAxk7DyUNx3lVlir/umBknm C8KQckXa7KVjA== To: Tassilo Horn From: "M. Ian Graham" Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Message-ID: In-Reply-To: <87sfpxhkuz.fsf@fastmail.fm> References: <87sfpxhkuz.fsf@fastmail.fm> Feedback-ID: 29547276:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55149 X-Mailman-Approved-At: Thu, 28 Apr 2022 02:36:18 -0400 Cc: "55149@debbugs.gnu.org" <55149@debbugs.gnu.org>, "monnier@iro.umontreal.ca" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "M. Ian Graham" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Oh, you are right. But I was able to extract (at least one of) the > problematic with-editor advice(s) which cause the breakage. > Save the below as bug-recipe.el: Nice find. Confirmed on my end that this breaks emacsclient commands after = f30625943e but not before. Had to add a require 'cl-lib to the top, otherwi= se works perfectly with bare emacs -Q. -Ian From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 03:01:38 2022 Received: (at submit) by debbugs.gnu.org; 28 Apr 2022 07:01:38 +0000 Received: from localhost ([127.0.0.1]:45105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njy9i-0006S3-3M for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:01:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:41220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njy9g-0006Rs-5A for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:01:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njy9S-0006IZ-2r for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:01:26 -0400 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]:44943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njy9Q-0006RA-3v for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:01:21 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 5F321C000E; Thu, 28 Apr 2022 07:01:13 +0000 (UTC) From: Juri Linkov To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Organization: LINKOV.NET References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> Date: Thu, 28 Apr 2022 09:58:45 +0300 In-Reply-To: (Stefan Monnier via's message of "Wed, 27 Apr 2022 17:48:27 -0400") Message-ID: <86bkwly9qy.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4b98:dc4:8::226; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit Cc: thorn@fastmail.fm, No Wayman , 55149@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) > Could you give some details about that? > The `git-commit` bug involves a lot of code, so it would be very helpful > to have a recipe that involves less code. I have the same problem, and distilled it to the shortest test case: ``` (defun testa () 1) (advice-add 'testa :after (lambda (&rest _) 2)) (defun testb () (interactive) (message "! %S" (testa))) ``` In 28 it returns 1. In 29 it returns 2. The regression is that the return value of :after now overrides the return value of the original function. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 03:15:25 2022 Received: (at submit) by debbugs.gnu.org; 28 Apr 2022 07:15:26 +0000 Received: from localhost ([127.0.0.1]:45131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njyN3-0006nR-Ik for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:15:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:59862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njyMx-0006n4-PM for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:15:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyMx-0002yC-8s for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:15:19 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:43969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyMv-0008Cy-Bf for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:15:19 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id E87383200946; Thu, 28 Apr 2022 03:15:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 28 Apr 2022 03:15:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651130113; x=1651216513; bh=SyGQ8dSC6K hSOwOsAsUehDdVy45tvXHLDUq1DNDp71M=; b=UJ0q9naPmAk8YtLcL3co6Nj1vP yuiEQyqbShhEBUkqn8ujF72/xHi2myZ1ZCVu/uVGI5iag9l8honxelAVBFMQ04jZ osxIKztiSZgShtyXL+B/EGgGLv1WK7nI1RtTqV1gvIp167bl6Mz5tAeVHnKlKcsI VPqy5zDBb6mMhc8SbrU/2MugJDv9eB3Ax3xzybZ9xQxC2orWatXhRJr/Xmt95Rlq CTvpM+V2Lo/j619SxIu67MjKyajoTr3sbOTh0vhqWMuY79QnKfxT6WLYn6QDpgDM HPfi99vLVGD1A3Hwheak7Clbct190txL+JkVa/Ha4dgUCtdmXp7fAcv8NX9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651130113; x= 1651216513; bh=SyGQ8dSC6KhSOwOsAsUehDdVy45tvXHLDUq1DNDp71M=; b=k tcE639MxtMJP8w4eiOEDey11Mycf0qH/wTKPajJY4rydCVq9rYtimo1jpc+3wEd6 fycTG5SDHCfdn9A8/S0ichZLen+YKkI2I+lUdFvE11/2osLOOb1WRneX+a0cefK0 vliUCJZX0jvGWOSkJHHeMHcuNJQiiNdjvTYSFTINZOT1puK7VtGyZLDbXUJcE0mv KUc5rd6y8GvOs6tWtwpU5mqr123PPjR3lgYOW/HTu9/YakYdJTFGNgP6zKRIGjbu 0be/mSxAKYOoudlZ6wS8+7Bn5Ri2cGl+HDD551/w8cnaQ8qWSw/jA5vcP1r3EJUd IQq7T2izFTGk4Q36NCECg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhhohhrnhesfhgrshhtmhgrihhlrdhfmheqnecuggftrfgrth htvghrnhepgeffiefhjeekueeiueehteetgfehtefgffegfeduheejiefhgfehteektefh vdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepth hhohhrnhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 03:15:12 -0400 (EDT) References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> User-agent: mu4e 1.7.13; emacs 29.0.50 From: Tassilo Horn To: Juri Linkov Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 09:12:27 +0200 In-reply-to: <86bkwly9qy.fsf@mail.linkov.net> Message-ID: <87k0b9he68.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.19; envelope-from=thorn@fastmail.fm; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit Cc: "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" , No Wayman , 55149@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Juri Linkov writes: > I have the same problem, and distilled it to the shortest test case: > > ``` > (defun testa () > 1) > > (advice-add 'testa :after > (lambda (&rest _) 2)) > > (defun testb () > (interactive) > (message "! %S" (testa))) > ``` > > In 28 it returns 1. > In 29 it returns 2. > > The regression is that the return value of :after now overrides > the return value of the original function. Oh, indeed. But isn't that exactly as documented for add-function? :after (lambda (&rest r) (apply OLDFUN r) (apply FUNCTION r)) Of course, we'd rather want :after (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r))) Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 03:24:33 2022 Received: (at submit) by debbugs.gnu.org; 28 Apr 2022 07:24:33 +0000 Received: from localhost ([127.0.0.1]:45146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njyVt-00071d-4z for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:24:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:42734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njyVr-00071S-Qg for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:24:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyVa-0002OD-SY for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:24:25 -0400 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]:43677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyVZ-0000ti-2L for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:24:14 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 5A9D2100003; Thu, 28 Apr 2022 07:24:06 +0000 (UTC) From: Juri Linkov To: Tassilo Horn Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Organization: LINKOV.NET References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> <87k0b9he68.fsf@fastmail.fm> Date: Thu, 28 Apr 2022 10:22:24 +0300 In-Reply-To: <87k0b9he68.fsf@fastmail.fm> (Tassilo Horn's message of "Thu, 28 Apr 2022 09:12:27 +0200") Message-ID: <86pml1wu33.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4b98:dc4:8::231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit Cc: "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" , No Wayman , 55149@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) >> The regression is that the return value of :after now overrides >> the return value of the original function. > > Oh, indeed. But isn't that exactly as documented for add-function? > > :after (lambda (&rest r) (apply OLDFUN r) (apply FUNCTION r)) Indeed, it seems documentation differed from the actual implementation. > Of course, we'd rather want > > :after (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r))) Yep, this looks like what it's natural to expect from such advice type. Or maybe a new type could be added to modify the return value? From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 03:32:09 2022 Received: (at submit) by debbugs.gnu.org; 28 Apr 2022 07:32:09 +0000 Received: from localhost ([127.0.0.1]:45172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njydE-0007Eh-QG for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:32:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:54630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njydD-0007ES-5f for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:32:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njydB-0002kR-Iz for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:32:06 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:42853) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyd8-0002Gu-J9 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:32:05 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 3FA86320077A; Thu, 28 Apr 2022 03:32:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 28 Apr 2022 03:32:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651131119; x=1651217519; bh=ifO1pMC/W9 6+9zZ9IoR94AFgS/a1NtJMwMj7FZjgvMM=; b=oq35jVkSv9RJjWA7Gjp9DsXuld DAyYmI1cVgX/R3KUo6HfTNUMw3/CeojuE5TJ/U+LeVW+ktB5tsPY7fdgUVIfPYa3 KP/IPSX45ZhLhWegMMX2Zsu9RtjnHJgs9Y+nSSHP6Uj4qZx+g4AX/qTqO4TA2N0R sHH058YJgUA3nBDJUA2G6sabzCHSuF28gTJ5jYiJGIVxDIhFwFtVZq88NlDHlzh2 6Qd1+YF5A6pFR61kxmjSW+jymNdRwVMdy0DXp8YWICsiT/b2jlhtC9xKRLK7fMYC XLpTLl/+TVpUBiGPVi2EJRP5otxxGXgh8JoC2BOrPDjuvAhnUWaFUCwJJj5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651131119; x= 1651217519; bh=ifO1pMC/W96+9zZ9IoR94AFgS/a1NtJMwMj7FZjgvMM=; b=G IQHkdaohZeBc612Ouqt/NyzQ5c6/3vxOQKL1WiZ6kocl/BYHZaXFD8U2J6b9xVAb WM1cIJrzaOo5FdcFEBTkqWIMoN1FPiCQCqIXznGc1bgJuQ+XxWItpdJG45CKlPJW 2xaw09mKTVMnfCgxWlPXyl+HHkznjlS3bGMl87iaLM1NiK3LijFv57iRCGx0c0zJ +sRAG1BWEEIUa6xUPttjuXBxiQ1ulk74Tj2nM9MdZl+tBijNwhgml5QJPP+HCRuX 4xEDw8kxlf7NonK5x2rN72J94Ez5BlLSGZQGNTkJthP7+ramq21HYTSfw2WPZClw 7dXU5nl9nwFuvb05RdudA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhhohhrnhesfhgrshhtmhgrihhlrdhfmheqnecuggftrfgrth htvghrnhepgeffiefhjeekueeiueehteetgfehtefgffegfeduheejiefhgfehteektefh vdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepth hhohhrnhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 03:31:58 -0400 (EDT) References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> <87k0b9he68.fsf@fastmail.fm> <86pml1wu33.fsf@mail.linkov.net> User-agent: mu4e 1.7.13; emacs 29.0.50 From: Tassilo Horn To: Juri Linkov Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 09:31:22 +0200 In-reply-to: <86pml1wu33.fsf@mail.linkov.net> Message-ID: <87fslxhdea.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.19; envelope-from=thorn@fastmail.fm; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit Cc: "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" , No Wayman , 55149@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Juri Linkov writes: >>> The regression is that the return value of :after now overrides >>> the return value of the original function. >> >> Oh, indeed. But isn't that exactly as documented for add-function? >> >> :after (lambda (&rest r) (apply OLDFUN r) (apply FUNCTION r)) > > Indeed, it seems documentation differed from the actual implementation. > >> Of course, we'd rather want >> >> :after (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r))) > > Yep, this looks like what it's natural to expect from such advice type. > Or maybe a new type could be added to modify the return value? There is :filter-return to do exactly that. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 04:01:17 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 08:01:17 +0000 Received: from localhost ([127.0.0.1]:45193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njz5Q-0007ya-Il for submit@debbugs.gnu.org; Thu, 28 Apr 2022 04:01:17 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:18868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njy4k-0006HL-Oj for 55149@debbugs.gnu.org; Thu, 28 Apr 2022 02:56:32 -0400 Date: Thu, 28 Apr 2022 06:56:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=miangraham.com; s=protonmail3; t=1651128983; bh=k45HIB1CTCeIad03VfsUsuzhU1ITvP7gOo0ZUm/690Q=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=g/5cOgxrEwvG/yO87oEbKaxM62+/7tesaZQNt2nK7j8T7btjWn0Ks7BhVvpgBtc2w ipq38x8sQngWsx/RmzrZ1AIiTMldh2KtX88ZR6fOBUb+ysmMVX4FcINstqImoRGbID yx005QXY7156rXztgmYVdLvqCVkgOwd+llL9ICnSBhDZjDvHdfrYxGrcX3Cn5C0WPE nhYHcGe19Bn6gO3imq4xiYVo+XbREWEBK33S6sxYMgcbz74r1yBULR7nsP7XYfVeJp IxeCue8OQHdhu4/00XuLTgWFRkpjeCkpde5dsQ2vWKgxDkzIHol8/DMfDMDu/JRUs2 ACs4SsTq5n2WA== To: Tassilo Horn From: "M. Ian Graham" Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Message-ID: In-Reply-To: <87o80lhg9b.fsf@fastmail.fm> References: <87sfpxhkuz.fsf@fastmail.fm> <87o80lhg9b.fsf@fastmail.fm> Feedback-ID: 29547276:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55149 X-Mailman-Approved-At: Thu, 28 Apr 2022 04:01:15 -0400 Cc: "55149@debbugs.gnu.org" <55149@debbugs.gnu.org>, "monnier@iro.umontreal.ca" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "M. Ian Graham" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Oh, well, the recipe can even be simplyfied to defining just a > do-nothing advice! Ah ha. Return value shenanigans. Here's a no-server test case. --- begin elisp --- (advice-add 'original :after #'original--advice) (defun original () "correct: original return value passes through") (defun original--advice () "broken: advice function's return value is used"= ) (message (original)) --- end elisp --- Output before f30625943e: $ emacs -Q --script bug-recipe.el correct: original return value passes through Output after f30625943e: $ emacs -Q --script bug-recipe.el broken: advice function's return value is used -Ian From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 06:21:05 2022 Received: (at control) by debbugs.gnu.org; 28 Apr 2022 10:21:05 +0000 Received: from localhost ([127.0.0.1]:45435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk1Gj-0005Ht-3n for submit@debbugs.gnu.org; Thu, 28 Apr 2022 06:21:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk1Gh-0005H2-Q7 for control@debbugs.gnu.org; Thu, 28 Apr 2022 06:21:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zo/Pv23b7H6JJr4gTrdAIG74cu/nYSNOhAqjCOQ9zqQ=; b=YYDQRlwbsrDrBvAAFZTdimovC1 i5MYC/0fGc+Bf5otLtIkRKUzsOEEtFaxNnY+Xifgf1PzmtDKUucF48npT8zKeot+C2pR06xnhmwCr n0SU4kvyOjUhj4tMLlHRNvvur9l1gW/67ikWFzW/snMaHd0WKd43Pxz+WcxNYa2iAzKM=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk1Ga-00080b-1O for control@debbugs.gnu.org; Thu, 28 Apr 2022 12:20:57 +0200 Date: Thu, 28 Apr 2022 12:20:55 +0200 Message-Id: <87ee1hpkzc.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #55160 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: forcemerge 55160 55149 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) forcemerge 55160 55149 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 06:23:16 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 10:23:16 +0000 Received: from localhost ([127.0.0.1]:45440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk1Iq-0005M6-Ef for submit@debbugs.gnu.org; Thu, 28 Apr 2022 06:23:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk1Io-0005Lk-QH; Thu, 28 Apr 2022 06:23:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rbgaasEVWzW59XWZ8apXA0NLIfu8mdeofAhyjafbh+c=; b=JJWhT5qT1KliiWzW15zOskEzIs qMItswWiXl6Z1K1k4MV/cxy1LreYjSErnOy52TLFp3M2rVOdsk7XEFBtn6h/HGNBOM/D9R7cBfGIn beOzMgMZOuMzOLw3/AfBL2HMFsWo8RlLAA4QVRqwLED6HEIOSH+WybEfebEqd71Oa148=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk1If-00081G-DW; Thu, 28 Apr 2022 12:23:07 +0200 From: Lars Ingebrigtsen To: dick Subject: Re: bug#55161: 29.0.50; [PATCH] oclosure transcription error redux References: <87mtg5zt3a.fsf@dick> X-Now-Playing: Yukihiro Takahashi's _Blue Moon Blue_: "A Star Is Born" Date: Thu, 28 Apr 2022 12:23:04 +0200 In-Reply-To: <87mtg5zt3a.fsf@dick> (dick's message of "Thu, 28 Apr 2022 01:15:37 -0400") Message-ID: <87a6c5pkvr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: dick writes: > - (:after (apply cdr r) (apply car r)) > + (:after (prog1 (apply cdr r) (apply car r))) I guess this is the same as bug#55149, so I've merged the reports. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55149 Cc: 55149@debbugs.gnu.org, Stefan Monnier , 55161@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) dick writes: > - (:after (apply cdr r) (apply car r)) > + (:after (prog1 (apply cdr r) (apply car r))) I guess this is the same as bug#55149, so I've merged the reports. Apparently, returning the value of the :after function is what's documented to happen (and is what the trunk does now), but it didn't use to do that, so it's breaking advice that relies on the old behaviour, if I understand 55149 correctly. Stefan? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 09:39:27 2022 Received: (at 55149-done) by debbugs.gnu.org; 28 Apr 2022 13:39:27 +0000 Received: from localhost ([127.0.0.1]:45820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4Mh-00055u-G5 for submit@debbugs.gnu.org; Thu, 28 Apr 2022 09:39:27 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4Mf-00055e-2U for 55149-done@debbugs.gnu.org; Thu, 28 Apr 2022 09:39:26 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4CC1C441136; Thu, 28 Apr 2022 09:39:19 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A2665441130; Thu, 28 Apr 2022 09:39:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651153157; bh=wfaxlTS3AilAr9grQzo1yArtFsz55x4WX8qQBV1Gyio=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dQSTTN3BaInEksVMPm4kK8sWeqR5evL3crlQlIjvlDF0Dn2adx0MLgQzO7wclpqGT xdop2SAn0kxrxt+TnzS374YhNdAvulOcnTPsX94bMBF/s9wyrc8EXW0g97NkqVPoFz fTn+M1efRTbMHU8VGM4HgbaEQHFcHTxQtTtg4YIUX2TN0NIlyeS1Xil/2RBfa1EENU 6X1qZsYQkeitv3juc5pD4/kAWXv0Xqx6hChpW11ek7qocf7lhLO2fKIIQ45kTE4MXi IyAHAKUlKGwirBOob7MlhEZKuFoMb3FqgMsUK4pZ9343uxmXwWniHHYb64mp7XFoMv /UCH50HL1DCPQ== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6219D12044C; Thu, 28 Apr 2022 09:39:17 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Message-ID: References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> Date: Thu, 28 Apr 2022 09:39:16 -0400 In-Reply-To: <86bkwly9qy.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 28 Apr 2022 09:58:45 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55149-done Cc: thorn@fastmail.fm, No Wayman , 55149-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I have the same problem, and distilled it to the shortest test case: > > ``` > (defun testa () > 1) > > (advice-add 'testa :after > (lambda (&rest _) 2)) > > (defun testb () > (interactive) > (message "! %S" (testa))) > ``` Thanks, should be fixed now, Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 09:42:18 2022 Received: (at 55149-done) by debbugs.gnu.org; 28 Apr 2022 13:42:18 +0000 Received: from localhost ([127.0.0.1]:45843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4PS-0005Bl-Iv for submit@debbugs.gnu.org; Thu, 28 Apr 2022 09:42:18 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4PR-0005BV-BZ; Thu, 28 Apr 2022 09:42:17 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D049B100164; Thu, 28 Apr 2022 09:42:11 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 481E010027D; Thu, 28 Apr 2022 09:42:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651153330; bh=ZmzfrO5WmzGvSLc+GbJPtX8gxdGzoXh2jqs3LHCebqo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Pg8OtkkcO1A8+A3oh2xrhfnDutmbyzTdh6lk1rMdX+6x9fW8z/Nfon1M6AqiA52PJ 1eX04GEy76wFWF0IFhzfz1Cf+kDCGW2ubs+vGk+Iam2Mxwmebi3p4M4A/zanVsKoL7 FFuo4NYgyvWAwnNts0vEiI/sH0mziveuRDr9Rrz3By5oMxMKsQ/3EbgYTAEKqpJCC/ zeZgmXRBysivRkxnntueeBGD6Pz6asMKTQXVI5DBg9ADxsnXgdGrRjrdSL5qVd6F07 ClagRu+jYA5W9WjksxcjKz5ezsHbJzeBy/YYMHATpbVu/LgFUInbFm48jEoewYRmdq 1OIxb+f8tbUyg== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C1A5B120297; Thu, 28 Apr 2022 09:42:09 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#55161: 29.0.50; [PATCH] oclosure transcription error redux Message-ID: References: <87mtg5zt3a.fsf@dick> <87a6c5pkvr.fsf@gnus.org> Date: Thu, 28 Apr 2022 09:42:08 -0400 In-Reply-To: <87a6c5pkvr.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 28 Apr 2022 12:23:04 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55149-done Cc: 55161-done@debbugs.gnu.org, dick , 55149-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2022-04-28 12:23:04] wrote: > dick writes: > >> - (:after (apply cdr r) (apply car r)) >> + (:after (prog1 (apply cdr r) (apply car r))) > > I guess this is the same as bug#55149, so I've merged the reports. > > Apparently, returning the value of the :after function is what's > documented to happen (and is what the trunk does now), but it didn't > use to do that, so it's breaking advice that relies on the old > behaviour, if I understand 55149 correctly. > Stefan? Yes, I implemented the new code from the doc (since the old code was written in the form of an "undecipherable" bytecode string), but the doc was wrong. It's now fixed. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 09:50:37 2022 Received: (at submit) by debbugs.gnu.org; 28 Apr 2022 13:50:37 +0000 Received: from localhost ([127.0.0.1]:45860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4XV-0007bK-71 for submit@debbugs.gnu.org; Thu, 28 Apr 2022 09:50:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:38278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4XT-0007bD-Cb for submit@debbugs.gnu.org; Thu, 28 Apr 2022 09:50:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4XT-0000by-5P for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:50:35 -0400 Received: from ciao.gmane.io ([116.202.254.214]:56536) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4XR-0004oj-8X for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:50:34 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nk4XK-0001jL-Vd for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 15:50:26 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Rudolf Schlatte Subject: Re: bug#55149: bug#55161: 29.0.50; [PATCH] oclosure transcription error redux Date: Thu, 28 Apr 2022 15:50:14 +0200 Message-ID: References: <87mtg5zt3a.fsf@dick> <87a6c5pkvr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (darwin) Cancel-Lock: sha1:5n8O7OC8wVQ/H1RjuGzTeXHuQ0g= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Lars Ingebrigtsen writes: > dick writes: > >> - (:after (apply cdr r) (apply car r)) >> + (:after (prog1 (apply cdr r) (apply car r))) > > I guess this is the same as bug#55149, so I've merged the reports. > > Apparently, returning the value of the :after function is what's > documented to happen (and is what the trunk does now), but it didn't > use to do that, so it's breaking advice that relies on the old > behaviour, if I understand 55149 correctly. This behavior is a bit surprising, since Common Lisp specifies that the return values of :after methods are ignored (“All the after methods are called in most-specific-last order. Their values are ignored.” http://www.lispworks.com/documentation/HyperSpec/Body/07_ffb.htm). To override the return value of a method, :around methods are used. I don't want to argue that CL method combinations and elisp advice are the same thing, or that Emacs Lisp has to necessarily follow CL semantics, but it would be good to have the possibility of inserting a bit of code that should "just run" after a function, without overriding its return value. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 10:19:54 2022 Received: (at 55149-done) by debbugs.gnu.org; 28 Apr 2022 14:19:54 +0000 Received: from localhost ([127.0.0.1]:49508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4zq-00030P-0m for submit@debbugs.gnu.org; Thu, 28 Apr 2022 10:19:54 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:51707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4zo-00030B-1k for 55149-done@debbugs.gnu.org; Thu, 28 Apr 2022 10:19:52 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BF1B05C00F5; Thu, 28 Apr 2022 10:19:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 28 Apr 2022 10:19:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651155585; x=1651241985; bh=Ig5PbJr796 Z4DuEw76oYcSGU4o0jAY2L+5Nd8cmEr2U=; b=DF6SmUGvgvMoMtSl8oEDVUuHpJ GMdeIIm4FlAPBQa0sqanjdFY/ltmNLOsQa42GBwHGSgWbSkrELbkAZftDXmDotWm sl13Oa0CbK3SAG/YjP/gqrssLV895vJ715QRkeUq8eRbKrU70Yfy8DHBKZaAwTmy hhqB4v8EFR9rNrxmwhOvsYKeomd6yTM5ptgT7FdRVsXF1h2bW04PJ99LRy2naNfg GhhEY6oU32HVzBxMJ/KaoHgNPy07GqXjfzijPC8X9MwZrdREaAIkaccGMGOVxjm+ JHkIE8Uw3vjT3ZWJf03Pk1F56sWYIBFj93h8Zxo4e34fgPTtGbH5jyhx2Uwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651155585; x= 1651241985; bh=Ig5PbJr796Z4DuEw76oYcSGU4o0jAY2L+5Nd8cmEr2U=; b=j 4y46HX2JY2IdaoJUehij38jx1pgoIOTF68FF7VUSxbM5FWduwB7FwvqaZoLgEn+7 oAoxlU4YY3k8NN3fj8J319PLypg6gKiiGCiJVY/jYXyeJxIAf0rjVVQrCwGQL3Fk AQF2kNKjy10fA4Lqmul/ostCtCh6Ggz3feLcH3b/mciTbzgz5p1TXbJ8VfoOjboJ EhboL9FJttutGiElnQq4lOuBLCc0HaeIwVA/6Ckc8ajiJGehorosv0yTcmlUIfuk 3PY39v6+/lpUFJsfsrhdZn5sFVmvMi8rDdCrznLr3VM93V/EubGksaNe4QzHhVsz 0911b2sScw/wnxUIXNCZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejgdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehthhhorhhnsehfrghsthhmrghilhdrfhhmqeenucggtffrrghtth gvrhhnpeegffeihfejkeeuieeuheettefgheetgfffgeefudehjeeihffgheetkeethfdv gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthh horhhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 10:19:44 -0400 (EDT) References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> User-agent: mu4e 1.7.13; emacs 29.0.50 From: Tassilo Horn To: Stefan Monnier Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 16:14:56 +0200 In-reply-to: Message-ID: <875ymt70jl.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55149-done Cc: 55149-done@debbugs.gnu.org, No Wayman , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: >> I have the same problem, and distilled it to the shortest test case: >> >> ``` >> (defun testa () >> 1) >> >> (advice-add 'testa :after >> (lambda (&rest _) 2)) >> >> (defun testb () >> (interactive) >> (message "! %S" (testa))) >> ``` > > Thanks, should be fixed now, It is, thanks. Shouldn't you also adapt the add-function docstring? Oh, that's adapted automatically! Interesting approach. And even more interesting that the info docs were correct since 2014. :-) Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 10:28:37 2022 Received: (at 55149-done) by debbugs.gnu.org; 28 Apr 2022 14:28:37 +0000 Received: from localhost ([127.0.0.1]:49521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk58G-0003Dh-R6 for submit@debbugs.gnu.org; Thu, 28 Apr 2022 10:28:37 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk58F-0003DV-HE for 55149-done@debbugs.gnu.org; Thu, 28 Apr 2022 10:28:36 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6E87F10027D; Thu, 28 Apr 2022 10:28:29 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F092B100164; Thu, 28 Apr 2022 10:28:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651156107; bh=iG4v8xpKtiTI3YaAOyTlEZBEYEGvGuL0nnNfdIdPN5s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fpNb3kZutJsfPxgTBceeIQNt5eo3d+WB6Wy4Jquh0TC1+sg5VOkoiwZbdfI9gS2Gz XurewnK4gUsv7544LtiFIQ9dpMZW16iWM6LtkceK7dKQpyuCwiVraxSyMF5R8vRTt5 viIEXFr4q4CDvVufNp6TG2WoJ4YvvUQSsDISkAgEgwkLjmZEepBH2keC7i2l1lsMnB MazysXBlHPdwNB5oR/o144eZOvQMh1/nB7BP0CCh2URnG6CiTeJsYsdxvlM+nKDgZL JHUkTgPhLcHsatN7pEH4yttZRNDfHfSfcBhYgduPZ22NhbYVIgQVVE+JsA5Vmoyg1F o6OYXMo7W57LA== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B07D41204FE; Thu, 28 Apr 2022 10:28:27 -0400 (EDT) From: Stefan Monnier To: Tassilo Horn Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Message-ID: References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> <875ymt70jl.fsf@fastmail.fm> Date: Thu, 28 Apr 2022 10:28:25 -0400 In-Reply-To: <875ymt70jl.fsf@fastmail.fm> (Tassilo Horn's message of "Thu, 28 Apr 2022 16:14:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55149-done Cc: 55149-done@debbugs.gnu.org, No Wayman , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > It is, thanks. Shouldn't you also adapt the add-function docstring? > Oh, that's adapted automatically! Interesting approach. :-) Actually, it was done to avoid copy&paste between the docstrings of `add-function` and `advice-add`, but it's nice that it also avoids duplication between the code and the doc and makes sure the doc is in sync with the code. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 10:44:04 2022 Received: (at 55149-done) by debbugs.gnu.org; 28 Apr 2022 14:44:04 +0000 Received: from localhost ([127.0.0.1]:49559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk5NE-0003cv-8I for submit@debbugs.gnu.org; Thu, 28 Apr 2022 10:44:04 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk5NC-0003cJ-Oh for 55149-done@debbugs.gnu.org; Thu, 28 Apr 2022 10:44:03 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 311D15C0042; Thu, 28 Apr 2022 10:43:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 28 Apr 2022 10:43:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651157037; x=1651243437; bh=phf+K3/IKA I2IsdxpUn1DuYXdKL5rv0RBnxCfOl9UJs=; b=ZUwWw6EVNcMgB1PGhvx1TkAKOZ lPU3m/cELFY4HPz/zp8F6cTQE0Q6bypH7+UEGFLXnBpI3S5U7wP7dufl9der5nMx EjSL/2cH35S2ziIzTwFkYEWXgYAY7KkAkgGKiHxsJG/BbRwui8L+gnqAYX2wnAXm ySwQJAyl8abX7PeD6hWKeUqW/zN2VczzaN9m5hQ/1mw5Sk7hhJu2F/DFc8kl6hee pt63JkwBF5PBddAJt+8o7lU1rPZarspM/5WFHmbBbfG3XIksY4F6OO66DmSECJeR XF3IX92NKSbj8u1uXaHfqAm/SBLtkiasPaSM/mBS3IDzfICXZfQS3pKdqiSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651157037; x= 1651243437; bh=phf+K3/IKAI2IsdxpUn1DuYXdKL5rv0RBnxCfOl9UJs=; b=r 9iQgYxmcK7db57Edmm7tS/zdX9hAgwYZPCVgsWU9Vq9PuHy8p+JWcvJTbdWDKXUW Wa6TA4eUW32xSeZC9XnIoG8J/kECweIE8f0Y+hSDitVrKOlH0Zfnq/qUJaoNGq9Z xEN9p9HTtqtlgxHSZbK//BAanPkwnp9NIsAhpe9S2CqyWQ5zng0uDFtbssvM72oX ZeOV/Nhs7aPBCX44K8Gv/rfVJoaWOQeRcxVmibLYdN1XLacDvzt+ZG0GH3zjTzjY WAFwYlhxw7IM/KmBcrIp4bFkd87t5RjNh4xOBr2caUvAkdDv3jMi/T+60OVB4Kai efSWWv4YnrdPj1j+sQ1fQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejgdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehthhhorhhnsehfrghsthhmrghilhdrfhhmqeenucggtffrrghtth gvrhhnpeegffeihfejkeeuieeuheettefgheetgfffgeefudehjeeihffgheetkeethfdv gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthh horhhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 10:43:56 -0400 (EDT) References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> <875ymt70jl.fsf@fastmail.fm> User-agent: mu4e 1.7.13; emacs 29.0.50 From: Tassilo Horn To: Stefan Monnier Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 16:39:11 +0200 In-reply-to: Message-ID: <871qxh6zf8.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55149-done Cc: 55149-done@debbugs.gnu.org, No Wayman , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: >> It is, thanks. Shouldn't you also adapt the add-function docstring? >> Oh, that's adapted automatically! Interesting approach. > > :-) > Actually, it was done to avoid copy&paste between the docstrings of > `add-function` and `advice-add`, but it's nice that it also avoids > duplication between the code and the doc and makes sure the doc is in > sync with the code. Indeed, and I think until recently advice-add didn't document HOW but just referred to add-function which was a bit annoying because usually one uses advice-add so does C-h f on that and then needs to TAB to add-function to get the docs on that. Would you mind adding this magic also to define-advice so that the HOW is described there as well? Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 11:26:53 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 15:26:54 +0000 Received: from localhost ([127.0.0.1]:49638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk62f-0004mM-KG for submit@debbugs.gnu.org; Thu, 28 Apr 2022 11:26:53 -0400 Received: from mail.hostpark.net ([212.243.197.30]:51072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk62c-0004m4-Fw; Thu, 28 Apr 2022 11:26:51 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 482F4168ED; Thu, 28 Apr 2022 17:26:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:user-agent:message-id :in-reply-to:date:date:references:subject:subject:from:from :received:received; s=sel2011a; t=1651159608; bh=kW292XzJHZczv7p +7CjAKBPvS4qYXAg1Ez8wwqqYLcE=; b=0UhToJpG5GPbgGMfh6l5dYZXq9+QWiu XKXehPQdVmEqDxiFOtP8PPvM8yQQ24ci5bikLRCEyvAxF1sj87mtJOCS1gWH9o2Q QGPsWBDzLDaoMT0ZE89vJCFOdXcQnEZFDRtiXsR/RWI5G7T11d0O0bEDKL3aldIT PHq9ZMJoyNRk= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id CcujSibDbSdD; Thu, 28 Apr 2022 17:26:48 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 13117168F2; Thu, 28 Apr 2022 17:26:48 +0200 (CEST) From: Jonas Bernoulli To: Stefan Monnier Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor References: <87mtg5zt3a.fsf@dick> <87a6c5pkvr.fsf@gnus.org> Date: Thu, 28 Apr 2022 17:26:47 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 28 Apr 2022 09:42:08 -0400") Message-ID: <87a6c56xfs.fsf_-_@bernoul.li> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55149 Cc: 55161-done@debbugs.gnu.org, Lars Ingebrigtsen , 55149-done@debbugs.gnu.org, 55149@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: > Lars Ingebrigtsen [2022-04-28 12:23:04] wrote: >> dick writes: >> >>> - (:after (apply cdr r) (apply car r)) >>> + (:after (prog1 (apply cdr r) (apply car r))) >> >> I guess this is the same as bug#55149, so I've merged the reports. >> >> Apparently, returning the value of the :after function is what's >> documented to happen (and is what the trunk does now), but it didn't >> use to do that, so it's breaking advice that relies on the old >> behaviour, if I understand 55149 correctly. >> Stefan? > > Yes, I implemented the new code from the doc (since the old code was > written in the form of an "undecipherable" bytecode string), but the doc > was wrong. It's now fixed. At least add-function's docstring did contain the (prog1 ...) until 92e49944a39ce6372a80430f65913c4c8b531677 started to generate the docstring. -`:after' (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r))) - ... +<<>> So we are not restoring an old bug and changing the docstring to describe the restored behavior instead of the intended but not actually implemented behavior. We unintentionally briefly changed the behavior *as well as* the documentation and have now restored both to what we had before. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 12:32:47 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 16:32:47 +0000 Received: from localhost ([127.0.0.1]:49782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk74R-0000Md-M6 for submit@debbugs.gnu.org; Thu, 28 Apr 2022 12:32:47 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk74P-0000MJ-N3; Thu, 28 Apr 2022 12:32:46 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DF374441559; Thu, 28 Apr 2022 12:32:39 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 882464412F9; Thu, 28 Apr 2022 12:32:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651163554; bh=xXZvFl67gPDMVtN8j8i+AYrY7nqCoZj+ssClFKp3EN8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=F5wW1DUxvatG6SAfjQXO3oyeHMtR66km0eTyNSikHvLqkquRCYl9XKTCAVotY0FTZ LaV6UkbA2pjKkmxkQkxgKeNHaKzg2hhhYokY3b+VaTz6et+xzKJLaf74bJWailrzwm sPjKvRZvrl35wTOU+eAChXTpq0/8f+xI+uj+0VhNDDjGbqXMG/WmlUbd5AMtkuCYXW XQZnc0OOokmWYZXUOIZYk+e7W2iTKxjac7MKHAeAFV3ga8UAWoHajPEKHK4TDzM44a RJrQFBBHNz6HIq6O7yNrpG0Yo1JV8ft/IXVx+bhAwu93mrHxi1pRQDiU3CwnulOqr3 jpxuJYKlPlHnw== Received: from alfajor (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3F0701204BC; Thu, 28 Apr 2022 12:32:34 -0400 (EDT) From: Stefan Monnier To: Jonas Bernoulli Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Message-ID: References: <87mtg5zt3a.fsf@dick> <87a6c5pkvr.fsf@gnus.org> <87a6c56xfs.fsf_-_@bernoul.li> Date: Thu, 28 Apr 2022 12:32:33 -0400 In-Reply-To: <87a6c56xfs.fsf_-_@bernoul.li> (Jonas Bernoulli's message of "Thu, 28 Apr 2022 17:26:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55149 Cc: 55161-done@debbugs.gnu.org, Lars Ingebrigtsen , 55149-done@debbugs.gnu.org, 55149@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > -`:after' (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r))) Hmm... so it was really just a plain mess up on my part! Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 18:50:00 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 22:50:00 +0000 Received: from localhost ([127.0.0.1]:50265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkCxU-0003gz-Gm for submit@debbugs.gnu.org; Thu, 28 Apr 2022 18:50:00 -0400 Received: from mail.hostpark.net ([212.243.197.30]:35930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkCxR-0003gg-LT; Thu, 28 Apr 2022 18:49:58 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id DE63D16367; Fri, 29 Apr 2022 00:49:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1651186194; bh=K7UZUWQpYwJFgk4aBcp8DELi bLlt9hYxruMH39A7Ogg=; b=X7arHWyG0fuoAa/reVuD3alB3qdA7Q+1seFVFCUM QA1HJAQ2SDZzrRQWY96xO8WxsCCpPRImRaPvlmOLKe8jef5y7cQCQwKuEy5sZDnj 1fq1VpwLEgorDK0aXH/wLAp17xbPw18IvHsm3lW+X8vDjV7Hsct558Q4eFQosKQQ zfc= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id EElpHTOqabNa; Fri, 29 Apr 2022 00:49:54 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id A97AE16379; Fri, 29 Apr 2022 00:49:54 +0200 (CEST) From: Jonas Bernoulli To: Stefan Monnier Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor In-Reply-To: References: <87mtg5zt3a.fsf@dick> <87a6c5pkvr.fsf@gnus.org> <87a6c56xfs.fsf_-_@bernoul.li> Date: Fri, 29 Apr 2022 00:49:52 +0200 Message-ID: <874k2crffz.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55149 Cc: 55161-done@debbugs.gnu.org, Lars Ingebrigtsen , 55149-done@debbugs.gnu.org, 55149@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: >> -`:after' (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r))) > > Hmm... so it was really just a plain mess up on my part! > > > Stefan That's not the part I was trying to focus on, just that the documentation always was correct (and that my use of :after didn't just work by accident). ;D Jonas From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 19:44:26 2022 Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 23:44:26 +0000 Received: from localhost ([127.0.0.1]:50314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkDo9-0007BA-Kr for submit@debbugs.gnu.org; Thu, 28 Apr 2022 19:44:25 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkDo7-0007An-M9; Thu, 28 Apr 2022 19:44:24 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 428ED10027D; Thu, 28 Apr 2022 19:44:17 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 027F9100164; Thu, 28 Apr 2022 19:44:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651189455; bh=9j2M9Hzfhs9YpuQkYPU5lv6ddUCW1swmXAyFJtkMYSM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=B1y5e0n67C8/OZeopez1eNCnGahumru5HHUaARxwG5r47P/m578D4QrggrdPL8sDs tLs3xmYMpKjDowRKj4DXp2dQGDB1q1I2SnvT5bdy85yMUNhCEFD5ilJIixuRXEKZg7 rbeh32ekweaen1A3rSCl2VAqEtGxUJmT/0/gnwP1FpzQkmlYEwfswhIK/yKL92Wbyl 4tbUbTbp9Rl44nlbiX/CtxIf2peyCU9frpRO+vqah4GCejSOKqtjxTUkxocPicIj3n 3rw6jF6E7VPoMt+L+DI0ID/ktZVL8167FQNNiqRMIE0LRIooqt7B+0oB+HSXvlDGsZ +5Cjemd6yGEPg== Received: from alfajor (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6A59012045A; Thu, 28 Apr 2022 19:44:14 -0400 (EDT) From: Stefan Monnier To: Jonas Bernoulli Subject: Re: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Message-ID: References: <87mtg5zt3a.fsf@dick> <87a6c5pkvr.fsf@gnus.org> <87a6c56xfs.fsf_-_@bernoul.li> <874k2crffz.fsf@bernoul.li> Date: Thu, 28 Apr 2022 19:44:12 -0400 In-Reply-To: <874k2crffz.fsf@bernoul.li> (Jonas Bernoulli's message of "Fri, 29 Apr 2022 00:49:52 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55149 Cc: 55161-done@debbugs.gnu.org, Lars Ingebrigtsen , 55149-done@debbugs.gnu.org, 55149@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > That's not the part I was trying to focus on, just that the > documentation always was correct (and that my use of :after > didn't just work by accident). ;D The intended semantics was very much the one you relied on, yes. And apparently, the doc reflected that :-) Stefan From unknown Fri Jun 20 07:09:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 May 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator