Subject: bug#55140: 27.1; Feature request: allow customize holidays list

From: Lars Ingebrigtsen <[email-masked]>
Date: Wed, 27 Apr 2022 18:50:56 +0200

Glenn Morris <[email-masked]> writes:

> I don't understand this request, nor the solution.
>
> list-holidays allows the list of holidays to be passed as third argument.

That doesn't really help with the interactive spec, which is what's been
changed.

> This argument defaults to the variable calendar-holidays,
> which is a defcustom. So that seems like two ways you can control
> the list of holidays?

calendar-holidays controls the "All" value.

> The solution splits the completion list used by the interactive
> prompting into a separate function. Is the misspelling "holydays"
> intentional?

Nope; fixed.

>
> "you can alter the results by redefining that function, or use
> `add-function' to all values.". The last part of that doesn't make sense.

Typo.

> And you can redefine any function in Emacs, so does this really need stating?

I think it makes sense to state that this is the intended customisation
point for users.

> But how is this any better than defining your own interactive wrapper
> function that just calls list-holidays non-interactively with the
> desired list?

That's a possibility, of course, but somewhat convoluted.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no