GNU bug report logs - #55107
[PATCH] gnu: zsh: Build and install info pages.

Previous Next

Full log

Message #8 received at 55107 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 55107 <at> debbugs.gnu.org
Subject: Re: [bug#55107] [PATCH] gnu: zsh: Build and install info pages.
Date: Wed, 27 Apr 2022 00:51:39 -0300

Hello Andrew,

This looks great. Just a couple of comments:

Andrew Tropin <andrew <at> trop.in> writes:

> [[PGP Signed Part:Undecided]]
>
> * gnu/packages/shells.scm (zsh)[arguments]: Build and install info pages.

The changelog should also mention the addition of texinfo to inputs (or
native inputs).

> @@ -522,9 +524,13 @@ (define-public zsh
>                           (("command -pv") "command -v")
>                           (("command -p") "command ")
>                           (("'command' -p") "'command' "))
> -                       #t)))))
> +                       #t))

Phases don't need to return #t anymore, so this patch would be a nice
opportunity to remove it here.

> +                   (add-after 'build 'make-info
> +                     (lambda _ (invoke "make" "info")))
> +                   (add-after 'build 'install-info
> +                     (lambda _ (invoke "make" "install.info"))))))
>      (native-inputs (list autoconf))
> -    (inputs (list ncurses pcre perl))
> +    (inputs (list ncurses pcre perl texinfo))

texinfo is a tool executed during the build process itself, so it should
be listed in native-inputs to allow cross-compilation.

-- 
Thanks
Thiago

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.