GNU bug report logs - #55086
28.1; Improve doc of set-fontset-font

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Howard Melman <hmelman <at> gmail.com>
Subject: bug#55086: closed (Re: bug#55086: 28.1; Improve doc of
 set-fontset-font)
Date: Sun, 24 Apr 2022 06:58:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#55086: 28.1; Improve doc of set-fontset-font

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 55086 <at> debbugs.gnu.org.

-- 
55086: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55086
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Howard Melman <hmelman <at> gmail.com>
Cc: 55086-done <at> debbugs.gnu.org
Subject: Re: bug#55086: 28.1; Improve doc of set-fontset-font
Date: Sun, 24 Apr 2022 09:57:27 +0300

> From: Howard Melman <hmelman <at> gmail.com>
> Date: Sat, 23 Apr 2022 17:51:21 -0400
> 
> The eldoc string for set-fontset-font in Emacs 28 is
> 
>     (NAME TARGET FONT-SPEC &optional FRAME ADD)
> 
> I found NAME and TARGET to be unhelpfully generic.  The
> docstring does say that name is the name of a fontset and
> that TARGET is about characters.
> 
> The elisp manual names the params as:
> 
>     Function: set-fontset-font name character font-spec &optional frame add
> 
> character is an improvement but it should be plural.
> 
> I think they should be the same in both places and
> this would be clearer:
> 
>     (FONTSET CHARACTERS FONT-SPEC &optional FRAME ADD)

Thanks, done.

[Message part 3 (message/rfc822, inline)]

From: Howard Melman <hmelman <at> gmail.com>
To: GNU Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 28.1; Improve doc of set-fontset-font
Date: Sat, 23 Apr 2022 17:51:21 -0400

The eldoc string for set-fontset-font in Emacs 28 is

    (NAME TARGET FONT-SPEC &optional FRAME ADD)

I found NAME and TARGET to be unhelpfully generic.  The
docstring does say that name is the name of a fontset and
that TARGET is about characters.

The elisp manual names the params as:

    Function: set-fontset-font name character font-spec &optional frame add

character is an improvement but it should be plural.

I think they should be the same in both places and
this would be clearer:

    (FONTSET CHARACTERS FONT-SPEC &optional FRAME ADD)

Howard

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.