GNU bug report logs - #55067
[PATCH] gnu: nomad-optimizer: Disable failing test.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Paul A. Patience" <paul <at> apatience.com>
Subject: bug#55067: closed (Re: bug#55067: [PATCH] gnu: nomad-optimizer:
 Disable failing test.)
Date: Tue, 26 Apr 2022 08:46:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#55067: [PATCH] gnu: nomad-optimizer: Disable failing test.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 55067 <at> debbugs.gnu.org.

-- 
55067: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55067
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: 55067-done <at> debbugs.gnu.org
Subject: Re: bug#55067: [PATCH] gnu: nomad-optimizer: Disable failing test.
Date: Tue, 26 Apr 2022 10:45:31 +0200

> * gnu/packages/maths.scm (nomad-optimizer)[arguments]: Disable the
> examples/advanced/library/PSDMads test.

Pushed, thanks Paul & Maxime!

Mathieu

[Message part 3 (message/rfc822, inline)]

From: "Paul A. Patience" <paul <at> apatience.com>
To: guix-patches <at> gnu.org
Cc: "Paul A. Patience" <paul <at> apatience.com>
Subject: [PATCH] gnu: nomad-optimizer: Disable failing test.
Date: Fri, 22 Apr 2022 16:20:36 +0000

* gnu/packages/maths.scm (nomad-optimizer)[arguments]: Disable the
examples/advanced/library/PSDMads test.
---
It turns out the PSDMads test fails randomly.
I've disabled it.

 gnu/packages/maths.scm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index f4778179d6..26488a614c 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -2008,6 +2008,9 @@ (define-public nomad-optimizer
          (add-after 'fix-sources-for-build 'fix-sources-for-tests
            (lambda _
              (substitute* "examples/CMakeLists.txt"
+               ;; This test passes only sometimes.
+               (("^ +add_subdirectory\\(\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/advanced/library/PSDMads\\)\n")
+                "")
                ;; examples/basic/batch/example3 is accidentally omitted.
                (("^(add_subdirectory\\(\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/basic/batch/example)2(\\)\n)"
                  _ prefix suffix)
@@ -2052,10 +2055,6 @@ (define-public nomad-optimizer
               "examples/advanced/library/exampleSuggestAndObserve/cache0.txt")

              (let ((builddir (string-append (getcwd) "/../build")))
-               ;; For some reason, omitting this fix causes the
-               ;; examples/advanced/library/PSDMads test to fail, even though
-               ;; it doesn't seem to reference any part of the FixedVariable
-               ;; test.
                (let ((dir "examples/advanced/library/FixedVariable"))
                  (substitute* (string-append dir "/fixedVariable.cpp")
                    (("^( +std::string sExe = ).*" _ prefix)
--
2.35.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.