From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 22 12:21:05 2022 Received: (at submit) by debbugs.gnu.org; 22 Apr 2022 16:21:05 +0000 Received: from localhost ([127.0.0.1]:54583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhw1p-0001kr-0N for submit@debbugs.gnu.org; Fri, 22 Apr 2022 12:21:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:41120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhw1n-0001ki-GD for submit@debbugs.gnu.org; Fri, 22 Apr 2022 12:21:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhw1m-0003z9-Ci for guix-patches@gnu.org; Fri, 22 Apr 2022 12:21:03 -0400 Received: from mail-4018.proton.ch ([185.70.40.18]:48581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhw1a-0002z6-9u for guix-patches@gnu.org; Fri, 22 Apr 2022 12:21:01 -0400 Date: Fri, 22 Apr 2022 16:20:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apatience.com; s=protonmail2; t=1650644447; bh=xdRZumKgmixTdpP6UxAtSKQ22SgWfuWK+01aieKuEAM=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:Feedback-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID; b=fXiSN/QL+2cBOfC6lnEcad44dpS1p3KHcLddrMwPkKs3Xa7MKWVqAWAT3ZZ1Vs7y0 IsWRPy3XnkAKfim5VKZEDd8wgyiSegHxvx4Zy7kiFDIq//tlU7hbuBCeHMo0phZUh0 BarmoAL7I17ktnsuM1jkfLVnnC5k1Szme/d+7OhWAAIng5NtttkqjPC64rpzNP7l2w WzTwUW+s+w/SYimOE3eGdVrEcSXIiRV8kyD7fYIYagShApqdxp5BjPtjawpOMJw14U 1cKW2Lqk9nlkGxRJbg7udzRvjcarnDve08AiQNdplncWRtmVCsuhTgkY0zXvZyxphc CAIw7uB0U7wEA== To: guix-patches@gnu.org From: "Paul A. Patience" Subject: [PATCH] gnu: nomad-optimizer: Disable failing test. Message-ID: <20220422162024.91287-1-paul@apatience.com> Feedback-ID: 19227857:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.18; envelope-from=paul@apatience.com; helo=mail-4018.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: "Paul A. Patience" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Paul A. Patience" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/maths.scm (nomad-optimizer)[arguments]: Disable the examples/advanced/library/PSDMads test. --- It turns out the PSDMads test fails randomly. I've disabled it. gnu/packages/maths.scm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index f4778179d6..26488a614c 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -2008,6 +2008,9 @@ (define-public nomad-optimizer (add-after 'fix-sources-for-build 'fix-sources-for-tests (lambda _ (substitute* "examples/CMakeLists.txt" + ;; This test passes only sometimes. + (("^ +add_subdirectory\\(\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/= advanced/library/PSDMads\\)\n") + "") ;; examples/basic/batch/example3 is accidentally omitted. (("^(add_subdirectory\\(\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/b= asic/batch/example)2(\\)\n)" _ prefix suffix) @@ -2052,10 +2055,6 @@ (define-public nomad-optimizer "examples/advanced/library/exampleSuggestAndObserve/cache0.t= xt") (let ((builddir (string-append (getcwd) "/../build"))) - ;; For some reason, omitting this fix causes the - ;; examples/advanced/library/PSDMads test to fail, even tho= ugh - ;; it doesn't seem to reference any part of the FixedVariab= le - ;; test. (let ((dir "examples/advanced/library/FixedVariable")) (substitute* (string-append dir "/fixedVariable.cpp") (("^( +std::string sExe =3D ).*" _ prefix) -- 2.35.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 22 12:30:50 2022 Received: (at 55067) by debbugs.gnu.org; 22 Apr 2022 16:30:50 +0000 Received: from localhost ([127.0.0.1]:54590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhwBB-00023H-Un for submit@debbugs.gnu.org; Fri, 22 Apr 2022 12:30:50 -0400 Received: from mail-40136.proton.ch ([185.70.40.136]:46678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhwBA-000234-Ia for 55067@debbugs.gnu.org; Fri, 22 Apr 2022 12:30:45 -0400 Date: Fri, 22 Apr 2022 16:30:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apatience.com; s=protonmail2; t=1650645034; bh=ZN3oV872C4UzpdFX1enwZ68BjoLFNWD2RePaYsxsy+c=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:Feedback-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID; b=FhgXdXnhZHa4FNShS7OSqKmswYUzYNYXdehCTJu4geSz/IR/VFr10IFzx0q5SF3Vz sg/Y+1opIklTuCorppjxwka8LF200zKXRCSG9/yoJcg0aOSfU30XgK4tw/u0Ox7hef CwISPuYSUlG7VwDSvuAcYgHleBIZnZ/sCocaTCeYs/lXB/nX26aOr/4EnF28xHcG0u dp0yTfL9xT5v0ROfSqiGNOjm/TLgiXX0SmeAtlBDUGRG/1xpMYOy9bNPhQzT3Ww+XP kOT397Z05ytfXLeT9Dr1jKb3ecY6EAtschE9/TKzJABA+3q/wweuOHN1HL0Hrd3Vsl 0IEzz7ed8c9ng== To: 55067@debbugs.gnu.org From: "Paul A. Patience" Subject: [PATCH v2] gnu: nomad-optimizer: Disable failing test. Message-ID: <20220422163021.92454-1-paul@apatience.com> Feedback-ID: 19227857:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55067 Cc: "Paul A. Patience" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Paul A. Patience" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/maths.scm (nomad-optimizer)[arguments]: Disable the examples/advanced/library/PSDMads test. --- Just updating the copyright header too. gnu/packages/maths.scm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index f4778179d6..190b62fca1 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -45,7 +45,7 @@ ;;; Copyright =C2=A9 2021 Gerd Heber ;;; Copyright =C2=A9 2021 Franck P=C3=A9rignon ;;; Copyright =C2=A9 2021 Philip McGrath -;;; Copyright =C2=A9 2021 Paul A. Patience +;;; Copyright =C2=A9 2021-2022 Paul A. Patience ;;; Copyright =C2=A9 2021 Ivan Gankevich ;;; Copyright =C2=A9 2021 Jean-Baptiste Volatier ;;; Copyright =C2=A9 2021 Guillaume Le Vaillant @@ -2008,6 +2008,9 @@ (define-public nomad-optimizer (add-after 'fix-sources-for-build 'fix-sources-for-tests (lambda _ (substitute* "examples/CMakeLists.txt" + ;; This test passes only sometimes. + (("^ +add_subdirectory\\(\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/= advanced/library/PSDMads\\)\n") + "") ;; examples/basic/batch/example3 is accidentally omitted. (("^(add_subdirectory\\(\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/b= asic/batch/example)2(\\)\n)" _ prefix suffix) @@ -2052,10 +2055,6 @@ (define-public nomad-optimizer "examples/advanced/library/exampleSuggestAndObserve/cache0.t= xt") (let ((builddir (string-append (getcwd) "/../build"))) - ;; For some reason, omitting this fix causes the - ;; examples/advanced/library/PSDMads test to fail, even tho= ugh - ;; it doesn't seem to reference any part of the FixedVariab= le - ;; test. (let ((dir "examples/advanced/library/FixedVariable")) (substitute* (string-append dir "/fixedVariable.cpp") (("^( +std::string sExe =3D ).*" _ prefix) -- 2.35.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 22 13:25:31 2022 Received: (at 55067) by debbugs.gnu.org; 22 Apr 2022 17:25:31 +0000 Received: from localhost ([127.0.0.1]:54603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhx2B-0003U7-1n for submit@debbugs.gnu.org; Fri, 22 Apr 2022 13:25:31 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:46154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhx29-0003Ty-1l for 55067@debbugs.gnu.org; Fri, 22 Apr 2022 13:25:29 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by xavier.telenet-ops.be with bizsmtp id MtRT270044UW6Th01tRTWg; Fri, 22 Apr 2022 19:25:27 +0200 Message-ID: <3fca716b728e196be715326f84c51d2e90e29eef.camel@telenet.be> Subject: Re: [bug#55067] [PATCH] gnu: nomad-optimizer: Disable failing test. From: Maxime Devos To: "Paul A. Patience" , 55067@debbugs.gnu.org Date: Fri, 22 Apr 2022 19:25:20 +0200 In-Reply-To: <20220422162024.91287-1-paul@apatience.com> References: <20220422162024.91287-1-paul@apatience.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-YnTCW9eP0VT+anWKLX/V" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1650648327; bh=ulu0fiOoqzsCFgMqO0bTINQKg1jp97l0fZkAGngPAy0=; h=Subject:From:To:Date:In-Reply-To:References; b=DxRR8JHvsv56F8PrWvpo3LJKSFBdyqztWDyoQffxs5QiqkzAmKXOxYMdmvKjZcuKI MR9pdVWoAm0oBId78OCbI+mTCPpA0+Pw9UeJ9P3DJFs6+h6gkJ/KuEBDAui82SZPMu b7L1nuRti4lQ9jMrzQPcFrbHAtsNjXEfeDgGOMCQb+vgGPbrVQyxKKriioFDhjYJgA obk6nygpsZOnvDV9RmvzA3QvUCxSu2Ew4lRCRVwkNA6z9dbO4sQX8YOlPkRrWOG+OG Z2kTbwNAKVb6RpfL+miEEcn4uEl66cE3G+IzWcGDxJV+SgEGc2blYTgRc2KUNh7t5F MX2wNbgKPTFhg== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55067 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-YnTCW9eP0VT+anWKLX/V Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Paul A. Patience schreef op vr 22-04-2022 om 16:20 [+0000]: > --- > It turns out the PSDMads test fails randomly. Sounds like a bug, preferably it would 100% reliably report the underlying problem, whatever it is. > I've disabled it. I don't think this is a good reason to disable the test. Disabling tests whenever they fail defeats the point of tests. Cf. with, say, clinical trials for testing safety of new medical treatments. If some drug fails one of the tests (sometimes or always), then one cannot simply ignore the test. Greetings, Maxime. --=-YnTCW9eP0VT+anWKLX/V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmLlABccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hwiAQDwX5SoHl+wjcDbNijThzY3OQ96 qAOIGOXiQXf0puSCBwEAjPVDiqUo1xBiAHZUgg4ykSnzvXk/mwuiyCFDtJkfLgw= =xbPW -----END PGP SIGNATURE----- --=-YnTCW9eP0VT+anWKLX/V-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 22 15:02:47 2022 Received: (at 55067) by debbugs.gnu.org; 22 Apr 2022 19:02:47 +0000 Received: from localhost ([127.0.0.1]:54681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhyYJ-0005xy-Lc for submit@debbugs.gnu.org; Fri, 22 Apr 2022 15:02:47 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:11743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhyYH-0005xk-PN for 55067@debbugs.gnu.org; Fri, 22 Apr 2022 15:02:47 -0400 Date: Fri, 22 Apr 2022 19:02:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apatience.com; s=protonmail2; t=1650654158; bh=YDGGFNajv9OYLPdy9cwEgKcEN6zUpuW3VBR4anQ30/c=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=FT2WzdntXayG6516mCeIb7lZ4H0LBPazeh18x/u+bI3VXejOEi6LGSWH6sP2cjV6+ F/luyOVJ83Mzws5NOm0SPmN4D701GDux6tc/k9EBaFcxLgmVBK0TQuWU1841kOCjOm hZVBG4DFGCeMq5LiE4Q7n0YzMUk4aAESeWTU1efHKuxuaN8bHBI5iyeJZLwynZKFwZ a+c89HxO0eVhMTuXMTk3OkeXOMPAPtzojiLyZBy9BbirEKQV8u+rUPDOdir7CRYtFm MO/f2nKTODA6iMlB4k6iUf/34hobSL47euVNVcF2rXkgvWRklV3M+cNxUA0sTBwAmX WO0d25AoBN+/Q== To: Maxime Devos From: "Paul A. Patience" Subject: Re: [bug#55067] [PATCH] gnu: nomad-optimizer: Disable failing test. Message-ID: <87ee1pne56.fsf@apatience.com> In-Reply-To: <3fca716b728e196be715326f84c51d2e90e29eef.camel@telenet.be> References: <20220422162024.91287-1-paul@apatience.com> <3fca716b728e196be715326f84c51d2e90e29eef.camel@telenet.be> Feedback-ID: 19227857:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55067 Cc: 55067@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Paul A. Patience" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2022-04-22 13:25:20-04:00, Maxime Devos wrote: >> It turns out the PSDMads test fails randomly. > > Sounds like a bug, preferably it would 100% reliably report the > underlying problem, whatever it is. I agree with you, and I have already reported the issue to the developers (along with some other issues that I addressed in the package definition). >> I've disabled it. > > I don't think this is a good reason to disable the test. > Disabling tests whenever they fail defeats the point of tests. This test failure wasn't getting detected in the past due to a missing "set -o pipefail" in the test runner, which could explain why it was missed by the developers. I don't know enough to fix the bug myself, but I have a suspicion it is a bug in the test rather than in the library. Best regards, Paul From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 22 17:37:32 2022 Received: (at 55067) by debbugs.gnu.org; 22 Apr 2022 21:37:32 +0000 Received: from localhost ([127.0.0.1]:54783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ni0y3-0004Ln-QF for submit@debbugs.gnu.org; Fri, 22 Apr 2022 17:37:31 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:56526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ni0y0-0004LY-LH for 55067@debbugs.gnu.org; Fri, 22 Apr 2022 17:37:29 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id MxdS2700D4UW6Th06xdSvT; Fri, 22 Apr 2022 23:37:26 +0200 Message-ID: <4ca2b6316466f8d2c64b5f5892cc70fcd5533130.camel@telenet.be> Subject: Re: [bug#55067] [PATCH] gnu: nomad-optimizer: Disable failing test. From: Maxime Devos To: "Paul A. Patience" Date: Fri, 22 Apr 2022 23:37:21 +0200 In-Reply-To: <87ee1pne56.fsf@apatience.com> References: <20220422162024.91287-1-paul@apatience.com> <3fca716b728e196be715326f84c51d2e90e29eef.camel@telenet.be> <87ee1pne56.fsf@apatience.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-W8b7NfgmYVaIetC2t//f" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1650663447; bh=VzjJzD1UB954Appi0TBLkQaP0sgoLZ1lGDfcqKXEjes=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=AszRGiNNywmDqMNtuqmbJCNvudYcS8iu1P0VcodApIbkxhDGoRGdgA+k6fSUwAlZq bJ/UihblRILjh6BeR47pueTZu06lPHC7fthbeTo8B6wGnnZ2hlZdqWbrIRFy8xXLLD eHtlvetER4CStpVMWzKYQnmjb4kKGWwEyWDR4FtZwMmBInn7CSgv5j0rviG+qA0aC1 03h31my80aL8/YMCRkBmZfgp/Yu2/gnND1td/UCjnrghlATdpKUE2V9JB6OamGlo4V p9H5Zwbz7crbc4YRiAF3U6G/QOvojdU1i7YriqVpl/wizvRWeN5TKnJEcK5bub53sK ILJ3bljNizX3Q== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55067 Cc: 55067@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-W8b7NfgmYVaIetC2t//f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Paul A. Patience schreef op vr 22-04-2022 om 19:02 [+0000]: > On 2022-04-22 13:25:20-04:00, Maxime Devos wrote: > > > It turns out the PSDMads test fails randomly. > >=20 > > Sounds like a bug, preferably it would 100% reliably report the > > underlying problem, whatever it is. >=20 > I agree with you, and I have already reported the issue to the > developers (along with some other issues that I addressed in the package > definition). Then I recommend adding a link to the upstream report (in a comment), such that at the next update we know where to check if it has been resolved, and to avoid giving the impression that just skipping tests is acceptable. Greetings, Maxime. --=-W8b7NfgmYVaIetC2t//f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmMgERccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7v0ZAP9NqvGlqBERPkhuSCvo5l1FHave Pw1y7Hf+93yJnuxEogEA+Vdkh3AG71PjK9dG1Yuav0E9Dz6OSnWg18WYW6ImLgg= =Bm64 -----END PGP SIGNATURE----- --=-W8b7NfgmYVaIetC2t//f-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 25 15:10:33 2022 Received: (at 55067) by debbugs.gnu.org; 25 Apr 2022 19:10:33 +0000 Received: from localhost ([127.0.0.1]:36114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nj46P-0003ai-4m for submit@debbugs.gnu.org; Mon, 25 Apr 2022 15:10:33 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:45268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nj46L-0003aQ-7N for 55067@debbugs.gnu.org; Mon, 25 Apr 2022 15:10:27 -0400 Date: Mon, 25 Apr 2022 19:10:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apatience.com; s=protonmail2; t=1650913817; bh=+7TSYqpu1sbx7Kx0XaoUbbs2c78EMH5c1cOjviKV12k=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:Feedback-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID; b=DSdgzRE0MCt7tc68cedM4GRJRNw+3EW8ABroQQhbG8YUKzKdoLWGS6MAUuHw+7Pud JzFLmZr22f3O+fW/5DxuA9khw794A6YWFfQfsZJgGGLL5tTOtKAtoolScsUd1tLEiR OvG/lspzcKg0CTdr2VA7XMOhq5k9USHnwoRCZU4M+VkWo4l7myvb89gZVBUpn7ujaV WDO0g25IJCYrm4ID0148w3o30+A61PPQ4W+H2T+2h3JN6STdMOiMyRXh649AyaCRsX EqkWxbE0fsFxtjdbf1Q3lqCGA5MeN9mT+KatgVWlBQhmnyfRHbq08zn+8Rgpz/h2qi 5nZdhQfimx9hg== To: 55067@debbugs.gnu.org From: "Paul A. Patience" Subject: [PATCH v3] gnu: nomad-optimizer: Disable failing test. Message-ID: <20220425191002.58325-1-paul@apatience.com> Feedback-ID: 19227857:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55067 Cc: "Paul A. Patience" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Paul A. Patience" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/maths.scm (nomad-optimizer)[arguments]: Disable the examples/advanced/library/PSDMads test. --- I've added a link to the issue I opened upstream regarding this failing tes= t, as suggested by Maxime Devos. gnu/packages/maths.scm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index f4778179d6..448cdb4d73 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -45,7 +45,7 @@ ;;; Copyright =C2=A9 2021 Gerd Heber ;;; Copyright =C2=A9 2021 Franck P=C3=A9rignon ;;; Copyright =C2=A9 2021 Philip McGrath -;;; Copyright =C2=A9 2021 Paul A. Patience +;;; Copyright =C2=A9 2021-2022 Paul A. Patience ;;; Copyright =C2=A9 2021 Ivan Gankevich ;;; Copyright =C2=A9 2021 Jean-Baptiste Volatier ;;; Copyright =C2=A9 2021 Guillaume Le Vaillant @@ -2008,6 +2008,10 @@ (define-public nomad-optimizer (add-after 'fix-sources-for-build 'fix-sources-for-tests (lambda _ (substitute* "examples/CMakeLists.txt" + ;; This test passes only sometimes. + ;; See https://github.com/bbopt/nomad/issues/72. + (("^ +add_subdirectory\\(\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/= advanced/library/PSDMads\\)\n") + "") ;; examples/basic/batch/example3 is accidentally omitted. (("^(add_subdirectory\\(\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/b= asic/batch/example)2(\\)\n)" _ prefix suffix) @@ -2052,10 +2056,6 @@ (define-public nomad-optimizer "examples/advanced/library/exampleSuggestAndObserve/cache0.t= xt") (let ((builddir (string-append (getcwd) "/../build"))) - ;; For some reason, omitting this fix causes the - ;; examples/advanced/library/PSDMads test to fail, even tho= ugh - ;; it doesn't seem to reference any part of the FixedVariab= le - ;; test. (let ((dir "examples/advanced/library/FixedVariable")) (substitute* (string-append dir "/fixedVariable.cpp") (("^( +std::string sExe =3D ).*" _ prefix) -- 2.35.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 04:45:42 2022 Received: (at 55067-done) by debbugs.gnu.org; 26 Apr 2022 08:45:42 +0000 Received: from localhost ([127.0.0.1]:37011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njGpK-0003Ra-KQ for submit@debbugs.gnu.org; Tue, 26 Apr 2022 04:45:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njGpI-0003RN-Px for 55067-done@debbugs.gnu.org; Tue, 26 Apr 2022 04:45:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56616) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njGpD-00080E-Cr; Tue, 26 Apr 2022 04:45:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=KoPbKN1lzA/9YHUh0/L+YcKA3GpSc8D2sWrb0BGXao0=; b=MJeqsZfqCGUWzLnatWVV 1WLIIcMXVr9yIC7lSRnXuf0D98ITgGPFwUf40g83ggFuYW72i73z/j2QsX8sVgDchYqK2OolfIR9h 5MPdEYTFJwlrS72Eks7jXRcEWALJD/wvWI7kcE5TiT9UPAneWEQql76cfAJsWl+jC51cw22qrtink AK7EdPZ07nU8qW4qxIIbhNhVNm0zEfe2gjvwXlEd/Y/XrEypL4K8/u754wZGyxny1jyXLSeW0Fzgu 89+fpeXbVqx+3r8ik1dF0S3TK6xvMhIIcnxJNWrguYsXcv6ymWeL0cuhjHDbMbTOQO8EDWJE3SrF7 A3InR1OMS+lAvA==; Received: from 71.125.192.77.rev.sfr.net ([77.192.125.71]:42308 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njGpC-0006X5-GG; Tue, 26 Apr 2022 04:45:34 -0400 From: Mathieu Othacehe To: "Paul A. Patience" Subject: Re: bug#55067: [PATCH] gnu: nomad-optimizer: Disable failing test. References: <20220422162024.91287-1-paul@apatience.com> <20220425191002.58325-1-paul@apatience.com> Date: Tue, 26 Apr 2022 10:45:31 +0200 In-Reply-To: <20220425191002.58325-1-paul@apatience.com> (Paul A. Patience's message of "Mon, 25 Apr 2022 19:10:10 +0000") Message-ID: <878rrsw7v8.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55067-done Cc: 55067-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > * gnu/packages/maths.scm (nomad-optimizer)[arguments]: Disable the > examples/advanced/library/PSDMads test. Pushed, thanks Paul & Maxime! Mathieu From unknown Sat Jun 21 10:40:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 24 May 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator