GNU bug report logs - #55056
[PATCH] Delete temporary Flymake Elisp files

Previous Next

Full log

Message #8 received at 55056 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 55056 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#55056: [PATCH] Delete temporary Flymake Elisp files
Date: Fri, 22 Apr 2022 13:43:38 +0200

Philip Kaludercic <philipk <at> posteo.net> writes:

> The below patch adds a check to the sentinel to do so.  I was a bit
> paranoid and considered more process-states that might be necessary, but
> I hope that someone with a better understanding of the process interface
> will be able to help here.

[...]

> +          (when (memq (process-status proc) '(failed closed signal))
> +            (message "Elisp flymake [%s]: %S" (buffer-file-name) (process-status proc))
> +            (ignore-errors (delete-file temp-file))
> +            (kill-buffer output-buffer)))

I'm not very familiar with the flymake machinery, but isn't the problem
a bit further up?  That is:

        :sentinel
        (lambda (proc _event)
          (when (eq (process-status proc) 'exit)

Shouldn't that just be (unless (process-live-p proc) ...)?

Perhaps João has a comment; added to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.