From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 20 10:19:49 2022 Received: (at submit) by debbugs.gnu.org; 20 Apr 2022 14:19:49 +0000 Received: from localhost ([127.0.0.1]:46989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhBBN-000519-7U for submit@debbugs.gnu.org; Wed, 20 Apr 2022 10:19:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:40618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhBBL-000511-3b for submit@debbugs.gnu.org; Wed, 20 Apr 2022 10:19:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhBBK-0002qa-Ts for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2022 10:19:46 -0400 Received: from mout01.posteo.de ([185.67.36.65]:43029) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhBBI-0004xi-Km for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2022 10:19:46 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 672A6240026 for ; Wed, 20 Apr 2022 16:19:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1650464382; bh=1pNd4AEQ98EmgAqkZAlVyRFp539jMPB42Bvwfdye9iA=; h=From:To:Subject:Autocrypt:Date:From; b=iF08St16U7OTl1XAwG/Nkw+u0fA/49NIxoFlW6L3e8KnrsWiDUuokWh1PsRR8nYaY 611kWg7Ed6Dpz9nm8vovf1DNJwzqpgxq/EcHHjs/KFcvIoqZN+UiBxTmi5vZJOsQ3d Gi9K9CIPleVourCFW7eFuCsnepvY+nBEZ6c9QMV92h/IGpVj2dvsYy5RaW3sIoYoVi MEMLvx4rJCAr+vOUfqw09+knR65DUUEysBa3o5GehQMnh95nwpF3tY5WbUW7zVyP6v yCnfhNIbCrWzXoBDH5W5jy2ncW5/B+vAIBSW7r41RgYlvrPc5byMiDY7zqpzsCVJy3 H0XZGstkOQU/A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Kk2qd5n0Nz9rxM for ; Wed, 20 Apr 2022 16:19:41 +0200 (CEST) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: [PATCH] Use VC-relative file names in ChangeLog entries Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Wed, 20 Apr 2022 14:19:39 +0000 Message-ID: <8735i7zvk4.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch By default C-c C-w (log-edit-generate-changelog-from-diff) just uses the file name when generating a changelog message. As it has been requested to use the project relative path name when writing changelog messages, it seems to make sense to generate these automatically as well. Alternatively, this could also be configured using a directory local variable that would be set for emacs.git. In GNU Emacs 29.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0) of 2022-04-19 built on viero Repository revision: d168decab4a03cd48b8b96257c36ffa575c720e6 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Guix System Configured using: 'configure PKG_CONFIG_PATH=/home/philip/.guix-profile/lib/pkgconfig:/home/philip/.guix-profile/share/pkgconfig' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Use-VC-relative-file-names-in-ChangeLog-entries.patch >From f3f87cab56d1bc1754d9e83a9dd53d0cb48c02b0 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Tue, 30 Nov 2021 21:05:42 +0100 Subject: [PATCH] Use VC-relative file names in ChangeLog entries * lisp/vc/diff-mode.el (diff-add-log-current-defuns): Check vc-root-dir to prepend the project path to the file being modified. See https://mail.gnu.org/archive/html/emacs-devel/2021-11/msg02195.html --- lisp/vc/diff-mode.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el index 057ffcd06e..40749754d8 100644 --- a/lisp/vc/diff-mode.el +++ b/lisp/vc/diff-mode.el @@ -2343,7 +2343,10 @@ diff-add-log-current-defuns ;; hunks (e.g., "diff --git ..." etc). (re-search-forward diff-hunk-header-re nil t) (setq hunk-end (save-excursion (diff-end-of-hunk))) - (pcase-let* ((filename (substring-no-properties (diff-find-file-name))) + (pcase-let* ((filename (substring-no-properties + (file-relative-name + (diff-find-file-name) + (vc-root-dir)))) (=lines 0) (+lines 0) (-lines 0) -- 2.34.0 --=-=-= Content-Type: text/plain -- Philip Kaludercic --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 20 12:01:29 2022 Received: (at 55039) by debbugs.gnu.org; 20 Apr 2022 16:01:29 +0000 Received: from localhost ([127.0.0.1]:47145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhCll-0003oh-BT for submit@debbugs.gnu.org; Wed, 20 Apr 2022 12:01:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhClj-0003oI-19 for 55039@debbugs.gnu.org; Wed, 20 Apr 2022 12:01:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38384) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhCld-0005Im-7M; Wed, 20 Apr 2022 12:01:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4m62aEZIDeXFxShsKNSP1oyFo2erKLBR5U3Q2nUJ4ME=; b=audijRnhrS+i 1/5KKRiHv2EoAnZKQVZg1s/VT1i1qjWCenEY79qjH3/v15FYGBrymf75CRJp2LjesOIvTHhrszkMi tM4oU8+TW67BPwGsZ49lxbU3btInmufjU1YT1J6ENZ2+8KfuaO1ciyaoUfKdZtOe6dzf9aBF9OWxC 8IKFAW1p2sxbDf71wMu8DdSvnKMjHJ2/FsU9gjy6z6nXlTmFzv6IZSiROJOqWVmJmy4ktMAa4TY+z /f6c6rdtnyGl2k/rhLt0KP5gSvyQaN6WcHEXkE5LIHZPAp8K2yCz+zWgqGw1eIIPJJ/pzR//Hkm2W N7hcQA9qPa2gT7lxApRGrQ==; Received: from [87.69.77.57] (port=1263 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhClb-000527-RX; Wed, 20 Apr 2022 12:01:20 -0400 Date: Wed, 20 Apr 2022 19:01:12 +0300 Message-Id: <83v8v3sq0n.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <8735i7zvk4.fsf@posteo.net> (message from Philip Kaludercic on Wed, 20 Apr 2022 14:19:39 +0000) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Date: Wed, 20 Apr 2022 14:19:39 +0000 > > By default C-c C-w (log-edit-generate-changelog-from-diff) just uses the > file name when generating a changelog message. As it has been requested > to use the project relative path name when writing changelog messages, > it seems to make sense to generate these automatically as well. > > Alternatively, this could also be configured using a directory local > variable that would be set for emacs.git. First, I think this must be customizable, because different projects have different conventions. Second, I think the code should DTRT if there's already a ChangeLog file in the current directory or in one of its parent directories, because those usually show you the project's conventions. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 21 23:03:43 2022 Received: (at 55039) by debbugs.gnu.org; 22 Apr 2022 03:03:43 +0000 Received: from localhost ([127.0.0.1]:51192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhjaB-0007MW-0u for submit@debbugs.gnu.org; Thu, 21 Apr 2022 23:03:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhja6-0007MC-5b for 55039@debbugs.gnu.org; Thu, 21 Apr 2022 23:03:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhja0-0008IK-Mc; Thu, 21 Apr 2022 23:03:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=arXBYXDiehmuI7zHQhRZXFuOHpclfZEHNK5KjjdAAUM=; b=mxvxAKx/67hS Zt8gRF1BRt7xp8p2dPmZfTbzxewlUBFEbXEgehgRdYl39XwmIWszTudPJ0ywQb6MMbGXgqz7BkSbW B2njHOGuOQY0knmC7yfoI/DX6YXJMPnIn4CQ4OQDuhZyVB+qqUxMqufTkLH/vqcVAyBTUG7zXDgdU m0KeMefkHKaI7l8uS7sapSk/Lz3b1DxGSdxk+fw5ohIRIPSG17Rf5SkvH2oIOPK1xVlf0ekZtaBd7 fUmsAQY5V+86IWUEO2d5b3qGwOKQ80xSSQAMXB8fQPomlduNkHNRRpaXjWXg9dJ/co+x6IUcrLcJ7 AtUcuLiGBQH/n+Q4YkAsUg==; Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1nhja0-0004ol-ET; Thu, 21 Apr 2022 23:03:32 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Philip Kaludercic In-Reply-To: <8735i7zvk4.fsf@posteo.net> (message from Philip Kaludercic on Wed, 20 Apr 2022 14:19:39 +0000) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> Message-Id: Date: Thu, 21 Apr 2022 23:03:32 -0400 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] We used to have a ChangeLog file for each important directory in Emacs (src, lisp, etc, lib-src, and so on). I hope we still do, as a single ChangeLog for all of Emacs would be very long and thus cumbersome. In these ChangeLog files, we should delete the directory names which are superfluous. Thus, when generating src/ChangeLog, we should delete `src/' from the start of the source file names in the entries. Do we do that? Would this patch require changes in that? -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 22 01:30:04 2022 Received: (at 55039) by debbugs.gnu.org; 22 Apr 2022 05:30:04 +0000 Received: from localhost ([127.0.0.1]:51298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhlrn-0002pN-Ti for submit@debbugs.gnu.org; Fri, 22 Apr 2022 01:30:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhlrm-0002oJ-I7 for 55039@debbugs.gnu.org; Fri, 22 Apr 2022 01:30:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhlrh-0003tB-AS; Fri, 22 Apr 2022 01:29:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BseT9Q2kNn983L/ITzFkZs6y4q2qh1tlGmHPjWy85w8=; b=j7aG9rwz1J52 5NletkunjIs9lGXdiYHnQ7rGUWmhuB5cZPcvH4dzY+aXngFdGdfNizPlc73LX+FxQlXk9Iowp/yL5 ncf+Zuz/fdQu5Hq1qjRJMugsVsfyqdviBkJAm4sYHyO1YD3WqaCSiOsU4Zo2oAOOsChs9funmNSUs LcLIZfCm5MmG4OlYjAC4nFmbsYKzRnCHE1aK4y226zLi0+sEc0aiSIMnvy5b93NbQunUxDjKz3WjV dbd1vh81FLToh3b2Qu98OBf9f8UxVyK2zizhIXiBX1GC3LodWWPU4EgBMJkObHPDO5s8BLhNEAMk2 Hy2W3NZSbmNZ7Vk9fdR5Sw==; Received: from [87.69.77.57] (port=1978 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhlre-00038Y-Bq; Fri, 22 Apr 2022 01:29:54 -0400 Date: Fri, 22 Apr 2022 08:29:51 +0300 Message-Id: <834k2lr8hc.fsf@gnu.org> From: Eli Zaretskii To: rms@gnu.org In-Reply-To: (message from Richard Stallman on Thu, 21 Apr 2022 23:03:32 -0400) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: philipk@posteo.net, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Richard Stallman > Date: Thu, 21 Apr 2022 23:03:32 -0400 > Cc: 55039@debbugs.gnu.org > > We used to have a ChangeLog file for each important directory > in Emacs (src, lisp, etc, lib-src, and so on). > I hope we still do, as a single ChangeLog for all of Emacs > would be very long and thus cumbersome. We nowadays have a single ChangeLog for all of Emacs, which is produced from the Git commit logs. We start a new ChangeLog from time to time, to keep the file from growing too much, but that's all. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 22 23:46:45 2022 Received: (at 55039) by debbugs.gnu.org; 23 Apr 2022 03:46:45 +0000 Received: from localhost ([127.0.0.1]:54972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ni6jD-0005M3-Vy for submit@debbugs.gnu.org; Fri, 22 Apr 2022 23:46:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ni6jB-0005Lo-Ny for 55039@debbugs.gnu.org; Fri, 22 Apr 2022 23:46:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ni6j6-0006HL-7b; Fri, 22 Apr 2022 23:46:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=oFGCZBd112/Ou4rNO1CDydOycJSzYGfzsdNlUnFwY7c=; b=pCP7KIJIbPT/ neveXWHUoCQgbiTq0QffGKCt/F8CQHjilzFmbVOZ7C0jpYJNfGr9OG+wVKPx+1gNgkLm2KovDspTT UbByYIC1X3dCz/mvtz73m9O8XuaCl0cCwLa+i/nDlDZZEtLTlGjzCbGxHuZZ196qqpmGjtztiCItZ J2xUGFOth+Zq6E2ujUxecOHf2G+KzE9X5rViABnIty7Ar9touCSX7jGouLpBpoqGpOV0zsMnEGaiP 3p3Ndp3Hr+2bjY17ukfoWco5sPvgvFJcfH9lAaeAdsz2B6VEK0TgE0wkR+5lvrrpjyYMlQamfCDMp iANJYW76bl8zWaCBiq6MUw==; Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1ni6j5-0008SH-Kd; Fri, 22 Apr 2022 23:46:27 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Eli Zaretskii In-Reply-To: <834k2lr8hc.fsf@gnu.org> (message from Eli Zaretskii on Fri, 22 Apr 2022 08:29:51 +0300) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <834k2lr8hc.fsf@gnu.org> Message-Id: Date: Fri, 22 Apr 2022 23:46:27 -0400 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: philipk@posteo.net, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > We nowadays have a single ChangeLog for all of Emacs, which is > produced from the Git commit logs. We start a new ChangeLog from time > to time, to keep the file from growing too much, but that's all. Do you find it inconvenient to put all directories into a single ChangeLog file? I would expect it to be inconvenient, but I don't have actual experience using these files. -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 23 02:17:17 2022 Received: (at 55039) by debbugs.gnu.org; 23 Apr 2022 06:17:17 +0000 Received: from localhost ([127.0.0.1]:55018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ni953-0001HT-3D for submit@debbugs.gnu.org; Sat, 23 Apr 2022 02:17:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ni951-0001HI-Q6 for 55039@debbugs.gnu.org; Sat, 23 Apr 2022 02:17:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ni94w-0000Ng-Gf; Sat, 23 Apr 2022 02:17:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VO2QyogoAkg7fTod9rrus8/e+gucscs5CxbsAgRrHXw=; b=KIx5pFHAs0cx dSySaUsOADN1ostoJw7miry9ZU3kejS/ks8oITGKDa+pdo1C8irCIoiafQ5ohCJA+ZjJPk05HfAz5 VAIMO0rsZyeVr4XBBZ5ItcB1dOtfcU70cS3g5luCr0X3C9BJS/MMYd4WxsOcW1+PK32fBGO2DSuU3 ube/YxyIXZvc8zQ/VIvHi+mYFCDCyZlP2yOS45GmbUxf4T7nrrLxoPH3yTkZ2/6h6dSfKi+xVqNRR uqcaBw7Y6IWGkXa95WIT1ln7RGx9r07gze3zx3/Fnou1uWThLye67P9f0XTUiE++oQhHRAF6m6Rer Vzf2K7nC2CBekt2xPJlbFA==; Received: from [87.69.77.57] (port=4611 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ni94n-0003EO-ER; Sat, 23 Apr 2022 02:17:02 -0400 Date: Sat, 23 Apr 2022 09:17:02 +0300 Message-Id: <83ee1opbmp.fsf@gnu.org> From: Eli Zaretskii To: rms@gnu.org In-Reply-To: (message from Richard Stallman on Fri, 22 Apr 2022 23:46:27 -0400) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <834k2lr8hc.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: philipk@posteo.net, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Richard Stallman > Cc: philipk@posteo.net, 55039@debbugs.gnu.org > Date: Fri, 22 Apr 2022 23:46:27 -0400 > > > We nowadays have a single ChangeLog for all of Emacs, which is > > produced from the Git commit logs. We start a new ChangeLog from time > > to time, to keep the file from growing too much, but that's all. > > Do you find it inconvenient to put all directories into a single > ChangeLog file? No, not really. We do that now for a long time, so I'm used to it nowadays. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 07:13:13 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 11:13:13 +0000 Received: from localhost ([127.0.0.1]:49811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVWW0-0006OQ-TQ for submit@debbugs.gnu.org; Tue, 06 Sep 2022 07:13:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVWVz-0006OB-G6 for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 07:13:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1LuSpiHGB4R6C3blcuzwTz7m5dKeep9jAdLoPFF3mwg=; b=DVipvRH6aNAmQUc1cRIXBdqEgB YNyyWnvYMXhNQ+dpeLosnHKD421whhD/DgcyAsU1Cc3QixoksF6qgxXmLBAlsvnLYIVQgIHDDWbHy jSsOfQS/nv4xbG5kEd9Dm2pqxA/U3kKyc63rKjM5oA6OnA856RMtah/7Bpg9/lOGDSCs=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVWVp-0003vt-Tf; Tue, 06 Sep 2022 13:13:04 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <83v8v3sq0n.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Apr 2022 19:01:12 +0300") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> X-Now-Playing: David Bowie's _"Heroes"_: "Sense Of Doubt" Date: Tue, 06 Sep 2022 13:13:01 +0200 Message-ID: <87czc8u56q.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > First, I think this must be customizable, because different projects > have different conventions. This was several months ago -- Philip, did you do any further work in this direction? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Philip Kaludercic , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > First, I think this must be customizable, because different projects > have different conventions. This was several months ago -- Philip, did you do any further work in this direction? > Second, I think the code should DTRT if there's already a ChangeLog > file in the current directory or in one of its parent directories, > because those usually show you the project's conventions. This would be a separate issue, though? (And I agree that it would be nice to have, but it doesn't sound trivial to implement.) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 07:13:16 2022 Received: (at control) by debbugs.gnu.org; 6 Sep 2022 11:13:16 +0000 Received: from localhost ([127.0.0.1]:49814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVWW4-0006Oi-6z for submit@debbugs.gnu.org; Tue, 06 Sep 2022 07:13:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVWW2-0006OG-1n for control@debbugs.gnu.org; Tue, 06 Sep 2022 07:13:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8RWGvnLiMh6FH32aEiJN5O8w/do0HQY7/TTmsIVB4hk=; b=JReRnKNJ3EZlAA6foE2Q3sUxyH BDwF9y6EBv+hOLH7Wd5rZRzToCZuWHhVI7c2B0xI9InC5v9t+wJ1/LKjZ9wJh9aVxa2MzXSHU09PS Dz4qcVgLSsiLDozZoD9XfLFnnBnJj0HRRnA9FqoAPEUYbvYn90cC1ogbSrCqIhj15eOY=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVWVu-0003w5-4f for control@debbugs.gnu.org; Tue, 06 Sep 2022 13:13:08 +0200 Date: Tue, 06 Sep 2022 13:13:05 +0200 Message-Id: <87bkrsu56m.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #55039 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 55039 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 55039 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 07:24:45 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 11:24:45 +0000 Received: from localhost ([127.0.0.1]:49854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVWhB-0000X2-Gr for submit@debbugs.gnu.org; Tue, 06 Sep 2022 07:24:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVWhA-0000Wq-4N for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 07:24:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVWh4-0000xn-Rm; Tue, 06 Sep 2022 07:24:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ve3QBWx49hed6HXs5H9XNLlXWcwxDmutNZncErI1xpc=; b=Qs16kgQ0/jHo tjdMXXO6iYGTo2HJ2qGd3zjxXUcpP7+CK7WICgk74i/6678bmVb9fot8g73iSq+y8LfALvELXqCN7 OT/CRNy79hsg/wu6hLaoXGntqCsJqzEJksOSHWeEICdFfv9cqZJMAwT/RVGwJFFApa3a2vy/2k6Q+ a1UN4eTC1T/6b0MNCpltsUvR1cSGUpiNzUR4/Iz6kUJm+L2PxkPLGqLEK/m6ZwhuKAdT6rKTSe60k DC3jLeJy1hpbpjGxW0aCCYlc2lnwKeR/1sjP/3dmDWzcijiStjE6CjtMZwOWlDxGkyHld+OxVFR+p TY4AhKew+Q4ww1eK09edJg==; Received: from [87.69.77.57] (port=2352 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVWh3-0005Rw-II; Tue, 06 Sep 2022 07:24:38 -0400 Date: Tue, 06 Sep 2022 14:24:16 +0300 Message-Id: <83edwokaov.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87czc8u56q.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 06 Sep 2022 13:13:01 +0200) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: philipk@posteo.net, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Philip Kaludercic , 55039@debbugs.gnu.org > Date: Tue, 06 Sep 2022 13:13:01 +0200 > > Eli Zaretskii writes: > > > Second, I think the code should DTRT if there's already a ChangeLog > > file in the current directory or in one of its parent directories, > > because those usually show you the project's conventions. > > This would be a separate issue, though? (And I agree that it would be > nice to have, but it doesn't sound trivial to implement.) The proposed feature isn't optional, it unconditionally changes the behavior. AFAIU, it will change the way file names are mentioned in log messages regardless of anything. Does it sound right to you? IOW, providing a new feature in response to a request is fine, but why immediately make it the default, and why force it on everyone without any fire escape? So if we are not going to teach this feature to look at exiting ChangeLog files, at the very l;east this feature should be optional, perhaps off by default. And btw, this only changes the behavior of one command, but AFAIK there are other commands that produce ChangeLog-style entries -- what about them? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 07:30:29 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 11:30:29 +0000 Received: from localhost ([127.0.0.1]:49872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVWmj-0002D6-5U for submit@debbugs.gnu.org; Tue, 06 Sep 2022 07:30:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVWmg-0001pU-D0 for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 07:30:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5lK/K3ozaNokhIfkMgtBryDrHyxIzoikEVHtS6PzNgA=; b=ohD/RaCb1CGesySnMn02kF+8Qd xnfpWugdftpplr5bLhhPlK1B3F154wkvgtRDZSt/PT+SV52S+UIlC+VY21lJDj6D4A/XE/opuRFhb 96rV50GzIN0AinLFUuyP/lTVfxwQoENpYG1J8z9la2FbDd52qjRNmmT9J6Kmydb7PUqw=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVWmY-00045J-B4; Tue, 06 Sep 2022 13:30:20 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <83edwokaov.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Sep 2022 14:24:16 +0300") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <83edwokaov.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUuJTd0VoDEx+L/ //+imcAGAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YJBgscOgicBJwAAAFcSURBVCjPfZC/asJQFMa/ E6LQTinkSs3UxcE+xbVoh04RPFKdKrTQ+hR26K4QHZwcUoh5yn7nRsWpJ4R7f/d85y+c3mC4mNZm gHtF+vGzbCB9QNzbzAK4YY5Rfxx0UPWQbDHSBkA4eJ2eAC8HJtItdBKAYj7r3BNKwsQhv6enXc23 Ss8gD9DRmc6hnwblIz3M9i6ekNWFO0LfCFHVrvW4RL3GClEZ7Xc14QB6Stl/s4N9yQSosNwRjhWL SoW+9VZ/8R4V6GWEoIo2SXoFmZ+foH5adTs23Npg453NzYoxugVHWwbAUBRunDVApXeTrFbIWNdU tkY2Pksa2AeugZDw0gpAWSJ5ElRqyxIf2y5i9+vDo8WIKt8EjckVpI4hsTTSZOz9BUJgLDnOUUjP ntZdi0WfQxsCifnfFql1KjnDRXwaZD6BRThLNJDcwp3V5RmgfcoXjmiFi8X41/4AnMZxyJcWb5kA AAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDktMDZUMTE6Mjg6NTgrMDA6MDDfM9qOAAAAJXRFWHRk YXRlOm1vZGlmeQAyMDIyLTA5LTA2VDExOjI4OjU4KzAwOjAwrm5iMgAAAABJRU5ErkJggg== X-Now-Playing: Yes's _Tormato_: "a) Future Times b) Rejoice" Date: Tue, 06 Sep 2022 13:30:17 +0200 Message-ID: <87leqwspti.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> This would be a separate issue, though? (And I agree that it would be >> nice to have, but it doesn't sound trivial to implement.) > > The proposed feature isn't optional, it unconditionally change [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: philipk@posteo.net, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> This would be a separate issue, though? (And I agree that it would be >> nice to have, but it doesn't sound trivial to implement.) > > The proposed feature isn't optional, it unconditionally changes the > behavior. AFAIU, it will change the way file names are mentioned in > log messages regardless of anything. Does it sound right to you? No, I agreed with you that the proposed patch needs work. I just pointed out that your second paragraph was a separate issue, because the code doesn't heed existing ChangeLog files anyway. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 08:45:16 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 12:45:16 +0000 Received: from localhost ([127.0.0.1]:50039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVXx5-0007MB-Jr for submit@debbugs.gnu.org; Tue, 06 Sep 2022 08:45:15 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40335) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVXx0-0007Lq-Vq for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 08:45:14 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1EF65240101 for <55039@debbugs.gnu.org>; Tue, 6 Sep 2022 14:45:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662468305; bh=964Nui5Rq4xoadGihymdh1EnH9M22Z9/8yxxWVgtycw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=DH+lzh42llcpX2RjpYOkK9xwtctiyaNWgo3ESSatheJ2qK1z6ygtWylbBjAd9zBoj zmHE7cCJjUA/mtRCgPv7OjLtWUzpJxRFu/2A+qz+ryK128pnnWn/6S/yTPH0TDB7eu AcY226ZR4psLj1G1UdUN76Lkhxje4vU8ieBiF2pclqnYWt25YGu0LOB9B28RsCfEeI kXkJhS8GUPxsjCBuHfoC7cklo6nn39jlKpKPZZYZnNQZ38d0ECmRpOonwChC3fQh0A MSCCeMLXzOCKFSiMiDjdoZXIqLnVlDAKCzcUU1o8oQ30WOwuaXBMzox2XYm0F7jWAf cZQnIutcIS8sw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MMQ8F592qz9rxg; Tue, 6 Sep 2022 14:45:01 +0200 (CEST) From: Philip Kaludercic To: Lars Ingebrigtsen Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87czc8u56q.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 06 Sep 2022 13:13:01 +0200") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Tue, 06 Sep 2022 12:45:00 +0000 Message-ID: <871qsooenn.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >> First, I think this must be customizable, because different projects >> have different conventions. > > This was several months ago -- Philip, did you do any further work in > this direction? No I hadn't, but I can take tackle it again as this shouldn't be that difficult. >> Second, I think the code should DTRT if there's already a ChangeLog >> file in the current directory or in one of its parent directories, >> because those usually show you the project's conventions. > > This would be a separate issue, though? (And I agree that it would be > nice to have, but it doesn't sound trivial to implement.) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 10:35:14 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 14:35:14 +0000 Received: from localhost ([127.0.0.1]:52245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVZfW-0002fi-4X for submit@debbugs.gnu.org; Tue, 06 Sep 2022 10:35:14 -0400 Received: from mout01.posteo.de ([185.67.36.65]:50831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVZfU-0002fR-D1 for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 10:35:13 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DF495240026 for <55039@debbugs.gnu.org>; Tue, 6 Sep 2022 16:35:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662474906; bh=3yHE5991vXytbIcr7D3a/mNlyixEuo5MJPaiHB2fSok=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Y/OGIV7xb6jJdNYrBfgInKa8TxvWQJMTQf2puKRfeg8QGjQp7Vp0JGIUVhH78qCYn j9VBsEiBIAaWc0oOgsL9kTsvIxvLpCD1JTg8EtX/KLJHiMgYYvg4ubzcbuqLCRupkx pAcLQh4UHvLCR3qOdgKz/kkVC7ZDpiY3vTa85CJKL9wmSHSXOgtk2xd95B1U5RAKoX /bFi+FcN5kdPscaHASY2PhIpKoQSgHm5wYe9nQw0d+5RyXKt5LTOMj0JaH9PU4CAhn m1U1+qmHi6LjiLyCINrJqnwBOgxF70NeIzXOtCrTiQH8KLvovYSUXLkCDI9TGAd40b fPl/6TkCi54Jg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MMSbF0wFGz9rxb; Tue, 6 Sep 2022 16:35:03 +0200 (CEST) From: Philip Kaludercic To: Lars Ingebrigtsen Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <871qsooenn.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 06 Sep 2022 14:45:00 +0200") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Tue, 06 Sep 2022 14:34:58 +0000 Message-ID: <87o7vsfu5p.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Philip Kaludercic writes: > Lars Ingebrigtsen writes: > >> Eli Zaretskii writes: >> >>> First, I think this must be customizable, because different projects >>> have different conventions. >> >> This was several months ago -- Philip, did you do any further work in >> this direction? > > No I hadn't, but I can take tackle it again as this shouldn't be that > difficult. Something like this should be enough, at least functionality wise, right? --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el index 322d4abd31..1f0eec0d66 100644 --- a/lisp/vc/diff-mode.el +++ b/lisp/vc/diff-mode.el @@ -2336,6 +2336,12 @@ diff-undo (let ((inhibit-read-only t)) (undo arg))) +(defcustom diff-relative-names-in-changelog nil + "Use relative file names when generating ChangeLog messages." + :type 'boolean + :safe #'booleanp + :version "29.1") + (defun diff-add-log-current-defuns () "Return an alist of defun names for the current diff. The elements of the alist are of the form (FILE . (DEFUN...)), @@ -2374,9 +2380,11 @@ diff-add-log-current-defuns (re-search-forward diff-hunk-header-re nil t) (setq hunk-end (save-excursion (diff-end-of-hunk))) (pcase-let* ((filename (substring-no-properties - (file-relative-name - (diff-find-file-name) - (vc-root-dir)))) + (if diff-relative-names-in-changelog + (file-relative-name + (diff-find-file-name) + (vc-root-dir)) + (diff-find-file-name)))) (=lines 0) (+lines 0) (-lines 0) --=-=-= Content-Type: text/plain Assuming nobody objects to the name of the option, should this be documented in NEWS and/or in the Manual? Also, as the entire point of the patch was that emacs.git is using relative path names, should a .dir-locals.el variable be set to ensure this is done? --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 10:39:40 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 14:39:40 +0000 Received: from localhost ([127.0.0.1]:52255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVZjo-0002mn-4o for submit@debbugs.gnu.org; Tue, 06 Sep 2022 10:39:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVZjm-0002mW-Dz for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 10:39:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yxxR/lfJ4BSxIMqCX89FCyb+BES/OS8ebeEdnUdnceg=; b=bxtR8BlUMZew6m41lJTl7Wo/dv UFYf2t21iR9sA/uIxpNFaZohcE0YZaI/ttoBY2BTdE6qdyWsQG9uFMVYAejtAra02z4msH/7LButI Pp2Mnsaqcgg36f1cYBjfVUSzA1Oa90MZkcU7PKnUup48rwr93joJLLHfvNINePQXvHVg=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVZjd-0005gB-HL; Tue, 06 Sep 2022 16:39:31 +0200 From: Lars Ingebrigtsen To: Philip Kaludercic Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87o7vsfu5p.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 06 Sep 2022 14:34:58 +0000") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUmIiSMfHPIwr// ///XfD68AAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YJBg4bFerHbekAAAGPSURBVCjPRdFBa6NAFAfw l1KH6MmCKepJignqp3BDG8KeTFGpPZlFhySfws0hbHMyIUrrKQYDOp9ynTG2c5of/5nHezwAmKtW rRZRAvTMeasWSJTeMPkUiBG2VxuGCq5/IONVC+2GPzXamD0u9cxSpG/4E0Vm1Rjw72GPBuE9/53c rfcvHYwW9X72g8/dlkE2LtHg33HbJxF8XLZ2h6MOX8sDg2QetQHR06RDrklYP9+w0yVs9MjNNX4L HQrRzK0m/tAZNL3YuKsvo0f8Vy7YqKCFTQVyrnRYBCkMXwUG0ePPwD/NJJYEoxOgyW7eYVECsrbP FOPGPwBSpvcUavayhJHnMSjXaZk8ZSZHwV1f63B5eJ9S3JF0gJ6VIqdAxAX/hEhD0S7KsU6P5I2h iVMhfSQVQ3A9ocQnZwreKzMhCQhbKsrLbPbL6yD4ZbEYeBv2R30PC4dbWyxRg2UWcat2DtpbIHoV RDHD2JViByrMno1BenAWFWYFrnD/YCN3lFFkYEsguCKbxwUYiYpjc/Afhu+BQQa9QocAAAAldEVY dGRhdGU6Y3JlYXRlADIwMjItMDktMDZUMTQ6Mjc6MjErMDA6MDCsSn7aAAAAJXRFWHRkYXRlOm1v ZGlmeQAyMDIyLTA5LTA2VDE0OjI3OjIxKzAwOjAw3RfGZgAAAABJRU5ErkJggg== X-Now-Playing: Peter Gabriel's _Peter Gabriel 2_: "A Wonderful Day In A One-Way World" Date: Tue, 06 Sep 2022 16:39:29 +0200 Message-ID: <87fsh4r2hq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philip Kaludercic writes: > Something like this should be enough, at least functionality wise, > right? Looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: > Something like this should be enough, at least functionality wise, > right? Looks good to me. > Assuming nobody objects to the name of the option, should this be > documented in NEWS and/or in the Manual? Also, as the entire point of > the patch was that emacs.git is using relative path names, Should be in NEWS and mentioned in the `diff-add-log-current-defuns' doc string, I think. I don't know whether it's necessary to document it in the manual. > should a .dir-locals.el variable be set to ensure this is done? I think so. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 10:58:17 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 14:58:17 +0000 Received: from localhost ([127.0.0.1]:52298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVa1p-0003Vv-E5 for submit@debbugs.gnu.org; Tue, 06 Sep 2022 10:58:17 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:38869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVa1n-0003VX-PU for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 10:58:16 -0400 Received: by mail-wr1-f48.google.com with SMTP id b5so15885186wrr.5 for <55039@debbugs.gnu.org>; Tue, 06 Sep 2022 07:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=38yMU45UYoB0GMo2UD6bfvjn4LTxkzTx1mECg5Q65YE=; b=XkQvVkcTP3RRfserEIqjqOm35MjMLYF+xXwbTRViYVKDe/hePnnqNDUxHulUaZUDcG dw8wBXEtKqkWow95ju4Vo7QsPxcGqhKxw553vQpZe9vROSYl7jQaT9G8MXoMw/QVrVtZ 2SD8fUqPCmxZkrA30CIOxQQVPJ4Y6jr5gkTeXhm2hatUzeyKnjqug/6HNojpfs+R0K3I j4KKXpDxhiYFWjHhzXgEK6gArevBHTbGWS9eCPnG612IyIEQw9Ppey54QdS8okJ7Ef/H NvTA3qDWFKDSzVxtWwBYF0Zac/Be47htTHn9jisBtRYv1rr0m7odTZr6dKoL9rI+9RV3 Q6Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=38yMU45UYoB0GMo2UD6bfvjn4LTxkzTx1mECg5Q65YE=; b=z44xLz94IpYWAHhwuOIUxnQikyayyJ8kqegt2k2doMoyT3UM80USccyNKh4CjZ9kq0 /GQxdGaOhkPYMurLSP+YAPVzohPE2IXJOxujaDSjTLtAfpsty/1v7fHrWEJwRLFa1G42 OLAxdaVkU4fM4g3F1Rf2WE51uA54r1Nw06gwGurqMYpgcMIum8dEHdUhguV6QmYm/B12 ra7LRNtMCRWll5vDwfxWAuHPTIDt4r7Dk7mlOsgYNgQgh4tVqXgq+nL7izUKpsUsN3ck kghb1uJA/6+qw200ewVTK8Rmnz//yvjCG/5YzwlzoxCKR4HKsoJtI8s95XWhM3naQGrF fYyA== X-Gm-Message-State: ACgBeo3Y4Z0616998j33a5NCtFDCVLvFuGbZxcybFN3qDbtQQ6Pkq4U2 +n1XY8R+AwRAnY5yrebEPxypA3niEe4QCQ== X-Google-Smtp-Source: AA6agR7B5Z8wo3H3mTh6MUqaTmHwo8UNcLDP9MaBjnuTISgYmMDpb0nzAVWQPqH3w9o1lb78hG0WQA== X-Received: by 2002:adf:f58b:0:b0:228:6504:6751 with SMTP id f11-20020adff58b000000b0022865046751mr6944477wro.3.1662476289449; Tue, 06 Sep 2022 07:58:09 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:f116:dbc2:98c7:dbf1]) by smtp.gmail.com with ESMTPSA id d6-20020a5d6446000000b00224f5bfa890sm12475146wrw.97.2022.09.06.07.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 07:58:08 -0700 (PDT) From: Robert Pluim To: Philip Kaludercic Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87o7vsfu5p.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 06 Sep 2022 14:34:58 +0000") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> Date: Tue, 06 Sep 2022 16:58:07 +0200 Message-ID: <877d2gczy8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55039 Cc: Lars Ingebrigtsen , Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 06 Sep 2022 14:34:58 +0000, Philip Kaludercic said: Philip> (defun diff-add-log-current-defuns () Philip> "Return an alist of defun names for the current diff. Philip> The elements of the alist are of the form (FILE . (DEFUN...)), Philip> @@ -2374,9 +2380,11 @@ diff-add-log-current-defuns Philip> (re-search-forward diff-hunk-header-re nil t) Philip> (setq hunk-end (save-excursion (diff-end-of-hunk))) Philip> (pcase-let* ((filename (substring-no-properties Philip> - (file-relative-name Philip> - (diff-find-file-name) Philip> - (vc-root-dir)))) Philip> + (if diff-relative-names-in-cha= ngelog Philip> + (file-relative-name Philip> + (diff-find-file-name) Philip> + (vc-root-dir)) Philip> + (diff-find-file-name)))) Philip> (=3Dlines 0) Philip> (+lines 0) Philip> (-lines 0) That doesn=CA=BCt look like the code that=CA=BCs currently in master. Is th= is on top of your previous patch? Philip> Assuming nobody objects to the name of the option, should this = be Philip> documented in NEWS and/or in the Manual? Also, as the entire p= oint of Philip> the patch was that emacs.git is using relative path names, shou= ld a Philip> .dir-locals.el variable be set to ensure this is done? NEWS and .dir-locals.el definitely. I guess you could add to the "Log Buffer" node in the emacs manual if you=CA=BCre feeling inspired =F0=9F=98= =80 Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 11:03:03 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 15:03:04 +0000 Received: from localhost ([127.0.0.1]:52322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVa6R-0003lE-Hk for submit@debbugs.gnu.org; Tue, 06 Sep 2022 11:03:03 -0400 Received: from mout01.posteo.de ([185.67.36.65]:43013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVa6Q-0003kK-1m for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 11:03:02 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0DDFF240026 for <55039@debbugs.gnu.org>; Tue, 6 Sep 2022 17:02:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662476576; bh=N4DELu3OmUniesjvGLtGgnkw+k6Gjeo2Xg3U2H3810M=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=JmnidIU1f+vYEtLV1ppC0n/5XNXcPQtn0TNAiMUAaOEd7UCrWK/LBW2ngaZDRgXf4 JNT9sx2JUXr+OT4r3d2S4jYuWmhrfb9isxa4G18KfD9txM7w+34NLgizkweZT1Egya 2ikuc7/jLrIIK7s1CGvrkFZW5jZvUCviyWRagrLuuU03NQmjJnje7fMyF9R2ZAq1c4 zrIY+zc5gu8Mx8s7/MpdVio/G1dPjRINrAFOCfTt26fAkvvjCuyR/xrRuD2pHb9E9/ M4wFtGc5MLrfan1Sv/exbNA583mUTXE9AoOMAF+OzlePi7btojE0su6ErnHpRP6w/d jWbx389xQZFuA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MMTCL0xFyz6tpp; Tue, 6 Sep 2022 17:02:53 +0200 (CEST) From: Philip Kaludercic To: Robert Pluim Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <877d2gczy8.fsf@gmail.com> (Robert Pluim's message of "Tue, 06 Sep 2022 16:58:07 +0200") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <877d2gczy8.fsf@gmail.com> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Tue, 06 Sep 2022 15:02:53 +0000 Message-ID: <87h71kfsv6.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Lars Ingebrigtsen , Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: >>>>>> On Tue, 06 Sep 2022 14:34:58 +0000, Philip Kaludercic said: > Philip> (defun diff-add-log-current-defuns () > Philip> "Return an alist of defun names for the current diff. > Philip> The elements of the alist are of the form (FILE . (DEFUN...)= ), > Philip> @@ -2374,9 +2380,11 @@ diff-add-log-current-defuns > Philip> (re-search-forward diff-hunk-header-re nil t) > Philip> (setq hunk-end (save-excursion (diff-end-of-hunk))) > Philip> (pcase-let* ((filename (substring-no-properties > Philip> - (file-relative-name > Philip> - (diff-find-file-name) > Philip> - (vc-root-dir)))) > Philip> + (if diff-relative-names-in-c= hangelog > Philip> + (file-relative-name > Philip> + (diff-find-file-name) > Philip> + (vc-root-dir)) > Philip> + (diff-find-file-name)))) > Philip> (=3Dlines 0) > Philip> (+lines 0) > Philip> (-lines 0) > > That doesn=CA=BCt look like the code that=CA=BCs currently in master. Is = this on > top of your previous patch? No, these changes would be on top of the previous patch, but I'm of course going to merge them into a single commit. > Philip> Assuming nobody objects to the name of the option, should thi= s be > Philip> documented in NEWS and/or in the Manual? Also, as the entire= point of > Philip> the patch was that emacs.git is using relative path names, sh= ould a > Philip> .dir-locals.el variable be set to ensure this is done? > > NEWS and .dir-locals.el definitely. I guess you could add to the "Log > Buffer" node in the emacs manual if you=CA=BCre feeling inspired =F0=9F= =98=80 I'll consider it. > Robert From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 11:46:43 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 15:46:44 +0000 Received: from localhost ([127.0.0.1]:52389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVamh-0007Ao-MZ for submit@debbugs.gnu.org; Tue, 06 Sep 2022 11:46:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVamf-0007AY-Dn for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 11:46:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59590) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVamX-0000qE-Hl; Tue, 06 Sep 2022 11:46:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jG2k3OiNsfSiWGXddR7CPU//iQ1vYI9vypRegP4IM3k=; b=b9aaZFAmypzh mIWo7mEtdZF44urFfqUYxmk2MbhydXGuUatA1vKKrY+1143sGd1l0KlMpsQARhx4IBJ8MKwTqWK+r rJefNO/ivHPvmHPoZyGDqWPxo2wojoG6h0Hqp5IKvd8ufHNfuYBg4px15m0gz4HKJ4tKJIz9wdqJU HeZafeaHOAyhd2+JjwxtqKHT410SpOj//kC6HrStclALnazTBUyK7kyCf5+DS8RYsY6FVayd7TT9t hOul9rWq8bLst7kWXABkIs9eJpBjaV4MykeYsH505XUQoI7WcrSD9Evq0kSklFNJkf4RpdI9Ex2eL Nk9G9VsCdGvqIrWdLHSL+w==; Received: from [87.69.77.57] (port=2551 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVamW-0001YK-UM; Tue, 06 Sep 2022 11:46:33 -0400 Date: Tue, 06 Sep 2022 18:46:14 +0300 Message-Id: <83y1uwijzt.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87o7vsfu5p.fsf@posteo.net> (message from Philip Kaludercic on Tue, 06 Sep 2022 14:34:58 +0000) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: Eli Zaretskii , 55039@debbugs.gnu.org > Date: Tue, 06 Sep 2022 14:34:58 +0000 > > +(defcustom diff-relative-names-in-changelog nil > + "Use relative file names when generating ChangeLog messages." The doc string should reference the commands for which this option is relevant. > Assuming nobody objects to the name of the option, should this be > documented in NEWS and/or in the Manual? I think so, yes, since "C-x 4 A" is in the manual, and this option will affect it, right? > Also, as the entire point of > the patch was that emacs.git is using relative path names, should a > .dir-locals.el variable be set to ensure this is done? I guess so, yes. But what would happen to people who use Emacs versions before 29? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 12:18:50 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 16:18:50 +0000 Received: from localhost ([127.0.0.1]:52472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVbHl-0008Mf-RE for submit@debbugs.gnu.org; Tue, 06 Sep 2022 12:18:50 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:42877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVbHj-0008M9-Pf for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 12:18:48 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 25D57240002; Tue, 6 Sep 2022 16:18:39 +0000 (UTC) From: Juri Linkov To: Philip Kaludercic Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87o7vsfu5p.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 06 Sep 2022 14:34:58 +0000") Organization: LINKOV.NET References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> Date: Tue, 06 Sep 2022 19:13:09 +0300 Message-ID: <867d2gttf6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55039 Cc: Lars Ingebrigtsen , Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > +(defcustom diff-relative-names-in-changelog nil > + "Use relative file names when generating ChangeLog messages." > + :type 'boolean > + :safe #'booleanp > + :version "29.1") > + > (defun diff-add-log-current-defuns () > "Return an alist of defun names for the current diff. > The elements of the alist are of the form (FILE . (DEFUN...)), Couldn't they share the same name prefix, e.g. diff-add-log-relative-names? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 16:10:54 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 20:10:54 +0000 Received: from localhost ([127.0.0.1]:52781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVeuM-0000E9-3r for submit@debbugs.gnu.org; Tue, 06 Sep 2022 16:10:54 -0400 Received: from mout02.posteo.de ([185.67.36.66]:52565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVeuH-0000Dp-Hu for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 16:10:52 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B6B6E240101 for <55039@debbugs.gnu.org>; Tue, 6 Sep 2022 22:10:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662495043; bh=F2xiGWErMZ2+mYLeWvrndeXUCYd02yiLPizMpW9xqGI=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=b56GysutQWblkUM/iqHtJYnzKaWxw+p1YlAb5pDYEnOGSWLhZvOcDJh/vO5WTrz+y k/pZBmNZN7dtdGgBJc3LL4O6fSbizsj4N7htXRliL3wCE7QsFQ5278E5t4x/LnnfQZ UaSmibaeyrECUc5QxjqnrrGivhECcIdQ7WCtMQavRknLUumvahKvVISfE8yPVARtQW NbFLheMvq3lHAjaiwWuRvaLziivOiBtsX8pAc03q5yxHMUAGxXLbvJb9uJGTzpRLLR bECgXuNaQUh64O1sl440yx/8znYprGKdwR8+XcFeNZdF0mU1qvZ4lH0+U8y3fgfS8t Y3h7N6sokIvbQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MMc2V6821z9rxV; Tue, 6 Sep 2022 22:10:42 +0200 (CEST) From: Philip Kaludercic To: Lars Ingebrigtsen Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87czc8u56q.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 06 Sep 2022 13:13:01 +0200") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Tue, 06 Sep 2022 20:10:41 +0000 Message-ID: <87fsh4e01q.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Here is an updated patch: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-new-user-option-diff-add-log-relative-names.patch >From f8e4b14198e8a9ccd5e4cbdbe044eb468697c2b8 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Tue, 6 Sep 2022 22:06:29 +0200 Subject: [PATCH] Add new user option 'diff-add-log-relative-names' * .dir-locals.el: Set 'diff-add-log-relative-names' to t * doc/emacs/maintaining.texi (Log Buffer): Mention 'diff-add-log-relative-names' * etc/NEWS: Mention 'diff-add-log-relative-names' * lisp/vc/diff-mode.el (diff-add-log-relative-names): Add new option. (diff-add-log-current-defuns): Use new option. --- .dir-locals.el | 3 ++- doc/emacs/maintaining.texi | 5 ++++- etc/NEWS | 5 +++++ lisp/vc/diff-mode.el | 17 +++++++++++++++-- 4 files changed, 26 insertions(+), 4 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index 7812beb001..3312021920 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -5,7 +5,8 @@ (sentence-end-double-space . t) (fill-column . 70) (emacs-lisp-docstring-fill-column . 65) - (bug-reference-url-format . "https://debbugs.gnu.org/%s"))) + (bug-reference-url-format . "https://debbugs.gnu.org/%s") + (diff-add-log-relative-names . t))) (c-mode . ((c-file-style . "GNU") (c-noise-macro-names . ("INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" "UNINIT" "CALLBACK" "ALIGN_STACK")) (electric-quote-comment . nil) diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi index 60169d8d8c..0f1dc18f1a 100644 --- a/doc/emacs/maintaining.texi +++ b/doc/emacs/maintaining.texi @@ -694,7 +694,10 @@ Log Buffer (@code{log-edit-generate-changelog-from-diff}), to generate skeleton ChangeLog entries, listing all changed file and function names based on the diff of the VC fileset. Consecutive entries left empty will be -combined by @kbd{C-q} (@code{fill-paragraph}). +combined by @kbd{C-q} (@code{fill-paragraph}). By default the +inserted file names will just be the files without a path. If +@code{diff-add-log-relative-names} is non-nil, a partial path relative +to the VC root directory will be inserted instead. @kindex C-c C-a @r{(Log Edit mode)} @findex log-edit-insert-changelog diff --git a/etc/NEWS b/etc/NEWS index 1317cd0128..0547796b6c 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1288,6 +1288,11 @@ Sets the value of the buffer-local variable 'whitespace-style' in 'diff-mode' buffers. By default, this variable is '(face trailing)', which preserves behavior from previous Emacs versions. ++++ +*** New user option 'diff-relative-names-in-changelog'. +If non-nil insert file names in ChangeLog skeletons relative to the +VC root directory. + ** Ispell --- diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el index 6b30de3cb3..7cafb43334 100644 --- a/lisp/vc/diff-mode.el +++ b/lisp/vc/diff-mode.el @@ -2336,10 +2336,18 @@ diff-undo (let ((inhibit-read-only t)) (undo arg))) +(defcustom diff-add-log-relative-names nil + "Use relative file names when generating ChangeLog messages." + :type 'boolean + :safe #'booleanp + :version "29.1") + (defun diff-add-log-current-defuns () "Return an alist of defun names for the current diff. The elements of the alist are of the form (FILE . (DEFUN...)), -where DEFUN... is a list of function names found in FILE." +where DEFUN... is a list of function names found in FILE. If +`diff-add-log-relative-names' is non-nil, insert file names +relative to the VC root directory." (save-excursion (goto-char (point-min)) (let* ((defuns nil) @@ -2373,7 +2381,12 @@ diff-add-log-current-defuns ;; hunks (e.g., "diff --git ..." etc). (re-search-forward diff-hunk-header-re nil t) (setq hunk-end (save-excursion (diff-end-of-hunk))) - (pcase-let* ((filename (substring-no-properties (diff-find-file-name))) + (pcase-let* ((filename (substring-no-properties + (if diff-add-log-relative-names + (file-relative-name + (diff-find-file-name) + (vc-root-dir)) + (diff-find-file-name)))) (=lines 0) (+lines 0) (-lines 0) -- 2.30.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 16:12:07 2022 Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 20:12:08 +0000 Received: from localhost ([127.0.0.1]:52785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVevX-0000Gq-LH for submit@debbugs.gnu.org; Tue, 06 Sep 2022 16:12:07 -0400 Received: from mout01.posteo.de ([185.67.36.65]:52961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVevW-0000GK-CL for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 16:12:06 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D6F7324002A for <55039@debbugs.gnu.org>; Tue, 6 Sep 2022 22:12:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662495120; bh=tdsaw4+yFgd/JAzI+J9R2UT55sQ5mv377S6zXibmUrs=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=FZAt5OJXpDYo/rKENnkH4ThSAI4rLaE77dUOW6W3Y/VEBuqPjerZzpNkh79J0DywH 4PxchiLEZyaTC3blr/d47g7+awHWPDod7sCIkdjfVqsrpA+ljzmHx6zAZcjrhAvdgJ D6UJH9Mo06eIKnt2K9szWTwwYB+icvl9U7KkgSv0VnsAWnlTbZPIOnOgt4VqXIhfrD RAgTufHerxX2QJ5EguwjH3XsQZHIDP/IAsp78nLpOOPnhwYtMSYwi7a0tY2V3p68Cc S4mCpnuGmMWQVo8Y/oHyg/3qk6ZjJMB7ltE+TveTm+h228Fix0ZZuV2XHDa6KvOGAl h7G1DUdJ52LSQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MMc400Dylz6tmN; Tue, 6 Sep 2022 22:11:57 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <83y1uwijzt.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Sep 2022 18:46:14 +0300") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Tue, 06 Sep 2022 20:11:57 +0000 Message-ID: <87bkrsdzzm.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> Assuming nobody objects to the name of the option, should this be >> documented in NEWS and/or in the Manual? > > I think so, yes, since "C-x 4 A" is in the manual, and this option > will affect it, right? >From what I see, it won't be affected. Do you think it should be? >> Also, as the entire point of >> the patch was that emacs.git is using relative path names, should a >> .dir-locals.el variable be set to ensure this is done? > > I guess so, yes. But what would happen to people who use Emacs > versions before 29? It should have no effect. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 06:08:16 2022 Received: (at 55039) by debbugs.gnu.org; 7 Sep 2022 10:08:16 +0000 Received: from localhost ([127.0.0.1]:53424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVryi-0004Qe-AJ for submit@debbugs.gnu.org; Wed, 07 Sep 2022 06:08:16 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:35831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVrye-0004QN-0c for 55039@debbugs.gnu.org; Wed, 07 Sep 2022 06:08:15 -0400 Received: by mail-wm1-f51.google.com with SMTP id m17-20020a7bce11000000b003a5bedec07bso11499784wmc.0 for <55039@debbugs.gnu.org>; Wed, 07 Sep 2022 03:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=AOTWe91mNk4/fOhLcVoG7eX50Z2u3u7qqDYPLQv6PUg=; b=XXb95VK3j22YRwBjOgrbPrhRpcurQAdKEb2T+HLa5Odm8T2n1qarymEk5SnhPvXtms KGspE87qefkrtREYkG4UAq4taNyCNR68ZGiWrTFvLQuNNeSZ8oFPEvo1/8NReYYwzRQ7 IQOzJmVsp3BLwrjE9l7Jc7sJmhzA+kjCg7pwCR9qmclFCg/j88x/BLqjMfnoSTyApz00 mlPwxVzILxnqlcyKYO9K0juKLmUcBBbGMTBJF1k19ShN2pA6wEae16Opg3ejOsuRdEDs 1/xWeaVEnWEGMrOE+dd269+nDEHSfMrstB9tBpx6nNozOtyorCdoylfWoWEmgYGwDi0g t9kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=AOTWe91mNk4/fOhLcVoG7eX50Z2u3u7qqDYPLQv6PUg=; b=TyswRJb2oncy7UATx62Rtp/lydrLj3dAcS/rgnI3CZlIbF7WuM5AKZ0NYi2X/039tY 4vFug1u/GkyJjGfg6C4z2HLjtaVB0CP+cntwxeUslA2EqtfaecKu/4Og43kLzZF06Ifu A2MWJKWTaeN3D8HerIbhR3g2dTRx+/y3mG/kctCD40aXSoGh+sNboY1n18ghChrT0ms1 XHaJ5CPAgNT/cHl5XiQOTisGHKqzQGMKTAR0VuijtG31ItbjfgII4ewhEWELBciXRLvF dpcLauOodoodesU6Y3zy6364i3+Mfnf5JLPNScFg+yWS3gIQWBCaxSsElVEeIHEkwrmu 4LQw== X-Gm-Message-State: ACgBeo1IL2OoNCl0Efj8MA6zfIGO7HXVKzDQOpHyPO9vfa0l5Wtm8ppO vxVyNLY4/KVqwQJf0lqCVeBz/oGCVCk= X-Google-Smtp-Source: AA6agR7b6jOl+mFueBA/sxoUsanhMASGa358B7kWLdLJkcKrh2828rXVAosZOxyyUbi3NB4vM/qPoQ== X-Received: by 2002:a05:600c:3b92:b0:3a6:5645:5fc7 with SMTP id n18-20020a05600c3b9200b003a656455fc7mr1507562wms.148.1662545284815; Wed, 07 Sep 2022 03:08:04 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:1a83:d106:c1f4:476c]) by smtp.gmail.com with ESMTPSA id l17-20020a5d6751000000b00228ccd00cedsm8155330wrw.107.2022.09.07.03.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 03:08:04 -0700 (PDT) From: Robert Pluim To: Philip Kaludercic Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87fsh4e01q.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 06 Sep 2022 20:10:41 +0000") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> Date: Wed, 07 Sep 2022 12:08:03 +0200 Message-ID: <87pmg7bipo.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55039 Cc: Lars Ingebrigtsen , Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 06 Sep 2022 20:10:41 +0000, Philip Kaludercic said: Philip> Here is an updated patch: Philip> From f8e4b14198e8a9ccd5e4cbdbe044eb468697c2b8 Mon Sep 17 00:00:= 00 2001 Philip> From: Philip Kaludercic Philip> Date: Tue, 6 Sep 2022 22:06:29 +0200 Philip> Subject: [PATCH] Add new user option 'diff-add-log-relative-nam= es' Philip> * .dir-locals.el: Set 'diff-add-log-relative-names' to t Philip> * doc/emacs/maintaining.texi (Log Buffer): Mention Philip> 'diff-add-log-relative-names' Philip> * etc/NEWS: Mention 'diff-add-log-relative-names' Philip> * lisp/vc/diff-mode.el (diff-add-log-relative-names): Add new o= ption. Philip> (diff-add-log-current-defuns): Use new option. The name of the option in NEWS is different from what=CA=BCs in the code (I prefer the one in NEWS). Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 08:48:34 2022 Received: (at 55039) by debbugs.gnu.org; 7 Sep 2022 12:48:34 +0000 Received: from localhost ([127.0.0.1]:53913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVuTq-0002ZL-Du for submit@debbugs.gnu.org; Wed, 07 Sep 2022 08:48:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVuTo-0002Z6-JI for 55039@debbugs.gnu.org; Wed, 07 Sep 2022 08:48:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tmr4U9y6oEpSzqDPpbcCOr5mcOl/Mo3wcbj3Fy7CFbs=; b=tpB48Cm3rfeXbo2LmBqPPS83Jq EzjaVFlD+g0Mak0NqQcPQ82/czU4OiDq4diMHWo6dFQ2k8Txq2Y1P3x9icA7dFet+G9A9j7hCMG0e M1htYZhjbp+DCwdr+J/nT5FXBm0gMhXtBIPFUEmendW0B268q14pquDd4JlJ0DfEd3Ow=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVuTg-0006rC-B6; Wed, 07 Sep 2022 14:48:26 +0200 From: Lars Ingebrigtsen To: Philip Kaludercic Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87fsh4e01q.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 06 Sep 2022 20:10:41 +0000") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEWhlEBJRSr////o CFXIAAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAABLAAAASwAc4jpUgAAAAd0SU1FB+YJBhYCMCj24n4A AADgSURBVCjPdZLRCgQhCEUVxneD/J+CejfI//+VtWxmdx9GmMHDvZlKAO+BdqKcXG/4U9AUqDEt oF+F0r/tR3kFfAXg0Ut5musi30Yzj6/CYz4CjJ7KA/XqkWxI0h+lpbTu4OXFBmukAL4AJwNyO6Db vsA/5QMrSI/trvoDDNz4htZS1kgzSascgF0HVw24xGQ03b1zrdV6juGv7OvIqe4Ta0E6B22lqBjV HqWzFDSxPQNQ8Q3aPNvz7Yhp1XONhwSg22xaiQ6WQoanUS8gdmz+p/UaQvBbux+7h55kou9v6gPB V0n+mfEx0AAAAFplWElmTU0AKgAAAAgABQESAAMAAAABAAEAAAEaAAUAAAABAAAASgEbAAUAAAAB AAAAUgEoAAMAAAABAAEAAAITAAMAAAABAAEAAAAAAAAAAAEsAAAAAQAAASwAAAABYCqauwAAACV0 RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0wNlQyMjowMjo0NyswMDowMGs0yuQAAAAldEVYdGRhdGU6 bW9kaWZ5ADIwMjItMDktMDZUMjI6MDI6NDcrMDA6MDAaaXJYAAAAF3RFWHRleGlmOllDYkNyUG9z aXRpb25pbmcAMawPgGMAAAAASUVORK5CYII= X-Now-Playing: The Tamlins - =?utf-8?Q?=E2=80=98Baltimore=E2=80=99's?= _Late Night Tales: Version Excursions (Selected By Don Letts)_: "Originally recorded by Randy Newman" Date: Wed, 07 Sep 2022 14:48:23 +0200 Message-ID: <875yhznyeg.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philip Kaludercic writes: > Here is an updated patch: Looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: > Here is an updated patch: Looks good to me. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 09:27:42 2022 Received: (at 55039) by debbugs.gnu.org; 7 Sep 2022 13:27:42 +0000 Received: from localhost ([127.0.0.1]:54071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVv5h-0007ye-U6 for submit@debbugs.gnu.org; Wed, 07 Sep 2022 09:27:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVv5f-0007yQ-Ko for 55039@debbugs.gnu.org; Wed, 07 Sep 2022 09:27:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVv5a-0005Wy-9F; Wed, 07 Sep 2022 09:27:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IAy74IpTYJaD21lmlhMfBnP2+scO5BabHA5PqCaw4VU=; b=c0ZEyvv3kAO/ 4C9c45sEbYDq0ElquufIAi2jaW+cAbvWg3wgU+RmK3pMKILJ+yvwxzNseaTb3oTHrRgwyOzP8Bbv4 HmFfrRiREggoWLvfjVnaKfm+CgoQXeZX9diuSDlq6hVPACks3jkDwnIIJM30p7A9vWxlXp/fd6Qrj yszyMjnBcLxxykuJ3vVwNSAJnj1Nd/hsPeIlYPkCIm5toWNl4+VuySaKL031XrF9VV98pm9B4YAL5 3v4ge+k4ds4hP1jW0dX+Y5+iKa/h5R02LKiwrGQbbkOeZZYhKkSgMcchgy59iShxMeUpjHdeRlNie xo9bt4ED/iml4xCZZEpU1Q==; Received: from [87.69.77.57] (port=3059 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVv5Z-0005JY-Mh; Wed, 07 Sep 2022 09:27:34 -0400 Date: Wed, 07 Sep 2022 16:27:17 +0300 Message-Id: <83wnafgvre.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87fsh4e01q.fsf@posteo.net> (message from Philip Kaludercic on Tue, 06 Sep 2022 20:10:41 +0000) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: Eli Zaretskii , 55039@debbugs.gnu.org > Date: Tue, 06 Sep 2022 20:10:41 +0000 > > --- a/doc/emacs/maintaining.texi > +++ b/doc/emacs/maintaining.texi > @@ -694,7 +694,10 @@ Log Buffer > (@code{log-edit-generate-changelog-from-diff}), to generate skeleton > ChangeLog entries, listing all changed file and function names based > on the diff of the VC fileset. Consecutive entries left empty will be > -combined by @kbd{C-q} (@code{fill-paragraph}). > +combined by @kbd{C-q} (@code{fill-paragraph}). By default the > +inserted file names will just be the files without a path. If > +@code{diff-add-log-relative-names} is non-nil, a partial path relative > +to the VC root directory will be inserted instead. GNU Coding Standards frown on using "path" for anything but PATH-style directory lists. Please use "leading directories" or somesuch here, as that's what you mean. > +*** New user option 'diff-relative-names-in-changelog'. > +If non-nil insert file names in ChangeLog skeletons relative to the ^ Comma missing there. > +(defcustom diff-add-log-relative-names nil > + "Use relative file names when generating ChangeLog messages." This doesn't say relative to what. It also doesn't mention the commands which are affected. > (defun diff-add-log-current-defuns () > "Return an alist of defun names for the current diff. > The elements of the alist are of the form (FILE . (DEFUN...)), > -where DEFUN... is a list of function names found in FILE." > +where DEFUN... is a list of function names found in FILE. If > +`diff-add-log-relative-names' is non-nil, insert file names > +relative to the VC root directory." The "insert" part is out of place here, since there's no insertion. How about If `diff-add-log-relative-names' is non-nil, file names in the alist are relative to the root directory of the VC repository. instead? From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 11:53:39 2022 Received: (at 55039) by debbugs.gnu.org; 7 Sep 2022 15:53:39 +0000 Received: from localhost ([127.0.0.1]:55887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVxMx-0003jH-1D for submit@debbugs.gnu.org; Wed, 07 Sep 2022 11:53:39 -0400 Received: from mout02.posteo.de ([185.67.36.66]:48773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVxMv-0003j3-4E for 55039@debbugs.gnu.org; Wed, 07 Sep 2022 11:53:37 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EE024240103 for <55039@debbugs.gnu.org>; Wed, 7 Sep 2022 17:53:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662566011; bh=TmPGrI4G9etV/1QNg1mzXxX6UtkHKumt63tEoDgrxLY=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=dhstjyWQqX3OGGbIxJ9Ft4SLJwYiSvS/1sYsUofyJxSl0Mi3DyJP6jomhbWc7jYQh tIhzakhVMEJEfsupD6ARx51i3CoXjk+XZSlwqr8gAV6P55MNjsHDciB2QKA1qQ4tM2 nfyXD4o1ZJ1oOs5yD8BpN46dyEty85ZCHXpy4XUf6dtQ6lhnIZg84sU9YtqsS2wLYf zNJz42mDE1c5eC9UOxDFLxc3umKUlo9gzsC8E3A97D+MVIo9mWuN1mWKucXd2bLKvA nxIEuugsKEgfYVC/514YgQd4FOxWJTDVnt+TizIyrPDxp7VfiBEHpe+6Iv13Xbqqf1 nQCgzodHdLq8w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MN6HF6Cj0z6tpY; Wed, 7 Sep 2022 17:53:29 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <83wnafgvre.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 07 Sep 2022 16:27:17 +0300") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> <83wnafgvre.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Wed, 07 Sep 2022 15:53:29 +0000 Message-ID: <87h71jnpty.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Eli Zaretskii , 55039@debbugs.gnu.org >> Date: Tue, 06 Sep 2022 20:10:41 +0000 >> >> --- a/doc/emacs/maintaining.texi >> +++ b/doc/emacs/maintaining.texi >> @@ -694,7 +694,10 @@ Log Buffer >> (@code{log-edit-generate-changelog-from-diff}), to generate skeleton >> ChangeLog entries, listing all changed file and function names based >> on the diff of the VC fileset. Consecutive entries left empty will be >> -combined by @kbd{C-q} (@code{fill-paragraph}). >> +combined by @kbd{C-q} (@code{fill-paragraph}). By default the >> +inserted file names will just be the files without a path. If >> +@code{diff-add-log-relative-names} is non-nil, a partial path relative >> +to the VC root directory will be inserted instead. > > GNU Coding Standards frown on using "path" for anything but PATH-style > directory lists. Please use "leading directories" or somesuch here, > as that's what you mean. I've just remove the changes to the manual from my patch. >> +*** New user option 'diff-relative-names-in-changelog'. >> +If non-nil insert file names in ChangeLog skeletons relative to the > ^ > Comma missing there. Done. >> +(defcustom diff-add-log-relative-names nil >> + "Use relative file names when generating ChangeLog messages." > > This doesn't say relative to what. It also doesn't mention the > commands which are affected. Added. >> (defun diff-add-log-current-defuns () >> "Return an alist of defun names for the current diff. >> The elements of the alist are of the form (FILE . (DEFUN...)), >> -where DEFUN... is a list of function names found in FILE." >> +where DEFUN... is a list of function names found in FILE. If >> +`diff-add-log-relative-names' is non-nil, insert file names >> +relative to the VC root directory." > > The "insert" part is out of place here, since there's no insertion. > > How about > > If `diff-add-log-relative-names' is non-nil, file names in the alist > are relative to the root directory of the VC repository. > > instead? I like it. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-new-user-option-diff-add-log-use-relative-names.patch >From 8ef441e5d5340b06dd04d294a384ae05bf7f5615 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Tue, 6 Sep 2022 22:06:29 +0200 Subject: [PATCH] Add new user option 'diff-add-log-use-relative-names' * .dir-locals.el: Set 'diff-add-log-use-relative-names' to t * etc/NEWS: Mention 'diff-add-log-relative-names' * lisp/vc/diff-mode.el (diff-add-log-use-relative-names): Add new option. (diff-add-log-current-defuns): Use new option. --- .dir-locals.el | 3 ++- etc/NEWS | 5 +++++ lisp/vc/diff-mode.el | 20 ++++++++++++++++++-- 3 files changed, 25 insertions(+), 3 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index 1c90ddcf56..9882a19f85 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -5,7 +5,8 @@ (sentence-end-double-space . t) (fill-column . 70) (emacs-lisp-docstring-fill-column . 65) - (bug-reference-url-format . "https://debbugs.gnu.org/%s"))) + (bug-reference-url-format . "https://debbugs.gnu.org/%s") + (diff-add-log-use-relative-names . t))) (c-mode . ((c-file-style . "GNU") (c-noise-macro-names . ("INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" "UNINIT" "CALLBACK" "ALIGN_STACK")) (electric-quote-comment . nil) diff --git a/etc/NEWS b/etc/NEWS index b61b88d6fb..76c66a8e39 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1340,6 +1340,11 @@ Sets the value of the buffer-local variable 'whitespace-style' in 'diff-mode' buffers. By default, this variable is '(face trailing)', which preserves behavior from previous Emacs versions. ++++ +*** New user option 'diff-add-log-use-relative-names'. +If non-nil insert file names in ChangeLog skeletons relative to the +VC root directory. + ** Ispell --- diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el index a01943437c..1d2fbca0e5 100644 --- a/lisp/vc/diff-mode.el +++ b/lisp/vc/diff-mode.el @@ -2336,10 +2336,21 @@ diff-undo (let ((inhibit-read-only t)) (undo arg))) +(defcustom diff-add-log-use-relative-names nil + "Use relative file names when generating ChangeLog skeletons. +The files will be relative to the root directory of the VC +repository. This option affects the behaviour of +`diff-add-log-current-defuns'." + :type 'boolean + :safe #'booleanp + :version "29.1") + (defun diff-add-log-current-defuns () "Return an alist of defun names for the current diff. The elements of the alist are of the form (FILE . (DEFUN...)), -where DEFUN... is a list of function names found in FILE." +where DEFUN... is a list of function names found in FILE. If +`diff-add-log-use-relative-names' is non-nil, file names in the alist +are relative to the root directory of the VC repository." (save-excursion (goto-char (point-min)) (let* ((defuns nil) @@ -2373,7 +2384,12 @@ diff-add-log-current-defuns ;; hunks (e.g., "diff --git ..." etc). (re-search-forward diff-hunk-header-re nil t) (setq hunk-end (save-excursion (diff-end-of-hunk))) - (pcase-let* ((filename (substring-no-properties (diff-find-file-name))) + (pcase-let* ((filename (substring-no-properties + (if diff-add-log-use-relative-names + (file-relative-name + (diff-find-file-name) + (vc-root-dir)) + (diff-find-file-name)))) (=lines 0) (+lines 0) (-lines 0) -- 2.30.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 14:12:54 2022 Received: (at 55039) by debbugs.gnu.org; 7 Sep 2022 18:12:54 +0000 Received: from localhost ([127.0.0.1]:56147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVzXi-0007OX-Hs for submit@debbugs.gnu.org; Wed, 07 Sep 2022 14:12:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVzXg-0007OJ-Jc for 55039@debbugs.gnu.org; Wed, 07 Sep 2022 14:12:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVzXa-0001wT-2B; Wed, 07 Sep 2022 14:12:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7wl+0YjvzUhJyxkiFDr8fhpGanYfRzTR0IPU7KT5cfU=; b=ayuWhhlshN9/ EctKijQHOLzH0eQhDT3XSi4A+OVxeplzRYK20wnHDkANkTTIG0KKuYOMEz5X3h7WEEr1BajLZOcby Inx/KhtWUOFpUxxFbkvJFsJkuochmdAqtkgqiTzltVUwntbP2Kaku0MVzbxmfADCjkuLXtnAn6jAu KBWhEsOcpm+x3boWogseLhNui8UVoO+SoJIWjLee8uBzGSeX2I9QQwaH1eyLg9FF1Ly8+XZeAnvVJ 6hlza+X8Lsjiiiv/CsZ1iwRnIRwzbHMYRBoxGNExTk+9n2f01UQtZyZMhyYJ6nFYVzqMsSGoMSrhp Me0snpuAmIYnxu47/qPUvg==; Received: from [87.69.77.57] (port=4571 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVzXZ-0001dx-F2; Wed, 07 Sep 2022 14:12:45 -0400 Date: Wed, 07 Sep 2022 21:12:30 +0300 Message-Id: <83mtbbgik1.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87h71jnpty.fsf@posteo.net> (message from Philip Kaludercic on Wed, 07 Sep 2022 15:53:29 +0000) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> <83wnafgvre.fsf@gnu.org> <87h71jnpty.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: larsi@gnus.org, 55039@debbugs.gnu.org > Date: Wed, 07 Sep 2022 15:53:29 +0000 > > >> --- a/doc/emacs/maintaining.texi > >> +++ b/doc/emacs/maintaining.texi > >> @@ -694,7 +694,10 @@ Log Buffer > >> (@code{log-edit-generate-changelog-from-diff}), to generate skeleton > >> ChangeLog entries, listing all changed file and function names based > >> on the diff of the VC fileset. Consecutive entries left empty will be > >> -combined by @kbd{C-q} (@code{fill-paragraph}). > >> +combined by @kbd{C-q} (@code{fill-paragraph}). By default the > >> +inserted file names will just be the files without a path. If > >> +@code{diff-add-log-relative-names} is non-nil, a partial path relative > >> +to the VC root directory will be inserted instead. > > > > GNU Coding Standards frown on using "path" for anything but PATH-style > > directory lists. Please use "leading directories" or somesuch here, > > as that's what you mean. > > I've just remove the changes to the manual from my patch. Why? That was nowhere near what I intended to say with the above comments, which were minor. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 14:27:36 2022 Received: (at 55039) by debbugs.gnu.org; 7 Sep 2022 18:27:36 +0000 Received: from localhost ([127.0.0.1]:56183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVzlv-0007lS-OK for submit@debbugs.gnu.org; Wed, 07 Sep 2022 14:27:36 -0400 Received: from mout01.posteo.de ([185.67.36.65]:50037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVzlt-0007lF-Sy for 55039@debbugs.gnu.org; Wed, 07 Sep 2022 14:27:34 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B19FA240027 for <55039@debbugs.gnu.org>; Wed, 7 Sep 2022 20:27:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662575247; bh=TQMlw0VJnV2jaLt8KXHTOKQsV6EbH0nJVvqAyzK5Cvw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=h14k9n8hhEEqmdyLqnoVCeqhjgvm0ZVEzee+JuYqiy2m6nV3wyzuUbYjg22QrczL0 mRqMr5XwCNQXu3nE/fokvkVU71sJC72KdCo+knCvp/mR6ZHhnyLcVBUw3BPg20VLay K/BYSwGXtk+yoF8fm57zydpRFPpke3ZvPTfqWIcHmb8J2FQnn2edM/So7tnQuz4Mc2 ShEg1h7dHPINhodnGxcp/bKfcIUn+ylG/d1LGxfAL2tj3JgLVkEyCFVnGBP++W2LyR RFmMZykvHcv6F1o1eUDu2RF4t1NtLeWvjSx7I1fuzseraYtHGlL9BugURSV8WxEntz 4HjPAJG70wnmg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MN9ht58ckz6trP; Wed, 7 Sep 2022 20:27:25 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <83mtbbgik1.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 07 Sep 2022 21:12:30 +0300") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> <83wnafgvre.fsf@gnu.org> <87h71jnpty.fsf@posteo.net> <83mtbbgik1.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Wed, 07 Sep 2022 18:27:18 +0000 Message-ID: <87wnaft4zd.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: larsi@gnus.org, 55039@debbugs.gnu.org >> Date: Wed, 07 Sep 2022 15:53:29 +0000 >> >> >> --- a/doc/emacs/maintaining.texi >> >> +++ b/doc/emacs/maintaining.texi >> >> @@ -694,7 +694,10 @@ Log Buffer >> >> (@code{log-edit-generate-changelog-from-diff}), to generate skeleton >> >> ChangeLog entries, listing all changed file and function names based >> >> on the diff of the VC fileset. Consecutive entries left empty will be >> >> -combined by @kbd{C-q} (@code{fill-paragraph}). >> >> +combined by @kbd{C-q} (@code{fill-paragraph}). By default the >> >> +inserted file names will just be the files without a path. If >> >> +@code{diff-add-log-relative-names} is non-nil, a partial path relative >> >> +to the VC root directory will be inserted instead. >> > >> > GNU Coding Standards frown on using "path" for anything but PATH-style >> > directory lists. Please use "leading directories" or somesuch here, >> > as that's what you mean. >> >> I've just remove the changes to the manual from my patch. > > Why? That was nowhere near what I intended to say with the above > comments, which were minor. It wasn't because of your comments, rather I just felt mentioning it was too clumsy, and a few others said they didn't feel it was necessary to mention the option in the manual. But if you think that it should be added, then I'll try it again and take your comments into account. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 14:47:02 2022 Received: (at 55039) by debbugs.gnu.org; 7 Sep 2022 18:47:02 +0000 Received: from localhost ([127.0.0.1]:56289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oW04k-0008Lx-73 for submit@debbugs.gnu.org; Wed, 07 Sep 2022 14:47:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oW04i-0008LT-ON for 55039@debbugs.gnu.org; Wed, 07 Sep 2022 14:47:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW04d-0007af-8g; Wed, 07 Sep 2022 14:46:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VhBEFtudGaSy23YE/9F6TvBx/X1HMCTP7CyxXR1T7Qg=; b=DH22EavVp19u WAZzukae4NNXvPgTcEDlyJuWdhrFZYOMr43ni5tZU+ff25owFQBM8Gteu4SSLE8Ab+irqwulWbpeD M4p5hQZ7WF7Bvfpauj5eGzhP3IzD1ZcU6BOh3z8QVxv5TPw8cupVLPSRe+lfzZiZeWcuHfyk/iAYr 6VSVcS884ScFMBlo7QCX8E6qtZ/UfJA+qiNxg3IO9GvwY3pqte1kPSlifFmjEiFl/COlreS5UtvDh /L7R5UfIWsLau/3oF+8dpw24ExgeVaLmdoJ6DXX1kIGdEQbI/SBrinp9XgM4QEXajGqb8UoIY04VK lVp5d+PJlVbBn7WcLgI4bg==; Received: from [87.69.77.57] (port=2687 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW04c-000158-Ld; Wed, 07 Sep 2022 14:46:55 -0400 Date: Wed, 07 Sep 2022 21:46:38 +0300 Message-Id: <83edwnggz5.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87wnaft4zd.fsf@posteo.net> (message from Philip Kaludercic on Wed, 07 Sep 2022 18:27:18 +0000) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> <83wnafgvre.fsf@gnu.org> <87h71jnpty.fsf@posteo.net> <83mtbbgik1.fsf@gnu.org> <87wnaft4zd.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: larsi@gnus.org, 55039@debbugs.gnu.org > Date: Wed, 07 Sep 2022 18:27:18 +0000 > > Eli Zaretskii writes: > > >> I've just remove the changes to the manual from my patch. > > > > Why? That was nowhere near what I intended to say with the above > > comments, which were minor. > > It wasn't because of your comments, rather I just felt mentioning it was > too clumsy, and a few others said they didn't feel it was necessary to > mention the option in the manual. But if you think that it should be > added, then I'll try it again and take your comments into account. Yes, I think it should be in the manual. But if you'd rather leave that to me, I'm fine with that. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 17:24:00 2022 Received: (at 55039) by debbugs.gnu.org; 7 Sep 2022 21:24:00 +0000 Received: from localhost ([127.0.0.1]:56377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oW2We-0003o8-8p for submit@debbugs.gnu.org; Wed, 07 Sep 2022 17:24:00 -0400 Received: from mout01.posteo.de ([185.67.36.65]:32991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oW2Wc-0003nt-9X for 55039@debbugs.gnu.org; Wed, 07 Sep 2022 17:23:58 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 69E26240026 for <55039@debbugs.gnu.org>; Wed, 7 Sep 2022 23:23:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662585832; bh=92gxgyxU4AGUWgxBEbNjaHOObuj4YbRZB/A+4lHGDfE=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=BkHH2LGBr4529xD7Rg5q49MUFvdCy0Z1pQiZCKl+ZWuXELmR2jNz7RWVq2hd5DBHq wAWVTa9rOGnW426rlQHXFWLLQqux7+bwJ64dftHk0gsUIPKXOhQT64g22+EBkZzZTS YRPxheITuTcZs/NVwl9DTkjud3fs0NaAAtnieH1l78buYXIre4IoLIORSlvDff8fxQ WdiAPdz4MJF0C+8BWfXIdfSMrlloq8AdPhga8EeS0Y4WgyWERrHLAgAd6MPqRZCNJt JyBN4yCzS3PSAh3hBV1MXC7hNDiJyQx8LbWUH+mechV6Br+BRIESadsyMDXNo4yUzH KWBnwzK5rr8ig== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MNFcP2Rsqz6tmG; Wed, 7 Sep 2022 23:23:49 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <83edwnggz5.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 07 Sep 2022 21:46:38 +0300") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> <83wnafgvre.fsf@gnu.org> <87h71jnpty.fsf@posteo.net> <83mtbbgik1.fsf@gnu.org> <87wnaft4zd.fsf@posteo.net> <83edwnggz5.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Wed, 07 Sep 2022 21:23:38 +0000 Message-ID: <87pmg6ubdx.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: larsi@gnus.org, 55039@debbugs.gnu.org >> Date: Wed, 07 Sep 2022 18:27:18 +0000 >> >> Eli Zaretskii writes: >> >> >> I've just remove the changes to the manual from my patch. >> > >> > Why? That was nowhere near what I intended to say with the above >> > comments, which were minor. >> >> It wasn't because of your comments, rather I just felt mentioning it was >> too clumsy, and a few others said they didn't feel it was necessary to >> mention the option in the manual. But if you think that it should be >> added, then I'll try it again and take your comments into account. > > Yes, I think it should be in the manual. But if you'd rather leave > that to me, I'm fine with that. Here is my latest attempt (will merge it into the patch): --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi index 343cc83ce5..f16d0a922e 100644 --- a/doc/emacs/maintaining.texi +++ b/doc/emacs/maintaining.texi @@ -694,7 +694,10 @@ Log Buffer (@code{log-edit-generate-changelog-from-diff}), to generate skeleton ChangeLog entries, listing all changed file and function names based on the diff of the VC fileset. Consecutive entries left empty will be -combined by @kbd{C-q} (@code{fill-paragraph}). +combined by @kbd{C-q} (@code{fill-paragraph}). By default the +skeleton will just include the file name, without any leading +directories. If you wish to prepend the leading directories up to the +VC root, customize @code{diff-add-log-use-relative-names}. @kindex C-c C-a @r{(Log Edit mode)} @findex log-edit-insert-changelog --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 22:58:48 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 02:58:48 +0000 Received: from localhost ([127.0.0.1]:56834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oW7kd-0001s5-T4 for submit@debbugs.gnu.org; Wed, 07 Sep 2022 22:58:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oW7kc-0001rk-1P for 55039@DEBBUGS.gnu.org; Wed, 07 Sep 2022 22:58:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52090) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW7kW-0003u5-QI; Wed, 07 Sep 2022 22:58:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:to:From: mime-version; bh=ZlbvyTsDwSJ24fNeYPIJUPisoybT1ix61USVHQaoNBw=; b=mDuCpWL1t2EZ fO0Rxya6MCeOzIIT3leC1boZ2nH3GIzsW4Ed8i0+HlpNGacttAddsWEGQfDzx+oGP8MHGYw2+UxdA Em670YeADCTRNke9VVMXudMBPDBZs8H82RSFxtw97rm9DtfUj5p/uftRkK6dApztXpu/EXtPjH+fq PstwZvgQij5x6HboqPoSbP5+VJajZnsI+Q2yon3lqOf3KkXQG7OCWMkNh4kQdSnUeRSDP75sLcwBg jP7KNOHW3f9+XflyPHquLz5yzk7Gpj4WnIuZ+UpxFaxzFQqDFeI4fVgzbydx/wCUEMzRziBgaSUS+ QpYZcjlc6rZDESBgPuzS8A==; Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1oW7kV-0003IJ-Ri; Wed, 07 Sep 2022 22:58:39 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman to: philipk@posteo.net In-Reply-To: <83wnafgvre.fsf@gnu.org> (message from Eli Zaretskii on Wed, 07 Sep 2022 16:27:17 +0300) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> <83wnafgvre.fsf@gnu.org> Message-Id: Date: Wed, 07 Sep 2022 22:58:39 -0400 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: 55039@DEBBUGS.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > If > > +@code{diff-add-log-relative-names} is non-nil, a partial path relative > > +to the VC root directory will be inserted instead. 1. Please try to rewrite passive voice sentences using active voice. Passive voice omits the subject and that tends to reduce clarity. 2. Shouldn't there be @code around `nil' in a Texinfo file? -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 01:39:21 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 05:39:21 +0000 Received: from localhost ([127.0.0.1]:56979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWAG1-000204-3L for submit@debbugs.gnu.org; Thu, 08 Sep 2022 01:39:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWAFy-0001zr-Um for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 01:39:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWAFt-0001SE-3B; Thu, 08 Sep 2022 01:39:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Lk73P8OMxUBNalfF0GglTgPGjJaVq7jI9lUuW0/IGzQ=; b=rVInW4c8WvN/ xbH0okusfmeImlzKhCC94OHcV5LFzfEEsCMJiWGpqqujOCShqy1FeAzX05BjfBNzIK6vEivKl1jmV RvZu7VlDH1GLuKwiLUZitE9HIpO2WP09AIEtKZO0YOTw966M9iAt7JgV0FgLToq+MVYN2Accw3JXY SOX68hHqab8cOP7eisS7pGuAk5YhKycJmgy2AdMpBNtdN34UClQYzpO+5IL0jJlDYjKeNVSCpj+wB SpU5oOr8mPA5h6ZXZ7eBq8RDDZwBBWRNH93yAZNr/2GThzlT1A2xPcDCOCmnxbFpaeLDL3su1hDKu V/oxZZW6/DYTxkl3HkfJFQ==; Received: from [87.69.77.57] (port=2666 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWAFs-0007Rj-9u; Thu, 08 Sep 2022 01:39:12 -0400 Date: Thu, 08 Sep 2022 08:38:58 +0300 Message-Id: <831qsmh1cd.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87pmg6ubdx.fsf@posteo.net> (message from Philip Kaludercic on Wed, 07 Sep 2022 21:23:38 +0000) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> <83wnafgvre.fsf@gnu.org> <87h71jnpty.fsf@posteo.net> <83mtbbgik1.fsf@gnu.org> <87wnaft4zd.fsf@posteo.net> <83edwnggz5.fsf@gnu.org> <87pmg6ubdx.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: larsi@gnus.org, 55039@debbugs.gnu.org > Date: Wed, 07 Sep 2022 21:23:38 +0000 > > >> It wasn't because of your comments, rather I just felt mentioning it was > >> too clumsy, and a few others said they didn't feel it was necessary to > >> mention the option in the manual. But if you think that it should be > >> added, then I'll try it again and take your comments into account. > > > > Yes, I think it should be in the manual. But if you'd rather leave > > that to me, I'm fine with that. > > Here is my latest attempt (will merge it into the patch): LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 02:18:59 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 06:18:59 +0000 Received: from localhost ([127.0.0.1]:57012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWAsN-0002yY-5Y for submit@debbugs.gnu.org; Thu, 08 Sep 2022 02:18:59 -0400 Received: from mout02.posteo.de ([185.67.36.66]:36147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWAsL-0002yK-M0 for 55039@DEBBUGS.gnu.org; Thu, 08 Sep 2022 02:18:58 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9EBCF240101 for <55039@DEBBUGS.gnu.org>; Thu, 8 Sep 2022 08:18:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662617931; bh=pdptyfFXs6Ufj6CdpXcQgXda1Oh8arTdJ3lmL1p32IU=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=niy+MJKqu8LgC4V7fNM2UP1OAvbUFqhgZ75q2sq9c3XP/KLyxyx1x7z5FQ/ytW/54 LSxvrnrps97i3UoU8ZFUIv9an5bDZbD7vZv2mb/49GjUmZyoDjgesgyNQ4brKjAUaK uiDM8UquTfDwZz+B3mY67USqkr9mfOClrh93GBTR0UTyv2B4fNDWAVRez7kzuB1pP6 ylkyunZnDF712LZZCgnMQ54pCzksKNS4CEH4pfDTQ+5FU3WW/eY/T2YUhPB9WYNwfv QuJWD5vednD1CZSh9q6sweFaCfouzD/FobXj/6q+CTOQCmqkPLaxX9E4ulo7kscL+f hIwNzmRTLXT7g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MNTTk54s8z6tqk; Thu, 8 Sep 2022 08:18:50 +0200 (CEST) From: Philip Kaludercic To: Richard Stallman Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: (Richard Stallman's message of "Wed, 07 Sep 2022 22:58:39 -0400") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> <83wnafgvre.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Thu, 08 Sep 2022 06:18:48 +0000 Message-ID: <87lequtmlz.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: 55039@DEBBUGS.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Richard Stallman writes: > [[[ To any NSA and FBI agents reading my email: please consider ]]] > [[[ whether defending the US Constitution against all enemies, ]]] > [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > > If > > > +@code{diff-add-log-relative-names} is non-nil, a partial path relative > > > +to the VC root directory will be inserted instead. > > 1. Please try to rewrite passive voice sentences using active voice. > Passive voice omits the subject and that tends to reduce clarity. > > 2. Shouldn't there be @code around `nil' in a Texinfo file? You are right, but the patch you were commenting on was outdated. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 02:22:23 2022 Received: (at 55039-done) by debbugs.gnu.org; 8 Sep 2022 06:22:23 +0000 Received: from localhost ([127.0.0.1]:57019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWAvf-00034T-69 for submit@debbugs.gnu.org; Thu, 08 Sep 2022 02:22:23 -0400 Received: from mout02.posteo.de ([185.67.36.66]:51645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWAvc-00034F-UI for 55039-done@debbugs.gnu.org; Thu, 08 Sep 2022 02:22:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 6A612240104 for <55039-done@debbugs.gnu.org>; Thu, 8 Sep 2022 08:22:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662618135; bh=Qsd7XZILVDFzNWvghq7hoWJI7OagrgsnV9VJ02o9Vp0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=QBANT/JJ9aTARRbgZZP9YQgxHDGvu2VxJUhNwkPJFM1g5x5Oc4lUAG9PWsRVGEBJq 1U46dIRWSPAeziHDf+Kzq/LE3n4cZITRq7WatDfzW5o2OYq8XYEKA/R1AtszZtVyLv KRvj7mFJ4C94q11XA7PfQhWBSbzctGH6iyA42Yb28huhcwu5f81Owl4VdcMLJHxfyA s7kMlhbbMRfaNdeVxgF9E7QBrl6veEFFqzPbEPGJnsVIwv5scq75Gozg1Hz4P1Oyz/ MauZZNpv7PgZNMJ44tuP3XjJBK3dSD7H/OjC7JVS7dzCwl8SneCDYvuwW4LJ5of/Vr BJ7Zc+QEQsRNg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MNTYf6y51z6tnY; Thu, 8 Sep 2022 08:22:14 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <831qsmh1cd.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Sep 2022 08:38:58 +0300") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> <83wnafgvre.fsf@gnu.org> <87h71jnpty.fsf@posteo.net> <83mtbbgik1.fsf@gnu.org> <87wnaft4zd.fsf@posteo.net> <83edwnggz5.fsf@gnu.org> <87pmg6ubdx.fsf@posteo.net> <831qsmh1cd.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Thu, 08 Sep 2022 06:22:13 +0000 Message-ID: <87fsh2tmga.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039-done Cc: larsi@gnus.org, 55039-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: larsi@gnus.org, 55039@debbugs.gnu.org >> Date: Wed, 07 Sep 2022 21:23:38 +0000 >> >> >> It wasn't because of your comments, rather I just felt mentioning it was >> >> too clumsy, and a few others said they didn't feel it was necessary to >> >> mention the option in the manual. But if you think that it should be >> >> added, then I'll try it again and take your comments into account. >> > >> > Yes, I think it should be in the manual. But if you'd rather leave >> > that to me, I'm fine with that. >> >> Here is my latest attempt (will merge it into the patch): > > LGTM, thanks. Great, I've pushed the commit. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 03:07:24 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 07:07:24 +0000 Received: from localhost ([127.0.0.1]:57073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWBdE-0004Hq-2q for submit@debbugs.gnu.org; Thu, 08 Sep 2022 03:07:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWBdB-0004Hd-OI for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 03:07:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWBd5-0005d8-Im; Thu, 08 Sep 2022 03:07:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TBIHa8+3uyAqvvjTgMmXhqp3wDUMX6GJ/yZlxnfHQSM=; b=oyNHyrMT8+rc LigRDaW6B618ZHl5v/RMtHJ9TVb2y3NI7Z3HvfxoRdRlsMBL93RE+itwhsmPLpXkFAqJ3hH+NrN2k NP1afjudNp7NMdiScslBFzqjJZujY8hVp2sm7dl+9bBpyzUYi49UcNwX3MFoQ+JT86bKGf1pcIuDe us0zLERIIbdMVZnbRrLm9rV166YH2sdknw3FRkH6LKU1bl6WKpxg5NiHptaT2HxyWxxRFmd02f1ky D5Dgi7ky5z3MKRC+0LqGLd138+V/RzK8UJl4RfUCkYoyARx/70SE8xzw8lFRWxVEpgqN2JxGmuJsH +EdbctYeqzMcBuY2Jxlhxg==; Received: from [87.69.77.57] (port=4055 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWBd4-0006du-UZ; Thu, 08 Sep 2022 03:07:15 -0400 Date: Thu, 08 Sep 2022 10:07:00 +0300 Message-Id: <83mtbafip7.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87bkrsdzzm.fsf@posteo.net> (message from Philip Kaludercic on Tue, 06 Sep 2022 20:11:57 +0000) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: larsi@gnus.org, 55039@debbugs.gnu.org > Date: Tue, 06 Sep 2022 20:11:57 +0000 > > >> Also, as the entire point of > >> the patch was that emacs.git is using relative path names, should a > >> .dir-locals.el variable be set to ensure this is done? > > > > I guess so, yes. But what would happen to people who use Emacs > > versions before 29? > > It should have no effect. Unfortunately, this is not true, at least not the way this was implemented in our .dir-locals.el. Now, whenever I visit _any_ file in the repository, I get this warning pop up: The local variables list in d:/gnu/git/emacs/trunk/ contains values that may not be safe (*). Do you want to apply it? You can type y -- to apply the local variables list. n -- to ignore the local variables list. ! -- to apply the local variables list, and permanently mark these values (*) as safe (in the future, they will be set automatically.) i -- to ignore the local variables list, and permanently mark these values (*) as ignored tab-width : 8 sentence-end-double-space : t fill-column : 70 emacs-lisp-docstring-fill-column : 65 bug-reference-url-format : "https://debbugs.gnu.org/%s" * diff-add-log-use-relative-names : t indent-tabs-mode : nil electric-quote-comment : nil electric-quote-string : nil mode : bug-reference-prog and I _must_ type a response. If I answer !, Emacs will write to my init file, which I'm not sure I like; if I type y, I will have to do that for every file I visit. This is the nuisance caused by immediately adding newly introduced variables into file-local or directory-local settings to our repository. We should keep this in mind when introducing such stuff. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 04:46:08 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 08:46:08 +0000 Received: from localhost ([127.0.0.1]:57212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWDAl-0006qM-RG for submit@debbugs.gnu.org; Thu, 08 Sep 2022 04:46:08 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWDAk-0006pe-Lm for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 04:46:07 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BEDB1240027 for <55039@debbugs.gnu.org>; Thu, 8 Sep 2022 10:45:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662626760; bh=X7PmFRbh37s0haYOuoQGYeBb7TZJZSG+IhULBGZOiFI=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=r3kwn2DKxaQytPTFduZEfGg6aWFLjJY7i8EePqehb6lnqSr6ifekHRfz0425LuWtV 8nPJ5JsQS/wosj0UaH/s1axODoy+ClwHHZiNA44RduUmGC+m4F3W1CotbPoVv4u/pj mu8rCc6yYmzaDJEpVuPOswhDkMdxdgU3PYhLum5CSbcgzdDORUufv4pz6KNg3Joyw7 T2jA1bAxoAMEC5/BIFK9uk5Y8iwHAtOrqu1HStOENqh9TE79pGyyzvd+0KWYLXoomM QYJlHBAnPw8YFdJSOegE3zvk4OmDhmQ9sdgr+h1FYs8g5g6M/I38rGeP3N2E/rXRZK Q1nQAt6Pjwrgg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MNXlT4dM8z9rxL; Thu, 8 Sep 2022 10:45:56 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <83mtbafip7.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Sep 2022 10:07:00 +0300") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Thu, 08 Sep 2022 08:45:47 +0000 Message-ID: <87sfl26ypw.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: larsi@gnus.org, 55039@debbugs.gnu.org >> Date: Tue, 06 Sep 2022 20:11:57 +0000 >> >> >> Also, as the entire point of >> >> the patch was that emacs.git is using relative path names, should a >> >> .dir-locals.el variable be set to ensure this is done? >> > >> > I guess so, yes. But what would happen to people who use Emacs >> > versions before 29? >> >> It should have no effect. > > Unfortunately, this is not true, at least not the way this was > implemented in our .dir-locals.el. Now, whenever I visit _any_ file > in the repository, I get this warning pop up: > > The local variables list in d:/gnu/git/emacs/trunk/ > contains values that may not be safe (*). > > Do you want to apply it? You can type > y -- to apply the local variables list. > n -- to ignore the local variables list. > ! -- to apply the local variables list, and permanently mark these > values (*) as safe (in the future, they will be set automatically.) > i -- to ignore the local variables list, and permanently mark these > values (*) as ignored > > tab-width : 8 > sentence-end-double-space : t > fill-column : 70 > emacs-lisp-docstring-fill-column : 65 > bug-reference-url-format : "https://debbugs.gnu.org/%s" > * diff-add-log-use-relative-names : t > indent-tabs-mode : nil > electric-quote-comment : nil > electric-quote-string : nil > mode : bug-reference-prog > > and I _must_ type a response. If I answer !, Emacs will write to my > init file, which I'm not sure I like; if I type y, I will have to do > that for every file I visit. I see, should I revert the change? > This is the nuisance caused by immediately adding newly introduced > variables into file-local or directory-local settings to our > repository. We should keep this in mind when introducing such stuff. Generally speaking, the ability to set a variable only if the symbol is bound would be useful for features like these. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 05:20:38 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 09:20:38 +0000 Received: from localhost ([127.0.0.1]:57268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWDi9-0007lr-QZ for submit@debbugs.gnu.org; Thu, 08 Sep 2022 05:20:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWDi7-0007lc-Fq for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 05:20:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWDi2-0000zx-7K; Thu, 08 Sep 2022 05:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Hccm1HQcMgCRvKfTVDI1+/2Y7RY8p/seV0XiGV0vGS0=; b=YCqAT2ZgBFhy 2NbTO0s938VLOBAWmS+eNulrnpcWKo5E01reLD+jmXMGSdfV8680VHxaDr6E1mAvoYeiltlEb+K0C x11mRY1eUjPlvpxOKXZy/TaGSIqhnnqWTLWxBmooh4i6a9SR2CfEcqcOOqyNMZVl0nVlDxRWwj94S xqaZQDojFkeH+qqLxBvye08VyO+XYetcNOQ2F9YgG053gKwqiwoGMaHPKrvmL9P/9vxKRDlX2Tj71 HZf4TdHh8URPVP5hxvEV+KI+dOkstCnzdw6ab3TpuaRuWgkUd1Kkv0CY3MwnJ+cxu9HsHQcMxHOeP dBjSwmdzMQKHQ1hUJs3cGA==; Received: from [87.69.77.57] (port=4230 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWDi0-0000H4-Ml; Thu, 08 Sep 2022 05:20:29 -0400 Date: Thu, 08 Sep 2022 12:20:13 +0300 Message-Id: <838rmufcj6.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87sfl26ypw.fsf@posteo.net> (message from Philip Kaludercic on Thu, 08 Sep 2022 08:45:47 +0000) Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: larsi@gnus.org, 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: larsi@gnus.org, 55039@debbugs.gnu.org > Date: Thu, 08 Sep 2022 08:45:47 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Cc: larsi@gnus.org, 55039@debbugs.gnu.org > >> Date: Tue, 06 Sep 2022 20:11:57 +0000 > >> > >> >> Also, as the entire point of > >> >> the patch was that emacs.git is using relative path names, should a > >> >> .dir-locals.el variable be set to ensure this is done? > >> > > >> > I guess so, yes. But what would happen to people who use Emacs > >> > versions before 29? > >> > >> It should have no effect. > > > > Unfortunately, this is not true, at least not the way this was > > implemented in our .dir-locals.el. Now, whenever I visit _any_ file > > in the repository, I get this warning pop up: > > > > The local variables list in d:/gnu/git/emacs/trunk/ > > contains values that may not be safe (*). > > > > Do you want to apply it? You can type > > y -- to apply the local variables list. > > n -- to ignore the local variables list. > > ! -- to apply the local variables list, and permanently mark these > > values (*) as safe (in the future, they will be set automatically.) > > i -- to ignore the local variables list, and permanently mark these > > values (*) as ignored > > > > tab-width : 8 > > sentence-end-double-space : t > > fill-column : 70 > > emacs-lisp-docstring-fill-column : 65 > > bug-reference-url-format : "https://debbugs.gnu.org/%s" > > * diff-add-log-use-relative-names : t > > indent-tabs-mode : nil > > electric-quote-comment : nil > > electric-quote-string : nil > > mode : bug-reference-prog > > > > and I _must_ type a response. If I answer !, Emacs will write to my > > init file, which I'm not sure I like; if I type y, I will have to do > > that for every file I visit. > > I see, should I revert the change? Is it possible to make the setting dependent on the Emacs version? I don't think there's a need to revert, even if we cannot make this better. Assuming people want this setting very much, that is. Just something to remember for the future: introducing these is not cost-free. > > This is the nuisance caused by immediately adding newly introduced > > variables into file-local or directory-local settings to our > > repository. We should keep this in mind when introducing such stuff. > > Generally speaking, the ability to set a variable only if the symbol is > bound would be useful for features like these. I don't think that's possible in practice, since many variables are loaded only when needed. But if I'm wrong, then yes, it would be good to have such a capability. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 08:11:47 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 12:11:47 +0000 Received: from localhost ([127.0.0.1]:57439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGNn-00064C-GH for submit@debbugs.gnu.org; Thu, 08 Sep 2022 08:11:47 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGNl-00063v-BF for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 08:11:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6nxlVLQgS4gLW25zgx1QoKPcE9qLfr/3Vx1/9WIwyGs=; b=vYLwaMoPpTrCPCXg0ed+byl9BN 9APSER4IBw6jweimW6PCBYmbJo2SXUxdLZG6Cwj/Yq0Zd8brF3weNqnuBqooPQ4wRnBGBMO0U4R7v wfzrZdcXWYQuoBv4Eo2LDIruTzUMOwj+i3zbdKJb7ZEtfqxrB+NTGXE9d74gepaXh3CA=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWGNc-00020t-4L; Thu, 08 Sep 2022 14:11:38 +0200 From: Lars Ingebrigtsen To: Philip Kaludercic Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87sfl26ypw.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 08 Sep 2022 08:45:47 +0000") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> X-Now-Playing: Jan Jelinek's _The Raw and The Cooked_: "The Raw and The Cooked (V)" Date: Thu, 08 Sep 2022 14:11:35 +0200 Message-ID: <87lequ3w20.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philip Kaludercic writes: > Generally speaking, the ability to set a variable only if the symbol is > bound would be useful for features like these. Yes, that would be very nice. But I think introducing something like that would be difficult... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: > Generally speaking, the ability to set a variable only if the symbol is > bound would be useful for features like these. Yes, that would be very nice. But I think introducing something like that would be difficult... Introduce a new syntax like ;; Local Variables: ;; foo-bar: t boundp ;; End: is difficult to make backwards-compatible, but perhaps we can come up with something that older Emacsen will ignore but newer ones can parse? We could also introduce a new section for these variables: ;; Boundp Local Variables: ;; foo-bar: t ;; End: But... I'm not much fan of that. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 08:19:30 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 12:19:30 +0000 Received: from localhost ([127.0.0.1]:57447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGVG-0006GX-Fe for submit@debbugs.gnu.org; Thu, 08 Sep 2022 08:19:30 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGVE-0006GG-MI for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 08:19:29 -0400 Received: by mail-pg1-f196.google.com with SMTP id t65so5635879pgt.2 for <55039@debbugs.gnu.org>; Thu, 08 Sep 2022 05:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=aVgXluViU6F2NWMpJKv62t1ZjvukfoZscBvzw2sGLE0=; b=UTh9lXstuQXbB1j1Uc9e3+sqWjbVr+/UPJns0Hkr0y5CsmUjb6dFDpmMktszTyXfFV 8SV0d/QMzDWevqb5S3ZYU/h1g+eRAVz4IngkdSaU1d4hXSaWJSlZozTb6VUqgv8P1M/Z 5xYbQ4wnBCXZsrXXcjHUwVt5QgjG47M9aq6jvLWMn0rma8SFvenNuCtozX7g2Gm4kh6Q /EisZc5rBFFH7LuXmrpNP9BFDhk6KhuNkw9EeRth83I5jC/v96GC2OkdzKTyY9UVqN8b sCQxqrKR7rxEtbjpuH9k4CG8ltqLYJGoJDKyFHlYgmbSjiTmSIFm6gSn1MMO0t9Nvdkh GfSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=aVgXluViU6F2NWMpJKv62t1ZjvukfoZscBvzw2sGLE0=; b=CA7l1hEppSsyQRjBvbMLEgzhna+bcDPD73VizvJ430CsZIU+PhveojHpL1d7DPV1lk WxlMddUSEARskfHFJPKRyb6WBgO4AdiKJ+gDYziQkwlaZlePaNX5KKo0Ah/d4HaJgP5a LwU0vXi8046bbwi+pO8AXQReICNms0ImplMWoJGnWe1FHSYSTk8FoxjWYT6GjuIQuRCp N3vr9/z8JifD7QQddto9eLYAWf0E3DEuzCMsw9G5pnBtwGuqUcSxkniKZmBpapEgzAJx OaytgehC715rvJeZgXx+fOram2mgMosLILlBVxKe9boanK1y98iHY2nl14i4FFOqLCl3 YwpQ== X-Gm-Message-State: ACgBeo0ulqGtSv29gs2yce0JUdb9oJy6hRIDyhypZvyHVA4UT7mya0cb PP1gkXCQ9Ml8kVhNMk8HBE4= X-Google-Smtp-Source: AA6agR7ibMkUAI8KXJK36j6B04Z5g/2mdLCH+ASvXwoutj2tWPjI0jUhgi1t8CjnbJ83JHyiZ69p3g== X-Received: by 2002:a63:c59:0:b0:42b:c924:cde4 with SMTP id 25-20020a630c59000000b0042bc924cde4mr7804609pgm.279.1662639562879; Thu, 08 Sep 2022 05:19:22 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id n13-20020a170903110d00b0016d72804664sm14468934plh.205.2022.09.08.05.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 05:19:22 -0700 (PDT) From: Visuwesh To: Lars Ingebrigtsen Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87lequ3w20.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 08 Sep 2022 14:11:35 +0200") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> Date: Thu, 08 Sep 2022 17:49:19 +0530 Message-ID: <878rmuxdmg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55039 Cc: Philip Kaludercic , Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=9A= =E0=AF=86=E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0= =AF=8D 08, 2022] Lars Ingebrigtsen wrote: > Philip Kaludercic writes: > >> Generally speaking, the ability to set a variable only if the symbol is >> bound would be useful for features like these. > > Yes, that would be very nice. But I think introducing something like > that would be difficult... > > Introduce a new syntax like > > ;; Local Variables: > ;; foo-bar: t boundp > ;; End: > > is difficult to make backwards-compatible, but perhaps we can come up > with something that older Emacsen will ignore but newer ones can parse? Can we not change where boundp is located? I.e., ;; boundp foo-bar: t ? IMO, this also reads nicely. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 08:34:02 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 12:34:02 +0000 Received: from localhost ([127.0.0.1]:57482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGjJ-0006gr-Lr for submit@debbugs.gnu.org; Thu, 08 Sep 2022 08:34:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGjH-0006gI-JA for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 08:33:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fUt2oL6NGj+jNGTeVcbsWIe1iyc52ODBX5jPHd7ZJts=; b=Ize/YdAo3YcDSq+/o23pb7x4u+ RAbGoUvMcJzJ6atM9QwfsT6X/I9y3l1MADfCFO+TJ3Y0WxzSSpyG1oTN5do2qV/qoRrIzpqUE2HJ/ kcPHaNRbzndCLfwef9FuUc7mqengkI5RZty/fv1nho6XQ74/+wJA9Qe9WL6iokXtyEAE=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWGj8-0002GE-Fu; Thu, 08 Sep 2022 14:33:52 +0200 From: Lars Ingebrigtsen To: Visuwesh Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <878rmuxdmg.fsf@gmail.com> (Visuwesh's message of "Thu, 08 Sep 2022 17:49:19 +0530") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEW+v8VqiK2PXFBK PDX///+YrPXjAAAAAWJLR0QEj2jZUQAAAAlwSFlzAAAASAAAAEgARslrPgAAAAd0SU1FB+YJCAwh I+OPhVQAAAGfSURBVDjLbVSBseswCMP5C5RkgRoWeIH9d/sSttMmV9pzWmRACC4iotrFhmVm9MNP 7yoiL9E+/D3T83ScBYjsZm70wRURiDsHoB7JL4EsW0CUJwicGRa+gLrllSSZMHUA/aAjsh+nav3O AeTZQVmaNJ3AjICrTrcJ6ALKtsrBtLpYMaJNoiClbdUAsOeXRfcJbJ4PAxd9zT7uRoZH/gY+fxwf iwnoBZy5w/0TUHAFUEwwp3pyPIigtOYYDgDxoSCVyAox2yMWMCS1ZYGI2ew8FgK6P3ogchcpxwoV q/tdx75MujdV0biBmD+Bomq2AJ/JnYmuVZUM9XsV5gpG2L2+jfZl9vY1O2Loo0pc9D2rPLYcStlb LsX8NEq8hbHGF4C8NgJZ44U1Mf8UD5YH8LdZNTPLvDfOFBFGDv/ctpnL/CWthQwudskNq4Vdc/IL 8Gh/qvaQ3QJXWm/bA4gKw9ruz0GxHPf5SPkoVXNwMuU6y2DIM2YjsdcyeAGcEtQYF2oqpRH15zsD eza2DUsqU7lgvvK/39XOBJwxfKFQoBr9f1IlsJAyZ+5MAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIy LTA5LTA4VDEyOjMzOjM1KzAwOjAw3K0MmwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOS0wOFQx MjozMzozNSswMDowMK3wtCcAAAAASUVORK5CYII= X-Now-Playing: Melvin Gibbs's _4 + 1 equals 5 for May 25_: "Oh My (feat. Kokayi)" Date: Thu, 08 Sep 2022 14:33:44 +0200 Message-ID: <87bkrq3v13.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Visuwesh writes: > Can we not change where boundp is located? I.e., > > ;; boundp foo-bar: t > > ? IMO, this also reads nicely. But is that backwards-compatible? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Philip Kaludercic , Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Visuwesh writes: > Can we not change where boundp is located? I.e., > > ;; boundp foo-bar: t > > ? IMO, this also reads nicely. But is that backwards-compatible? From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 08:43:30 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 12:43:30 +0000 Received: from localhost ([127.0.0.1]:57542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGsU-0006zO-98 for submit@debbugs.gnu.org; Thu, 08 Sep 2022 08:43:30 -0400 Received: from mout01.posteo.de ([185.67.36.65]:55177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGsS-0006z9-2U for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 08:43:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5CA3C240027 for <55039@debbugs.gnu.org>; Thu, 8 Sep 2022 14:43:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662641002; bh=wseNfZDs0urwzAtU2M00M4HldoThyi7gbXaQ1NwvMZk=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=attQGKZdww7FCMoPLpFyzLGJyQrnMrX0dxcAsPUQU8PwKYLbsr1rvX3n1UKfGfaMe 95zG8An/BTMVglkULHBkXRnwXg3BFaeMoz7Gv4feFyvN4M6EddGto2TqXMZlnKH9JM uGS0xEHd2Z4dgAh/iB7EZB88UtjjOX6lo7uQvz08/X7NTFQxk+0uckdiUdeP+/ilOa ptf29wCwJNajbtRN3meo1/9tMIMq7yYcSicBjPhUDUiGoKGp8vmLTkS4imRX0R9doR 6C78CAjzRHK7IcsAuiHC3f23So8tKQ0aqJLMFBkEl3+4Q5EFNtttzzP3muUohPA0z8 fY9CaBudFBCuw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MNf1P2FFdz9rxN; Thu, 8 Sep 2022 14:43:21 +0200 (CEST) From: Philip Kaludercic To: Lars Ingebrigtsen Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87bkrq3v13.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 08 Sep 2022 14:33:44 +0200") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> <87bkrq3v13.fsf@gnus.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Thu, 08 Sep 2022 12:43:20 +0000 Message-ID: <8735d26npz.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org, Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Visuwesh writes: > >> Can we not change where boundp is located? I.e., >> >> ;; boundp foo-bar: t >> >> ? IMO, this also reads nicely. > > But is that backwards-compatible? ^ typo? If you meant incompatible, it is any more or less incompatible than adding the boundp to the end of the line? From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 08:44:23 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 12:44:23 +0000 Received: from localhost ([127.0.0.1]:57551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGtL-00071M-0y for submit@debbugs.gnu.org; Thu, 08 Sep 2022 08:44:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGtI-00070w-RY for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 08:44:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7XiVT4pI1md1QK86BDfBehSG8/iq/P4i68DkyfvSnTw=; b=LITsyvyiWR2OjjFc4FiLSQhb9O E6kwwBizVBn6lKNGhVF9W3mg1rpGbvNgyG+KyMCyPQqLaPgjV/aDs8HHTXrS3HR+BYOJUQznQDUbq zFS4cjvCHalsTQGwjnXb2eOkGNQnL470x5FvxinQqokXNxy16z8/dXJPmg2jOIcMzeFw=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWGtA-0002Ns-6j; Thu, 08 Sep 2022 14:44:14 +0200 From: Lars Ingebrigtsen To: Philip Kaludercic Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <8735d26npz.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 08 Sep 2022 12:43:20 +0000") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> <87bkrq3v13.fsf@gnus.org> <8735d26npz.fsf@posteo.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEW+v8VqiK2PXFBK PDX///+YrPXjAAAAAWJLR0QEj2jZUQAAAAlwSFlzAAAASAAAAEgARslrPgAAAAd0SU1FB+YJCAwh I+OPhVQAAAGfSURBVDjLbVSBseswCMP5C5RkgRoWeIH9d/sSttMmV9pzWmRACC4iotrFhmVm9MNP 7yoiL9E+/D3T83ScBYjsZm70wRURiDsHoB7JL4EsW0CUJwicGRa+gLrllSSZMHUA/aAjsh+nav3O AeTZQVmaNJ3AjICrTrcJ6ALKtsrBtLpYMaJNoiClbdUAsOeXRfcJbJ4PAxd9zT7uRoZH/gY+fxwf iwnoBZy5w/0TUHAFUEwwp3pyPIigtOYYDgDxoSCVyAox2yMWMCS1ZYGI2ew8FgK6P3ogchcpxwoV q/tdx75MujdV0biBmD+Bomq2AJ/JnYmuVZUM9XsV5gpG2L2+jfZl9vY1O2Loo0pc9D2rPLYcStlb LsX8NEq8hbHGF4C8NgJZ44U1Mf8UD5YH8LdZNTPLvDfOFBFGDv/ctpnL/CWthQwudskNq4Vdc/IL 8Gh/qvaQ3QJXWm/bA4gKw9ruz0GxHPf5SPkoVXNwMuU6y2DIM2YjsdcyeAGcEtQYF2oqpRH15zsD eza2DUsqU7lgvvK/39XOBJwxfKFQoBr9f1IlsJAyZ+5MAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIy LTA5LTA4VDEyOjMzOjM1KzAwOjAw3K0MmwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOS0wOFQx MjozMzozNSswMDowMK3wtCcAAAAASUVORK5CYII= X-Now-Playing: Melvin Gibbs's _4 + 1 equals 5 for May 25_: "Message from the Streets (feat. Kokayi)" Date: Thu, 08 Sep 2022 14:44:11 +0200 Message-ID: <87wnae2fz8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philip Kaludercic writes: >> But is that backwards-compatible? > ^ typo? No? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org, Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: >> But is that backwards-compatible? > ^ typo? No? > If you meant incompatible, it is any more or less incompatible than > adding the boundp to the end of the line? It was a question -- I wouldn't have asked if I knew what the answer was. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 08:52:31 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 12:52:32 +0000 Received: from localhost ([127.0.0.1]:57581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWH1D-0000yO-IM for submit@debbugs.gnu.org; Thu, 08 Sep 2022 08:52:31 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:53861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWH1C-0000yB-Me for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 08:52:31 -0400 Received: by mail-wm1-f51.google.com with SMTP id h1so10772877wmd.3 for <55039@debbugs.gnu.org>; Thu, 08 Sep 2022 05:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=D1Bpf23hBj48ejA0YytKlJLpMdlBydKHD2I93TI9RMk=; b=kkf0/WmBLbaDAwQPBcVsflbGJihfvFk/q82sDTXIMPr5xyIuFTaM1x947dvHC881if uY6C657WrVDZOZPa06a+hTiiUZopLipGIJXVF+lSYVzwZQcGWJsg2oREsLzXd61z0ZM/ KRp6d2KHHDlkMt2ybOgzEm+PKta4QkFHzhrFVPPz+O/vBSFdlfU2Z2qdQKR4jL8guvuw iWcQKJEsY8wKMKn0LmTVTXN+3MVt6OUJwTINJwg82uLQrMPSZQ2pmtrXHJ8G2ULhFXZ3 9nq3dj0cnahovo1OFVTMGFuidCpw7OlFr3voY9RNzeAvp2LF2S4t2pB/pcyfzcpk/Of4 4O+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=D1Bpf23hBj48ejA0YytKlJLpMdlBydKHD2I93TI9RMk=; b=gHQA9dEceK4zQesyR8x8qKPELZMttUrRmhh6TGsTYmWq+OAZUlhMxnQny7jaNE5Fd8 3ZJoQcMO2hSQBtWRZiDry32x4O3fZdfnV13DBuSZYJW7iqWPkqsGeY+gqoB9BF2sLMkN l0dGAxsFX8XL5v4qrmF5vqOU6pvPYZtJ0tsOLb0B4IvQQy2SE+XW5GM0wgqkAiZbyE6l ELHpUUH8zDV0GVYk2H2TDvI5EE/uRJILVaQ6E3S93LyqpMQAIfNeqvDixH9uDo3eobGc 2u3OZAol2cgMgDS2JdszCkEvYV6OKUkr4z7dwHTMv8ppUjZIv0NXGq/JHUVK3tLgqqVd a3YA== X-Gm-Message-State: ACgBeo1KqOScfYHpr3tyiWracgztfSvoPjHbxQC6fjufE1Jv3oStR7IB mxPlNFKldLGR2+iDx7tRVZcim1tMwIc= X-Google-Smtp-Source: AA6agR7x0dSabPgzbmARTILyESvjjd+m5KuX80aaOLviR5LO5kgp5TWKx9gToUmcg5opob7Eljj3IA== X-Received: by 2002:a05:600c:3d91:b0:3a5:4132:b6a0 with SMTP id bi17-20020a05600c3d9100b003a54132b6a0mr2063186wmb.126.1662641544580; Thu, 08 Sep 2022 05:52:24 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:c77e:eb83:4552:e88d]) by smtp.gmail.com with ESMTPSA id z18-20020a5d6552000000b00228ddd9e1d5sm8480784wrv.98.2022.09.08.05.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 05:52:23 -0700 (PDT) From: Robert Pluim To: Visuwesh Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <878rmuxdmg.fsf@gmail.com> (Visuwesh's message of "Thu, 08 Sep 2022 17:49:19 +0530") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> Date: Thu, 08 Sep 2022 14:52:23 +0200 Message-ID: <87y1uu81vc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55039 Cc: Lars Ingebrigtsen , Eli Zaretskii , Philip Kaludercic , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 08 Sep 2022 17:49:19 +0530, Visuwesh sa= id: Visuwesh> [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF= =8D =E0=AE=9A=E0=AF=86=E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE= =AA=E0=AE=B0=E0=AF=8D 08, 2022] Lars Ingebrigtsen wrote: >> Philip Kaludercic writes: >>=20 >>> Generally speaking, the ability to set a variable only if the symbo= l is >>> bound would be useful for features like these. >>=20 >> Yes, that would be very nice. But I think introducing something like >> that would be difficult... >>=20 >> Introduce a new syntax like >>=20 >> ;; Local Variables: >> ;; foo-bar: t boundp >> ;; End: >>=20 >> is difficult to make backwards-compatible, but perhaps we can come up >> with something that older Emacsen will ignore but newer ones can par= se? Visuwesh> Can we not change where boundp is located? I.e., Visuwesh> ;; boundp foo-bar: t Visuwesh> ? IMO, this also reads nicely. There=CA=BCs always: eval: (when (boundp =CA=BCfoo-bar) (setq foo-bar t)) but that causes prompting by default. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 08:53:17 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 12:53:17 +0000 Received: from localhost ([127.0.0.1]:57585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWH1x-00010f-07 for submit@debbugs.gnu.org; Thu, 08 Sep 2022 08:53:17 -0400 Received: from mout02.posteo.de ([185.67.36.66]:36311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWH1v-00010Q-4p for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 08:53:15 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 35358240104 for <55039@debbugs.gnu.org>; Thu, 8 Sep 2022 14:53:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662641589; bh=QNI2m4FdbxmoMWJ5FokDlP+uFzaOleQKaiZuYs1TE/w=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=mF5cYFBnVi/KYzaBS926wg4fWNwiaFva8Yz57TANxpA4QPF1Id1B42j1uusk62IYF KfJTZOtj4taF4RXBEJLNlpUELQWdwVBlRFbF0etjjG2d1KLyqhnUZaegJPKZ5r8Dd9 CxUqPuxf0B0CnLTMxZh4Zq2HkUNBiPL+z+uh+90Yf6cBtLX3z2YWPYVtMVFktOsAD0 fLuRsRLRROgkPzUnOwG+qeycHKGWLNTw+/IMdQ4dSJp6gbPXL3S7eJyRWLl/rRom3C tsvVPL9lf99K9+35G8zaCg/vGu0ZFJ6IEGb1x+LQ5QehjpgH8WLDSBLvIxl4GgF6Rr idQKMbJIHdA6g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MNfDh32xkz6ttF; Thu, 8 Sep 2022 14:53:08 +0200 (CEST) From: Philip Kaludercic To: Lars Ingebrigtsen Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87wnae2fz8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 08 Sep 2022 14:44:11 +0200") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> <87bkrq3v13.fsf@gnus.org> <8735d26npz.fsf@posteo.net> <87wnae2fz8.fsf@gnus.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Thu, 08 Sep 2022 12:53:07 +0000 Message-ID: <87y1uu58p8.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org, Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >>> But is that backwards-compatible? >> ^ typo? > > No? > >> If you meant incompatible, it is any more or less incompatible than >> adding the boundp to the end of the line? > > It was a question -- I wouldn't have asked if I knew what the answer > was. In that case I am confused, if ;; boundp foo-bar: t is backwards-compatible it appears preferable. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 08:56:30 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 12:56:30 +0000 Received: from localhost ([127.0.0.1]:57615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWH4z-00017O-PC for submit@debbugs.gnu.org; Thu, 08 Sep 2022 08:56:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWH4m-00016z-8P for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 08:56:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IhNI5BCUGaQ0fyhrhtTwO2OMSu6aM1FRLA0Uz9N2I9Q=; b=iYUDm5ljx45rPxfiXOFu+eVmcH sXdF2SaZbBcmTMC2AC0aVOtWz+ZYw0cUIl9OT3mox4jBE2XvOAlI9JUTsOK8g1TzSKC2MNTt6kG7J IpKkxsvR6+/lMnYZKQ1+Py6ovUdGXGVDA/Yv0IGhT/TRnQtx/udkgOVWY4doATVlaStA=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWH4d-0002UX-KT; Thu, 08 Sep 2022 14:56:05 +0200 From: Lars Ingebrigtsen To: Philip Kaludercic Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87y1uu58p8.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 08 Sep 2022 12:53:07 +0000") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> <87bkrq3v13.fsf@gnus.org> <8735d26npz.fsf@posteo.net> <87wnae2fz8.fsf@gnus.org> <87y1uu58p8.fsf@posteo.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWXlWNpalDFzrf/ //+6G1XXAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0SU1FB+YJCAw3Jo99 xAwAAAEDSURBVCjPbdG9boQwDAfwfxCWKqYghb0duvAUQTqWm5wq3ts36XBT99tvaKWKp6zzBQw1 QsoPJ8GJgRQGw6aBf0A4QOQPTCLzkTlDdQKmHQbUnwHs0xZd1eC8vg00ok0j3ZgbDIww27nCBu8r AJEVrqATrZOogCXHNcO5UWIDmV6PsA4F1jtaLgV9WBiMmmGS0Z+gZRc8SQy+og8SVkWXQDehA9+B XlCBaLSyBrH6f99gFFzxPn2INOhQM7ZgTadhh4Ikfr6VDRZ9IkpGQkxj1HJC4ApDd3E75GcwDXCv jrRqzPl6490feLPYga9PTA3b9sDku9yfdOEkyN3WL78oXdz+AJswgvt/SGGhAAAAWmVYSWZNTQAq AAAACAAFARIAAwAAAAEAAQAAARoABQAAAAEAAABKARsABQAAAAEAAABSASgAAwAAAAEAAgAAAhMA AwAAAAEAAQAAAAAAAAAAAEgAAAABAAAASAAAAAEfUvc0AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIy LTA5LTA4VDEyOjU1OjM4KzAwOjAwWNHXXwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOS0wOFQx Mjo1NTozOCswMDowMCmMb+MAAAAXdEVYdGV4aWY6WUNiQ3JQb3NpdGlvbmluZwAxrA+AYwAAAABJ RU5ErkJggg== X-Now-Playing: Body =?utf-8?Q?Me=CF=80a's?= _The Work Is Slow_: "Horse Flower Storm-Fabuloso" Date: Thu, 08 Sep 2022 14:56:02 +0200 Message-ID: <87h71i2ffh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philip Kaludercic writes: > In that case I am confused, if > > ;; boundp foo-bar: t > > is backwards-compatible it appears preferable. Now I'm confused! I'm not sure how you can be confused by a request for information? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org, Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: > In that case I am confused, if > > ;; boundp foo-bar: t > > is backwards-compatible it appears preferable. Now I'm confused! I'm not sure how you can be confused by a request for information? From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 08:57:07 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 12:57:07 +0000 Received: from localhost ([127.0.0.1]:57619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWH5f-000191-C0 for submit@debbugs.gnu.org; Thu, 08 Sep 2022 08:57:07 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:38607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWH5b-00018C-H1 for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 08:57:05 -0400 Received: by mail-wr1-f41.google.com with SMTP id b5so25927927wrr.5 for <55039@debbugs.gnu.org>; Thu, 08 Sep 2022 05:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=yPEEdcYsdFxexAHV05IElAg/finSSDzjs2X21puBT+E=; b=MIhankAQUMJdJSdK7Tat+kJ87JZMOCw7q6zVlwMdQ3jT3Z3yEjKzGluyGk/CXxlk2x Hiu2MI4pBT8V5vBWEEq/g7+7uThwDOqQuF9+qxtiAxdobfdvR2o0JJK6ZK9ztCtk9HzX Sd80Os+ccySHFjTtm/Ig22xoOTT4hH+D0bkSqO6ccqQNVsbz/lZDQuTnz7jbldS6JsMd 6ZJRCvl8Ds+6ABHE4Sxq7upeZfLaQj+MDwRMafTn6Qyehn04zTCQJ3jCW5KizhZseVEP EXYy8hEoSwg+w+tVt1F7ASZHP8p0JDx4M+wg/+oySvqzo78GHOnb/NLW3wDWM/jgD2/U jFrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=yPEEdcYsdFxexAHV05IElAg/finSSDzjs2X21puBT+E=; b=rdEROm8z0ugVFnv8ANVDDOQVQWCaJR6FMYmiO9yaICMrUYG9wQxNLcx86fgLHXwB/m BkrNAPmT217h9BaveJIxfM7N3vLLPH3Nr7Tzwk30D4v9wp1sxSfKF3Ci1670XV+RmMnt 5nLIX4FSkrCStSOZhwFwM/Q1HOkpw3I87JkIZpbTQxmP08VNhdEiPt+eohBxIJquadkw KQr0RpCGShm+MZa6bgu2z4WP3kGznQR1xBT8f8kvPjRM+FvhyIXlU4ErYBwf2ODZUdmy RZiimCNSrF5DlvXoPTAelfsDYmQ4Zyh3naSAKaR9Vfs5uQn8gmOicKI5qZEYtUP0Q97w XacQ== X-Gm-Message-State: ACgBeo35JkI0t5jp5WxCIbLcE/+89M54x2vU8r3UEgeBu7tExxbQvvcB Rtd7wtY07tVzarZIwU9l8S4= X-Google-Smtp-Source: AA6agR6ZquHq9OsHGBCpbFPvo+0M4QyMT9An2w6fef52G7xYhgal86qJiW5xIK/mYVwtQZX37Ks1+A== X-Received: by 2002:adf:f98b:0:b0:22a:2946:d98f with SMTP id f11-20020adff98b000000b0022a2946d98fmr3116409wrr.636.1662641817686; Thu, 08 Sep 2022 05:56:57 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:c77e:eb83:4552:e88d]) by smtp.gmail.com with ESMTPSA id h41-20020a05600c49a900b003a604a29a34sm2461414wmp.35.2022.09.08.05.56.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 05:56:57 -0700 (PDT) From: Robert Pluim To: Philip Kaludercic Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87y1uu58p8.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 08 Sep 2022 12:53:07 +0000") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> <87bkrq3v13.fsf@gnus.org> <8735d26npz.fsf@posteo.net> <87wnae2fz8.fsf@gnus.org> <87y1uu58p8.fsf@posteo.net> Date: Thu, 08 Sep 2022 14:56:56 +0200 Message-ID: <87tu5i81nr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55039 Cc: Lars Ingebrigtsen , Visuwesh , Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 08 Sep 2022 12:53:07 +0000, Philip Kaludercic said: Philip> Lars Ingebrigtsen writes: >> Philip Kaludercic writes: >> >>>> But is that backwards-compatible? >>> ^ typo? >> >> No? >> >>> If you meant incompatible, it is any more or less incompatible than >>> adding the boundp to the end of the line? >> >> It was a question -- I wouldn't have asked if I knew what the answer >> was. Philip> In that case I am confused, if Philip> ;; boundp foo-bar: t Philip> is backwards-compatible it appears preferable. File mode specification error: (user-error Malformed local variable line: "boundp foo-bar: t") Robert -- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 09:11:12 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 13:11:13 +0000 Received: from localhost ([127.0.0.1]:57653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWHJI-0003gp-NG for submit@debbugs.gnu.org; Thu, 08 Sep 2022 09:11:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWHJC-0003g2-Mp for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 09:11:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9ZD9biLENrRgNcB8XsM6wH1q/eDOd8XOjDStYnoo96k=; b=I+pU0rwGZWbRFtAB7ujQ6z0zPp oSPLDX+OhC2r2wl2ftJyUfq3kfJe+Vz5FIzfeh4YYaiiWulwfxr8cYiHAwD2ZtkSsHqKyUPXxx/jw 6zPtnonal1tL+FNJol5aJsX6ARE5F33miYvl1oOC48ryd29jH8VoWDjVEB5g2FDcsEgc=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWHJ3-0002dG-Vd; Thu, 08 Sep 2022 15:11:00 +0200 From: Lars Ingebrigtsen To: Robert Pluim Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87tu5i81nr.fsf@gmail.com> (Robert Pluim's message of "Thu, 08 Sep 2022 14:56:56 +0200") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> <87bkrq3v13.fsf@gnus.org> <8735d26npz.fsf@posteo.net> <87wnae2fz8.fsf@gnus.org> <87y1uu58p8.fsf@posteo.net> <87tu5i81nr.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWXlWNpalDFzrf/ //+6G1XXAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0SU1FB+YJCAw3Jo99 xAwAAAEDSURBVCjPbdG9boQwDAfwfxCWKqYghb0duvAUQTqWm5wq3ts36XBT99tvaKWKp6zzBQw1 QsoPJ8GJgRQGw6aBf0A4QOQPTCLzkTlDdQKmHQbUnwHs0xZd1eC8vg00ok0j3ZgbDIww27nCBu8r AJEVrqATrZOogCXHNcO5UWIDmV6PsA4F1jtaLgV9WBiMmmGS0Z+gZRc8SQy+og8SVkWXQDehA9+B XlCBaLSyBrH6f99gFFzxPn2INOhQM7ZgTadhh4Ikfr6VDRZ9IkpGQkxj1HJC4ApDd3E75GcwDXCv jrRqzPl6490feLPYga9PTA3b9sDku9yfdOEkyN3WL78oXdz+AJswgvt/SGGhAAAAWmVYSWZNTQAq AAAACAAFARIAAwAAAAEAAQAAARoABQAAAAEAAABKARsABQAAAAEAAABSASgAAwAAAAEAAgAAAhMA AwAAAAEAAQAAAAAAAAAAAEgAAAABAAAASAAAAAEfUvc0AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIy LTA5LTA4VDEyOjU1OjM4KzAwOjAwWNHXXwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOS0wOFQx Mjo1NTozOCswMDowMCmMb+MAAAAXdEVYdGV4aWY6WUNiQ3JQb3NpdGlvbmluZwAxrA+AYwAAAABJ RU5ErkJggg== X-Now-Playing: Body =?utf-8?Q?Me=CF=80a's?= _The Work Is Slow_: "Motherwell" Date: Thu, 08 Sep 2022 15:10:57 +0200 Message-ID: <87zgfa1066.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > File mode specification error: (user-error Malformed local variable > line: "boundp foo-bar: t") Thanks. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Philip Kaludercic , Visuwesh , Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: > File mode specification error: (user-error Malformed local variable > line: "boundp foo-bar: t") Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 09:13:35 2022 Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 13:13:35 +0000 Received: from localhost ([127.0.0.1]:57660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWHLb-0003kd-5J for submit@debbugs.gnu.org; Thu, 08 Sep 2022 09:13:35 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWHLZ-0003kP-6B for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 09:13:34 -0400 Received: by mail-pf1-f196.google.com with SMTP id b23so1309974pfp.9 for <55039@debbugs.gnu.org>; Thu, 08 Sep 2022 06:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=2iDEAjoCWEWTMYXlacqFdcBefZePqzN7oac0Mu2As64=; b=Y9UgO17b5bGuWkwQ4w0FTiQgjCFfLqpNGvfpPZqrb29Jc8xfdq7mhIbMzGmbQzP/di zb98oSgaIdPwCy8AdOKUD7nGzrp2oZiMkjSHjuU38rH+m5GvyNTOA7QJWvEwQGHb5buk suDsegM0HbKmnWxfplb3E9uAj4nUpb+pyVXLTMLllVHQueXJHjDBDcYQ/yALLEjHLU2R pgoypbfzFecx4XgRA8fasKpNqRSMps8f4K4vDtgYAwYquvUCRdC24NlMOLx7oMQ0S3rl dAL+9mgHi48I9sOpiuSzv/riDbVjIfKsI23q5wnc0maQmCUttWo+i9sJmMkVtnSp9PTk 8a6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=2iDEAjoCWEWTMYXlacqFdcBefZePqzN7oac0Mu2As64=; b=JJQkYeWJ8uYvIYSJobuIzY9OszyEJJxkfXkYSYx1gkRsVrFRepT9d3+9vHhfKaLb9F o7ZmsL+TuadfXFbyCnLcKdch5RSgQEpUpmfh87EkGuxvqkXCwNrkvFpLSQubia39YOdU L9e7DaBrHXSI+WJVqgsN4Tg4t5pnJXvZTsE90U0ITdMxCZkgTKioqewT9GfnWORJkJMA oCPdNzWuxVXzp9LctBz/weCuGlSoP/E5NF2/pHnJGvdjbAIko6ayAbk8LqXPzpxggDFn skjEPa9/aeD3nhgqPcO/ZeI+WtEapu5BJAyFhcJXT57r9KXiihdA8CXVQQXk4qIeXm30 AVZw== X-Gm-Message-State: ACgBeo1sYKSalSecae9PM6Q5sUr7sS0RI/Be7IoHIQgIRFta7Xatx7Kk ruagxOUsVldeLZqpAW8V6Hw= X-Google-Smtp-Source: AA6agR5oDtV6gh3iDgoaLvEwjxniNICJKhVtUItlj4UfqIGh6fuoB/Sotfx7A64w2bykQF8iKc70ZA== X-Received: by 2002:a63:e513:0:b0:42b:d733:602d with SMTP id r19-20020a63e513000000b0042bd733602dmr7499408pgh.549.1662642807041; Thu, 08 Sep 2022 06:13:27 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id y14-20020aa79e0e000000b0053f2505318asm2110241pfq.142.2022.09.08.06.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 06:13:26 -0700 (PDT) From: Visuwesh To: Lars Ingebrigtsen Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87bkrq3v13.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 08 Sep 2022 14:33:44 +0200") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> <87bkrq3v13.fsf@gnus.org> Date: Thu, 08 Sep 2022 18:43:22 +0530 Message-ID: <87y1uuvwjx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55039 Cc: Philip Kaludercic , Eli Zaretskii , 55039@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=9A= =E0=AF=86=E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0= =AF=8D 08, 2022] Lars Ingebrigtsen wrote: > Visuwesh writes: > >> Can we not change where boundp is located? I.e., >> >> ;; boundp foo-bar: t >> >> ? IMO, this also reads nicely. > > But is that backwards-compatible? Doesn't seem to be the case unfortunately. No idea what I was thinking about when I wrote that. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 04:16:50 2022 Received: (at 55039) by debbugs.gnu.org; 11 Sep 2022 08:16:51 +0000 Received: from localhost ([127.0.0.1]:40688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXI94-0004bX-Gf for submit@debbugs.gnu.org; Sun, 11 Sep 2022 04:16:50 -0400 Received: from mout01.posteo.de ([185.67.36.65]:46923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXI92-0004bJ-Qh for 55039@debbugs.gnu.org; Sun, 11 Sep 2022 04:16:49 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CC71E240029 for <55039@debbugs.gnu.org>; Sun, 11 Sep 2022 10:16:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662884202; bh=siqe7zKKdPD/4kTAbrfvYOK7I5EDr5+uts47CZjm5dg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=YhyrHRYIGA/HU893531mnJ5FCcJsU8XSGWOKEqPsTQieW9XLBXkPiPIdXIJYMourM d2NJp3rOoYm0+PTLLKBx2Jm834eKusDdjQuuevEyPpQfbkQnJNm+GW9DTjSVk194yL TWePyOomAdJtKCtsqhprWbTSZU1Wa9eESfGy5fouS1MQjYNkgPCrwpAmtKGEbI5HK0 JjJK+f7Jqek8cd+WHELl2CXy5IC4T26FDBBr6QNlHRJae3jKGA0QWN4SX5iNzeuf7X /GAGhPD2BOjhCoZfeUN47dHmc5zuC+GwX+ReKvVq6U54YwBV1Zg5tnkFjTjgV92Hde zlaTand0oGOFA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MQMyK4Nrvz6tmd; Sun, 11 Sep 2022 10:16:38 +0200 (CEST) From: Philip Kaludercic To: Lars Ingebrigtsen Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <87h71i2ffh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 08 Sep 2022 14:56:02 +0200") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> <87bkrq3v13.fsf@gnus.org> <8735d26npz.fsf@posteo.net> <87wnae2fz8.fsf@gnus.org> <87y1uu58p8.fsf@posteo.net> <87h71i2ffh.fsf@gnus.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Sun, 11 Sep 2022 08:16:38 +0000 Message-ID: <875yhul40p.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org, Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> In that case I am confused, if >> >> ;; boundp foo-bar: t >> >> is backwards-compatible it appears preferable. > > Now I'm confused! I'm not sure how you can be confused by a request for > information? Never mind, I had misread the thread. It appears that if backwards-compatibility is of importance, an additional section would be necessary. Perhaps this could also be used as an opportunity to update how buffer local variables are specified in general. Are there any other issues that are known besides this one? Robert Pluim writes: >>>>>> On Thu, 08 Sep 2022 12:53:07 +0000, Philip Kaludercic said: > > Philip> Lars Ingebrigtsen writes: > >> Philip Kaludercic writes: > >> > >>>> But is that backwards-compatible? > >>> ^ typo? > >> > >> No? > >> > >>> If you meant incompatible, it is any more or less incompatible than > >>> adding the boundp to the end of the line? > >> > >> It was a question -- I wouldn't have asked if I knew what the answer > >> was. > > Philip> In that case I am confused, if > > Philip> ;; boundp foo-bar: t > > Philip> is backwards-compatible it appears preferable. > > File mode specification error: (user-error Malformed local variable line: "boundp foo-bar: t") > > Robert From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 07:08:20 2022 Received: (at 55039) by debbugs.gnu.org; 11 Sep 2022 11:08:20 +0000 Received: from localhost ([127.0.0.1]:40876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXKp1-0002ok-R4 for submit@debbugs.gnu.org; Sun, 11 Sep 2022 07:08:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXKoz-0002oX-OQ for 55039@debbugs.gnu.org; Sun, 11 Sep 2022 07:08:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eZt9+tyz6ZSnekQuvsM/FeEfRGroCYNvWz2vJZQgx9Y=; b=Y9Y09ew7z+ZM/2PnLHdV/Po5V6 4A4mXPSptzJbWBTT+rsL9wOyeRBRpc3uzfFpplD3kYaVFygKpBWLXFeptwgZtsM2AXDiDglZ+cmGe Tq3fnm0Hh1vlG6imaxoJM0ipqG8VkyqVSUrwtlfsJ+MUNRwraZRwVlYyru7DGyn7O5S8=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXKoq-0003Z2-QP; Sun, 11 Sep 2022 13:08:11 +0200 From: Lars Ingebrigtsen To: Philip Kaludercic Subject: Re: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries In-Reply-To: <875yhul40p.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 11 Sep 2022 08:16:38 +0000") References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> <87lequ3w20.fsf@gnus.org> <878rmuxdmg.fsf@gmail.com> <87bkrq3v13.fsf@gnus.org> <8735d26npz.fsf@posteo.net> <87wnae2fz8.fsf@gnus.org> <87y1uu58p8.fsf@posteo.net> <87h71i2ffh.fsf@gnus.org> <875yhul40p.fsf@posteo.net> X-Now-Playing: Insides's _Euphoria_: "Distractions" Date: Sun, 11 Sep 2022 13:08:08 +0200 Message-ID: <87k06agodj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philip Kaludercic writes: > Perhaps this could also be used as an opportunity to update how buffer > local variables are specified in general. Are there any other issues > that are known besides this one? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55039 Cc: Eli Zaretskii , 55039@debbugs.gnu.org, Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: > Perhaps this could also be used as an opportunity to update how buffer > local variables are specified in general. Are there any other issues > that are known besides this one? There was also discussion about whether to allow some variables to be set before calling the mode function, and not afterwards. Major modes clear local variables, so they have to be set afterwards. But some major modes behave differently based on variable settings, so they should be set first sometimes. Being able to specify that would also be nice. From unknown Sat Aug 16 23:40:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 09 Oct 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator