GNU bug report logs - #55007
Minibuffer prompt is incorrect in Viper mode since commit 50512e3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55007 in the body.
You can then email your comments to 55007 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: atheik <atteh.mailbox <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Minibuffer prompt is incorrect in Viper mode since commit 50512e3
Date: Mon, 18 Apr 2022 22:12:57 +0300

The use of 'format-prompt' in 'lisp/emulation/viper-cmd.el' results in
incorrect minibuffer prompts in Viper mode. It does not make sense to
append ": " to the minibuffer prompt when entering commands in command
mode. Commit 50512e3 also changed the behavior such that the default
prompt does not disappear when a character is entered into the
minibuffer when entering a command in command mode.

Please consider reverting the changes done in commit 50512e3 for
'lisp/emulation/viper-cmd.el'.

Message #8 received at 55007 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: atheik <atteh.mailbox <at> gmail.com>
Cc: 55007 <at> debbugs.gnu.org
Subject: Re: bug#55007: Minibuffer prompt is incorrect in Viper mode since
 commit 50512e3
Date: Tue, 19 Apr 2022 13:48:16 +0200

atheik <atteh.mailbox <at> gmail.com> writes:

> Please consider reverting the changes done in commit 50512e3 for
> 'lisp/emulation/viper-cmd.el'.

I've now done so in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 55007 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: atteh.mailbox <at> gmail.com, 55007 <at> debbugs.gnu.org
Subject: Re: bug#55007: Minibuffer prompt is incorrect in Viper mode since
 commit 50512e3
Date: Tue, 19 Apr 2022 15:54:50 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Tue, 19 Apr 2022 13:48:16 +0200
> Cc: 55007 <at> debbugs.gnu.org
> 
> atheik <atteh.mailbox <at> gmail.com> writes:
> 
> > Please consider reverting the changes done in commit 50512e3 for
> > 'lisp/emulation/viper-cmd.el'.
> 
> I've now done so in Emacs 29.

Shouldn't we do this on the release branch instead?  I thought this
was a regression in Emacs 28.1?

Message #16 received at 55007 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: atteh.mailbox <at> gmail.com, 55007 <at> debbugs.gnu.org
Subject: Re: bug#55007: Minibuffer prompt is incorrect in Viper mode since
 commit 50512e3
Date: Wed, 20 Apr 2022 12:37:29 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> Shouldn't we do this on the release branch instead?  I thought this
> was a regression in Emacs 28.1?

The bug report didn't mention an Emacs version.  But I see you're right,
so I've cherry-picked this for emacs-28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.