GNU bug report logs - #55000
[PATCH] gnu: Fix incorrect path in home-fish-service

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#55000: closed ([PATCH] gnu: Fix incorrect path in
 home-fish-service)
Date: Thu, 28 Apr 2022 22:00:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 28 Apr 2022 23:59:24 +0200
with message-id <874k2cc1j7.fsf <at> gnu.org>
and subject line Re: bug#55000: [PATCH] gnu: Fix incorrect path in home-fish-service
has caused the debbugs.gnu.org bug report #55000,
regarding [PATCH] gnu: Fix incorrect path in home-fish-service
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
55000: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55000
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maya <maya.omase <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Fix incorrect path in home-fish-service
Date: Sun, 17 Apr 2022 19:05:48 +0000

I haven't found any info on this and I wasn't sure if I should open a bug report. I believe this is a bug in the home-fish-service, as guix home copies the configuration file to "~/config/fish/config.fish" but the path where fish looks for is "~/.config/fish/config.fish"

Other than that it functions correctly, it must've been a mistake as one rarely changes this file and once in the right place, it works perfectly. Without it though, the guix home is non-functional.

Regards,
Maya
---
 gnu/home/services/shells.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/home/services/shells.scm b/gnu/home/services/shells.scm
index d96c951cd8..fd0a8397f6 100644
--- a/gnu/home/services/shells.scm
+++ b/gnu/home/services/shells.scm
@@ -586,7 +586,7 @@ (define-configuration home-fish-configuration
    serialize-fish-abbreviations))

 (define (fish-files-service config)
-  `(("config/fish/config.fish"
+  `((".config/fish/config.fish"
      ,(mixed-text-file
        "fish-config.fish"
        #~(string-append "\
--
2.35.1

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maya <maya.omase <at> protonmail.com>
Cc: 55000-done <at> debbugs.gnu.org
Subject: Re: bug#55000: [PATCH] gnu: Fix incorrect path in home-fish-service
Date: Thu, 28 Apr 2022 23:59:24 +0200

Hi,

Maya <maya.omase <at> protonmail.com> skribis:

> I haven't found any info on this and I wasn't sure if I should open a bug report. I believe this is a bug in the home-fish-service, as guix home copies the configuration file to "~/config/fish/config.fish" but the path where fish looks for is "~/.config/fish/config.fish"
>
> Other than that it functions correctly, it must've been a mistake as one rarely changes this file and once in the right place, it works perfectly. Without it though, the guix home is non-functional.

Indeed.  This is because ‘home-files-service-type’ no longer prepends
“.” to file names.

Applied now, thanks!

Ludo’.

PS: And congrats on getting bug #55000.  :-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.