GNU bug report logs - #54998
[PATCH] gnu: Add servefile.

Previous Next

To reply to this bug, email your comments to 54998 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Cc: Stefan Reichör <stefan <at> xsteve.at>
Subject: [PATCH] gnu: Add servefile.
Date: Sun, 17 Apr 2022 23:29:54 +0200

* gnu/packages/web.scm (servefile): New variable.
---
 gnu/packages/web.scm | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index ee74a4385d..9df55d21cc 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -47,7 +47,7 @@
 ;;; Copyright © 2020, 2021 Ryan Prior <rprior <at> protonmail.com>
 ;;; Copyright © 2020 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
-;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
+;;; Copyright © 2021, 2022 Stefan Reichör <stefan <at> xsteve.at>
 ;;; Copyright © 2021 la snesne <lasnesne <at> lagunposprasihopre.org>
 ;;; Copyright © 2021 Matthew James Kraai <kraai <at> ftbfs.org>
 ;;; Copyright © 2021 Sarah Morgensen <iskarian <at> mgsn.dev>
@@ -5000,6 +5000,27 @@ can easily be invoked on a single file.  Your partner can access the file with
 tools they trust (e.g. wget).")
     (license license:gpl2+)))
 
+(define-public servefile
+  (package
+    (name "servefile")
+    (version "0.5.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "servefile" version))
+       (sha256
+        (base32
+         "1ywi9yzc2l24nxfb2mvmkha7qfaapjvqchd6rhjbc54ijwrdq9m1"))))
+    (build-system python-build-system)
+    (inputs (list python-pyopenssl))
+    (arguments
+     '(#:tests? #f)) ; tests fail
+    (home-page "https://github.com/sebageek/servefile")
+    (synopsis "Serve or receive files from shell via a small HTTP server")
+    (description "Serve files from shell via a small HTTP server. It
+also supports uploads, SSL, HTTP basic auth and directory listings.")
+    (license license:gpl3+)))
+
 (define netsurf-buildsystem
   (package
     (name "netsurf-buildsystem")
-- 
2.25.1

Message #8 received at 54998 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Stefan Reichör <stefan <at> xsteve.at>, 
 54998 <at> debbugs.gnu.org
Subject: Re: [bug#54998] [PATCH] gnu: Add servefile.
Date: Mon, 18 Apr 2022 13:48:30 +0200

[Message part 1 (text/plain, inline)]

Stefan Reichör schreef op zo 17-04-2022 om 23:29 [+0200]:
> +    (arguments
> +     '(#:tests? #f)) ; tests fail

Which tests?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 54998 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Stefan Reichör <stefan <at> xsteve.at>, 
 54998 <at> debbugs.gnu.org
Subject: Re: [bug#54998] [PATCH] gnu: Add servefile.
Date: Mon, 18 Apr 2022 13:54:11 +0200

[Message part 1 (text/plain, inline)]

Stefan Reichör schreef op zo 17-04-2022 om 23:29 [+0200]:
> +    (inputs (list python-pyopenssl))

Looking at
<https://github.com/sebageek/servefile/blob/master/servefile/servefile.py#L270>,
it looks like it depends on 'tar', 'gzip', 'bzip2' and 'xz',
which might need to be absolutised.

Typo at line
<https://github.com/sebageek/servefile/blob/0b010d5c10c5010963a8b8bc0e61cff914dd9b56/servefile/servefile.py#L351>.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 54998 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Stefan Reichör <stefan <at> xsteve.at>, 
 54998 <at> debbugs.gnu.org
Subject: Re: [bug#54998] [PATCH] gnu: Add servefile.
Date: Mon, 18 Apr 2022 13:55:33 +0200

[Message part 1 (text/plain, inline)]

Stefan Reichör schreef op zo 17-04-2022 om 23:29 [+0200]:
> +    (description "Serve files from shell via a small HTTP server. It
> +also supports uploads, SSL, HTTP basic auth and directory listings.")

Nowadays it's called TLS; not SSL (SSL is the old version)

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 54998 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Stefan Reichör <stefan <at> xsteve.at>, 
 54998 <at> debbugs.gnu.org
Subject: Re: [bug#54998] [PATCH] gnu: Add servefile.
Date: Mon, 18 Apr 2022 13:57:14 +0200

[Message part 1 (text/plain, inline)]

Stefan Reichör schreef op zo 17-04-2022 om 23:29 [+0200]:
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "servefile" version))
> +       (sha256
> +        (base32
> +         "1ywi9yzc2l24nxfb2mvmkha7qfaapjvqchd6rhjbc54ijwrdq9m1"))))

It uses TLSv1_2_METHOD which apparently is deprecated
(https://stackoverflow.com/questions/58143753/why-can-i-not-found-tlsv1-3-client-method-when-programming-with-openssl),
for TLS 1.3 support something else needs to be done here.

Given the potential security impact, I think it's important here to do
the non-deprecated thing.

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 54998 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Stefan Reichör <stefan <at> xsteve.at>, 
 54998 <at> debbugs.gnu.org
Subject: Re: [bug#54998] [PATCH] gnu: Add servefile.
Date: Mon, 18 Apr 2022 13:58:44 +0200

[Message part 1 (text/plain, inline)]

Stefan Reichör schreef op zo 17-04-2022 om 23:29 [+0200]:
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "servefile" version))
> +       (sha256
> +        (base32
> +        

At
<https://github.com/sebageek/servefile/blob/0b010d5c10c5010963a8b8bc0e61cff914dd9b56/servefile/servefile.py#L861>
and following lines, things like 'ip', 'sed', 'grep' and 'ifconfig' are
run and may need to be absolutised with an appropriate 'substitute*'.

G

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 54998 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 54998 <at> debbugs.gnu.org
Subject: RE: Adding servefile to Guix
Date: Mon, 1 Apr 2024 10:03:46 +0100

Hi Stefan,

Are you still interested in adding Servefile to Guix?

Looks like the upstream has released a new version, and you can add bugs to the upstream tracker for the issues that Maxime advised. If you could update and reroll your patch hopefully we can get it reviewed!

Thanks,

Futurile / Steve

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.