From unknown Sat Jun 14 18:52:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Apr 2022 20:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 54976@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165014224727048 (code B ref -1); Sat, 16 Apr 2022 20:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Apr 2022 20:50:47 +0000 Received: from localhost ([127.0.0.1]:34416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfpNW-00072C-Sn for submit@debbugs.gnu.org; Sat, 16 Apr 2022 16:50:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:52580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfpNV-000724-F4 for submit@debbugs.gnu.org; Sat, 16 Apr 2022 16:50:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfpNV-0005NK-2U for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2022 16:50:45 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:33289) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfpNT-0007dZ-0B for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2022 16:50:44 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 2820B3201FD3 for ; Sat, 16 Apr 2022 16:50:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 16 Apr 2022 16:50:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t= 1650142240; x=1650228640; bh=B4LvRv5wyWqgVbtf3Xjxi26xy/bhLZ70WLp Lvjwyszw=; b=VlWClGN0puudYyi1XPxjDJUJc89mvfKQOha+NxqEsu26UUMKXEA vD5HlgRvUOL2M99IF0EUQFU9Y1ELWojr4ncZCIAkDcLJCAeMRz6+v0/dLIVokdyc LTGVI1SsmQZWeq12AwpJv5bb+82RWtXvb53RGM9th02kQtVxSfNs9MVVUQCAyDqQ U0r/CRasc5xtonxpqJEexjJ60oj+NVY3zIKbZxB7GnzQdvB2MJQPjv8/nvs+kTJg mYM13ySdkOXBe86z/gUucSJ1BuUg3wXAQB9Ob7PO+UJD78Iqwy+xWMMeuY03sEx9 EA3RJ82QGDYYeYzv2fh52F23Xp+JWYAK+4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1650142240; x=1650228640; bh=B4LvRv5wyWqgV btf3Xjxi26xy/bhLZ70WLpLvjwyszw=; b=F07SdXyZbAg3g0JI9pjs3cqJPjOcN d1Cs5fi8LZbnkoGZTHpxiDHTdkhsVTCRE4A6mWMUFn+Y9AWhfr1UcMkvo04Y9buz NLGs7ydNS3P9rXyCwxU4uMXZunE2K7k1khSmnbEHE9fQ39vBRjDU1RsPOXdeqjFI lDEfc/4r8Vmg+T1zp9CD6ecVvF+khkX5rg3g9RvbkeV7+/4qZkG62bTgaNU5Z9f9 3zumFK/SJPaCvrUGDnwnPG16FqLWf9z8HPVkJ7zYrprJDmICh8aEqTSQcMEchl8g Xb/6YWlB0MjRrwv3sFqsmX2t20l0buP5eyV1JdCkV27074FGQ9x2QfSWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeljedgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgffffkgggtsehttddttd dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepkeffveegfeetvdetud fhtefffeefheehkeejfeehieffvdejleeltedtueeivdeinecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih htthhonhdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sat, 16 Apr 2022 16:50:40 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 689437E511F; Sat, 16 Apr 2022 13:50:39 -0700 (MST) From: Sean Whitton User-Agent: Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Sat, 16 Apr 2022 13:50:39 -0700 Message-ID: <87czhgkb1c.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.25; envelope-from=spwhitton@spwhitton.name; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Hello, Suppose you put this in your init.el: (add-to-list 'eshell-modules-list 'eshell-elecslash) because you want to use the new em-elecslash.el module I'm working on. Then if you try to M-x eshell on an older version of Emacs which lacks em-elecslash, Eshell will fail to initialise at all. It is easy add a guard (when (locate-library ...)) or similar, but this is not possible if you have added eshell-elecslash using the customise interface. In that case, by enabling the module, youq just make your init unusable with older Emacs. It would be better to print a warning, say, rather than error. -- Sean Whitton From unknown Sat Jun 14 18:52:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jun 2022 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 54976@debbugs.gnu.org Received: via spool by 54976-submit@debbugs.gnu.org id=B54976.165565066725417 (code B ref 54976); Sun, 19 Jun 2022 14:58:01 +0000 Received: (at 54976) by debbugs.gnu.org; 19 Jun 2022 14:57:47 +0000 Received: from localhost ([127.0.0.1]:52843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2wN0-0006bo-JY for submit@debbugs.gnu.org; Sun, 19 Jun 2022 10:57:46 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:33125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2wMy-0006bT-RA for 54976@debbugs.gnu.org; Sun, 19 Jun 2022 10:57:45 -0400 Received: by mail-pj1-f49.google.com with SMTP id hv24-20020a17090ae41800b001e33eebdb5dso10473229pjb.0 for <54976@debbugs.gnu.org>; Sun, 19 Jun 2022 07:57:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=I9TeUsn0ck7/+cqqmc2ctgauqhnMYDXZPkYtMwiSQGM=; b=7lFppuQPTibp7jn7doSPNlyLZoxK/gin7+k5w6oR5b8h0XAIahDq4cBR42DO+wDlnY O1OCBlw6sdN4HKlKgRxbdcNnspa62677WnJjJc26xdUsXUYzxCRVNu5MM3xgNwUF5Gg/ E2F7eLP2VsCaHAspa9UIU6gFHbH2kNn4bj5y1r9VLALZGaFO9iKLK8Ll0Yj9jOBaLZUc vlkeA/5CSaFaweqBhz9GgbpWlJL98Jr6CTPSMsaxAbRMub6Qv63O+RgQxdPwQuTuDabb 5p1kZ6yf+vzl6cv01Wr8ujSFwPtiAzr5g3EYU/KHQIN7eVY+vhFeCZ8XtYg3L/+H0YGY qDdw== X-Gm-Message-State: AJIora+tLPLoM/xU13AN+pvlFzDrn0hlbxrdVTNLS+UaW/DGYghBMKkm raQ07Y8XuNFqsmcYrAgHE1DkTEHiL3SaGhJ7G8g= X-Google-Smtp-Source: AGRyM1usg74lTpnm4UG/5ajeJoQ4L+vCYGklYlQDITSe6SCMzL5gXxwQUNXS2wC2rZQ3wwKsNp4Dhd3Zznx+nuo/N8U= X-Received: by 2002:a17:902:e8d7:b0:168:e2da:893c with SMTP id v23-20020a170902e8d700b00168e2da893cmr19782643plg.152.1655650658921; Sun, 19 Jun 2022 07:57:38 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Jun 2022 07:57:38 -0700 From: Stefan Kangas In-Reply-To: <87czhgkb1c.fsf@melete.silentflame.com> (Sean Whitton's message of "Sat, 16 Apr 2022 13:50:39 -0700") References: <87czhgkb1c.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Sun, 19 Jun 2022 07:57:38 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 54976 29.1 thanks Sean Whitton writes: > Suppose you put this in your init.el: > > (add-to-list 'eshell-modules-list 'eshell-elecslash) > > because you want to use the new em-elecslash.el module I'm working on. > > Then if you try to M-x eshell on an older version of Emacs which lacks > em-elecslash, Eshell will fail to initialise at all. > > It is easy add a guard (when (locate-library ...)) or similar, but this > is not possible if you have added eshell-elecslash using the customise > interface. In that case, by enabling the module, youq just make your > init unusable with older Emacs. > > It would be better to print a warning, say, rather than error. I agree that it makes more sense to warn here instead of refusing to start. So I have now done that in Emacs 29 (commit d6b4803850). From unknown Sat Jun 14 18:52:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jun 2022 22:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: 54976@debbugs.gnu.org Received: via spool by 54976-submit@debbugs.gnu.org id=B54976.165567759113955 (code B ref 54976); Sun, 19 Jun 2022 22:27:02 +0000 Received: (at 54976) by debbugs.gnu.org; 19 Jun 2022 22:26:31 +0000 Received: from localhost ([127.0.0.1]:53382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o33NH-0003d1-LN for submit@debbugs.gnu.org; Sun, 19 Jun 2022 18:26:31 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:47319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o33NE-0003cm-Rp for 54976@debbugs.gnu.org; Sun, 19 Jun 2022 18:26:30 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C4CC632007CF; Sun, 19 Jun 2022 18:26:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 19 Jun 2022 18:26:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1655677582; x=1655763982; bh=Fk wjBd+gZ/lR7wXOyyZxLaTQw6+euhyZG848GSOo6rI=; b=RNHeAvidIO3m/4Ccel ZLFugyEnvq0MFUKAUp2gAWFPTJP2HO+CBCuFMts8boR5M+ECe0EeWjgO3eg6PYsA x3jkap1yNdzAwYdONOzr3ThmDfPwxKijemiJzSA9BApd0KrsrrlJx27KnfEwZI6V KMn3SKJq2rm0ui0lpyMdYmFFqLVqUeRsbZCvyOaYJfFcHYg/OJpv4RguhOC1hVHo DwHMie6Q/nJK58mv+sHdjweJmYdco3dDoa1CNt+7vDZo4HQ+/0t85o208Ggr47dW wIEf+tMUab/Y0auZzuM4QbHaInf1URUbVP1tDLA1UoDfZB4SeQMMVvBAM56y6VFo /rKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1655677582; x=1655763982; bh=FkwjBd+gZ/lR7wXOyyZxLaTQw6+e uhyZG848GSOo6rI=; b=BwLZzOPVPrn0QwGsVqbXke+12V7yukHTRIiRdwczWBLp GltFWUi9ws1H23cXKGZJinMGZgNfBegD+jzP9xnTP2yecW5nLoa/t1ld1e5OiaJq pgZN1OAyjJg7X/BKh6lDGIvvKSA71dKyfTyGw5iutJQ6egPEpNoRfrDvEjAlrX/j dA0P4PabT5JA/n7uUpCbXMB04MliNiTqvkiiDRyMHGSm86lLTkmRv8UDZ9u7f8b9 c82lhDy3xLlS4Vh9A2w/q18HLmo0cU5KxM7XIqBdw1bSmuPtNQbtpB+NeH07er4D D84vF5BuEi7BKl9g/QwX36xO+nHo+M5yLONZEuU1TA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeftddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedvjeettdeiteejgeejkefggfehtdekledtfedtteekgfeu keeftdduhfetleejkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Jun 2022 18:26:21 -0400 (EDT) Received: by athena.silentflame.com (Postfix, from userid 1000) id C43EE1B630C; Sun, 19 Jun 2022 22:26:20 +0000 (UTC) From: Sean Whitton In-Reply-To: References: <87czhgkb1c.fsf@melete.silentflame.com> User-Agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Sun, 19 Jun 2022 15:26:20 -0700 Message-ID: <87czf4l27n.fsf@athena.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sun 19 Jun 2022 at 07:57am -07, Stefan Kangas wrote: > close 54976 29.1 > thanks > > Sean Whitton writes: > >> Suppose you put this in your init.el: >> >> (add-to-list 'eshell-modules-list 'eshell-elecslash) >> >> because you want to use the new em-elecslash.el module I'm working on. >> >> Then if you try to M-x eshell on an older version of Emacs which lacks >> em-elecslash, Eshell will fail to initialise at all. >> >> It is easy add a guard (when (locate-library ...)) or similar, but this >> is not possible if you have added eshell-elecslash using the customise >> interface. In that case, by enabling the module, youq just make your >> init unusable with older Emacs. >> >> It would be better to print a warning, say, rather than error. > > I agree that it makes more sense to warn here instead of refusing to > start. So I have now done that in Emacs 29 (commit d6b4803850). Many thanks for this! -- Sean Whitton