GNU bug report logs - #54974
[PATCH] added btop

Previous Next

Package: guix-patches;

Reported by: Wil deBeest <bovid-19 <at> 4tii.de>

Date: Sat, 16 Apr 2022 16:18:01 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #14 received at 54974 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Greg Hogan <code <at> greghogan.com>, Wil deBeest <bovid-19 <at> 4tii.de>
Cc: 54974 <at> debbugs.gnu.org
Subject: Re: [bug#54974] [PATCH] added btop
Date: Mon, 18 Apr 2022 20:47:19 +0200

[Message part 1 (text/plain, inline)]
Greg Hogan schreef op ma 18-04-2022 om 09:40 [-0400]:
> Instead of the "replace 'install" lambda, I had done:
>   #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs
> "out")))
> which is both shorter and to my understanding more generic (more
> adaptable to future additional binaries or libraries, though this
> package will likely only ever have a single binary).

Long term, %outputs, %build-inputs, ... are being phased out, so I'd go
with, so I'd go with

   (arguments (list #:make-flags #~(string-append "PREFIX=" #$output)))

here instead.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 2 years and 235 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.