From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 16 12:17:39 2022 Received: (at submit) by debbugs.gnu.org; 16 Apr 2022 16:17:39 +0000 Received: from localhost ([127.0.0.1]:34155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfl7B-0008RM-1T for submit@debbugs.gnu.org; Sat, 16 Apr 2022 12:17:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:36404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfkf3-0007kG-O9 for submit@debbugs.gnu.org; Sat, 16 Apr 2022 11:48:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfkf3-0004CC-HM for guix-patches@gnu.org; Sat, 16 Apr 2022 11:48:33 -0400 Received: from mail.4tii.de ([178.254.9.173]:52104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfkew-00067E-Jy for guix-patches@gnu.org; Sat, 16 Apr 2022 11:48:33 -0400 Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=4tii.de; s=mail; t=1650124103; bh=hLKEPYF4988K0Jk3iHoMdOcSZLmEx2SL2tx1hfzN0e4=; h=From:Subject:Date:To; b=SKtHzBD+JCQdO9jrHR9d/ue9eORtw4zUwlm6vZfDPANU5pBjRy/tJFAEyB9VkDEQx evAYpRpL5Pocao/eIg6yZn+pSsuqkf9fsEWzORRtubjBtqCISE1H8n2pOcG7GkVnag UBg1rCrj872IpdEl/PsGAx8Bn6gKQBkvDp58UVmw= Content-Transfer-Encoding: quoted-printable From: Wil deBeest Mime-Version: 1.0 (1.0) Subject: [PATCH] added btop Message-Id: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> Date: Sat, 16 Apr 2022 17:37:55 +0200 To: guix-patches@gnu.org Received-SPF: pass client-ip=178.254.9.173; envelope-from=bovid-19@4tii.de; helo=mail.4tii.de X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 16 Apr 2022 12:17:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) =EF=BB=BF --- gnu/packages/admin.scm | 52 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 1db04adf71..68f09cdbf9 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -730,6 +730,58 @@ (define-public bpytop memory, disks, network and processes. It's a Python port and continuation o= f @command{bashtop}.") (license license:asl2.0))) +(define-public btop + (package + (name "btop") + (version "1.2.5") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/aristocratos/btop") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1v0lj296bzwgs29hv9z3r82fwmibiqgsvsqqh2fimxs0jmld7c2v")))) + (build-system gnu-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (delete 'configure) ;; not provided + (delete 'check) ;; not provided + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((bin (string-append + (assoc-ref outputs "out")"/bin"))) + (install-file "bin/btop" bin))))))) + (home-page "https://github.com/aristocratos/btop") + (synopsis "Resource monitor for processor, memory, disks, network and p= rocesses") + (description "Resource monitor that shows usage and stats +for processor, memory, disks, network and processes. + +C++ version and continuation of bashtop and bpytop. + +Features + + Easy to use, with a game inspired menu system. + Full mouse support, all buttons with a highlighted key is clickable + and mouse scroll works in process list and menu boxes. + Fast and responsive UI with UP, DOWN keys process selection. + Function for showing detailed stats for selected process. + Ability to filter processes. + Easy switching between sorting options. + Tree view of processes. + Send any signal to selected process. + UI menu for changing all config file options. + Auto scaling graph for network usage. + Shows IO activity and speeds for disks + Battery meter + Selectable symbols for the graphs + Custom presets + And more... +") + (license license:asl2.0))) (define-public pies (package base-commit: 20645d8467852990413c1ea9cf81cec82d23defd --=20 2.35.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 09:40:47 2022 Received: (at 54974) by debbugs.gnu.org; 18 Apr 2022 13:40:47 +0000 Received: from localhost ([127.0.0.1]:38490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngRcU-0007F0-OB for submit@debbugs.gnu.org; Mon, 18 Apr 2022 09:40:47 -0400 Received: from mail-pj1-f53.google.com ([209.85.216.53]:38436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngRcR-0007El-5J for 54974@debbugs.gnu.org; Mon, 18 Apr 2022 09:40:45 -0400 Received: by mail-pj1-f53.google.com with SMTP id s14-20020a17090a880e00b001caaf6d3dd1so17292056pjn.3 for <54974@debbugs.gnu.org>; Mon, 18 Apr 2022 06:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MrwVm2SXLEBHbgYBDElNVem8T8NiCFF5xt8gILIu8M8=; b=SH735xZ4cjEeUnNuP9BU5jPrYwPdiEGXve2ypFvWEOjZnwCTSAOIH0XZL5gfsohi3O wBftxZOTPa3wupspOKxAtRafsFRsu1rSQidsRJZVvZFrwyfKKgC/XDdkTqIzpiNUpu+6 4QwtFpCmNVWK7uuIdyGA1wGTowlaL71/QpirTmnj62WhySzQ0JuyGJuxFOaxvlVGpb7l GKkqaNwb5nmcOt419D7fPUEZ6nhETb/6Xbxbs7FLhjXOEM//yjrRnOBkp1kAqR2X1GsR an76Bvem+mh+wdhnX/qrpI5t9ryvgUWDu/018pzZgtbA/1k9xvG5/krYTFDtWVsuWkWu dTfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MrwVm2SXLEBHbgYBDElNVem8T8NiCFF5xt8gILIu8M8=; b=d3zOw0ExpFi4D9xRJ5BsGiK3/Xw5jGzVJAEc40kZJd9SRLRFFArwopTXMfTmrP/jgp GcBIdLX6AFE5JN1lJfLV1NbigBR+TAPye7X8DUL34vcZ/BRRtYG8oY+tAKvbDV6WCxRW QzzCqMnRelor5yA0BQ6piSwY0/FI+zHkMZdxFkG8azoq+YUnkxeE2ZlZAvz01/I1olgz jr0yeOK+CiT1nyebo6pxxcU7vnghjZPf9JAHMEvAbdjR1jrZYlEb+u2dljNcqSmQLO21 EH1iFKNPuZjML0USSFecqI6kZia52X0JYsD/KqyS59mLExAdgPdQsWV/qXWoJk09OBrv 2QMg== X-Gm-Message-State: AOAM531X/YYKDCHEzX7UufpG0/zg4PhCQHZT7mM7xVtffbHl2sKOVGk6 H+bKJyEntbRHxt/5VmFCkQfmxlFW2rzgOVYBdBShcq00Sp7hkTTg X-Google-Smtp-Source: ABdhPJwk+iKWDyHC9d8naY+nFMDJqRbr0m2UR5gbVhwovo1G7w6F+NKOkIyp3O47UKtu5Mv1Dvu758W8UbsZ7oFAU74= X-Received: by 2002:a17:902:c944:b0:158:de4a:6975 with SMTP id i4-20020a170902c94400b00158de4a6975mr10881373pla.131.1650289237217; Mon, 18 Apr 2022 06:40:37 -0700 (PDT) MIME-Version: 1.0 References: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> In-Reply-To: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> From: Greg Hogan Date: Mon, 18 Apr 2022 09:40:26 -0400 Message-ID: Subject: Re: [bug#54974] [PATCH] added btop To: Wil deBeest Content-Type: multipart/alternative; boundary="000000000000c2e43105dcede75d" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54974 Cc: 54974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c2e43105dcede75d Content-Type: text/plain; charset="UTF-8" Hi Wil, I had recently looked at adding this package so I happen to have a few comments. v1.2.6 was released last week. Is it preferable to "(delete 'check)" the test phase or specify the "#:tests? #f" argument? Instead of the "replace 'install" lambda, I had done: #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))) which is both shorter and to my understanding more generic (more adaptable to future additional binaries or libraries, though this package will likely only ever have a single binary). Greg On Sat, Apr 16, 2022 at 12:18 PM Wil deBeest wrote: > > --- > gnu/packages/admin.scm | 52 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm > index 1db04adf71..68f09cdbf9 100644 > --- a/gnu/packages/admin.scm > +++ b/gnu/packages/admin.scm > @@ -730,6 +730,58 @@ (define-public bpytop > memory, disks, network and processes. It's a Python port and continuation > of > @command{bashtop}.") > (license license:asl2.0))) > +(define-public btop > + (package > + (name "btop") > + (version "1.2.5") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/aristocratos/btop") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1v0lj296bzwgs29hv9z3r82fwmibiqgsvsqqh2fimxs0jmld7c2v")))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'configure) ;; not provided > + (delete 'check) ;; not provided > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append > + (assoc-ref outputs "out")"/bin"))) > + (install-file "bin/btop" bin))))))) > + (home-page "https://github.com/aristocratos/btop") > + (synopsis "Resource monitor for processor, memory, disks, network and > processes") > + (description "Resource monitor that shows usage and stats > +for processor, memory, disks, network and processes. > + > +C++ version and continuation of bashtop and bpytop. > + > +Features > + > + Easy to use, with a game inspired menu system. > + Full mouse support, all buttons with a highlighted key is clickable > + and mouse scroll works in process list and menu boxes. > + Fast and responsive UI with UP, DOWN keys process selection. > + Function for showing detailed stats for selected process. > + Ability to filter processes. > + Easy switching between sorting options. > + Tree view of processes. > + Send any signal to selected process. > + UI menu for changing all config file options. > + Auto scaling graph for network usage. > + Shows IO activity and speeds for disks > + Battery meter > + Selectable symbols for the graphs > + Custom presets > + And more... > +") > + (license license:asl2.0))) > > (define-public pies > (package > > base-commit: 20645d8467852990413c1ea9cf81cec82d23defd > -- > 2.35.1 > > > > --000000000000c2e43105dcede75d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Wil,

I had recently looked at = adding this package so I happen to have a few comments.

= v1.2.6 was released last week.

Is it preferable=C2= =A0to "(delete 'check)" the test phase or specify the "#= :tests? #f" argument?

Instead of the "re= place 'install" lambda, I had done:
=C2=A0 #:make-flags = (list (string-append "PREFIX=3D" (assoc-ref %outputs "out&qu= ot;)))
which=C2=A0is both shorter and to my understanding more ge= neric (more adaptable to future additional binaries or libraries, though th= is package will likely only ever have a single binary).

Greg

On Sat, Apr 16, 2022 at 12:18 PM Wil deBeest <bovid-19@4tii.de> wrote:

---
gnu/packages/admin.scm | 52 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 1db04adf71..68f09cdbf9 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -730,6 +730,58 @@ (define-public bpytop
memory, disks, network and processes.=C2=A0 It's a Python port and cont= inuation of
@command{bashtop}.")
=C2=A0 =C2=A0 (license license:asl2.0)))
+(define-public btop
+=C2=A0 (package
+=C2=A0 =C2=A0 (name "btop")
+=C2=A0 =C2=A0 (version "1.2.5")
+=C2=A0 =C2=A0 (source
+=C2=A0 =C2=A0 =C2=A0 (origin
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fetch)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "http= s://github.com/aristocratos/btop")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit (string-append &qu= ot;v" version))))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (git-file-name name version))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"1v0lj296bzwgs29hv9z3r82fwmibiqgsvs= qqh2fimxs0jmld7c2v"))))
+=C2=A0 =C2=A0 (build-system gnu-build-system)
+=C2=A0 =C2=A0 (arguments
+=C2=A0 =C2=A0 =C2=A0`(#:phases
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(modify-phases %standard-phases
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete 'configure) ;; not provided<= br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete 'check) ;; not provided
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(replace 'install
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambda* (#:key outputs #:allow-o= ther-keys)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((bin (string-append<= br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(assoc-ref outputs "out")"/bin")))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(install-file "= ;bin/btop" bin)))))))
+=C2=A0 =C2=A0 (home-page "https://github.com/aristocratos/= btop")
+=C2=A0 =C2=A0 (synopsis "Resource monitor for processor, memory, disk= s, network and processes")
+=C2=A0 =C2=A0 (description "Resource monitor that shows usage and sta= ts
+for processor, memory, disks, network and processes.
+
+C++ version and continuation of bashtop and bpytop.
+
+Features
+
+=C2=A0 =C2=A0 Easy to use, with a game inspired menu system.
+=C2=A0 =C2=A0 Full mouse support, all buttons with a highlighted key is cl= ickable
+ and mouse scroll works in process list and menu boxes.
+=C2=A0 =C2=A0 Fast and responsive UI with UP, DOWN keys process selection.=
+=C2=A0 =C2=A0 Function for showing detailed stats for selected process. +=C2=A0 =C2=A0 Ability to filter processes.
+=C2=A0 =C2=A0 Easy switching between sorting options.
+=C2=A0 =C2=A0 Tree view of processes.
+=C2=A0 =C2=A0 Send any signal to selected process.
+=C2=A0 =C2=A0 UI menu for changing all config file options.
+=C2=A0 =C2=A0 Auto scaling graph for network usage.
+=C2=A0 =C2=A0 Shows IO activity and speeds for disks
+=C2=A0 =C2=A0 Battery meter
+=C2=A0 =C2=A0 Selectable symbols for the graphs
+=C2=A0 =C2=A0 Custom presets
+=C2=A0 =C2=A0 And more...
+")
+=C2=A0 =C2=A0 =C2=A0(license license:asl2.0)))

(define-public pies
=C2=A0 (package

base-commit: 20645d8467852990413c1ea9cf81cec82d23defd
--
2.35.1



--000000000000c2e43105dcede75d-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 14:10:34 2022 Received: (at 54974) by debbugs.gnu.org; 18 Apr 2022 18:10:34 +0000 Received: from localhost ([127.0.0.1]:40681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngVpZ-0006Fa-JO for submit@debbugs.gnu.org; Mon, 18 Apr 2022 14:10:33 -0400 Received: from mail.4tii.de ([178.254.9.173]:47490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngViD-00062P-JJ for 54974@debbugs.gnu.org; Mon, 18 Apr 2022 14:02:58 -0400 Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=4tii.de; s=mail; t=1650304970; bh=7hXJMI1qbYdodmv1kdxT2tHPR1rNwdxtBzJPccX4hxk=; h=From:Subject:Date:Cc:To; b=vxLrHYmmOBfj+EMDo5inzURIFSN2bm6ENdYKatOb56YqMZjU6KmHoAOPIxfsHP5h/ sP+BzJi3WIs8/OlPNkgDECwy6qDdTJyUjFst4TT3D6p7myDBwNZI5tUFW7Je8689lT 6cYgXajYl/BnhvhUUO+rP2BEKaHwimP21a9JwFuI= Content-Transfer-Encoding: quoted-printable From: Wil deBeest Mime-Version: 1.0 (1.0) Subject: Re: [bug#54974] [PATCH] added btop Message-Id: Date: Mon, 18 Apr 2022 20:02:49 +0200 To: Greg Hogan X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54974 X-Mailman-Approved-At: Mon, 18 Apr 2022 14:10:32 -0400 Cc: 54974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) =EF=BB=BFGreg Hogan writes: > Hi Wil, Hi Greg, thank you for the feedback! > I had recently looked at adding this package so I happen to have a few com= ments. >=20 > v1.2.6 was released last week. I had updated the package from v1.0.0 before creating the patch, but thanks to my mail server I was only able to send it the other day. > Is it preferable to "(delete 'check)" the test phase or specify the "#:tes= ts? #f" argument? I am quite new to Guix and Scheme, but `#:tests? #f' seems much better to me= . > Instead of the "replace 'install" lambda, I had done: > #:make-flags (list (string-append "PREFIX=3D" (assoc-ref %outputs "out")))= > which is both shorter and to my understanding more generic (more adaptable= to future additional binaries or libraries, though this > package will likely only ever have a single binary). That's definitely neater. I'd suggest you send your patch here to replace my hacky one, but if you prefer I could also incorporate your improvements into mine and update the version. Wil > Greg >=20 > On Sat, Apr 16, 2022 at 12:18 PM Wil deBeest wrote: >=20 > --- > gnu/packages/admin.scm | 52 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) >=20 > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm > index 1db04adf71..68f09cdbf9 100644 > --- a/gnu/packages/admin.scm > +++ b/gnu/packages/admin.scm > @@ -730,6 +730,58 @@ (define-public bpytop > memory, disks, network and processes. It's a Python port and continuation= of > @command{bashtop}.") > (license license:asl2.0))) > +(define-public btop > + (package > + (name "btop") > + (version "1.2.5") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/aristocratos/btop") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1v0lj296bzwgs29hv9z3r82fwmibiqgsvsqqh2fimxs0jmld7c2v")))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'configure) ;; not provided > + (delete 'check) ;; not provided > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append > + (assoc-ref outputs "out")"/bin"))) > + (install-file "bin/btop" bin))))))) > + (home-page "https://github.com/aristocratos/btop") > + (synopsis "Resource monitor for processor, memory, disks, network and= processes") > + (description "Resource monitor that shows usage and stats > +for processor, memory, disks, network and processes. > + > +C++ version and continuation of bashtop and bpytop. > + > +Features > + > + Easy to use, with a game inspired menu system. > + Full mouse support, all buttons with a highlighted key is clickable > + and mouse scroll works in process list and menu boxes. > + Fast and responsive UI with UP, DOWN keys process selection. > + Function for showing detailed stats for selected process. > + Ability to filter processes. > + Easy switching between sorting options. > + Tree view of processes. > + Send any signal to selected process. > + UI menu for changing all config file options. > + Auto scaling graph for network usage. > + Shows IO activity and speeds for disks > + Battery meter > + Selectable symbols for the graphs > + Custom presets > + And more... > +") > + (license license:asl2.0))) >=20 > (define-public pies > (package >=20 > base-commit: 20645d8467852990413c1ea9cf81cec82d23defd > --=20 > 2.35.1 --=20 Pascal From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 14:47:31 2022 Received: (at 54974) by debbugs.gnu.org; 18 Apr 2022 18:47:31 +0000 Received: from localhost ([127.0.0.1]:40772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngWPL-0007F4-4K for submit@debbugs.gnu.org; Mon, 18 Apr 2022 14:47:31 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:54682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngWPJ-0007Ew-BS for 54974@debbugs.gnu.org; Mon, 18 Apr 2022 14:47:30 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id LJnT270074UW6Th06JnTcR; Mon, 18 Apr 2022 20:47:28 +0200 Message-ID: Subject: Re: [bug#54974] [PATCH] added btop From: Maxime Devos To: Greg Hogan , Wil deBeest Date: Mon, 18 Apr 2022 20:47:19 +0200 In-Reply-To: References: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-+j4tw24AFbGaYMPChRGB" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1650307648; bh=Kv80pnFx1UFpz+6tJiV+D40/hpPg/trlmqDYBRI8HK4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=fCDHhL5XDAmeAMppqkAQmhOJLvTLTAfiK6M+0YwwPjZYOi4pkjgiw5roc8GcjiuRO bh2/blB4KiAW/keOeh/6p00UEtPF1nE62qh6izcREbr8ZDG0+QKEOjkPNwKpmFmyQs TZ0xfoML6DmcGxBAFTBIPmD9KOW3lJGe0XNm/C85rcl07Phr+VSGEiTRHpRjLwN5BS rclgmZV593jSwIouoiqzBuw3dR53Eah2gC1Hum8tKd1vdFajmCkD7jnEWeqwpt6crI HwnF2k/Uu1hGULHSY+/fPARvVJFlC/g73ubx/B0I8Q6YBhuJKLVadQ6Uv2GScTbo9F GSF7xl1mmIowg== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54974 Cc: 54974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-+j4tw24AFbGaYMPChRGB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Greg Hogan schreef op ma 18-04-2022 om 09:40 [-0400]: > Instead of the "replace 'install" lambda, I had done: > =C2=A0 #:make-flags (list (string-append "PREFIX=3D" (assoc-ref %outputs > "out"))) > which=C2=A0is both shorter and to my understanding more generic (more > adaptable to future additional binaries or libraries, though this > package will likely only ever have a single binary). Long term, %outputs, %build-inputs, ... are being phased out, so I'd go with, so I'd go with (arguments (list #:make-flags #~(string-append "PREFIX=3D" #$output))) here instead. Greetings, Maxime. --=-+j4tw24AFbGaYMPChRGB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYl2yNxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7o0qAP4wemfFI33yAzLAnrXzJXAHGx9L jBFhgOh3ejsnTwO//gD/TTXigCRbhVfE+0f2nHjddBtkSdvaGcpVJe9BbAMOUQs= =C+YI -----END PGP SIGNATURE----- --=-+j4tw24AFbGaYMPChRGB-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 14:53:12 2022 Received: (at 54974) by debbugs.gnu.org; 18 Apr 2022 18:53:12 +0000 Received: from localhost ([127.0.0.1]:40779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngWUq-0007QQ-Nu for submit@debbugs.gnu.org; Mon, 18 Apr 2022 14:53:12 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:51790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngWUp-0007QI-3a for 54974@debbugs.gnu.org; Mon, 18 Apr 2022 14:53:11 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id LJt92700B4UW6Th06Jt9mX; Mon, 18 Apr 2022 20:53:09 +0200 Message-ID: <97da943a1c1aaea2622bed8e651f3fdb3368e5c4.camel@telenet.be> Subject: Re: [bug#54974] [PATCH] added btop From: Maxime Devos To: Wil deBeest , 54974@debbugs.gnu.org Date: Mon, 18 Apr 2022 20:53:09 +0200 In-Reply-To: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> References: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-qbeG6o4ojqCUc7kkpONg" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1650307989; bh=1tIijsbN+NLHkiEBes1tbojPXRARnKa5KLXHFhqRq38=; h=Subject:From:To:Date:In-Reply-To:References; b=V2u6z74DZBnkUHd3SvqfAqHf+D7c4EKrSmOV/9iiWGnQaR44dYskd/jIoA3S1p5VK 1a+1DU1bom4h/iOmH0x2HHEpOB4YdQZIKz/U0ob19nJzjrieq4dQ5bVwmSiO0zdyY+ ZdNu+9vcwRGva1cPR2fK+ZrhZzEW6H7X4A3513PuHmb3ntekc3u5w7mdgwWdoDVFwr FkP/mipy2Bov9tyJREljnZmggXjNOHsjRq0MP7uk2+Zmk0xoF0rCWhzNlmxJbG6Y87 I8W4S1bXhP81m9OQ5ZyfaLYWYbZCTAWnM16jenrXwNQf6ia/Gg375+Gr/6feOPXlRN xT1sWnmyPqprQ== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54974 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-qbeG6o4ojqCUc7kkpONg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Wil deBeest schreef op za 16-04-2022 om 17:37 [+0200]: > +=C2=A0=C2=A0=C2=A0 (description "Resource monitor that shows usage and s= tats > +for processor, memory, disks, network and processes. > + > +C++ Seems like an implementation detail to me. > version and continuation of bashtop and bpytop. In that case, can 'bashtop' and 'bpytop' be removed now? (Using '(deprecated-package ...) for a smooth transition). Greetings, Maxime. --=-qbeG6o4ojqCUc7kkpONg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYl2zlRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rlSAQD+a5LYt77bsCx3BPHmKM+qV6Em ABpxlCy6CGlkHKZ7UQEAuZ/yzl9k5xQPY2UOkEl1RWe1L9reJmTVL46MvYQN5Q4= =Fges -----END PGP SIGNATURE----- --=-qbeG6o4ojqCUc7kkpONg-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 14:55:33 2022 Received: (at 54974) by debbugs.gnu.org; 18 Apr 2022 18:55:33 +0000 Received: from localhost ([127.0.0.1]:40788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngWX7-0007UK-9d for submit@debbugs.gnu.org; Mon, 18 Apr 2022 14:55:33 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:34464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngWX5-0007UA-Ct for 54974@debbugs.gnu.org; Mon, 18 Apr 2022 14:55:31 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id LJvW2700M4UW6Th06JvWXL; Mon, 18 Apr 2022 20:55:30 +0200 Message-ID: Subject: Re: [bug#54974] [PATCH] added btop From: Maxime Devos To: Wil deBeest , 54974@debbugs.gnu.org Date: Mon, 18 Apr 2022 20:55:30 +0200 In-Reply-To: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> References: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-2OGq4ejFzVtNNmhhp2bS" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1650308130; bh=kKZ2Z8f03C8drcWlk18Qc8oBBMKWrsX97QHA5tyV5fk=; h=Subject:From:To:Date:In-Reply-To:References; b=CzxlZDweeLbOudiozS8qIfxYOImaP7d2q9c1lEyjl+lyM+Ldv1aOeg1nmRJDdFE0y YKmseNksHPHImFQeAHNfBOSh7qTpCwime5gEnMIfAVo606QIbg+Syj+w4W5fq5jibH Xagk5iilHYGs0xtNeHrDl7/bv1AL8e8ENDt8ye9xuT3+/d0pEIoU44RBJnjXhf77J9 KxDCX5nYcIUiu7jziX6aeVB1vDtYbfKir7GUkiXDspbbizRO9jnW/1AbiHdRtAyEXk Z1Fur6WbxNtUkS3azvqUjS1cJvroYXqD6IeOHDXqm8tXu2MH0JuhCOaV9vPd9VIyf7 F3zCkxpY+Ncpw== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54974 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-2OGq4ejFzVtNNmhhp2bS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Wil deBeest schreef op za 16-04-2022 om 17:37 [+0200]: > +Features > + > +=C2=A0=C2=A0=C2=A0 Easy to use, with a game inspired menu system. > +=C2=A0=C2=A0=C2=A0 Full mouse support, all buttons with a highlighted ke= y is clickable > + and mouse scroll works in process list and menu boxes. > +=C2=A0=C2=A0=C2=A0 Fast and responsive UI with UP, DOWN keys process sel= ection. What's an UP and DOWN key? I just have a regular up and down keys but no fancy uppercase UP and DOWN keys ... > +=C2=A0=C2=A0=C2=A0 Function for showing detailed stats for selected proc= ess. > +=C2=A0=C2=A0=C2=A0 Ability to filter processes. > +=C2=A0=C2=A0=C2=A0 Easy switching between sorting options. > +=C2=A0=C2=A0=C2=A0 Tree view of processes. > +=C2=A0=C2=A0=C2=A0 Send any signal to selected process. > +=C2=A0=C2=A0=C2=A0 UI menu for changing all config file options. > +=C2=A0=C2=A0=C2=A0 Auto scaling graph for network usage. > +=C2=A0=C2=A0=C2=A0 Shows IO activity and speeds for disks > +=C2=A0=C2=A0=C2=A0 Battery meter > +=C2=A0=C2=A0=C2=A0 Selectable symbols for the graphs > +=C2=A0=C2=A0=C2=A0 Custom presets > +=C2=A0=C2=A0=C2=A0 And more... It's a list, so you can use the Texinfo markup @itemize, @item and @end itemize here. It's also leaning a bit towards marketing talk with the =E2=80=98and more ...=E2=80=99 and rather subjective =E2=80=98fast and resp= onsive UI=E2=80=99, ... Greetings, Maxime. --=-2OGq4ejFzVtNNmhhp2bS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYl20IhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7gIAAP9I6jdaoijM6fMnpazbyXfKjYOx 0PHaouwIDm9I8nx5RQD/XEMWTBemCzv2tJ6sD5mlEy+o/Wxn8ZAqG1V0cPngmQ8= =E3/1 -----END PGP SIGNATURE----- --=-2OGq4ejFzVtNNmhhp2bS-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 19:17:54 2022 Received: (at 54974) by debbugs.gnu.org; 28 Apr 2022 23:17:55 +0000 Received: from localhost ([127.0.0.1]:50297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkDOU-0006Yr-Bn for submit@debbugs.gnu.org; Thu, 28 Apr 2022 19:17:54 -0400 Received: from mail.4tii.de ([178.254.9.173]:35380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkDOS-0006Ya-UT for 54974@debbugs.gnu.org; Thu, 28 Apr 2022 19:17:53 -0400 Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=4tii.de; s=mail; t=1651187866; bh=2IAiCb1T7HiPUB8OR/BUVNLud5Ak/aQnV++JOlZshJI=; h=From:Subject:Date:Cc:To; b=AzCGJk+iNbevhWs59ooTH/B6oNedEWkaaUdtBdKeGl+LgDobDT9AGGzrJYZLp8vWe UMxpk0PXw9LTQ42WxukUndQsWvubqIeSQQPU/+LHaFKmO0i/7zyJRWMCwCUOzFsr4W 1sJVDUSm3hoy0UpgmZeiHPAXLaVchDiXcjaHMulg= Content-Transfer-Encoding: quoted-printable From: Wil deBeest Mime-Version: 1.0 (1.0) Subject: Re: [bug#54974] [PATCH] added btop Message-Id: <32AB7591-1B34-4AA9-B503-5CAFBCE10D60@4tii.de> Date: Fri, 29 Apr 2022 01:17:44 +0200 To: Maxime Devos X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54974 Cc: 54974@debbugs.gnu.org, Greg Hogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) =EF=BB=BFHi Maxime, > Long term, %outputs, %build-inputs, ... are being phased out, so I'd go > with, so I'd go with >=20 > (arguments (list #:make-flags #~(string-append "PREFIX=3D" #$output))) >=20 > here instead. I haven't been able to integrate your snippet into the package. Could you show me how to do so or tell me which part of the handbook would be relevant? > can 'bashtop' and 'bpytop' be removed now? (Using > '(deprecated-package ...) for a smooth transition). The projects are all by the same developer and bashtop hasn't changed in two= years, so the assumption that the rewrites supersede the older implementati= ons doesn't seem farfetched. > What's an UP and DOWN key? I just have a regular up and down keys but > no fancy uppercase UP and DOWN keys ... > [...] > It's a list, so you can use the Texinfo markup @itemize, @item and @end > itemize here. It's also leaning a bit towards marketing talk with the > =E2=80=98and more ...=E2=80=99 and rather subjective =E2=80=98fast and res= ponsive UI=E2=80=99, ... That was just copy & paste, I had forgotten about cut ;) Cheers Wil |--------------------------| | [PATCH] added btop 1.2.6 | |--------------------------| --- gnu/packages/admin.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index a200050d97..7b2e9660e1 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -752,6 +752,36 @@ (define-public bpytop @command{bashtop}.") (license license:asl2.0))) +(define-public btop + (package + (name "btop") + (version "1.2.6") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/aristocratos/btop") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "03nd34q1w01visd2bg7mxrcjn0s6lnbm4s0vsfsj2mfv1rvyjl5b")))) + (build-system gnu-build-system) + (arguments + `(#:make-flags + (list (string-append "PREFIX=3D" %output)) + #:phases + (modify-phases %standard-phases + (delete 'configure)) + #:tests? #f)) + (home-page "https://github.com/aristocratos/btop") + (synopsis "Resource monitor") + (description "Resource monitor that shows usage and stats +for processor, memory, disks, network and processes. + +C++ version and continuation of bashtop and bpytop.") + (license license:asl2.0))) + (define-public pies (package (name "pies") base-commit: 882cacc1bb5be0df334dd7ce55b385a3a1678728 --=20 2.35.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 29 05:37:29 2022 Received: (at 54974) by debbugs.gnu.org; 29 Apr 2022 09:37:29 +0000 Received: from localhost ([127.0.0.1]:50866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkN45-0005CT-3Y for submit@debbugs.gnu.org; Fri, 29 Apr 2022 05:37:29 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:57136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkN43-0005CI-B1 for 54974@debbugs.gnu.org; Fri, 29 Apr 2022 05:37:27 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by xavier.telenet-ops.be with bizsmtp id QZdR2700R4UW6Th01ZdR5E; Fri, 29 Apr 2022 11:37:26 +0200 Message-ID: Subject: Re: [bug#54974] [PATCH] added btop From: Maxime Devos To: Wil deBeest Date: Fri, 29 Apr 2022 11:37:25 +0200 In-Reply-To: <32AB7591-1B34-4AA9-B503-5CAFBCE10D60@4tii.de> References: <32AB7591-1B34-4AA9-B503-5CAFBCE10D60@4tii.de> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fjXA9fD/FnJ9RdfWb/Ul" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1651225046; bh=ecWk/1zEMi7n3D0k7COTlNs8wCccU0FSlPaowwZ1kLw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=cLjkfa3q5DXvMR0/PhvyyCbP/xHsHV6c2QEylZ4lp9hGDSCwUOv81YcDk5bEWieoN 8qWcRviE3Gra8ZdouYXCquOQThBWsf1eBvFmD02RPL/a3JnMYZgox2k8RWTrdohYKz MVEp94ueWr+U9TRDMUQQxdoC/V99vKeECgEiRb1EcnL+i5QhX5fp1l7VNtsd5HDPK/ ri8k6nSAfPsEwU8XxJQRFWL1kMLjylKOdVeobw7fIEKUSZSroo/eLPCYiebR9L8gfH d1NQa+PvDk3hOVHNT7yKTobAG8o2r1erep9aAcDDUq26rkdhWe5uEYhA2qayPSG1wI mXb5l0w7elI5w== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54974 Cc: 54974@debbugs.gnu.org, Greg Hogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-fjXA9fD/FnJ9RdfWb/Ul Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Wil deBeest schreef op vr 29-04-2022 om 01:17 [+0200]: > =EF=BB=BFHi Maxime, >=20 > > Long term, %outputs, %build-inputs, ... are being phased out, so I'd go > > with, so I'd go with > >=20 > > =C2=A0=C2=A0 (arguments (list #:make-flags #~(string-append "PREFIX=3D"= #$output))) > >=20 > > here instead. >=20 > I haven't been able to integrate your snippet into the package.=C2=A0=C2= =A0 Could you > show me how to do so or tell me which part of the handbook would be > relevant? For a good example, see the 'stress-ng' package definition 'guix edit stress-ng'. #:make-flags is documented in the manual (search for #:make-flags or go to (guix)Build Systems). #$output is documented in =E2=80=98(guix)G-Expressions=E2=80=99. Very concretely: (package [...] (arguments (list #:tests? #false ; some comment #:make-flags #~(...) #:phases ;; [Stuff for replacing the install phase and ;; removing the configure phase] #~(modify-phases %standard-phases ...)))) Greetings, Maxime. --=-fjXA9fD/FnJ9RdfWb/Ul Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmux1RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kiQAP9dhsDjMNzGM4RAbnyGkovqiupM y7zYm6xxg6AHTubuTAEA86YMvLueYIqQ5BzokH9rOdk1XHmkElZdrDrwYUoFsgY= =Krvp -----END PGP SIGNATURE----- --=-fjXA9fD/FnJ9RdfWb/Ul-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 28 07:22:07 2022 Received: (at 54974) by debbugs.gnu.org; 28 May 2022 11:22:07 +0000 Received: from localhost ([127.0.0.1]:36550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuuWF-0005DM-3x for submit@debbugs.gnu.org; Sat, 28 May 2022 07:22:07 -0400 Received: from mail.4tii.de ([178.254.9.173]:47000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuuW6-0005Cf-Qa for 54974@debbugs.gnu.org; Sat, 28 May 2022 07:22:05 -0400 Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=4tii.de; s=mail; t=1653736911; bh=CZlCeZMAkYT9NfN0qao6V8fcjXTGJsG+1ORbsAWy+80=; h=From:Subject:Date:Cc:To; b=4fG/zig8IaoJajMd0oUxRmHMMHWaN/+EeV4cvOrtiz7RfmKQqt6lFyg5Kj2rloNFi 6g00lERggVGsgL7ZUb5a0RsFILhF6hX/G5lKvw67YFOe7on6RGKr4LqWJnuSrQpqbB 3wxuxW1462NKq+HzLwW52iVGZKwBnKseC0q+5R4E= Content-Transfer-Encoding: quoted-printable From: Wil deBeest Mime-Version: 1.0 (1.0) Subject: Re: [bug#54974] [PATCH] added btop Message-Id: Date: Sat, 28 May 2022 13:21:49 +0200 To: Maxime Devos X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54974 Cc: 54974@debbugs.gnu.org, Greg Hogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) =EF=BB=BFMaxime Devos writes: > [[PGP Signed Part:Undecided]] > Wil deBeest schreef op vr 29-04-2022 om 01:17 [+0200]: >> =EF=BB=BFHi Maxime, >>> Long term, %outputs, %build-inputs, ... are being phased out, so I'd go >>> with, so I'd go with >>> (arguments (list #:make-flags #~(string-append "PREFIX=3D" #$output))= ) >>> here instead. >> I haven't been able to integrate your snippet into the package. Could y= ou >> show me how to do so or tell me which part of the handbook would be >> relevant? >=20 > For a good example, see the 'stress-ng' package definition 'guix edit > stress-ng'. #:make-flags is documented in the manual (search for > #:make-flags or go to (guix)Build Systems). #$output is documented in > =E2=80=98(guix)G-Expressions=E2=80=99. >=20 > Very concretely: >=20 > (package > [...] > (arguments (list #:tests? #false ; some comment > #:make-flags #~(...) > #:phases > ;; [Stuff for replacing the install phase and > ;; removing the configure phase] > #~(modify-phases %standard-phases ...)))) >=20 > Greetings, > Maxime. >=20 > [[End of PGP Signed Part]] Thank you, I think I got it. I've also added gcc-12 as a native input for efficiency reasons [1]. Since I'm not familiar with the process of deprecation, I've kept the though= ts I had written down regarding your question on whether bashtop & bpytop co= uld be removed, even though there's probably nothing in there that hasn't at= least been discussed before [2] Cheers! --- gnu/packages/admin.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index af75dee697..fccc0e8dd3 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -101,6 +101,7 @@ (define-module (gnu packages admin) #:use-module (gnu packages file) #:use-module (gnu packages flex) #:use-module (gnu packages gawk) + #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) #:use-module (gnu packages gl) #:use-module (gnu packages glib) @@ -752,6 +753,37 @@ (define-public bpytop @command{bashtop}.") (license license:asl2.0))) +(define-public btop + (package + (name "btop") + (version "1.2.6") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/aristocratos/btop") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "03nd34q1w01visd2bg7mxrcjn0s6lnbm4s0vsfsj2mfv1rvyjl5b")))) + (native-inputs (list gcc-12)) + (build-system gnu-build-system) + (arguments + (list #:make-flags + #~(list (string-append "PREFIX=3D" #$output)) + #:phases + #~(modify-phases %standard-phases + (delete 'configure)) + #:tests? #f)) + (home-page "https://github.com/aristocratos/btop") + (synopsis "Resource monitor") + (description "Resource monitor that shows usage and stats +for processor, memory, disks, network and processes. + +C++ version and continuation of bashtop and bpytop.") + (license license:asl2.0))) + (define-public pies (package (name "pies") base-commit: 6e9d99f97f15347f44df0518faa5e3b8b9d5184e --=20 2.36.1 [1] "Needs GCC 10 or higher, (GCC 11 or above strongly recommended for better CPU efficiency in the compiled binary)", sayeth the readme [2] Is there a mechanism to flag these packages so a deprecation warning would be shown when they are searched for? (A first look seems to suggest `gexp->derivation' could be used for that, but I'll have read that more thoroughly) If there is I think it would make sense to add a deprecation warning including that reasons why they shouldn't be replaced can be directed to e.g. 54974@debbugs.gnu.org and wait for feedback for some set amount of time before either redefining the package names as aliases for btop or removing them. In both cases I think a message would make sense for those who have installed them. For others, adding something like "replaces its predecessors bashtop and bpytop" to the description seems to be enough. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 15:16:29 2022 Received: (at 54974-done) by debbugs.gnu.org; 28 Sep 2022 19:16:29 +0000 Received: from localhost ([127.0.0.1]:34716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odcXk-0002tv-RB for submit@debbugs.gnu.org; Wed, 28 Sep 2022 15:16:29 -0400 Received: from mail-qv1-f53.google.com ([209.85.219.53]:39621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odcXh-0002tV-2s; Wed, 28 Sep 2022 15:16:27 -0400 Received: by mail-qv1-f53.google.com with SMTP id p3so3216668qvz.6; Wed, 28 Sep 2022 12:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date; bh=kKQXald+cUvU9loFd32PcXzYN6Mof5OCLP/xjOw7YC4=; b=OKglsvQjlcWPlhbhEgGJ8P03bwPIdXmR7pmpvZX8PwimJvnSQQV5CtN0HkvvvAH3r1 7RXwkhJSpw3IBSOGBjjltp7t1pbvtY5sEqMzgKHg3kidKXhkGGNSwv4Zojt70byfI1n+ 9Lu9llFVc9/b83s7w+oWrcnCtJa6ugKegyLasxcaAUa8UX/A7TVTlh7PwkHK04K9kZZx iRsh5Uh/NVT4KZWrtOCjkaJaUKzJ1rkgtLz4ZiSVmHgZhEso+z/FR22lZUyfIe0scgXf x61+7OfSg7NfFdRNdknyqQQa5kllkymq5vCateB9f82rYtOP9ffqZNYKjJuceukkv1Lg lRvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=kKQXald+cUvU9loFd32PcXzYN6Mof5OCLP/xjOw7YC4=; b=mJ+bcnrhrWbcpw/GdNdxf8ryMx70o4HIczL1ejQBfqPb7CjuxusU2yiGLuYHM3t/bj RO7W37+RYy+5ffErw2lVtcHIbn2jGfqnvMUuVwT24lNhwEHwF1yyoYLtcVdd+MNXjuAT zgeke6fVUPUsXqPAhdSQqY5Q6XLNta5qixlhShDcpIDHd3NgZIJE1qm4jfwlcQ+NXTDG OiyEfSmnHsoiYam0Bf2chi3KSdZdE5B+VogGcdh6vMATlE34QgPzUvDRkYr+DFPRNVh2 6jkqaLQWTMHC/iKnWHjjBFRg/lQgZUBXl8lKzbXcd0j+RizRy9j7Ew2YkaTU1SaW2NRI AnTQ== X-Gm-Message-State: ACrzQf0pPOPjFGeHqEVwMP6fF0IpvIFbexrTll1DIwfw3Jb2PI29DfYo s5i3G5bK9Py9Hb0CJOYv+/ZDuG4WoqhjIQ== X-Google-Smtp-Source: AMsMyM6nzw6nANuSMkRps2153bpi3mDOKoN3WzIhHGFpQghROWs2fLLGemtEsosZbIbSBx/pU5jjlg== X-Received: by 2002:a05:6214:2aaa:b0:4ac:acbd:7ef8 with SMTP id js10-20020a0562142aaa00b004acacbd7ef8mr27001457qvb.126.1664392579421; Wed, 28 Sep 2022 12:16:19 -0700 (PDT) Received: from hurd (dsl-148-95.b2b2c.ca. [66.158.148.95]) by smtp.gmail.com with ESMTPSA id w13-20020a05620a444d00b006cbd92ca141sm3499019qkp.133.2022.09.28.12.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 12:16:19 -0700 (PDT) From: Maxim Cournoyer To: Maxime Devos Subject: Re: bug#57940: [PATCH] gnu: Add btop. References: <4927c335-f271-5f64-ea7f-759fbbde3141@telenet.be> Date: Wed, 28 Sep 2022 15:16:18 -0400 In-Reply-To: <4927c335-f271-5f64-ea7f-759fbbde3141@telenet.be> (Maxime Devos's message of "Mon, 19 Sep 2022 20:18:41 +0200") Message-ID: <87r0zvtim5.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 54974-done Cc: 57940-done@debbugs.gnu.org, phodina , 54974-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Maxime Devos writes: > merge 54974 57940 57271 > thanks > > Duplicate of , please reply to > 54974@debbugs.gnu.org. I committed this version, since it was easy to apply and had the most modern style. Thanks, Maxim From unknown Sun Jun 22 11:47:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 27 Oct 2022 11:24:19 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator