GNU bug report logs - #54937
[PATCH] gnu: Add cl-numpy-file-format.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54937 in the body.
You can then email your comments to 54937 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Paul A. Patience" <paul <at> apatience.com>
To: guix-patches <at> gnu.org
Cc: "Paul A. Patience" <paul <at> apatience.com>
Subject: [PATCH] gnu: Add cl-numpy-file-format.
Date: Thu, 14 Apr 2022 13:50:44 +0000

* gnu/packages/lisp-xyz.scm (cl-numpy-file-format,
ecl-numpy-file-format, sbcl-numpy-file-format): New variables.
---
 gnu/packages/lisp-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 29b3a10d98..28b25edd24 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -5151,6 +5151,38 @@ (define-public cl-find-port
 (define-public ecl-find-port
   (sbcl-package->ecl-package sbcl-find-port))

+(define-public sbcl-numpy-file-format
+  (let ((commit "e97aef6c592a412fdd1afa9a5f09d0b1ce134510")
+        (revision "1"))
+    (package
+      (name "sbcl-numpy-file-format")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/marcoheisig/numpy-file-format")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0j7jjcf6k3anvgpm4nf81g6gbhff44v0v9rai7kwm2bm3abzsjfd"))))
+      (build-system asdf-build-system/sbcl)
+      (inputs
+       (list sbcl-ieee-floats sbcl-trivial-features))
+      (home-page "https://github.com/marcoheisig/numpy-file-format")
+      (synopsis "Read and write NumPy .npy and .npz files")
+      (description
+       "The NUMPY-FILE-FORMAT library is a Common Lisp library for reading and
+writing NumPy @file{.npy} and @file{.npz} files.")
+      (license license:expat))))
+
+(define-public cl-numpy-file-format
+  (sbcl-package->cl-source-package sbcl-numpy-file-format))
+
+(define-public ecl-numpy-file-format
+  (sbcl-package->ecl-package sbcl-numpy-file-format))
+
 (define-public sbcl-py4cl
   (let ((commit "4c8a2b0814fd311f978964f825ce012290f60136")
         (revision "1"))
--
2.35.1

Message #10 received at 54937-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: 54937-done <at> debbugs.gnu.org
Subject: Re: [bug#54937] [PATCH] gnu: Add cl-numpy-file-format.
Date: Thu, 14 Apr 2022 14:35:33 +0000

[Message part 1 (text/plain, inline)]

Patch pushed as 0ddca9d682013f10b7e0137878ab68363d929167.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 54937-done <at> debbugs.gnu.org (full text, mbox):

From: "Paul A. Patience" <paul <at> apatience.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 54937-done <at> debbugs.gnu.org
Subject: Re: [bug#54937] [PATCH] gnu: Add cl-numpy-file-format.
Date: Thu, 14 Apr 2022 19:05:24 +0000

On Thursday, April 14th, 2022 at 10:35, Guillaume Le Vaillant <glv <at> posteo.net> wrote:
> Patch pushed as 0ddca9d682013f10b7e0137878ab68363d929167.
> Thanks.

Should

    (file-name (git-file-name "cl-numpy-file-format" version))

not be

    (file-name (git-file-name "numpy-file-format" version))

instead?

Best regards,
Paul

Message #16 received at 54937 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: 54937 <at> debbugs.gnu.org
Subject: Re: [bug#54937] [PATCH] gnu: Add cl-numpy-file-format.
Date: Thu, 14 Apr 2022 19:09:44 +0000

[Message part 1 (text/plain, inline)]

"Paul A. Patience" <paul <at> apatience.com> skribis:

> On Thursday, April 14th, 2022 at 10:35, Guillaume Le Vaillant <glv <at> posteo.net> wrote:
>> Patch pushed as 0ddca9d682013f10b7e0137878ab68363d929167.
>> Thanks.
>
> Should
>
>     (file-name (git-file-name "cl-numpy-file-format" version))
>
> not be
>
>     (file-name (git-file-name "numpy-file-format" version))
>
> instead?
>
> Best regards,
> Paul

Previously, all CL packages using git-fetch were using
'(git-file-name name version)' in the 'source' field, and therefore the
sources were named "sbcl-something", which is a little weird as these
sources are also used for the "cl-*" and "ecl-*" packages that are
derived from the "sbcl-*" package definitions. The sources are not
specific to sbcl.
This is why when updating a CL package I use
'(git-file-name "cl-something" version)' instead. This way the naming
scheme for CL sources is similar to the others, like Python sources
fetched from git named "python-something", the R sources named
"r-something", etc.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.