From unknown Tue Jun 24 05:14:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54935: 28.1; vc-dir fails with "sort: Wrong type argument: sequencep, t" Resent-From: Mike Woolley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Apr 2022 11:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 54935@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1649936163698 (code B ref -1); Thu, 14 Apr 2022 11:37:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Apr 2022 11:36:03 +0000 Received: from localhost ([127.0.0.1]:55482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nexla-0000B9-Tt for submit@debbugs.gnu.org; Thu, 14 Apr 2022 07:36:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:58820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nexlZ-0000Ae-HE for submit@debbugs.gnu.org; Thu, 14 Apr 2022 07:36:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nexlZ-0000vP-BT for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 07:36:01 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:34686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nexlX-0005hX-ER for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 07:36:01 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id B3F7676CB0 for ; Thu, 14 Apr 2022 11:35:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zNwZrAuZNx-G for ; Thu, 14 Apr 2022 11:35:56 +0000 (UTC) Received: from smtpclient.apple (185.146.143.150.dyn.plus.net [150.143.146.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 337EC76CB4 for ; Thu, 14 Apr 2022 11:35:56 +0000 (UTC) From: Mike Woolley Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Message-Id: Date: Thu, 14 Apr 2022 12:35:54 +0100 X-Mailer: Apple Mail (2.3696.80.82.1.1) Received-SPF: none client-ip=64.68.200.34; envelope-from=mike@bulsara.com; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) New in Emacs 28.1, vc-dir fails on some of my directories with "sort: = Wrong type argument: sequencep, t=E2=80=9D: Debugger entered--Lisp error: (wrong-type-argument sequencep t) #f(compiled-function (d1 d2) #)((Git . = "~/") (CVS . t)) sort(((CVS . t)) #f(compiled-function (d1 d2) #)) vc-responsible-backend("/Users/mike/") vc-dir("/Users/mike/" nil) funcall-interactively(vc-dir "/Users/mike/" nil) call-interactively(vc-dir nil nil) command-execute(vc-dir) It=E2=80=99s going wrong trying to take the _length of t_ in the = following code in vc-responsible-backend: ;; Just a single response (or none); use it. (if (< (length dirs) 2) (caar dirs) ;; Several roots; we seem to have one vc inside another's ;; directory. Choose the most specific. (caar (sort dirs (lambda (d1 d2) (< (length (cdr d2)) (length (cdr = d1)))))))) This scenario was working fine in previous versions of Emacs, so looks = like recent breakage. Note that there is a workaround by providing C-u to vc-dir and then = manually selecting Git, but clearly it would be better if the problem = was fixed. Thanks, Mike In GNU Emacs 28.1 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 = Version 10.14.6 (Build 18G95)) of 2022-04-04 built on builder10-14.lan Windowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.3.1 Configured using: 'configure --with-ns '--enable-locallisppath=3D/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: ACL GMP GNUTLS JSON LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER THREADS TOOLKIT_SCROLL_BARS ZLIB Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: Messages Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-mtn vc-hg vc-git diff-mode easy-mmode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc-dir seq byte-opt gv bytecomp byte-compile cconv ewoc vc cl-loaddefs cl-lib vc-dispatcher iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 64566 8597) (symbols 48 8001 1) (strings 32 23981 2059) (string-bytes 1 756454) (vectors 16 15847) (vector-slots 8 211662 14422) (floats 8 24 72) (intervals 56 248 0) (buffers 992 11)) From unknown Tue Jun 24 05:14:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#54935: 28.1; vc-dir fails with "sort: Wrong type argument: sequencep, t" Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Apr 2022 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mike Woolley Cc: 54935@debbugs.gnu.org Received: via spool by 54935-submit@debbugs.gnu.org id=B54935.164994408113772 (code B ref 54935); Thu, 14 Apr 2022 13:48:02 +0000 Received: (at 54935) by debbugs.gnu.org; 14 Apr 2022 13:48:01 +0000 Received: from localhost ([127.0.0.1]:55638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nezpI-0003a3-L3 for submit@debbugs.gnu.org; Thu, 14 Apr 2022 09:48:00 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nezpG-0003ZN-P5 for 54935@debbugs.gnu.org; Thu, 14 Apr 2022 09:47:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VXV/SiPlncVlhrF7paRcFwPBShMV7nmeJlxCErx9ye4=; b=RasxsI/sgDICyA0cqHUCmaADGi hmUTg56rE4d7pWbhnZQTry4pBKnIf9a6tvwD884J0gjfWMwDj4ipiZf2FimBg9vYr8lnLbmEkH7YN 1AyPa0LklbnGK0rwozfHhFtUKBE27TUzLXiW5AnXIaorz3qnqdsOWKHCndEGhNC7Wzd4=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nezp7-00022Z-Qx; Thu, 14 Apr 2022 15:47:52 +0200 From: Lars Ingebrigtsen References: Date: Thu, 14 Apr 2022 15:47:45 +0200 In-Reply-To: (Mike Woolley's message of "Thu, 14 Apr 2022 12:35:54 +0100") Message-ID: <87h76vn5dq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mike Woolley writes: > New in Emacs 28.1, vc-dir fails on some of my directories with "sort: Wrong type argument: sequencep, =?UTF-8?Q?t=E2=80=9D:?= > > Debugger entered--Lisp error: (wrong-type-argument sequencep t) > #f(compiled-function [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mike Woolley writes: > New in Emacs 28.1, vc-dir fails on some of my directories with "sort: Wro= ng type argument: sequencep, t=E2=80=9D: > > Debugger entered--Lisp error: (wrong-type-argument sequencep t) > #f(compiled-function (d1 d2) #)((Git . "~/= ") (CVS . t)) > sort(((CVS . t)) #f(compiled-function (d1 d2) #)) This was fixed in ad442b888 on master, but should have been fixed on the emacs-28 branch instead. So I've now cherry-picked that for emacs-28, so it'll be in Emacs 28.2. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 09:48:10 2022 Received: (at control) by debbugs.gnu.org; 14 Apr 2022 13:48:10 +0000 Received: from localhost ([127.0.0.1]:55644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nezpR-0003bW-VL for submit@debbugs.gnu.org; Thu, 14 Apr 2022 09:48:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nezpQ-0003av-KP for control@debbugs.gnu.org; Thu, 14 Apr 2022 09:48:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=F3KLkKtyKdt3vfFz3QaEWxc+n4AjnYs1zBJz3ESTMlk=; b=ufXzRaiCc17STWi5ORlpAO4dzE 0lSLhgSmYUGBPpCgqrcJY1Pm0H0SWCIQfdWwLm9pQU2HWZSvcsQP8ELeh8GJkMy2XeFxufMJSNesL XAHV+o4WB1hwrGJ6vho6fNUI2vPphK8hgmZROUnZkzWJnHJGCc73vm66gffH3ZU3gCSo=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nezpI-00022j-11 for control@debbugs.gnu.org; Thu, 14 Apr 2022 15:48:02 +0200 Date: Thu, 14 Apr 2022 15:47:58 +0200 Message-Id: <87fsmfn5dd.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #54935 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 54935 28.2 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 54935 28.2 quit