Subject: bug#54933: closed (Re: bug#54933: [patch] Add Liquid War 6)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 29 Apr 2022 21:15:02 +0000

Your bug report

#54933: [patch] Add Liquid War 6

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
54933: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54933
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#54933: [patch] Add Liquid War 6
From: Ludovic Courtès <[email-masked]>
To: zamfofex <[email-masked]>
Cc: [email-masked]
Date: Fri, 29 Apr 2022 23:14:22 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

zamfofex <[email-masked]> skribis:

> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index de398c297f..8765f70761 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm

Applied with mostly cosmetic changes:

> +    (inputs
> +      (list guile-2.0 zlib expat sqlite ncurses readline curl doxygen python-2
> +            libxslt perl graphviz glu libcaca
> +            (sdl-union (list sdl sdl-image sdl-ttf sdl-mixer))))

I passed it through ‘guix style’ and moved ‘doxygen’ to ‘native-inputs’
as suggested by ‘guix lint’.

> +    (arguments
> +      '(#:configure-flags
> +         (list
> +           "--enable-allinone"
> +           "CFLAGS=-Wno-error"
> +           (string-append "CPPFLAGS="
> +             "-I" (search-input-directory %build-inputs "include/SDL")))))

I used a gexp and ‘this-package-input’here.

> +    (description
> +      (string-append
> +        "Liquid War 6 is a unique multiplayer wargame. Your army is a blob of "
> +        "liquid and you have to try and eat your opponents. Rules are very "
> +        "simple yet original, they have been invented by Thomas Colcombet."))

I changed that to a literal string:

  https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html

For future patches please take a look at:

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

In particular, please use ‘git format-patch’ and possibly ‘git
send-email’ to send patches.  That ensures the commit log and authorship
are preserved and makes the reviewer’s life easier.  :-)

Thanks!

Ludo’.

Subject: [patch] Add Liquid War 6
From: zamfofex <[email-masked]>
To: "[email-masked]" <[email-masked]>
Date: Thu, 14 Apr 2022 07:00:29 -0300 (BRT)
List-Id: <debbugs-submit.debbugs.gnu.org>

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index de398c297f..8765f70761 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -70,6 +70,7 @@
 ;;; Copyright © 2021 Foo Chuan Wei <[email-masked]>
 ;;; Copyright © 2022 Yovan Naumovski <[email-masked]>
 ;;; Copyright © 2022 Roman Riabenko <[email-masked]>
+;;; Copyright © 2022 zamfofex <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -140,6 +141,7 @@ (define-module (gnu packages games)
   #:use-module (gnu packages golang)
   #:use-module (gnu packages gperf)
   #:use-module (gnu packages graphics)
+  #:use-module (gnu packages graphviz)
   #:use-module (gnu packages gsasl)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
@@ -12647,3 +12649,35 @@ (define-public fheroes2
 Magic II (aka HOMM2) game engine.  It requires assets and game resources to
 play; it will look for them at @file{~/.local/share/fheroes2} folder.")
     (license license:gpl2)))
+
+(define-public liquidwar6
+  (package
+    (name "liquidwar6")
+    (version "0.6.3902")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://gnu/liquidwar6/"
+                            "liquidwar6-" version ".tar.gz"))
+        (sha256
+         (base32 "1976nnl83d8wspjhb5d5ivdvdxgb8lp34wp54jal60z4zad581fn"))))
+    (inputs
+      (list guile-2.0 zlib expat sqlite ncurses readline curl doxygen python-2
+            libxslt perl graphviz glu libcaca
+            (sdl-union (list sdl sdl-image sdl-ttf sdl-mixer))))
+    (build-system gnu-build-system)
+    (arguments
+      '(#:configure-flags
+         (list
+           "--enable-allinone"
+           "CFLAGS=-Wno-error"
+           (string-append "CPPFLAGS="
+             "-I" (search-input-directory %build-inputs "include/SDL")))))
+    (synopsis "Liquid War 6 is a unique multiplayer wargame.")
+    (description
+      (string-append
+        "Liquid War 6 is a unique multiplayer wargame. Your army is a blob of "
+        "liquid and you have to try and eat your opponents. Rules are very "
+        "simple yet original, they have been invented by Thomas Colcombet."))
+    (home-page "https://www.gnu.org/software/liquidwar6/")
+    (license license:gpl3+)))