GNU bug report logs - #54918
[WIP] make guix-service-type more extendable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54918 in the body.
You can then email your comments to 54918 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Justin Veilleux <terramorpha <at> cock.li>
To: guix-patches <at> gnu.org
Subject: [WIP] make guix-service-type more extendable
Date: Wed, 13 Apr 2022 14:54:05 -0400

[Message part 1 (text/plain, inline)]

I noticed that the extension mechanism for guix-service-type don't 
expose authorized keys and substitute-urls. I want to create a service 
to easily set up new channels with their associated substitutes server, 
but I have to go through modify-services.

I realize that this change isn't trivial as it breaks some people's 
os.scm and requires updating the documentation, but I think it is a very 
low hanging fruit in terms of functionality.

Maybe there is a reason why things are the way they are, I would greatly 
appreciate comments.

Cheers.

[0001-first-commit.patch (text/x-patch, attachment)]

Message #8 received at 54918 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Justin Veilleux <terramorpha <at> cock.li>
Cc: 54918 <at> debbugs.gnu.org
Subject: Re: bug#54918: [WIP] make guix-service-type more extendable
Date: Sat, 30 Apr 2022 16:18:23 +0200

Hi Justin,

Justin Veilleux <terramorpha <at> cock.li> skribis:

> I realize that this change isn't trivial as it breaks some people's
> os.scm and requires updating the documentation, but I think it is a
> very low hanging fruit in terms of functionality.

I think the risk of breakage is low: the previous extension mechanism
had only one use case, qemu-binfmt.  That use case is now gone, so we
should be fine.

> +(define-record-type* <guix-extension>
> +  guix-extension make-guix-extension
> +  guix-extension?
> +  (authorized-keys guix-extension-authorized-keys ;list of gexps
> +                    (default '()))
> +  (substitute-urls guix-extension-substitute-urls ;list of strings
> +                    (default '()))
> +  (chroot-directories guix-extension-chroot-directories ;list of file-like/strings
> +                      (default '())))

I like this approach!

Together with update documentation and a changelog, it LGTM.  Could you
send an updated patch?

Thanks,
Ludo’.

Message #11 received at 54918 <at> debbugs.gnu.org (full text, mbox):

From: Justin Veilleux <terramorpha <at> cock.li>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 54918 <at> debbugs.gnu.org
Subject: Re: bug#54918: [WIP] make guix-service-type more extendable
Date: Sun, 1 May 2022 11:35:40 -0400

[Message part 1 (text/plain, inline)]

Hi, I updated the documentation (to the best of my abilities, I've never 
written texinfo).

For the changelog, I'm not familiar with the format for bigger changes, 
could you point me to the relevant documentation?

Cheers

[0001-commit-message.patch (text/x-patch, attachment)]

Message #16 received at 54918-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Justin Veilleux <terramorpha <at> cock.li>
Cc: 54918-done <at> debbugs.gnu.org
Subject: Re: bug#54918: [WIP] make guix-service-type more extendable
Date: Mon, 13 Jun 2022 12:32:16 +0200

Hi Justin,

Justin Veilleux <terramorpha <at> cock.li> skribis:

> From 314f6f1c8cb1057e6880f1776d096a615c2c5a30 Mon Sep 17 00:00:00 2001
> From: terramorpha <terramorpha <at> cock.li>
> Date: Mon, 11 Apr 2022 00:30:07 -0400
> Subject: [PATCH] commit message
>
> ---
>  doc/guix.texi         | 21 ++++++++++++++++++
>  gnu/services/base.scm | 50 ++++++++++++++++++++++++++++++++++---------
>  2 files changed, 61 insertions(+), 10 deletions(-)

Sorry for the looong delay.  I added a commit log and pushed as
fcad6226486b52e5d45531f60811d35eac34fa67.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.