GNU bug report logs - #54911
Missing modules argument for coverage-data->lcov

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#54911: closed (Missing modules argument for coverage-data->lcov)
Date: Thu, 16 Jun 2022 08:04:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 16 Jun 2022 10:03:26 +0200
with message-id <87zgidnigh.fsf <at> gnu.org>
and subject line Re: bug#54911: Missing modules argument for coverage-data->lcov
has caused the debbugs.gnu.org bug report #54911,
regarding Missing modules argument for coverage-data->lcov
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
54911: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54911
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jessica Tallon <tsyesika <at> tsyesika.se>
To: bug-guile <at> gnu.org
Subject: Missing modules argument for coverage-data->lcov
Date: Wed, 13 Apr 2022 16:01:27 +0200

[Message part 3 (text/plain, inline)]

Hello,

I noticed the documentation specify that the `coverage-data->lcov`
function should be able to take modules to limit the scope of the data
that's coverted to lcov. From the docs:

 -- Scheme Procedure: coverage-data->lcov data port #:key modules
     Traverse code coverage information DATA, as obtained with
     ‘with-code-coverage’, and write coverage information to port in the
     ‘.info’ format used by LCOV
     (http://ltp.sourceforge.net/coverage/lcov.php).  The report will
     include all of MODULES (or, by default, all the currently loaded
     modules) even if their code was not executed.

However I noticed that this didn't match the code. I've attached a patch
which implements the behavour described in the docs.

Thanks,
Jessica.

[0001-Fix-missing-modules-argument-for-coverage-data-lcov.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jessica Tallon <tsyesika <at> tsyesika.se>
Cc: 54911-done <at> debbugs.gnu.org
Subject: Re: bug#54911: Missing modules argument for coverage-data->lcov
Date: Thu, 16 Jun 2022 10:03:26 +0200

Hi Jessica,

Jessica Tallon <tsyesika <at> tsyesika.se> skribis:

>>From 828daf200539d3a642fcf8210df7b58aa0d5fede Mon Sep 17 00:00:00 2001
> From: Jessica Tallon <tsyesika <at> tsyesika.se>
> Date: Wed, 13 Apr 2022 15:57:24 +0200
> Subject: [PATCH] Fix missing modules argument for coverage-data->lcov
>
> The code coverage function `coverage-data->lcov` has a documented
> `modules` argument, however that was missing from the source. I have
> added it so when supplied it only converts the coverage data for the
> supplied modules. If not supplied it defaults the old behavour of
> including all the modules currently loaded.

I added a ChangeLog-style entry and committed it.

Thanks for fixing this issue!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.