GNU bug report logs - #54906
[PATCH] build: go-build-system: Add support for #:skip-build? #t.

Previous Next

Package: guix-patches;

Reported by: Attila Lendvai <attila <at> lendvai.name>

Date: Wed, 13 Apr 2022 12:03:01 UTC

Severity: normal

Tags: patch

Done: Attila Lendvai <attila <at> lendvai.name>

Bug is archived. No further changes may be made.

Full log

Message #14 received at 54906 <at> debbugs.gnu.org (full text, mbox):

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: Attila Lendvai <attila <at> lendvai.name>
Cc: 54906 <at> debbugs.gnu.org
Subject: Re: [bug#54906] [PATCH] build: go-build-system: Add support for
 #:skip-build? #t.
Date: Wed, 27 Apr 2022 12:42:02 -0500

(Please forgive me for using your patch to try out reviewing some Guix
patches! This is also my first time reviewing code over email, so feedback welcome!)

I don't have the context for why such a change is needed, but purely from a code perspective this LGTM.

Unfortunately I have no power to commit this.

-- 
Katherine
This bug report was last modified 2 years and 321 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.