GNU bug report logs - #54881
gnu: Add ncurses-5, ncurses/tinfo-5.

Previous Next

To reply to this bug, email your comments to 54881 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "B. Wilson" <elaexuotee <at> wilsonb.com>
To: guix-patches <at> gnu.org
Subject: gnu: Add ncurses-5, ncurses/tinfo-5.
Date: Tue, 12 Apr 2022 20:06:45 +0900

[Message part 1 (text/plain, inline)]

Hello Guix,

I have a need to use ncurses-with-tinfo <at> 5.

The ncurses package embeds the version string in various places, and even
hard-codes the version-major 6 in a couple places, making it impractical to
just create a transformation.

Is this patch reasonable?

[0001-gnu-Add-ncurses-5-ncurses-tinfo-5.patch (text/x-patch, attachment)]

Message #8 received at 54881 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "B. Wilson" <elaexuotee <at> wilsonb.com>
Cc: 54881 <at> debbugs.gnu.org
Subject: Re: bug#54881: gnu: Add ncurses-5, ncurses/tinfo-5.
Date: Mon, 09 May 2022 09:51:33 +0200

Hello,

> The ncurses package embeds the version string in various places, and even
> hard-codes the version-major 6 in a couple places, making it impractical to
> just create a transformation.
>
> Is this patch reasonable?

The make-ncurses-package procedure seems reasonable to be, as it will
also probably ease the upgrade of the package to future major revisions.

However, the introduction of ncurses-5 and ncurses/tinfo-5 has to match
a precise need for a package that is or will be part of Guix. Is that
the case?

Thanks,

Mathieu

Message #11 received at 54881 <at> debbugs.gnu.org (full text, mbox):

From: "B. Wilson" <elaexuotee <at> wilsonb.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 54881 <at> debbugs.gnu.org
Subject: Re: bug#54881: gnu: Add ncurses-5, ncurses/tinfo-5.
Date: Mon, 09 May 2022 20:39:52 +0900

Thanks for taking a look at this.

> However, the introduction of ncurses-5 and ncurses/tinfo-5 has to match
> a precise need for a package that is or will be part of Guix. Is that
> the case?

Yes, sort of. I am currently test-driving a package for Dyalog APL at the
moment, which requires ncurses/tinfo-5. However, due to licensing issues, that
package needs to be in the unmentionable repo.

I'm not quite sure of the appropriate protocol in this case.

Message #14 received at 54881 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "B. Wilson" <elaexuotee <at> wilsonb.com>
Cc: 54881 <at> debbugs.gnu.org
Subject: Re: bug#54881: gnu: Add ncurses-5, ncurses/tinfo-5.
Date: Mon, 09 May 2022 18:06:41 +0200

Hey,

> I'm not quite sure of the appropriate protocol in this case.

We could apply the part introducing the make-ncurses-package procedure
but leave the definition of ncurses-5 and ncurses/tinfo-5 to the
channels which have a use for it?

While testing the make-ncurses-package procedure, I have the following
compile error:

--8<---------------cut here---------------start------------->8---
gnu/packages/ncurses.scm:200:16: In procedure arguments:
error: extra-configure-flags: unbound variable
hint: Did you forget a `use-modules' form?
--8<---------------cut here---------------end--------------->8---

Anything familiar?

Thanks,

Mathieu

Message #17 received at 54881 <at> debbugs.gnu.org (full text, mbox):

From: "B. Wilson" <elaexuotee <at> wilsonb.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 54881 <at> debbugs.gnu.org
Subject: Re: bug#54881: gnu: Add ncurses-5, ncurses/tinfo-5.
Date: Tue, 10 May 2022 06:57:40 +0900

> We could apply the part introducing the make-ncurses-package procedure
> but leave the definition of ncurses-5 and ncurses/tinfo-5 to the
> channels which have a use for it?

Sounds reasonable to me.

> While testing the make-ncurses-package procedure, I have the following
> compile error:
> 
> --8<---------------cut here---------------start------------->8---
> gnu/packages/ncurses.scm:200:16: In procedure arguments:
> error: extra-configure-flags: unbound variable
> hint: Did you forget a `use-modules' form?
> --8<---------------cut here---------------end--------------->8---
> 
> Anything familiar?

Oof. That can be safely removed. I built and tested locally, but it looks like
that change is sitting on my local machine uncomitted. Whoops!

Message #20 received at 54881 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "B. Wilson" <elaexuotee <at> wilsonb.com>
Cc: 54881 <at> debbugs.gnu.org
Subject: Re: bug#54881: gnu: Add ncurses-5, ncurses/tinfo-5.
Date: Sun, 15 May 2022 13:44:25 +0200

Hello,

> Oof. That can be safely removed. I built and tested locally, but it looks like
> that change is sitting on my local machine uncomitted. Whoops!

I removed this bit and it looks like the introduction of the
make-ncurses-package procedure is causing a mass-rebuild. There's
probably another issue as this patch shouldn't cause any change to the
original package definition.

Thanks,

Mathieu

Message #23 received at 54881 <at> debbugs.gnu.org (full text, mbox):

From: "B. Wilson" <elaexuotee <at> wilsonb.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 54881 <at> debbugs.gnu.org
Subject: Re: bug#54881: gnu: Add ncurses-5, ncurses/tinfo-5.
Date: Mon, 16 May 2022 13:35:14 +0900

> I removed this bit and it looks like the introduction of the
> make-ncurses-package procedure is causing a mass-rebuild. There's
> probably another issue as this patch shouldn't cause any change to the
> original package definition.

Yikes. That's definitely a bug. The package definition for the existing version
should end up the exact same. Will look into it.

By the way, how did you check the mass rebuild? Is there a simple command to
check reverse dependencies or the like?

Cheers,
B. Wilson

Message #26 received at 54881 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "B. Wilson" <elaexuotee <at> wilsonb.com>
Cc: 54881 <at> debbugs.gnu.org
Subject: Re: bug#54881: gnu: Add ncurses-5, ncurses/tinfo-5.
Date: Mon, 16 May 2022 16:03:25 +0200

Hey,

> By the way, how did you check the mass rebuild? Is there a simple command to
> check reverse dependencies or the like?

When you run:

--8<---------------cut here---------------start------------->8---
./pre-inst-env guix build ncurses
--8<---------------cut here---------------end--------------->8---

there should not be any rebuild, that's how I check it at least :)

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.