GNU bug report logs - #54869
[PATCH 0/5] gnu: python-vedo: Update to 2022.2.0 and sanity-check failures.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#54872: closed ([PATCH 3/5] gnu: python-vedo: Honor #:tests?
 flag.)
Date: Fri, 06 May 2022 13:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 06 May 2022 15:11:33 +0200
with message-id <878rre4xh6.fsf_-_ <at> gnu.org>
and subject line Re: bug#54874: [PATCH 4/5] gnu: python-vedo: Remove input labels.
has caused the debbugs.gnu.org bug report #54869,
regarding [PATCH 3/5] gnu: python-vedo: Honor #:tests? flag.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
54869: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54869
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Paul A. Patience" <paul <at> apatience.com>
To: guix-patches <at> gnu.org
Cc: "Paul A. Patience" <paul <at> apatience.com>
Subject: [PATCH 3/5] gnu: python-vedo: Honor #:tests? flag.
Date: Tue, 12 Apr 2022 01:22:11 +0000

* gnu/packages/python-science.scm (python-vedo)[arguments]: Adjust
custom 'check phase to honor the #:tests? flag. Also remove its trailing
boolean.
---
 gnu/packages/python-science.scm | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
index 07d713e013..4538904b68 100644
--- a/gnu/packages/python-science.scm
+++ b/gnu/packages/python-science.scm
@@ -876,15 +876,15 @@ (define-public python-vedo
          (add-after 'build 'mpi-setup
            ,%openmpi-setup)
          (replace 'check
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (setenv "HOME" (getcwd))
-             (add-installed-pythonpath inputs outputs)
-             (with-directory-excursion "tests"
-               (for-each (lambda (dir)
-                           (with-directory-excursion dir
-                             (invoke "./run_all.sh")))
-                         '("common" "dolfin")))
-             #t)))))
+           (lambda* (#:key tests? inputs outputs #:allow-other-keys)
+             (when tests?
+               (setenv "HOME" (getcwd))
+               (add-installed-pythonpath inputs outputs)
+               (with-directory-excursion "tests"
+                 (for-each (lambda (dir)
+                             (with-directory-excursion dir
+                               (invoke "./run_all.sh")))
+                           '("common" "dolfin")))))))))
     (inputs        ; for the check phase
      `(("dolfin" ,fenics)
        ("pkgconfig" ,python-pkgconfig)
--
2.35.1

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: 54874-done <at> debbugs.gnu.org, 54869-done <at> debbugs.gnu.org
Subject: Re: bug#54874: [PATCH 4/5] gnu: python-vedo: Remove input labels.
Date: Fri, 06 May 2022 15:11:33 +0200

Hi Paul,

"Paul A. Patience" <paul <at> apatience.com> skribis:

>   gnu: fenics-dolfin: Honor #:tests? flag.
>   gnu: fenics: Honor #:tests? flag.
>   gnu: fenics: Fix sanity check.
>   gnu: python-vedo: Honor #:tests? flag.
>   gnu: python-vedo: Remove input labels.
>   gnu: python-vedo: Disable sanity check.
>   gnu: python-vedo: Update to 2022.2.0.

Finally applied.  Thank you, and thanks Maxime for reviewing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.