GNU bug report logs - #54869
[PATCH 0/5] gnu: python-vedo: Update to 2022.2.0 and sanity-check failures.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Paul A. Patience" <paul <at> apatience.com>
Subject: bug#54870: closed (Re: bug#54874: [PATCH 4/5] gnu: python-vedo:
 Remove input labels.)
Date: Fri, 06 May 2022 13:12:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#54869: [PATCH 1/5] gnu: fenics-dolfin: Honor #:tests? flag.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 54870 <at> debbugs.gnu.org.

-- 
54869: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54869
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: 54874-done <at> debbugs.gnu.org, 54869-done <at> debbugs.gnu.org
Subject: Re: bug#54874: [PATCH 4/5] gnu: python-vedo: Remove input labels.
Date: Fri, 06 May 2022 15:11:33 +0200

Hi Paul,

"Paul A. Patience" <paul <at> apatience.com> skribis:

>   gnu: fenics-dolfin: Honor #:tests? flag.
>   gnu: fenics: Honor #:tests? flag.
>   gnu: fenics: Fix sanity check.
>   gnu: python-vedo: Honor #:tests? flag.
>   gnu: python-vedo: Remove input labels.
>   gnu: python-vedo: Disable sanity check.
>   gnu: python-vedo: Update to 2022.2.0.

Finally applied.  Thank you, and thanks Maxime for reviewing!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: "Paul A. Patience" <paul <at> apatience.com>
To: guix-patches <at> gnu.org
Cc: "Paul A. Patience" <paul <at> apatience.com>
Subject: [PATCH 1/5] gnu: fenics-dolfin: Honor #:tests? flag.
Date: Tue, 12 Apr 2022 01:22:01 +0000

* gnu/packages/simulation.scm (fenics-dolfin)[arguments]: Adjust custom
'check phase to honor the #:tests? flag.
---
 gnu/packages/simulation.scm | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
index 3f2d8e136d..aebb6be15e 100644
--- a/gnu/packages/simulation.scm
+++ b/gnu/packages/simulation.scm
@@ -549,12 +549,13 @@ (define-public fenics-dolfin
                     ")\n") port)))
              #t))
          (replace 'check
-           (lambda _
-             (and (invoke "make" "unittests")
-                  (invoke "make" "demos")
-                  (invoke "ctest" "-R" "unittests")
-                  (invoke "ctest" "-R" "demo" "-R" "serial")
-                  (invoke "ctest" "-R" "demo" "-R" "mpi")))))))
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               (and (invoke "make" "unittests")
+                    (invoke "make" "demos")
+                    (invoke "ctest" "-R" "unittests")
+                    (invoke "ctest" "-R" "demo" "-R" "serial")
+                    (invoke "ctest" "-R" "demo" "-R" "mpi"))))))))
     (home-page "https://bitbucket.org/fenics-project/dolfin/")
     (synopsis "Problem solving environment for differential equations")
     (description
--
2.35.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.