GNU bug report logs - #54869
[PATCH 0/5] gnu: python-vedo: Update to 2022.2.0 and sanity-check failures.

Previous Next

Package: guix-patches;

Reported by: "Paul A. Patience" <paul <at> apatience.com>

Date: Tue, 12 Apr 2022 01:23:02 UTC

Severity: normal

Tags: patch

Merged with 54870, 54871, 54872, 54873, 54874

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #34 received at 54869 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: "Paul A. Patience" <paul <at> apatience.com>, 54869 <at> debbugs.gnu.org
Subject: Re: [bug#54869] [PATCH v2 1/7] gnu: fenics-dolfin: Honor #:tests?
 flag.
Date: Fri, 22 Apr 2022 19:46:52 +0200

[Message part 1 (text/plain, inline)]
Paul A. Patience schreef op vr 22-04-2022 om 11:53 [+0000]:
> -                  (invoke "ctest" "-R" "demo" "-R" "mpi")))))))
> +           (lambda* (#:key tests? #:allow-other-keys)
> +             (when tests?
> +               (and (invoke "make" "unittests")
> +                    (invoke "make" "demos")
> +                    (invoke "ctest" "-R" "unittests")
> +                    (invoke "ctest" "-R" "demo" "-R" "serial")
> +                    (invoke "ctest" "-R" "demo" "-R" "mpi"))))))))

The 'and' is pointless, it can be removed --- IIUC, 'invoke' throws
exceptions, it doesn't return #false.  Anyway, honouring #:tests? is
nice (for cross-compilation and --without-tests=...).

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 109 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.