Subject: bug#54872: closed (Re: bug#54874: [PATCH 4/5] gnu: python-vedo: Remove input labels.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 06 May 2022 13:12:02 +0000

Your bug report

#54869: [PATCH 3/5] gnu: python-vedo: Honor #:tests? flag.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
54869: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54869
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#54874: [PATCH 4/5] gnu: python-vedo: Remove input labels.
From: Ludovic Courtès <[email-masked]>
To: "Paul A. Patience" <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Fri, 06 May 2022 15:11:33 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Paul,

"Paul A. Patience" <[email-masked]> skribis:

>   gnu: fenics-dolfin: Honor #:tests? flag.
>   gnu: fenics: Honor #:tests? flag.
>   gnu: fenics: Fix sanity check.
>   gnu: python-vedo: Honor #:tests? flag.
>   gnu: python-vedo: Remove input labels.
>   gnu: python-vedo: Disable sanity check.
>   gnu: python-vedo: Update to 2022.2.0.

Finally applied.  Thank you, and thanks Maxime for reviewing!

Ludo’.

Subject: [PATCH 3/5] gnu: python-vedo: Honor #:tests? flag.
From: "Paul A. Patience" <[email-masked]>
To: [email-masked]
Cc: "Paul A. Patience" <[email-masked]>
Date: Tue, 12 Apr 2022 01:22:11 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/python-science.scm (python-vedo)[arguments]: Adjust
custom 'check phase to honor the #:tests? flag. Also remove its trailing
boolean.
---
 gnu/packages/python-science.scm | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
index 07d713e013..4538904b68 100644
--- a/gnu/packages/python-science.scm
+++ b/gnu/packages/python-science.scm
@@ -876,15 +876,15 @@ (define-public python-vedo
          (add-after 'build 'mpi-setup
            ,%openmpi-setup)
          (replace 'check
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (setenv "HOME" (getcwd))
-             (add-installed-pythonpath inputs outputs)
-             (with-directory-excursion "tests"
-               (for-each (lambda (dir)
-                           (with-directory-excursion dir
-                             (invoke "./run_all.sh")))
-                         '("common" "dolfin")))
-             #t)))))
+           (lambda* (#:key tests? inputs outputs #:allow-other-keys)
+             (when tests?
+               (setenv "HOME" (getcwd))
+               (add-installed-pythonpath inputs outputs)
+               (with-directory-excursion "tests"
+                 (for-each (lambda (dir)
+                             (with-directory-excursion dir
+                               (invoke "./run_all.sh")))
+                           '("common" "dolfin")))))))))
     (inputs        ; for the check phase
      `(("dolfin" ,fenics)
        ("pkgconfig" ,python-pkgconfig)
--
2.35.1