Subject: bug#54870: closed (Re: bug#54874: [PATCH 4/5] gnu: python-vedo: Remove input labels.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 06 May 2022 13:12:02 +0000

Your bug report

#54869: [PATCH 1/5] gnu: fenics-dolfin: Honor #:tests? flag.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
54869: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54869
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#54874: [PATCH 4/5] gnu: python-vedo: Remove input labels.
From: Ludovic Courtès <[email-masked]>
To: "Paul A. Patience" <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Fri, 06 May 2022 15:11:33 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Paul,

"Paul A. Patience" <[email-masked]> skribis:

>   gnu: fenics-dolfin: Honor #:tests? flag.
>   gnu: fenics: Honor #:tests? flag.
>   gnu: fenics: Fix sanity check.
>   gnu: python-vedo: Honor #:tests? flag.
>   gnu: python-vedo: Remove input labels.
>   gnu: python-vedo: Disable sanity check.
>   gnu: python-vedo: Update to 2022.2.0.

Finally applied.  Thank you, and thanks Maxime for reviewing!

Ludo’.

Subject: [PATCH 1/5] gnu: fenics-dolfin: Honor #:tests? flag.
From: "Paul A. Patience" <[email-masked]>
To: [email-masked]
Cc: "Paul A. Patience" <[email-masked]>
Date: Tue, 12 Apr 2022 01:22:01 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/simulation.scm (fenics-dolfin)[arguments]: Adjust custom
'check phase to honor the #:tests? flag.
---
 gnu/packages/simulation.scm | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
index 3f2d8e136d..aebb6be15e 100644
--- a/gnu/packages/simulation.scm
+++ b/gnu/packages/simulation.scm
@@ -549,12 +549,13 @@ (define-public fenics-dolfin
                     ")\n") port)))
              #t))
          (replace 'check
-           (lambda _
-             (and (invoke "make" "unittests")
-                  (invoke "make" "demos")
-                  (invoke "ctest" "-R" "unittests")
-                  (invoke "ctest" "-R" "demo" "-R" "serial")
-                  (invoke "ctest" "-R" "demo" "-R" "mpi")))))))
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               (and (invoke "make" "unittests")
+                    (invoke "make" "demos")
+                    (invoke "ctest" "-R" "unittests")
+                    (invoke "ctest" "-R" "demo" "-R" "serial")
+                    (invoke "ctest" "-R" "demo" "-R" "mpi"))))))))
     (home-page "https://bitbucket.org/fenics-project/dolfin/")
     (synopsis "Problem solving environment for differential equations")
     (description
--
2.35.1