GNU bug report logs - #54838
28.1; Buffers are not updated when a directory is renamed in dired

Previous Next

Full log

Message #11 received at 54838 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Nicolas Martyanoff <khaelin <at> gmail.com>, 54838 <at> debbugs.gnu.org
Subject: Re: bug#54838: 28.1; Buffers are not updated when a directory is
 renamed in dired
Date: Sun, 10 Apr 2022 19:19:26 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

Hi Eli,

> Tassilo, part of this bug is yet another fallout from replacing
> dired-in-this-tree-p with file-in-directory-p: the latter returns nil
> if its second arg doesn't exist, and in this scenario we are dealing
> with a directory that was already renamed to the new name.  Do you
> agree with my proposed solution for that below?

I would just revert back to using dired-in-this-tree-p and never
file-in-directory-p in those places.  I've done that for many places in
61677ac3e4685d8f81c3b90eb751d9b5e8a3732d, too, because it turned out
that the change from dired-in-this-tree-p to file-in-directory-p caused
performance problems.  The fact that dired-in-this-tree-p works for
non-existing files and dired relies on that didn't even occur to me. :-(

Bye,
Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.