GNU bug report logs - #54836
[PATCH 1/2] http-client: Fix redirection.

Previous Next

Package: guix-patches;

Reported by: Attila Lendvai <attila <at> lendvai.name>

Date: Sun, 10 Apr 2022 13:35:03 UTC

Severity: normal

Tags: moreinfo, patch

Full log


View this message in rfc822 format

From: Attila Lendvai <attila <at> lendvai.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 54836 <at> debbugs.gnu.org
Subject: [bug#54836] [PATCH 1/2] http-client: Fix redirection.
Date: Tue, 12 Apr 2022 07:28:33 +0000
> > It's not enough to just handle the thrown exception, because we need to be
> > able to get hold of the fetched content, too.
>
> Would it make sense, then, to use the lower-level ‘http-get’ from (web
> client)? That would let the code deal with all the HTTP idiosyncrasies.


i think it boils down to this trade-off:

1) keep http-fetch simpler, at the expense of reimplementing parts of
   it in the go importer (e.g. the redirection logic)

2) add this extra complexity to http-fetch, and avoid the extra
   complexity of a local, potentially half-assed %http-fetch in the go
   importer.

3) something else i'm not aware of

please advise how to reshape this patch/feature, because it's needed
to file my go importer patches.

--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
The use of power is only needed when you want to do something harmful, otherwise love is enough to get everything done.





This bug report was last modified 2 years and 158 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.